From 877421e59693f49fa649de0f43fda1f0d86633ea Mon Sep 17 00:00:00 2001 From: t8y2 <1156263951@qq.com> Date: Tue, 1 Sep 2026 15:24:40 +0000 Subject: [PATCH] fix(oracle): load materialized view DDL from metadata Closes #7538 --- agents/drivers/oracle-go/main.go | 2 +- agents/drivers/oracle-go/main_test.go | 47 +++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/agents/drivers/oracle-go/main.go b/agents/drivers/oracle-go/main.go index 7bdd9b6dfa..d96c9fbb95 100644 --- a/agents/drivers/oracle-go/main.go +++ b/agents/drivers/oracle-go/main.go @@ -2924,7 +2924,7 @@ func (s *server) getObjectSource(schema, name, objectType string) (map[string]an } return map[string]any{"name": name, "object_type": objectType, "schema": schema, "source": source}, nil } - if upperType == "SEQUENCE" || upperType == "SYNONYM" { + if upperType == "MATERIALIZED_VIEW" || upperType == "SEQUENCE" || upperType == "SYNONYM" { return s.getMetadataObjectSource(schema, name, upperType) } diff --git a/agents/drivers/oracle-go/main_test.go b/agents/drivers/oracle-go/main_test.go index 7c70409914..8218fa232d 100644 --- a/agents/drivers/oracle-go/main_test.go +++ b/agents/drivers/oracle-go/main_test.go @@ -2534,6 +2534,53 @@ func TestGetObjectSourceUsesDBMSMetadataForSequence(t *testing.T) { } } +func TestGetObjectSourceUsesDBMSMetadataForMaterializedView(t *testing.T) { + const ddl = `CREATE MATERIALIZED VIEW "HR"."SALES_MV" AS SELECT * FROM "HR"."SALES"` + db, scripted := openOracleViewSourceTestDB(t, []oracleViewSourceQueryStep{ + { + queryContains: "DBMS_METADATA.GET_DDL(:1, :2, :3)", + args: []driver.Value{"MATERIALIZED_VIEW", "SALES_MV", "HR"}, + rows: [][]driver.Value{{ddl}}, + }, + }) + s := newServer() + s.db = db + + result, err := s.getObjectSource("HR", "SALES_MV", "MATERIALIZED_VIEW") + if err != nil { + t.Fatal(err) + } + if result["source"] != ddl || result["object_type"] != "MATERIALIZED_VIEW" { + t.Fatalf("unexpected materialized view source: %#v", result) + } + if scripted.next != len(scripted.steps) { + t.Fatalf("expected %d queries, got %d", len(scripted.steps), scripted.next) + } +} + +func TestGetObjectSourcePropagatesMaterializedViewMetadataError(t *testing.T) { + db, scripted := openOracleViewSourceTestDB(t, []oracleViewSourceQueryStep{ + { + queryContains: "DBMS_METADATA.GET_DDL(:1, :2, :3)", + args: []driver.Value{"MATERIALIZED_VIEW", "SALES_MV", "HR"}, + err: errors.New("ORA-31603: object not found"), + }, + }) + s := newServer() + s.db = db + + result, err := s.getObjectSource("HR", "SALES_MV", "MATERIALIZED_VIEW") + if err == nil || !strings.Contains(err.Error(), "ORA-31603") { + t.Fatalf("expected DBMS_METADATA error, got result=%#v error=%v", result, err) + } + if result != nil { + t.Fatalf("metadata error must not return a successful source: %#v", result) + } + if scripted.next != len(scripted.steps) { + t.Fatalf("expected %d queries, got %d", len(scripted.steps), scripted.next) + } +} + func TestGetObjectSourceAggregatesProcedureSourceInOracle(t *testing.T) { const source = "PROCEDURE DBX_LARGE_SOURCE AS\nBEGIN\n -- preserve & special characters\n NULL;\nEND;" db, scripted := openOracleViewSourceTestDB(t, []oracleViewSourceQueryStep{