test: drop source-text assertion tests and merge locale checks

This commit is contained in:
t8y2 committed 2026-09-23 22:10:06 +08:00
1 parent 349d77d180
commit 8897e12714
257 files changed
+166 -12815

No files matched your search

@@ -61,11 +61,7 @@ vi.mock("@/components/nacos/NacosRoleAccessControl.vue", async () => {
import NacosAccessControlConsole from "../NacosAccessControlConsole.vue";
const source = readFileSync(resolve(process.cwd(), "apps/desktop/src/components/nacos/NacosAccessControlConsole.vue"), "utf8");
const legacySource = readFileSync(resolve(process.cwd(), "apps/desktop/src/components/nacos/NacosAccessControl.vue"), "utf8");
const treeItemSource = readFileSync(resolve(process.cwd(), "apps/desktop/src/components/sidebar/TreeItem.vue"), "utf8");
const connectionTreeSource = readFileSync(resolve(process.cwd(), "apps/desktop/src/components/sidebar/ConnectionTree.vue"), "utf8");
const connectionStoreSource = readFileSync(resolve(process.cwd(), "apps/desktop/src/stores/connectionStore.ts"), "utf8");
const mountedApps: Array<{ app: App; host: HTMLElement }> = [];
async function settle() {
@@ -85,43 +81,6 @@ afterEach(() => {
});
describe("NacosAccessControlConsole", () => {
it("uses the access-control header pattern for its navigation", () => {
expect(source).toContain('class="flex h-14 shrink-0 flex-wrap items-center gap-3 border-b px-4"');
expect(source).toContain('class="flex rounded-md border p-0.5 shadow-sm"');
expect(source).toContain("<UsersRound");
expect(source).toContain("<KeyRound");
expect(source).toContain('t("nacos.accessControlTitle")');
expect(source).toContain('t("nacos.accessControlDescription")');
});
it("only submits r-nacos namespace privilege fields supported by its API", () => {
expect(legacySource).not.toContain("privilegeEnabled");
expect(legacySource).toContain("whitelistIsAll: userForm.value.whitelistIsAll");
expect(legacySource).toContain("blacklistIsAll: userForm.value.blacklistIsAll");
expect(legacySource).toContain('import NacosNamespaceMultiSelect from "@/components/nacos/NacosNamespaceMultiSelect.vue"');
expect(legacySource).toContain('v-model="userForm.whitelist"');
expect(legacySource).toContain('v-model="userForm.blacklist"');
expect(legacySource).toContain("whitelist: [...userForm.value.whitelist]");
expect(legacySource).toContain("blacklist: [...userForm.value.blacklist]");
expect(legacySource).not.toContain('<textarea v-model="userForm.whitelist"');
expect(legacySource).not.toContain('<textarea v-model="userForm.blacklist"');
});
it("invalidates the r-nacos namespace picker when namespaces change", () => {
expect(legacySource).toContain('import { subscribeNacosNamespacesChanged, type NacosNamespacesChangedDetail } from "@/lib/nacos/nacosNamespaceCache"');
expect(legacySource).toContain("stopNacosNamespacesChangedListener = subscribeNacosNamespacesChanged(handleNacosNamespacesChanged)");
expect(legacySource).toContain("if (detail.connectionId !== props.connectionId) return");
expect(legacySource).toContain("if (userDialogOpen.value && isRNacos.value) void loadUserFormNamespaces(true)");
expect(legacySource).toContain("stopNacosNamespacesChangedListener?.()");
});
it("notifies users when an official Nacos password reset succeeds or fails", () => {
expect(legacySource).toContain('const userOperationNotice = ref<{ kind: "success" | "error"; message: string } | null>(null)');
expect(legacySource).toContain("await syncCurrentConnectionPassword(username, userForm.value.password)");
expect(legacySource).toContain('userOperationNotice.value = { kind: "error", message: t("nacos.passwordResetFailed", { message }) }');
expect(legacySource).toContain('v-if="userOperationNotice"');
});
it("requires exact username confirmation before deleting a user in the legacy workspace", () => {
expect(legacySource).toContain("const userDeleteConfirmed = computed(() => userDeleteConfirmation.value === pendingUserDelete.value?.username)");
expect(legacySource).toContain('@click="openDeleteUser(user)"');
@@ -129,29 +88,6 @@ describe("NacosAccessControlConsole", () => {
expect(legacySource).toContain(':disabled="deletingUser || !userDeleteConfirmed"');
});
it("does not hide user deletion solely because the user has ROLE_ADMIN", () => {
expect(legacySource).not.toContain('if (user.roles.includes("ROLE_ADMIN")) return');
expect(legacySource).not.toContain("v-if=\"!user.roles.includes('ROLE_ADMIN')\"");
});
it("uses the same role creation icon in the legacy and enhanced workspaces", () => {
expect(legacySource).toContain('import { KeyRound, Loader2, Pencil, Plus, RefreshCw, Search, ShieldCheck, ShieldPlus, Trash2, UserRound } from "@lucide/vue"');
expect(legacySource).toContain('@click="openAssignRole"><ShieldPlus class="h-3.5 w-3.5" />{{ t("nacos.assignRole") }}');
expect(readFileSync(resolve(process.cwd(), "apps/desktop/src/components/nacos/NacosRoleAccessControl.vue"), "utf8")).toContain('<ShieldPlus v-else class="h-3.5 w-3.5" />');
});
it("switches tabs when navigating between associated users and roles", () => {
expect(source).toContain("@select-user=\"activeTab = 'users'\"");
expect(source).toContain("@select-role=\"activeTab = 'roles'\"");
});
it("keeps the roles-only workspace reachable without an unavailable banner", () => {
expect(source).toContain('if (!supportsUsers.value && supportsRoles.value) activeTab.value = "roles"');
expect(source).toContain('v-if="!supportsUsers && !supportsRoles"');
expect(connectionStoreSource).toContain("sidebarSnapshot.accessControl.listUsers.supported === true ||");
expect(connectionStoreSource).toContain("sidebarSnapshot.accessControl.listRoleBindings.supported === true");
});
it("keeps the roles-only workspace visible alongside the permission warning", async () => {
const unsupported = { supported: false, reason: "permissionDenied" as const };
mocks.connectionInfo = {
@@ -195,12 +131,6 @@ describe("NacosAccessControlConsole", () => {
expect(workspace?.getAttribute("data-tab")).toBe("roles");
});
it("shares the directory-detail workspace across supported Nacos versions", () => {
expect(source).toContain('import NacosRoleAccessControl from "@/components/nacos/NacosRoleAccessControl.vue"');
expect(source).toContain('<NacosRoleAccessControl v-if="enhancedWorkspace && accessControl"');
expect(source).toContain(':capabilities="accessControl"');
});
it("keeps the enhanced read workspace visible when writes are permission denied", async () => {
const unsupported = { supported: false, reason: "permissionDenied" as const };
const supported = { supported: true };
@@ -290,10 +220,4 @@ describe("NacosAccessControlConsole", () => {
expect(mocks.nacosTestConnection).toHaveBeenLastCalledWith("nacos-refresh", true);
expect(mocks.refreshEnhancedWorkspace).toHaveBeenCalledTimes(1);
});
it("internationalizes the sidebar entry, including trees persisted with the old label", () => {
expect(connectionStoreSource).toContain('label: "nacos.accessControlSidebarLabel"');
expect(treeItemSource).toContain('if (node.type === "nacos-access-control") return t("nacos.accessControlSidebarLabel")');
expect(connectionTreeSource).toContain('node.type === "nacos-access-control" ? t("nacos.accessControlSidebarLabel") : node.label');
});
});
@@ -1,255 +0,0 @@
import { readFileSync } from "node:fs";
import { describe, expect, it } from "vitest";
const source = readFileSync(new URL("../NacosAdminConsole.vue", import.meta.url), "utf8");
describe("NacosAdminConsole config workbench layout", () => {
it("keeps access control outside the namespace-scoped workbench", () => {
expect(source).not.toContain("NacosAccessControl");
expect(source).toContain('type AdminTab = "configs" | "services";');
});
it("offers browser-console and Zen-mode actions in the workspace toolbar", () => {
expect(source).toContain("resolveNacosConsoleUrl");
expect(source).toContain("function openNacosConsole()");
expect(source).toContain('t("nacos.openConsole")');
expect(source).toContain("emit('toggleZenMode')");
expect(source).toContain('props.zenMode ? t("nacos.exitZenMode") : t("nacos.enterZenMode")');
});
it("keeps JSON metadata available while offering an on-demand table dialog", () => {
expect(source).toContain("function openInstanceMetadataTable(instance: NacosInstanceInfo)");
expect(source).toContain('t("nacos.viewMetadataTable")');
expect(source).toContain('class="nacos-instance-metadata-actions flex min-w-0 flex-wrap items-center gap-1"');
expect(source).toContain('<details class="min-w-0 text-muted-foreground">');
expect(source).not.toContain('<details class="min-w-0 flex-1 text-muted-foreground">');
expect(source).toContain('v-model:open="instanceMetadataTableOpen"');
expect(source).toContain('t("nacos.metadataKey")');
expect(source).toContain('t("nacos.metadataValue")');
expect(source).toContain("JSON.stringify(instance.metadata, null, 2)");
});
it("keeps the editor as the final and primary workbench surface", () => {
const contextBar = source.indexOf('class="nacos-config-context-bar');
const inspector = source.indexOf('class="nacos-config-inspector');
const toolbar = source.indexOf('class="nacos-editor-toolbar');
const editor = source.indexOf('ref="configEditorHost"');
expect(contextBar).toBeGreaterThan(0);
expect(inspector).toBeGreaterThan(contextBar);
expect(toolbar).toBeGreaterThan(inspector);
expect(editor).toBeGreaterThan(toolbar);
});
it("uses split-pane container queries instead of viewport breakpoints", () => {
expect(source).toContain(".nacos-config-workbench {\n container-type: inline-size;");
expect(source).toContain("@container (min-width: 960px)");
expect(source).toContain("@container (max-width: 480px)");
expect(source.indexOf('class="nacos-editor-actions-secondary')).toBeLessThan(source.indexOf('class="nacos-editor-actions-primary'));
expect(source).toContain("grid-template-columns: minmax(0, 1fr) auto;");
});
it("tracks format and metadata changes as unsaved configuration state", () => {
expect(source).toContain("configType.value !== originalConfigType.value");
expect(source).toContain('(selectedConfig.value.appName || "") !== originalConfigMetadata.value.appName');
expect(source).toContain('(selectedConfig.value.desc || "") !== originalConfigMetadata.value.desc');
expect(source).toContain('(selectedConfig.value.tags || "") !== originalConfigMetadata.value.tags');
});
it("returns a stale batch apply to preview instead of retrying an expired plan", () => {
const staleBranch = source.indexOf('isNacosErrorCode(error, "stalePreview")');
expect(staleBranch).toBeGreaterThan(0);
expect(source.indexOf("batchPreview.value = null;", staleBranch)).toBeGreaterThan(staleBranch);
expect(source.indexOf("batchTransferRequest.value = null;", staleBranch)).toBeGreaterThan(staleBranch);
expect(source.indexOf('batchError.value = t("nacos.previewExpired");', staleBranch)).toBeGreaterThan(staleBranch);
});
it("keeps service detail and instance loading as independent guarded requests", () => {
expect(source).toContain("const serviceDetailRequestGuard = createNacosLatestRequestGuard();");
expect(source).toContain("const instancesRequestGuard = createNacosLatestRequestGuard();");
expect(source).toContain("await Promise.all([loadServiceDetail(), loadInstances()]);");
});
it("keeps configuration list responses scoped to the latest filters", () => {
expect(source).toContain("const configListRequestGuard = createNacosLatestRequestGuard();");
expect(source).toContain("const requestId = configListRequestGuard.begin();");
expect(source).toContain("if (!isCurrentRequest()) return false;");
expect(source).toContain("if (configListRequestGuard.isCurrent(requestId)) configLoading.value = false;");
expect(source).toContain("const current = await loadConfigs(page);");
expect(source).toContain("if (!current || !isConnectionNotFoundError(configError.value)");
expect(source.match(/configListRequestGuard\.invalidate\(\);/g)?.length).toBeGreaterThanOrEqual(2);
});
it("keeps instance weight edits as drafts until the explicit save action", () => {
expect(source).toContain("instanceWeightDrafts.value[instanceIdentity(instance)] = String(value);");
expect(source).toContain('@click="requestInstanceWeightUpdate(instance)"');
expect(source).not.toContain('@change="requestInstanceWeightUpdate(instance)"');
});
it("tracks instance operations by token so stale requests cannot lock a row forever", () => {
expect(source).toContain("const updatingInstanceKeys = ref<Record<string, number>>({});");
expect(source).toContain("const operationToken = beginInstanceOperation(key);");
expect(source).toContain("clearInstanceOperation(key, operationToken);");
expect(source).not.toContain('if (updateId === instanceUpdateSequence) updatingInstanceKey.value = "";');
});
it("prevents service-management dialogs from closing through outside clicks or Escape", () => {
expect(source.match(/@pointer-down-outside\.prevent/g)?.length).toBeGreaterThanOrEqual(3);
expect(source.match(/@interact-outside\.prevent/g)?.length).toBeGreaterThanOrEqual(3);
expect(source.match(/@escape-key-down\.prevent/g)?.length).toBeGreaterThanOrEqual(3);
});
it("renders service details before the independently scrollable instance cards", () => {
const detail = source.indexOf("nacos.serviceDetails");
const instanceCards = source.indexOf('v-for="instance in instances"');
expect(detail).toBeGreaterThan(0);
expect(instanceCards).toBeGreaterThan(detail);
});
it("keeps verbose service details collapsed until the user expands them", () => {
expect(source).toContain("const serviceDetailExpanded = ref(restoredUiState.serviceDetailExpanded ?? false);");
});
it("reserves the cluster-clear action space so entering a filter cannot reflow the toolbar", () => {
expect(source).toContain('class="min-w-0 flex-1"');
expect(source).toContain('class="nacos-service-filter-group flex min-w-0 items-center gap-1"');
expect(source).toContain(':class="{ invisible: !serviceCluster }"');
expect(source).toContain(':disabled="instancesLoading || !serviceCluster"');
expect(source).not.toContain('v-if="serviceCluster"\n size="sm"');
});
it("uses the service split pane width for responsive service and instance layouts", () => {
expect(source).toContain(".nacos-service-workbench {\n container: nacos-service-workbench / inline-size;");
expect(source).toContain("@container nacos-service-workbench (max-width: 480px)");
expect(source).toContain("@container nacos-service-workbench (min-width: 620px)");
expect(source).toContain("@container nacos-service-workbench (min-width: 720px)");
expect(source).toContain('class="nacos-instance-layout flex gap-3"');
expect(source).toContain('class="nacos-instance-actions flex flex-wrap items-center gap-2"');
expect(source).toContain("overflow-wrap: anywhere;");
expect(source).not.toContain("xl:flex-row xl:items-start xl:justify-between");
expect(source).not.toContain("sm:grid-cols-[auto_minmax(0,1fr)]");
});
it("adds icon-only clear controls to populated configuration and service filters", () => {
for (const [filter, clear] of [
["configDataId", "clearConfigFilter('dataId')"],
["configGroup", "clearConfigFilter('group')"],
["configAppName", "clearConfigFilter('appName')"],
["serviceName", "clearServiceFilter('name')"],
["serviceGroup", "clearServiceFilter('group')"],
]) {
expect(source).toContain(`v-if="${filter}"`);
expect(source).toContain(`@click="${clear}"`);
}
expect(source).toContain("void loadConfigsWithRetry(1);");
expect(source).toContain("void loadServicesWithRetry(1);");
expect(source.match(/groupContains: true/g)?.length).toBeGreaterThanOrEqual(2);
expect(source.match(/:aria-label="t\('nacos\.clear'\)"/g)?.length).toBeGreaterThanOrEqual(5);
});
it("uses green outlined styling for healthy instances and red styling for unhealthy instances", () => {
expect(source).toContain("instance.healthy === false ? 'border-destructive/50 text-destructive' : 'border-emerald-500/50 text-emerald-700 dark:text-emerald-300'");
});
it("keeps the configuration editor zoom behavior aligned with the SQL editor", () => {
expect(source).toContain("createEditorZoomCommitScheduler");
expect(source).toContain("createEditorWheelZoomGestureGuard");
expect(source).toContain("EditorView.domEventHandlers");
expect(source).toContain("fontSizeFromWheelDelta(configEditorFontSize.value, event.deltaY)");
expect(source).toContain("if (!configEditorWheelZoomGestureGuard.accepts(event)) return false;");
expect(source).toContain("configEditorZoomCommitScheduler.dispose()");
});
it("keeps the configuration editor word wrapping aligned with the global editor setting", () => {
expect(source).toContain("const configEditorWordWrap = new Compartment()");
expect(source).toContain("configEditorWordWrap.of(editorSettings.wordWrap ? EditorView.lineWrapping : [])");
expect(source).toContain("configEditorWordWrap.reconfigure(settings.wordWrap ? EditorView.lineWrapping : [])");
expect(source).not.toContain("\n EditorView.lineWrapping,\n");
});
it("allows optional configuration columns to be hidden without hiding the data ID", () => {
const configListHeader = source.indexOf('class="sticky top-0 z-20 grid border-b bg-muted');
const columnVisibility = source.indexOf("nacos.visibleColumns");
expect(configListHeader).toBeGreaterThan(0);
expect(columnVisibility).toBeGreaterThan(configListHeader);
expect(source).toContain("configListToggleableColumns");
expect(source).toContain("DropdownMenuCheckboxItem");
expect(source).toContain("nacos.visibleColumns");
expect(source).toContain('v-for="(column, columnIndex) in configListColumns"');
expect(source).toContain("column === 'dataId'");
});
it("marks the selected configuration without giving its row the header background", () => {
expect(source).toContain("function isSelectedConfigListItem");
expect(source).toContain(":class=\"{ 'border-l-2 border-l-primary': isSelectedConfigListItem(item) }\"");
});
it("adds a guarded batch delete action for selected configurations", () => {
const toolbar = source.indexOf('class="flex min-w-0 flex-wrap items-center justify-end gap-2"');
const batchDeleteButton = source.indexOf("v-if=\"activeTab === 'configs' && selectedConfigCount > 0\"");
expect(toolbar).toBeGreaterThan(0);
expect(batchDeleteButton).toBeGreaterThan(toolbar);
expect(source).toContain('class="border-l border-current/30 pl-1.5 text-xs font-semibold tabular-nums"');
expect(source).not.toContain('<Badge variant="outline" class="h-5 min-w-5 border-current px-1.5 text-current">{{ selectedConfigCount }}</Badge>');
expect(source).toContain("const pendingBatchDelete = ref<NacosBatchDeleteSnapshot | null>(null);");
expect(source).toContain("const canRequestBatchDeleteConfigs = computed(");
expect(source).toContain("function requestBatchDeleteConfigs()");
expect(source).toContain("async function deleteSelectedConfigs()");
expect(source).toContain('await confirmNacosMutation(t("nacos.batchDelete"), snapshot.connectionId, snapshot.namespace)');
expect(source).toContain("for (const key of snapshot.keys)");
expect(source).toContain("await api.nacosDeleteConfig(snapshot.connectionId, key);");
expect(source).toContain("function reconcileDeletedConfigSelection(deletedKeys: ReadonlySet<string>)");
expect(source).toContain("reconcileDeletedConfigSelection(deletedKeys);");
expect(source).toContain("nacos.batchDeletePartial");
expect(source).toContain("nacos.batchDeleteInterrupted");
});
it("allows the Nacos configuration page size to be changed within the supported range", () => {
expect(source).toContain("const NACOS_CONFIG_PAGE_SIZE_OPTIONS = [20, 50, 100, 200, 500] as const;");
expect(source).toContain('const NACOS_CONFIG_PAGE_SIZE_STORAGE_KEY = "dbx-nacos-config-page-size";');
expect(source).toContain("function setConfigPageSize(value: string)");
expect(source).toContain("safeLocalStorageSet(NACOS_CONFIG_PAGE_SIZE_STORAGE_KEY, String(nextPageSize));");
expect(source).toContain('t("nacos.configPageSize")');
expect(source).toContain('v-for="size in NACOS_CONFIG_PAGE_SIZE_OPTIONS"');
expect(source).toContain('@update:model-value="setConfigPageSize(String($event))"');
expect(source).toContain(":aria-label=\"t('nacos.configPageSize')\"");
expect(source).toContain('class="grid shrink-0 grid-cols-[minmax(0,1fr)_auto] items-center gap-2 border-t px-3 py-2 text-xs text-muted-foreground"');
expect(source).not.toContain('class="flex shrink-0 flex-wrap items-center justify-between gap-x-3 gap-y-2 border-t px-3 py-2 text-xs text-muted-foreground"');
const footerStart = source.indexOf('class="grid shrink-0 grid-cols-[minmax(0,1fr)_auto] items-center gap-2 border-t px-3 py-2 text-xs text-muted-foreground"');
const footerEnd = source.indexOf("</div>\n </div>\n </Pane>", footerStart);
expect(source.slice(footerStart, footerEnd)).not.toContain('t("nacos.selectedCount", { count: selectedConfigCount })');
expect(source).toContain('<ChevronLeft class="h-3.5 w-3.5" />');
expect(source).toContain('<ChevronRight class="h-3.5 w-3.5" />');
});
it("uses semantic coloring for instance enable and disable actions", () => {
expect(source).toContain("border-emerald-500/50 text-emerald-700");
expect(source).toContain("border-destructive/50 text-destructive hover:bg-destructive/10");
});
it("hides instance operations that the selected API plane does not support", () => {
expect(source).toContain('v-if="registerInstanceCapability.supported"');
expect(source).toContain('v-if="updateInstanceHealthCapability.supported"');
expect(source).toContain('v-if="deregisterInstanceCapability.supported"');
});
it("separates the service header, filtering controls, and management actions", () => {
expect(source).toContain('<header class="shrink-0 border-b bg-background">');
expect(source).toContain('class="nacos-service-toolbar flex flex-wrap items-center gap-x-4 gap-y-2 border-t bg-muted/30 px-4 py-2"');
expect(source).toContain('t("nacos.serviceSettings")');
expect(source).toContain('t("nacos.registerInstance")');
});
it("gates every Nacos mutation behind the shared production confirmation", () => {
expect(source).toContain('import { executeWithProductionContextGuard } from "@/lib/database/productionExecutionGuard";');
expect(source).toContain("async function confirmNacosMutation");
expect(source).toContain('<ProductionContextBadge v-if="nacosProductionContext.active" compact />');
expect(source.match(/await confirmNacosMutation\(/g)?.length).toBeGreaterThanOrEqual(9);
for (const apiCall of ["nacosApplyConfigImport", "nacosApplyConfigTransfer", "nacosRollbackConfig", "nacosPublishConfig", "nacosDeleteConfig", "nacosUpdateInstance", "nacosCreateService", "nacosDeleteService", "nacosRegisterInstance", "nacosDeregisterInstance"]) {
expect(source).toContain(apiCall);
}
});
});
@@ -11,24 +11,6 @@ const source = readFileSync(new URL("../NacosAdminConsole.vue", import.meta.url)
* wiring that only exists inside this component, which is too large to mount.
*/
describe("NacosAdminConsole YAML diagnostics wiring", () => {
it("installs and seeds the linter only for YAML configs", () => {
expect(source).toContain('...(format === "yaml" ? [nacosConfigYamlLintExtension(configDiagnosticTranslate)] : []),');
expect(source).toContain('if (format === "yaml") view.dispatch(setDiagnostics(view.state, nacosConfigYamlLintDiagnostics(view.state.doc.toString(), configDiagnosticTranslate)));');
// A YAML-only extension: each helper has exactly one call site, inside the gated branch.
expect(source.match(/nacosConfigYamlLintExtension\(/g)).toHaveLength(1);
expect(source.match(/nacosConfigYamlLintDiagnostics\(/g)).toHaveLength(1);
});
it("keeps the lint logic out of the component", () => {
// The component only formats and displays diagnostics; it never parses YAML itself.
expect(source).not.toContain("analyzeNacosYaml(");
expect(source).not.toContain("parseAllDocuments(");
expect(source).not.toContain("parseDocument(");
expect(source).toContain('import { setDiagnostics } from "@codemirror/lint";');
expect(source).toContain('import { nacosConfigYamlLintDiagnostics, nacosConfigYamlLintExtension } from "@/lib/nacos/nacosConfigYamlLint";');
expect(source).toContain('import { translateNacosYamlDiagnostic } from "@/lib/nacos/nacosYamlDiagnostics";');
});
it("blocks publishing on error severity only", () => {
expect(source).toContain("if (nacosConfigValidationBlocksPublish(diagnostics)) {");
expect(source).not.toContain('diagnostics.some((diagnostic) => nacosConfigDiagnosticSeverity(diagnostic) === "error")');
@@ -37,22 +19,6 @@ describe("NacosAdminConsole YAML diagnostics wiring", () => {
expect(source).toContain("if (!showSuccess) return true;");
});
it("does not double-mark YAML diagnostics with the legacy decoration", () => {
expect(source).toContain('const configUsesYamlLint = computed(() => resolveNacosConfigFormat(configType.value, configDataId.value) === "yaml");');
expect(source).toContain("configValidationHighlightActive = !configUsesYamlLint.value;");
expect(source).toContain("effects: setConfigValidationHighlight.of(configUsesYamlLint.value ? [] : configValidationDiagnostics.value),");
});
it("reports severity and localized messages in the validation dialog", () => {
expect(source).toContain('{{ configValidationHasError ? t("nacos.validationErrorTitle") : t("nacos.validationWarningTitle") }}');
expect(source).toContain('{{ configValidationHasError ? t("nacos.validationErrorDescription") : t("nacos.validationWarningDescription") }}');
// Asserted separately because the formatter may wrap the spans.
expect(source).toContain("{{ configValidationSeverityLabel(diagnostic) }}");
expect(source).toContain("{{ configValidationMessage(diagnostic) }}");
// The localized text is resolved through the shared helper, never a raw parser string.
expect(source).toContain("return diagnostic.code ? translateNacosYamlDiagnostic({ code: diagnostic.code, message: diagnostic.message, params: diagnostic.params ?? {} }, configDiagnosticTranslate) : diagnostic.message;");
});
it("localizes every key it references, including the new severity labels", () => {
const referenced = [
"validationErrorTitle",
@@ -72,20 +38,4 @@ describe("NacosAdminConsole YAML diagnostics wiring", () => {
expect((nacos[key] as string).length, key).toBeGreaterThan(0);
}
});
it("adds no watcher, listener, or observer for live diagnostics", () => {
// CodeMirror owns the debounce; a component-level watcher would re-parse on
// every keystroke and leak across config switches.
expect(source.match(/watch\(/g)).toHaveLength(6);
expect(source.match(/addEventListener\(/g)).toHaveLength(1);
expect(source.match(/removeEventListener\(/g)).toHaveLength(1);
expect(source.match(/onMounted\(/g)).toHaveLength(1);
expect(source.match(/new ResizeObserver/g)).toHaveLength(1);
});
it("still tears the editor view down when the config changes", () => {
expect(source).toContain("configEditorView.value?.destroy();");
expect(source).toContain("configEditorView.value = null;");
expect(source).toContain("await refreshConfigEditor();");
});
});
@@ -4,31 +4,6 @@ import { describe, expect, it } from "vitest";
const source = readFileSync(new URL("../NacosRoleAccessControl.vue", import.meta.url), "utf8");
describe("NacosRoleAccessControl", () => {
it("uses a directory-detail layout for both users and roles", () => {
expect(source).toContain('class="flex w-64 shrink-0 flex-col border-r');
expect(source).toContain("v-if=\"tab === 'users'\"");
expect(source).toContain("v-else-if=\"tab === 'roles' && selectedRole\"");
});
it("places the contextual create action beside search instead of duplicating refresh", () => {
expect(source).toContain(":aria-label=\"tab === 'users' ? t('nacos.createUser') : t('nacos.accessCreateRole')\"");
expect(source).toContain("@click=\"tab === 'users' ? openCreateUser() : openCreateRole()\"");
expect(source).toContain("<UserPlus v-if=\"tab === 'users'\"");
expect(source).toContain("<ShieldPlus v-else");
expect(source).not.toContain(":aria-label=\"t('nacos.refresh')\"");
expect(source).not.toContain('class="h-8 w-full"');
});
it("keeps role creation complete with per-namespace permissions", () => {
expect(source).toContain("roleForm.newUsers");
expect(source).toContain("moveNamespacesToGranted");
expect(source).toContain('action: "rw"');
expect(source).toContain("setPermissionAction");
expect(source).toContain("accessUnassignedNamespaces");
expect(source).toContain("accessGrantedNamespaces");
expect(source).toContain('kind: "createRole"');
});
it("keeps the selected role identity when opening the delete dialog", () => {
expect(source).toContain("resetRoleForm(selectedRole.value.role)");
});
@@ -46,67 +21,4 @@ describe("NacosRoleAccessControl", () => {
expect(source).toContain('t("nacos.accessDeleteUserConfirmationHint")');
expect(source).toContain("userDialog === 'delete' && !userDeleteConfirmed");
});
it("lets the backend workflow protect only the final ROLE_ADMIN member", () => {
expect(source).toContain("if (!selectedUser.value) return");
expect(source).not.toContain('selectedUser.value.roles.includes("ROLE_ADMIN")');
expect(source).not.toContain("v-if=\"!selectedUser.roles.includes('ROLE_ADMIN')\"");
});
it("shows complete IDs only in the unassigned namespace list", () => {
expect(source).toContain('class="block truncate font-medium" :title="namespace.name"');
expect(source).toContain('class="block break-all text-[10px] leading-4 text-muted-foreground" :title="namespace.id"');
expect(source).not.toContain('<code v-if="namespace.name !== namespace.namespaceId"');
});
it("uses a wider, internally scrollable namespace picker and filters by name or ID", () => {
expect(source).toContain('class="max-h-[90vh] overflow-auto sm:max-w-3xl"');
expect(source).toContain("h-[min(28rem,45vh)]");
expect(source).toContain('const id = item.id ?? item.namespaceId ?? ""');
expect(source).toContain("item.name.toLocaleLowerCase().includes(normalized) || id.toLocaleLowerCase().includes(normalized)");
expect(source).toContain(":aria-label=\"t('nacos.accessSearchNamespaces')\"");
});
it("refreshes the role namespace options after a namespace change for this connection", () => {
expect(source).toContain('import { subscribeNacosNamespacesChanged, type NacosNamespacesChangedDetail } from "@/lib/nacos/nacosNamespaceCache"');
expect(source).toContain("function handleNacosNamespacesChanged(detail: NacosNamespacesChangedDetail)");
expect(source).toContain("if (detail.connectionId === props.connectionId) void loadSnapshot()");
expect(source).toContain("stopNacosNamespacesChangedListener = subscribeNacosNamespacesChanged(handleNacosNamespacesChanged)");
expect(source).toContain("stopNacosNamespacesChangedListener?.()");
});
it("merges split permission rows before editing an existing role", () => {
expect(source).toContain("mergeNacosNamespacePermissionAssignments(managedRolePermissions.value)");
});
it("gates every mutation by its probed operation capability", () => {
expect(source).toContain("capabilities: NacosAccessControlCapabilities");
expect(source).toContain("const canCreateUser = computed");
expect(source).toContain("const canGrantPermission = computed");
expect(source).toContain("const userOperationWritable = computed");
expect(source).toContain("const roleOperationWritable = computed");
expect(source).toContain(':disabled="saving || !userOperationWritable ||');
expect(source).toContain(':disabled="saving || !roleOperationWritable ||');
});
it("surfaces partial operations instead of hiding them in a toast", () => {
expect(source).toContain("operationNeedsPasswords");
expect(source).toContain("nacosRetryAccessOperation");
expect(source).toContain("nacosUndoAccessOperation");
expect(source).toContain("accessOperationResult");
});
it("uses the global notification for password reset results", () => {
expect(source).toContain('import { useToast } from "@/composables/useToast"');
expect(source).toContain("const { toast } = useToast()");
expect(source).toContain('toast(t("nacos.passwordResetSucceeded", { username }), 2500)');
expect(source).toContain('toast(t("nacos.passwordResetFailed", { message }), 5000)');
});
it("renders associated roles with the same navigable card pattern as role members", () => {
expect(source).toContain('v-if="selectedUser.roles.length" class="flex flex-wrap gap-1.5 rounded border bg-muted/20 p-1.5"');
expect(source).toContain(":title=\"t('nacos.accessOpenRole', { role })\"");
expect(source).toContain('@click="openAssociatedRole(role)"');
expect(source).toContain('emit("select-role")');
});
});