fix(transfer): count tables in rebuild confirm and localize hints

This commit is contained in:
HolyeTyrone authored and GitHub committed 2026-09-09 14:44:35 +08:00
1 parent 4e8a58a08c
commit 894ecdec42
12 files changed
+12 -12

No files matched your search

@@ -1048,7 +1048,7 @@ const confirmationSummary = computed(() => {
if (!request) return "";
const source = `${getConnectionName(request.sourceConnectionId)}.${request.sourceDatabase}.${request.sourceSchema}`;
const target = `${getConnectionName(request.targetConnectionId)}.${request.targetDatabase}.${request.targetSchema}`;
const count = request.objects.reduce((total, selection) => total + selection.names.length, 0);
const count = request.tables.length + request.objects.reduce((total, selection) => total + selection.names.length, 0);
return t("transfer.startConfirmMessage", { source, target, count });
});
@@ -1056,7 +1056,8 @@ const confirmationStrategy = computed(() => (confirmationRequest.value ? transfe
const rebuildConfirmationDetails = computed(() => {
const rebuild = confirmationPreview.value?.rebuild;
if (!rebuild) return "";
return [confirmationSummary.value, t("transfer.rebuildSummary", { count: rebuild.tables.length }), ...rebuild.warnings].filter(Boolean).join("\n");
const missingTargets = rebuild.tables.some((table) => !table.backupTable);
return [confirmationSummary.value, t("transfer.rebuildSummary", { count: rebuild.tables.length }), missingTargets ? t("transfer.rebuildMissingTargets") : ""].filter(Boolean).join("\n");
});
function requestTransferConfirmation(request: api.TransferRequest, preview: api.TransferOwnershipPreview): Promise<boolean> {
@@ -46,7 +46,6 @@ function preview(overrides: Partial<TransferOwnershipPreview> = {}): TransferOwn
rebuild: {
sql: 'ALTER TABLE "reporting"."orders" RENAME TO "orders__dbx_bak_123";\nCREATE TABLE "reporting"."orders" ("id" INTEGER);',
tables: [{ sourceTable: "Orders", targetTable: '"reporting"."orders"', backupTable: '"reporting"."orders__dbx_bak_123"' }],
warnings: ["Target-only metadata will be replaced"],
},
...overrides,
};