fix(grid): keep filter editor open after apply

Closes #10181
This commit is contained in:
t8y2 committed 2026-09-26 12:45:30 +00:00
1 parent 8a385c3348
commit 8b3843dfd8
14 files changed
+252 -37

No files matched your search

+9 -2
View File
@@ -59,7 +59,7 @@ describe("normalizeEditorSettings", () => {
expect(normalizeEditorSettings({ dataGridToolbarLayout: "invalid" } as any).dataGridToolbarLayout).toBe("single");
});
it("keeps filter editor expansion disabled unless explicitly enabled", () => {
it("keeps initial filter editor expansion disabled unless explicitly enabled", () => {
expect(normalizeEditorSettings({}).dataGridKeepFilterEditorExpanded).toBe(false);
expect(normalizeEditorSettings({ dataGridKeepFilterEditorExpanded: true }).dataGridKeepFilterEditorExpanded).toBe(true);
expect(normalizeEditorSettings({ dataGridKeepFilterEditorExpanded: false }).dataGridKeepFilterEditorExpanded).toBe(false);
@@ -68,10 +68,17 @@ describe("normalizeEditorSettings", () => {
expect(normalizeEditorSettings({ dataGridKeepFilterEditorExpanded: "true", dataGridAutoHideFilterBuilder: false } as any).dataGridKeepFilterEditorExpanded).toBe(false);
});
it("migrates the legacy auto-hide preference when the current preference is absent", () => {
it("normalizes the legacy auto-hide preference into the initial expansion preference", () => {
expect(normalizeEditorSettings({ dataGridAutoHideFilterBuilder: false } as any).dataGridKeepFilterEditorExpanded).toBe(true);
expect(normalizeEditorSettings({ dataGridAutoHideFilterBuilder: true } as any).dataGridKeepFilterEditorExpanded).toBe(false);
expect(normalizeEditorSettings({ dataGridKeepFilterEditorExpanded: false, dataGridAutoHideFilterBuilder: false } as any).dataGridKeepFilterEditorExpanded).toBe(false);
expect(normalizeEditorSettings({ dataGridKeepFilterEditorExpanded: true, dataGridAutoHideFilterBuilder: true } as any).dataGridKeepFilterEditorExpanded).toBe(true);
});
it("ignores malformed legacy auto-hide values during expansion normalization", () => {
expect(normalizeEditorSettings({ dataGridAutoHideFilterBuilder: "false" } as any).dataGridKeepFilterEditorExpanded).toBe(false);
expect(normalizeEditorSettings({ dataGridAutoHideFilterBuilder: 0 } as any).dataGridKeepFilterEditorExpanded).toBe(false);
expect(normalizeEditorSettings({ dataGridAutoHideFilterBuilder: null } as any).dataGridKeepFilterEditorExpanded).toBe(false);
});
it("normalizes persisted tab group names and colors", () => {
+3 -2
View File
@@ -884,6 +884,7 @@ export interface EditorSettings {
dataGridQuickEntry: boolean;
dataGridFilterEditorView: DataGridFilterEditorView;
dataGridToolbarLayout: DataGridToolbarLayout;
/** Opens Conditions/Text filter editors initially; users can still collapse them. */
dataGridKeepFilterEditorExpanded: boolean;
dataGridTextFilterPanelHeight: number;
localFilterPopoverWidth: number;
@@ -1875,8 +1876,8 @@ export function normalizeEditorSettings(settings: Partial<EditorSettings>, exist
/**
* Cloud snapshots are applied as partial settings updates rather than loaded
* through `normalizeEditorSettings`. Translate the removed inverse flag here
* so older snapshots retain their behavior on every incremental update path.
* through `normalizeEditorSettings`. Translate the removed inverse flag into
* the current initial-expansion preference on every incremental update path.
*/
function migrateLegacyFilterEditorExpansionPatch(partial: Partial<EditorSettings>): Partial<EditorSettings> {
const patch = partial as Partial<EditorSettings> & { dataGridAutoHideFilterBuilder?: unknown };