fix(editor): preserve user-adjusted SQL editor position during execution
This commit is contained in:
4 files changed
+86
-17
No files matched your search
@@ -2,6 +2,8 @@ export function createQueryEditorExecutionViewportOwnership() {
|
||||
let nextRequestId = 0;
|
||||
let pendingRequestId: number | undefined;
|
||||
let acceptedRequestId: number | undefined;
|
||||
let executionActive = false;
|
||||
let userInteractedDuringExecution = false;
|
||||
|
||||
return {
|
||||
beginRequest(): number {
|
||||
@@ -18,14 +20,25 @@ export function createQueryEditorExecutionViewportOwnership() {
|
||||
acceptedRequestId = requestId;
|
||||
return true;
|
||||
},
|
||||
consumeAcceptedRequest(): boolean {
|
||||
if (acceptedRequestId === undefined) return false;
|
||||
beginExecution() {
|
||||
executionActive = true;
|
||||
userInteractedDuringExecution = false;
|
||||
},
|
||||
recordUserInteraction() {
|
||||
if (executionActive) userInteractedDuringExecution = true;
|
||||
},
|
||||
consumeCompletionPreservation(): boolean {
|
||||
const preserveViewport = acceptedRequestId !== undefined || userInteractedDuringExecution;
|
||||
acceptedRequestId = undefined;
|
||||
return true;
|
||||
executionActive = false;
|
||||
userInteractedDuringExecution = false;
|
||||
return preserveViewport;
|
||||
},
|
||||
reset() {
|
||||
pendingRequestId = undefined;
|
||||
acceptedRequestId = undefined;
|
||||
executionActive = false;
|
||||
userInteractedDuringExecution = false;
|
||||
},
|
||||
};
|
||||
}
|
||||
Reference in new issue
Block a user