github/dbx
4
0
Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-10-30 08:20:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: parse MySQL JDBC URL credentials (#556)

Browse Source
This commit is contained in:
vrustx
2026-05-30 23:43:35 +08:00
committed by GitHub
parent 7c0ed986c1
commit 8ef4794105
2 changed files with 55 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/desktop/src/lib/connectionUrl.ts
+33 -5
View File
@@ -79,6 +79,30 @@ function queryParamValue(params: string, key: string): string | undefined {
return undefined;
}
function extractMysqlCredentialParams(params: string): { username?: string; password?: string; urlParams: string } {
let username: string | undefined;
let password: string | undefined;
let foundCredentialParam = false;
const urlParams: string[] = [];
for (const part of params.split(/[&;]/)) {
if (!part) continue;
const [rawKey, ...rest] = part.split("=");
const key = decodeUrlPart(rawKey).trim().toLowerCase();
if (key === "user") {
username = decodeUrlPart(rest.join("=")).trim();
foundCredentialParam = true;
} else if (key === "password") {
password = decodeUrlPart(rest.join("=")).trim();
foundCredentialParam = true;
} else {
urlParams.push(part);
}
}
return { username, password, urlParams: foundCredentialParam ? urlParams.join("&") : params };
}
function urlParamsRequireTls(dbType: DatabaseType, params: string): boolean {
if (dbType === "mysql") {
const requireSsl = queryParamValue(params, "require_ssl")?.toLowerCase();
@@ -243,7 +267,8 @@ export function parseConnectionUrl(value: string, preferredProfile?: string): Pa
if (jdbcOracle) return jdbcOracle;
const jdbcSqlServer = parseJdbcSqlServerUrl(input);
if (jdbcSqlServer) return jdbcSqlServer;
const source = input.replace(/^jdbc:/i, "");
const isJdbcUrl = /^jdbc:/i.test(input);
const source = isJdbcUrl ? input.replace(/^jdbc:/i, "") : input;
let parsed: URL;
try {
@@ -264,6 +289,9 @@ export function parseConnectionUrl(value: string, preferredProfile?: string): Pa
profile.type === "redis" && normalizedFragment === "insecure"
? [urlParams, "insecure=true"].filter(Boolean).join("&")
: urlParams;
const mysqlCredentials =
isJdbcUrl && profile.type === "mysql" ? extractMysqlCredentialParams(parsedUrlParams) : undefined;
const effectiveUrlParams = mysqlCredentials?.urlParams ?? parsedUrlParams;
if (profile.type === "mongodb") {
return {
dbType: profile.type,
@@ -287,11 +315,11 @@ export function parseConnectionUrl(value: string, preferredProfile?: string): Pa
driverLabel: profile.label,
host: parsed.hostname,
port: parsed.port ? Number(parsed.port) : profile.defaultPort,
username: decodeUrlPart(parsed.username),
password: decodeUrlPart(parsed.password),
username: mysqlCredentials?.username ?? decodeUrlPart(parsed.username),
password: mysqlCredentials?.password ?? decodeUrlPart(parsed.password),
database: databaseFromPath(parsed.pathname),
urlParams: parsedUrlParams,
ssl: scheme === "rediss" || scheme === "https" || urlParamsRequireTls(profile.type, parsedUrlParams),
urlParams: effectiveUrlParams,
ssl: scheme === "rediss" || scheme === "https" || urlParamsRequireTls(profile.type, effectiveUrlParams),
};
}