feat(safety): temporary write-unlock window for read-only connections
This commit is contained in:
1 parent
7933b7656f
commit
955558c81f
66 files changed
+1176
-124
No files matched your search
@@ -19,6 +19,9 @@ vi.mock("@/lib/backend/api", () => ({
|
||||
executeConditionalUpdate: mocks.executeConditionalUpdate,
|
||||
cancelConditionalUpdate: mocks.cancelConditionalUpdate,
|
||||
executeInTransaction: mocks.executeInTransaction,
|
||||
unlockConnectionWrites: vi.fn(),
|
||||
lockConnectionWrites: vi.fn(),
|
||||
connectionWriteUnlockState: vi.fn().mockResolvedValue(0),
|
||||
}));
|
||||
vi.mock("@/stores/connectionStore", () => ({
|
||||
useConnectionStore: () => ({ getConfig: mocks.getConfig }),
|
||||
|
||||
@@ -10,7 +10,7 @@ vi.mock("@/stores/connectionStore", () => ({
|
||||
useConnectionStore: () => ({
|
||||
getConfig: (id: string) => {
|
||||
if (id === "missing") return undefined;
|
||||
if (id === "readonly") return { name: "ro", read_only: true, is_production: false };
|
||||
if (id === "readonly") return { id: "readonly", name: "ro", read_only: true, is_production: false, db_type: "mq" };
|
||||
if (id === "prod") return { name: "prod-mq", read_only: false, is_production: true };
|
||||
return { name: "dev-mq", read_only: false, is_production: false };
|
||||
},
|
||||
@@ -21,6 +21,12 @@ vi.mock("@/stores/productionSafetyStore", () => ({
|
||||
useProductionSafetyStore: () => ({ requestConfirmation }),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/backend/api", () => ({
|
||||
unlockConnectionWrites: vi.fn(),
|
||||
lockConnectionWrites: vi.fn(),
|
||||
connectionWriteUnlockState: vi.fn().mockResolvedValue(0),
|
||||
}));
|
||||
|
||||
vi.mock("@/composables/useToast", () => ({
|
||||
useToast: () => ({ toast }),
|
||||
}));
|
||||
@@ -32,6 +38,7 @@ vi.mock("vue-i18n", () => ({
|
||||
}));
|
||||
|
||||
import { useMqMutationGuard } from "@/composables/useMqMutationGuard";
|
||||
import { useReadOnlyUnlockStore } from "@/stores/readOnlyUnlockStore";
|
||||
|
||||
describe("useMqMutationGuard", () => {
|
||||
beforeEach(() => {
|
||||
@@ -41,14 +48,20 @@ describe("useMqMutationGuard", () => {
|
||||
toast.mockReset();
|
||||
});
|
||||
|
||||
it("denies missing and read-only connections without prompting", async () => {
|
||||
it("denies missing connections and prompts to unlock read-only ones", async () => {
|
||||
const missing = useMqMutationGuard("missing");
|
||||
const readonly = useMqMutationGuard("readonly");
|
||||
await expect(missing.confirmMqWrite("send")).resolves.toBe(false);
|
||||
await expect(readonly.confirmMqWrite("send")).resolves.toBe(false);
|
||||
expect(requestConfirmation).not.toHaveBeenCalled();
|
||||
expect(toast).toHaveBeenCalledWith("mqAdmin.connectionMissing");
|
||||
expect(toast).toHaveBeenCalledWith("mqAdmin.writeDeniedReadOnly");
|
||||
|
||||
const unlockStore = useReadOnlyUnlockStore();
|
||||
const readonly = useMqMutationGuard("readonly");
|
||||
const pending = readonly.confirmMqWrite("send");
|
||||
await vi.waitFor(() => {
|
||||
expect(unlockStore.pending?.connectionId).toBe("readonly");
|
||||
});
|
||||
expect(requestConfirmation).not.toHaveBeenCalled();
|
||||
unlockStore.cancel();
|
||||
await expect(pending).resolves.toBe(false);
|
||||
});
|
||||
|
||||
it("allows non-production writes immediately", async () => {
|
||||
|
||||
@@ -17,6 +17,9 @@ vi.mock("vue-i18n", () => ({
|
||||
vi.mock("@/lib/backend/api", () => ({
|
||||
saveEditorSettings: vi.fn(),
|
||||
saveHistory: vi.fn(),
|
||||
unlockConnectionWrites: vi.fn(),
|
||||
lockConnectionWrites: vi.fn(),
|
||||
connectionWriteUnlockState: vi.fn().mockResolvedValue(0),
|
||||
}));
|
||||
|
||||
function installLocalStorage() {
|
||||
@@ -1199,8 +1202,9 @@ SELECT @value AS Message;`;
|
||||
});
|
||||
|
||||
const pendingExecution = execution.tryExecute();
|
||||
await Promise.resolve();
|
||||
expect(productionSafetyStore.pending?.sql).toContain("UPDATE users");
|
||||
await vi.waitFor(() => {
|
||||
expect(productionSafetyStore.pending?.sql).toContain("UPDATE users");
|
||||
});
|
||||
expect(executeCurrentSql).not.toHaveBeenCalled();
|
||||
|
||||
productionSafetyStore.confirm();
|
||||
|
||||
@@ -28,6 +28,9 @@ vi.mock("vue-i18n", () => ({
|
||||
vi.mock("@/lib/backend/api", () => ({
|
||||
saveEditorSettings: vi.fn(),
|
||||
saveHistory: vi.fn(),
|
||||
unlockConnectionWrites: vi.fn(),
|
||||
lockConnectionWrites: vi.fn(),
|
||||
connectionWriteUnlockState: vi.fn().mockResolvedValue(0),
|
||||
}));
|
||||
|
||||
function installLocalStorage() {
|
||||
|
||||
@@ -11,6 +11,7 @@ import { useConnectionStore } from "@/stores/connectionStore";
|
||||
import { useHistoryStore } from "@/stores/historyStore";
|
||||
import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
|
||||
import { assessProductionSql, productionContextForDatabase } from "@/lib/database/productionSafety";
|
||||
import { ensureReadOnlyWriteAccess, isWriteUnlockActive } from "@/lib/database/readOnlyWriteAccess";
|
||||
import type { ColumnInfo, DatabaseType } from "@/types/database";
|
||||
import { DBX_NEO4J_ELEMENT_ID_COLUMN, usesSyntheticRowIdKey } from "@/lib/table/tableEditing";
|
||||
import { effectiveDatabaseTypeForConnection } from "@/lib/database/jdbcDialect";
|
||||
@@ -1598,6 +1599,7 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
|
||||
|
||||
saveError.value = "";
|
||||
const connection = connectionStore.getConfig(connectionId.value);
|
||||
if (!(await ensureReadOnlyWriteAccess({ connection, sql: statement, source: i18n.global.t("readOnlyUnlock.sourceDataEditor") }))) return null;
|
||||
const productionAssessment = assessProductionSql(statement, connection, database.value);
|
||||
if (productionAssessment.active && productionAssessment.isMutation) {
|
||||
const confirmed = await productionSafetyStore.requestConfirmation({
|
||||
@@ -1605,7 +1607,7 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
|
||||
connectionName: connection?.name,
|
||||
database: database.value,
|
||||
productionDatabases: productionAssessment.databases,
|
||||
source: "Data editor",
|
||||
source: i18n.global.t("readOnlyUnlock.sourceDataEditor"),
|
||||
});
|
||||
if (!confirmed) return null;
|
||||
}
|
||||
@@ -1701,6 +1703,12 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
|
||||
}
|
||||
const customHandler = customSaveHandler?.value;
|
||||
const connection = connectionStore.getConfig(connectionId.value ?? "");
|
||||
if (connection?.read_only) {
|
||||
if (saveOptions.autoSave && !isWriteUnlockActive(connection.id)) return;
|
||||
if (!(await ensureReadOnlyWriteAccess({ connection, sql: describeDataGridChanges(snapshot), source: i18n.global.t("readOnlyUnlock.sourceDataEditor"), treatAsMutation: true }))) {
|
||||
return;
|
||||
}
|
||||
}
|
||||
const customHandlerProductionContext = productionContextForDatabase(connection, database.value);
|
||||
if (customHandler && customHandlerProductionContext.active) {
|
||||
// Custom data sources may not expose SQL, but their row mutations still need the same production interlock.
|
||||
@@ -1712,7 +1720,7 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
|
||||
connectionName: connection?.name,
|
||||
database: database.value,
|
||||
productionDatabases: customHandlerProductionContext.databases,
|
||||
source: "Data editor",
|
||||
source: i18n.global.t("readOnlyUnlock.sourceDataEditor"),
|
||||
});
|
||||
if (!confirmed) return;
|
||||
}
|
||||
@@ -1793,7 +1801,7 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
|
||||
connectionName: connection?.name,
|
||||
database: database.value,
|
||||
productionDatabases: productionAssessment.databases,
|
||||
source: "Data editor",
|
||||
source: i18n.global.t("readOnlyUnlock.sourceDataEditor"),
|
||||
});
|
||||
if (!confirmed) {
|
||||
await finishInterruptedSaveChanges(snapshot);
|
||||
|
||||
@@ -2,6 +2,7 @@ import { toValue, type MaybeRefOrGetter } from "vue";
|
||||
import { useI18n } from "vue-i18n";
|
||||
import { useConnectionStore } from "@/stores/connectionStore";
|
||||
import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
|
||||
import { ensureReadOnlyWriteAccess } from "@/lib/database/readOnlyWriteAccess";
|
||||
import { useToast } from "@/composables/useToast";
|
||||
|
||||
/**
|
||||
@@ -24,8 +25,7 @@ export function useMqMutationGuard(connectionId: MaybeRefOrGetter<string>) {
|
||||
toast(t("mqAdmin.connectionMissing"));
|
||||
return false;
|
||||
}
|
||||
if (config.read_only) {
|
||||
toast(t("mqAdmin.writeDeniedReadOnly"));
|
||||
if (!(await ensureReadOnlyWriteAccess({ connection: config, sql: operation, source: t("production.sourceMq"), treatAsMutation: true }))) {
|
||||
return false;
|
||||
}
|
||||
if (!config.is_production) return true;
|
||||
|
||||
@@ -4,6 +4,7 @@ import { useToast } from "@/composables/useToast";
|
||||
import { useConnectionStore } from "@/stores/connectionStore";
|
||||
import type { DatabaseType, TreeNode } from "@/types/database";
|
||||
import { supportsTableTruncate, supportsTableVacuum } from "@/lib/database/databaseCapabilities";
|
||||
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
|
||||
import {
|
||||
buildDropTableSql,
|
||||
buildEmptyTableSql,
|
||||
@@ -66,7 +67,7 @@ export function useSidebarTableMutationRuntime(options: SidebarTableMutationRunt
|
||||
const supportsTruncate = computed(() => supportsTableTruncate(currentDatabaseType()));
|
||||
const supportsVacuum = computed(() => {
|
||||
const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined;
|
||||
return activeNode.value.type === "table" && !config?.read_only && supportsTableVacuum(currentDatabaseType());
|
||||
return activeNode.value.type === "table" && !connectionIsEffectivelyReadOnly(config) && supportsTableVacuum(currentDatabaseType());
|
||||
});
|
||||
const canDropTableCascade = computed(() => activeNode.value.type === "table" && supportsDropTableCascade(currentDatabaseType()));
|
||||
const canTruncateTableCascade = computed(() => activeNode.value.type === "table" && supportsTruncateTableCascade(currentDatabaseType()));
|
||||
|
||||
@@ -19,6 +19,7 @@ import { extractSqlParameterDescriptors, type SqlParameterDescriptor, type SqlPa
|
||||
import { expandSqlVariables } from "@/lib/sql/sqlVariables";
|
||||
import { enabledSqlParameterSyntaxes, resolveSqlVariableSyntaxToggles } from "@/lib/sql/sqlVariableSyntax";
|
||||
import { assessProductionSql } from "@/lib/database/productionSafety";
|
||||
import { ensureReadOnlyWriteAccess } from "@/lib/database/readOnlyWriteAccess";
|
||||
import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
|
||||
import type { SqlExecutionDangerRequest } from "@/stores/sqlExecutionDangerStore";
|
||||
import type { ConnectionConfig, DatabaseType, QueryTab } from "@/types/database";
|
||||
@@ -176,6 +177,7 @@ export function useSqlExecution(deps: {
|
||||
}
|
||||
|
||||
async function continueExecute(sql: string, sourceOffset?: number, options: SqlExecutionOptions = {}) {
|
||||
if (!(await ensureReadOnlyWriteAccess({ connection: deps.activeConnection.value, sql, source: t("production.sourceSqlEditor") }))) return;
|
||||
// Redis: block dangerous commands when toggle is on (scan entire batch for highest safety level)
|
||||
if (deps.activeConnection.value?.db_type === "redis" && deps.blockDangerousRedisCommands?.value !== false) {
|
||||
const commands = sql
|
||||
@@ -358,6 +360,9 @@ export function useSqlExecution(deps: {
|
||||
const tabCancelRequested = (count: number) => (tab.cancelRequestCount ?? 0) !== count;
|
||||
if (cancelRequested()) return finish({ status: "cancelled" });
|
||||
if (!sql.trim()) return finish({ status: "failed", errorMessage: t("explain.emptySql") });
|
||||
if (!(await ensureReadOnlyWriteAccess({ connection, sql, source: t("production.sourceMultiDbSql") }))) {
|
||||
return finish({ status: "skipped", errorMessage: t("dangerDialog.cancel") });
|
||||
}
|
||||
if (requiresDatabaseSelection(executionTab, connection, sql)) {
|
||||
return finish({ status: "failed", errorMessage: t("editor.selectDatabaseRequired") });
|
||||
}
|
||||
@@ -544,6 +549,7 @@ export function useSqlExecution(deps: {
|
||||
settingsStore.updateEditorSettings({ confirmDangerousSqlExecution: false });
|
||||
}
|
||||
suppressDangerConfirm.value = false;
|
||||
if (!(await ensureReadOnlyWriteAccess({ connection: deps.activeConnection.value, sql, source: t("production.sourceSqlEditor") }))) return;
|
||||
await doExecute(sql, sourceOffset, { openInNewResultTab, editorViewportRequestId });
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user