feat(safety): temporary write-unlock window for read-only connections

This commit is contained in:
Farahani authored and GitHub committed 2026-08-27 17:37:54 +08:00
1 parent 7933b7656f
commit 955558c81f
66 files changed
+1176 -124

No files matched your search

+3
View File
@@ -331,6 +331,9 @@ async fn main() {
.route("/connection/connect", post(routes::connection::connect_db))
.route("/connection/database-info", post(routes::connection::connected_database_info))
.route("/connection/database-info/save", post(routes::connection::save_connection_database_info))
.route("/connection/write-unlock", post(routes::connection::unlock_connection_writes))
.route("/connection/write-unlock/lock", post(routes::connection::lock_connection_writes))
.route("/connection/write-unlock/state", post(routes::connection::connection_write_unlock_state))
.route("/connection/final-proxy-port", post(routes::connection::connection_final_proxy_port))
.route("/connection/disconnect", post(routes::connection::disconnect_db))
.route("/connection/check-health", post(routes::connection::check_connection_health))
+43 -1
View File
@@ -15,7 +15,7 @@ use dbx_core::runtime_config::{
release_runtime_config_on_disconnect, should_retain_runtime_config, TEST_PROBE_ID_PREFIX,
};
use dbx_core::session_credentials::{PurposeSessionCredentialWriteToken, SessionCredentialWriteToken};
use serde::Deserialize;
use serde::{Deserialize, Serialize};
use crate::auth::session_token_from_headers;
use crate::error::AppError;
@@ -141,6 +141,19 @@ pub struct SaveConnectionDatabaseInfoRequest {
pub database_info: Option<DatabaseConnectionInfo>,
}
#[derive(Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct UnlockConnectionWritesRequest {
pub connection_id: String,
pub duration_secs: u64,
}
#[derive(Serialize)]
#[serde(rename_all = "camelCase")]
pub struct WriteUnlockStateResponse {
pub remaining_ms: u64,
}
#[derive(Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct SaveConnectionsRequest {
@@ -441,6 +454,35 @@ pub async fn save_connection_database_info(
.map_err(AppError::from)
}
pub async fn unlock_connection_writes(
State(state): State<Arc<WebState>>,
Json(body): Json<UnlockConnectionWritesRequest>,
) -> Result<Json<WriteUnlockStateResponse>, AppError> {
if !state.app.configs.read().await.contains_key(&body.connection_id) {
return Err(AppError::from("Connection not found".to_string()));
}
let remaining_ms =
state.app.write_unlock_windows.unlock(&body.connection_id, body.duration_secs).await.map_err(AppError::from)?;
Ok(Json(WriteUnlockStateResponse { remaining_ms }))
}
pub async fn lock_connection_writes(
State(state): State<Arc<WebState>>,
Json(body): Json<ConnectionIdentifierQuoteRequest>,
) -> Result<Json<()>, AppError> {
state.app.write_unlock_windows.lock(&body.connection_id).await;
Ok(Json(()))
}
pub async fn connection_write_unlock_state(
State(state): State<Arc<WebState>>,
Json(body): Json<ConnectionIdentifierQuoteRequest>,
) -> Result<Json<WriteUnlockStateResponse>, AppError> {
Ok(Json(WriteUnlockStateResponse {
remaining_ms: state.app.write_unlock_windows.remaining_ms(&body.connection_id).await,
}))
}
pub async fn connection_final_proxy_port(
State(state): State<Arc<WebState>>,
headers: HeaderMap,