feat(safety): temporary write-unlock window for read-only connections

This commit is contained in:
Farahani authored and GitHub committed 2026-08-27 17:37:54 +08:00
1 parent 7933b7656f
commit 955558c81f
66 files changed
+1176 -124

No files matched your search

@@ -0,0 +1,73 @@
<script setup lang="ts">
import { computed, onMounted, watch } from "vue";
import { useI18n } from "vue-i18n";
import { Lock, Unlock } from "@lucide/vue";
import { Tooltip, TooltipContent, TooltipTrigger } from "@/components/ui/tooltip";
import { useConnectionStore } from "@/stores/connectionStore";
import { useReadOnlyUnlockStore } from "@/stores/readOnlyUnlockStore";
import { formatWriteUnlockRemaining } from "@/lib/database/readOnlyWriteAccess";
const props = defineProps<{
connectionId: string;
compact?: boolean;
showLabel?: boolean;
}>();
const { t } = useI18n();
const connectionStore = useConnectionStore();
const unlockStore = useReadOnlyUnlockStore();
const persistentlyReadOnly = computed(() => connectionStore.getConfig(props.connectionId)?.read_only === true);
const remainingMs = computed(() => unlockStore.remainingMs(props.connectionId));
const unlocked = computed(() => remainingMs.value > 0);
const remainingLabel = computed(() => formatWriteUnlockRemaining(remainingMs.value));
const tooltip = computed(() => {
if (unlocked.value) return `${t("readOnlyUnlock.unlockedBadge")} · ${t("readOnlyUnlock.remaining", { time: remainingLabel.value })}`;
return t("connection.readOnlyBadge");
});
async function onActivate() {
if (!persistentlyReadOnly.value) return;
if (unlocked.value) {
await unlockStore.lockNow(props.connectionId);
return;
}
await unlockStore.requestUnlock({
connectionId: props.connectionId,
connectionName: connectionStore.getConfig(props.connectionId)?.name,
source: t("readOnlyUnlock.sourceStatus"),
});
}
watch(
() => props.connectionId,
(connectionId) => {
if (persistentlyReadOnly.value) void unlockStore.refreshFromBackend(connectionId);
},
);
onMounted(() => {
if (persistentlyReadOnly.value) void unlockStore.refreshFromBackend(props.connectionId);
});
</script>
<template>
<Tooltip v-if="persistentlyReadOnly">
<TooltipTrigger as-child>
<button
type="button"
class="inline-flex items-center gap-0.5 rounded text-muted-foreground hover:bg-muted-foreground/15 hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
:class="compact ? 'h-4 px-0.5' : 'h-4 px-1'"
:aria-label="unlocked ? t('readOnlyUnlock.lockNow') : t('readOnlyUnlock.unlockAction')"
:title="unlocked ? t('readOnlyUnlock.lockNow') : t('readOnlyUnlock.unlockAction')"
@click.stop.prevent="onActivate"
>
<Unlock v-if="unlocked" class="h-3 w-3 shrink-0 text-amber-600 dark:text-amber-400" />
<Lock v-else class="h-3 w-3 shrink-0" />
<span v-if="showLabel && !unlocked" class="text-[10px] leading-none">{{ t("connection.readOnlyBadge") }}</span>
<span v-if="unlocked" class="text-[10px] tabular-nums leading-none">{{ remainingLabel }}</span>
</button>
</TooltipTrigger>
<TooltipContent>{{ tooltip }}</TooltipContent>
</Tooltip>
</template>
@@ -6,6 +6,7 @@ import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle } from "
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs"; import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import NacosConfigDiffDialog from "@/components/nacos/NacosConfigDiffDialog.vue"; import NacosConfigDiffDialog from "@/components/nacos/NacosConfigDiffDialog.vue";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import type { ConsulAclItem, ConsulAclKind, ConsulAclReferences, ConsulAclWrite, ConsulCapabilities } from "@/types/consul"; import type { ConsulAclItem, ConsulAclKind, ConsulAclReferences, ConsulAclWrite, ConsulCapabilities } from "@/types/consul";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
@@ -13,7 +14,7 @@ import { useI18n } from "vue-i18n";
const props = defineProps<{ connectionId: string; capabilities: ConsulCapabilities | null }>(); const props = defineProps<{ connectionId: string; capabilities: ConsulCapabilities | null }>();
const { t } = useI18n(); const { t } = useI18n();
const store = useConnectionStore(); const store = useConnectionStore();
const readOnly = computed(() => Boolean(store.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(store.getConfig(props.connectionId)));
const active = ref<ConsulAclKind>("token"); const active = ref<ConsulAclKind>("token");
const items = ref<Record<string, unknown>[]>([]); const items = ref<Record<string, unknown>[]>([]);
const loading = ref(false); const loading = ref(false);
@@ -15,6 +15,7 @@ import * as api from "@/lib/backend/api";
import { isTauriRuntime } from "@/lib/backend/tauriRuntime"; import { isTauriRuntime } from "@/lib/backend/tauriRuntime";
import { kvExportFilenameStem, type KvExportScopeRequest } from "@/lib/kv/kvExportScope"; import { kvExportFilenameStem, type KvExportScopeRequest } from "@/lib/kv/kvExportScope";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useConsulStore } from "@/stores/consulStore"; import { useConsulStore } from "@/stores/consulStore";
import { isCurrentWatchEvent, nextWatchIndex } from "@/lib/consul/watchState"; import { isCurrentWatchEvent, nextWatchIndex } from "@/lib/consul/watchState";
import type { ConsulDeletePrefixPreview, ConsulDeletePrefixReport, ConsulImportConflictPolicy, ConsulImportPreview, ConsulImportReport, ConsulKvBundle, ConsulSearchMatch, ConsulScope, ConsulWatchEvent } from "@/types/consul"; import type { ConsulDeletePrefixPreview, ConsulDeletePrefixReport, ConsulImportConflictPolicy, ConsulImportPreview, ConsulImportReport, ConsulKvBundle, ConsulSearchMatch, ConsulScope, ConsulWatchEvent } from "@/types/consul";
@@ -26,7 +27,7 @@ const connectionStore = useConnectionStore();
const consulStore = useConsulStore(); const consulStore = useConsulStore();
const browserRef = ref<InstanceType<typeof KvKeyBrowser> | null>(null); const browserRef = ref<InstanceType<typeof KvKeyBrowser> | null>(null);
const fileInputRef = ref<HTMLInputElement>(); const fileInputRef = ref<HTMLInputElement>();
const readOnly = computed(() => Boolean(connectionStore.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const consulConnections = computed(() => connectionStore.connections.filter((connection) => connection.db_type === "consul")); const consulConnections = computed(() => connectionStore.connections.filter((connection) => connection.db_type === "consul"));
const transferTargetConnections = computed(() => (transferMode.value === "migration" ? consulConnections.value.filter((connection) => connection.id !== props.connectionId) : consulConnections.value)); const transferTargetConnections = computed(() => (transferMode.value === "migration" ? consulConnections.value.filter((connection) => connection.id !== props.connectionId) : consulConnections.value));
@@ -66,7 +67,7 @@ const transferReport = ref<ConsulImportReport | null>(null);
const transferLoading = ref(false); const transferLoading = ref(false);
const transferApplying = ref(false); const transferApplying = ref(false);
const transferError = ref(""); const transferError = ref("");
const transferTargetReadOnly = computed(() => Boolean(connectionStore.getConfig(transferTargetId.value)?.read_only)); const transferTargetReadOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(transferTargetId.value)));
const deleteOpen = ref(false); const deleteOpen = ref(false);
const deletePrefix = ref(""); const deletePrefix = ref("");
@@ -10,13 +10,14 @@ import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import NacosConfigDiffDialog from "@/components/nacos/NacosConfigDiffDialog.vue"; import NacosConfigDiffDialog from "@/components/nacos/NacosConfigDiffDialog.vue";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import type { ConsulCapabilities, ConsulConfigEntry, ConsulDiscoveryChain, ConsulExportedService, ConsulIntention, ConsulPeering } from "@/types/consul"; import type { ConsulCapabilities, ConsulConfigEntry, ConsulDiscoveryChain, ConsulExportedService, ConsulIntention, ConsulPeering } from "@/types/consul";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
type MeshTab = "config" | "intentions" | "discovery" | "peering" | "exported"; type MeshTab = "config" | "intentions" | "discovery" | "peering" | "exported";
const props = defineProps<{ connectionId: string; capabilities: ConsulCapabilities | null }>(); const props = defineProps<{ connectionId: string; capabilities: ConsulCapabilities | null }>();
const store = useConnectionStore(); const store = useConnectionStore();
const readOnly = computed(() => Boolean(store.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(store.getConfig(props.connectionId)));
const { t } = useI18n(); const { t } = useI18n();
function capabilityLabel(value?: string) { function capabilityLabel(value?: string) {
if (value === "supported") return t("consul.ui.capabilitySupported"); if (value === "supported") return t("consul.ui.capabilitySupported");
@@ -7,6 +7,7 @@ import { Label } from "@/components/ui/label";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import type { ConsulCapabilities, ConsulOperatorDocument, ConsulOperatorReadKind } from "@/types/consul"; import type { ConsulCapabilities, ConsulOperatorDocument, ConsulOperatorReadKind } from "@/types/consul";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
const props = defineProps<{ connectionId: string; capabilities: ConsulCapabilities | null }>(); const props = defineProps<{ connectionId: string; capabilities: ConsulCapabilities | null }>();
@@ -26,7 +27,7 @@ const settings = computed(() => {
const external = connectionStore.getConfig(props.connectionId)?.external_config; const external = connectionStore.getConfig(props.connectionId)?.external_config;
return external && typeof external === "object" && !Array.isArray(external) ? (external as Record<string, unknown>) : {}; return external && typeof external === "object" && !Array.isArray(external) ? (external as Record<string, unknown>) : {};
}); });
const readOnly = computed(() => Boolean(connectionStore.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const autopilotWriteVisible = computed(() => settings.value.consulOperatorAutopilotWriteEnabled && props.capabilities?.operatorAutopilot === "supported"); const autopilotWriteVisible = computed(() => settings.value.consulOperatorAutopilotWriteEnabled && props.capabilities?.operatorAutopilot === "supported");
const raftWriteVisible = computed(() => settings.value.consulOperatorRaftWriteEnabled && props.capabilities?.operatorRaft === "supported"); const raftWriteVisible = computed(() => settings.value.consulOperatorRaftWriteEnabled && props.capabilities?.operatorRaft === "supported");
const keyringWriteVisible = computed(() => settings.value.consulOperatorKeyringWriteEnabled && props.capabilities?.operatorKeyring === "supported"); const keyringWriteVisible = computed(() => settings.value.consulOperatorKeyringWriteEnabled && props.capabilities?.operatorKeyring === "supported");
@@ -6,13 +6,14 @@ import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle } from "
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs"; import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
import type { ConsulCapabilities, ConsulEnterpriseKind, ConsulEnterpriseWrite, ConsulScopeImpact } from "@/types/consul"; import type { ConsulCapabilities, ConsulEnterpriseKind, ConsulEnterpriseWrite, ConsulScopeImpact } from "@/types/consul";
const props = defineProps<{ connectionId: string; capabilities: ConsulCapabilities | null }>(); const props = defineProps<{ connectionId: string; capabilities: ConsulCapabilities | null }>();
const { t } = useI18n(); const { t } = useI18n();
const store = useConnectionStore(); const store = useConnectionStore();
const readOnly = computed(() => Boolean(store.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(store.getConfig(props.connectionId)));
const active = ref<ConsulEnterpriseKind>("namespace"); const active = ref<ConsulEnterpriseKind>("namespace");
const items = ref<Record<string, unknown>[]>([]); const items = ref<Record<string, unknown>[]>([]);
const loading = ref(false); const loading = ref(false);
@@ -11,6 +11,7 @@ import { clampConsulPage, CONSUL_LIST_PAGE_SIZE, paginateConsulItems } from "@/l
import { consulSessionRenewDelayMs, parseConsulDurationMs } from "@/lib/consul/sessionRenew"; import { consulSessionRenewDelayMs, parseConsulDurationMs } from "@/lib/consul/sessionRenew";
import { normalizeConsulSession } from "@/lib/consul/sessionModel"; import { normalizeConsulSession } from "@/lib/consul/sessionModel";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useConsulStore } from "@/stores/consulStore"; import { useConsulStore } from "@/stores/consulStore";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
import type { ConsulResponseMetadata, ConsulSession, ConsulSessionKeysResponse, ConsulSessionServiceCheck } from "@/types/consul"; import type { ConsulResponseMetadata, ConsulSession, ConsulSessionKeysResponse, ConsulSessionServiceCheck } from "@/types/consul";
@@ -19,7 +20,7 @@ const props = defineProps<{ connectionId: string }>();
const { t } = useI18n(); const { t } = useI18n();
const store = useConnectionStore(); const store = useConnectionStore();
const consulStore = useConsulStore(); const consulStore = useConsulStore();
const readOnly = computed(() => Boolean(store.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(store.getConfig(props.connectionId)));
function behaviorLabel(behavior: string) { function behaviorLabel(behavior: string) {
if (behavior === "delete") return t("consul.ui.behaviorDelete"); if (behavior === "delete") return t("consul.ui.behaviorDelete");
if (behavior === "release") return t("consul.ui.behaviorRelease"); if (behavior === "release") return t("consul.ui.behaviorRelease");
@@ -7,6 +7,7 @@ import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import type { ConsulCapabilities, ConsulCoordinate, ConsulEvent, ConsulPreparedQuery, ConsulPreparedQueryExecuteResponse, ConsulPreparedQueryNode } from "@/types/consul"; import type { ConsulCapabilities, ConsulCoordinate, ConsulEvent, ConsulPreparedQuery, ConsulPreparedQueryExecuteResponse, ConsulPreparedQueryNode } from "@/types/consul";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
type ToolTab = "queries" | "events" | "coordinates"; type ToolTab = "queries" | "events" | "coordinates";
@@ -21,7 +22,7 @@ function capabilityLabel(value?: string) {
return t("consul.ui.capabilityUnknown"); return t("consul.ui.capabilityUnknown");
} }
const connectionStore = useConnectionStore(); const connectionStore = useConnectionStore();
const readOnly = computed(() => Boolean(connectionStore.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const canWriteQueries = computed(() => !readOnly.value && props.capabilities?.preparedQueries === "supported"); const canWriteQueries = computed(() => !readOnly.value && props.capabilities?.preparedQueries === "supported");
const canFireEvents = computed(() => !readOnly.value && props.capabilities?.events === "supported"); const canFireEvents = computed(() => !readOnly.value && props.capabilities?.events === "supported");
const queryAvailable = computed(() => !["unsupported", "disabled", "forbidden"].includes(props.capabilities?.preparedQueries || "")); const queryAvailable = computed(() => !["unsupported", "disabled", "forbidden"].includes(props.capabilities?.preparedQueries || ""));
@@ -18,6 +18,7 @@ import { buildGridFsFilesStructuredFilter, createGridFsFileFilterRule, currentGr
import { buildGridFsDownloadArchive, defaultGridFsArchiveFileName, formatGridFsUploadDate } from "@/lib/document/gridfsFiles"; import { buildGridFsDownloadArchive, defaultGridFsArchiveFileName, formatGridFsUploadDate } from "@/lib/document/gridfsFiles";
import { clampGridFsPage, gridFsTotalPages, paginateGridFsItems } from "@/lib/document/gridfsPagination"; import { clampGridFsPage, gridFsTotalPages, paginateGridFsItems } from "@/lib/document/gridfsPagination";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useSettingsStore } from "@/stores/settingsStore"; import { useSettingsStore } from "@/stores/settingsStore";
const props = defineProps<{ const props = defineProps<{
@@ -62,7 +63,7 @@ const partiallyChecked = computed(() => checkedFileIds.value.size > 0 && checked
const downloadTargets = computed(() => (checkedFileCount.value > 0 ? checkedFiles.value : selectedFile.value ? [selectedFile.value] : [])); const downloadTargets = computed(() => (checkedFileCount.value > 0 ? checkedFiles.value : selectedFile.value ? [selectedFile.value] : []));
const downloadButtonLabel = computed(() => (checkedFileCount.value > 0 ? t("gridfsBrowser.downloadSelected") : t("gridfsBrowser.downloadFile"))); const downloadButtonLabel = computed(() => (checkedFileCount.value > 0 ? t("gridfsBrowser.downloadSelected") : t("gridfsBrowser.downloadFile")));
const selectedMetadata = computed(() => (selectedFile.value?.metadata ? JSON.stringify(selectedFile.value.metadata, null, 2) : "")); const selectedMetadata = computed(() => (selectedFile.value?.metadata ? JSON.stringify(selectedFile.value.metadata, null, 2) : ""));
const isReadonly = computed(() => connectionStore.getConfig(props.connectionId)?.read_only ?? false); const isReadonly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const mongoProvider = documentStoreProviderFor("mongodb"); const mongoProvider = documentStoreProviderFor("mongodb");
const activeStructuredRuleCount = computed(() => { const activeStructuredRuleCount = computed(() => {
if (!appliedStructuredFilter.value) return 0; if (!appliedStructuredFilter.value) return 0;
@@ -11,6 +11,7 @@ import { useToast } from "@/composables/useToast";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import { currentGridFsBucketFilter, currentGridFsBucketSort, currentGridFsBucketSortDirection, gridFsBucketSortInputForColumn } from "@/lib/document/gridFsBrowser"; import { currentGridFsBucketFilter, currentGridFsBucketSort, currentGridFsBucketSortDirection, gridFsBucketSortInputForColumn } from "@/lib/document/gridFsBrowser";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useQueryStore } from "@/stores/queryStore"; import { useQueryStore } from "@/stores/queryStore";
const props = defineProps<{ const props = defineProps<{
@@ -39,7 +40,7 @@ const filterBuilderOpen = ref(false);
const selectedBucket = computed(() => buckets.value.find((bucket) => bucket.name === selectedBucketName.value) || null); const selectedBucket = computed(() => buckets.value.find((bucket) => bucket.name === selectedBucketName.value) || null);
const totalFiles = computed(() => buckets.value.reduce((sum, bucket) => sum + bucket.fileCount, 0)); const totalFiles = computed(() => buckets.value.reduce((sum, bucket) => sum + bucket.fileCount, 0));
const totalBytes = computed(() => buckets.value.reduce((sum, bucket) => sum + bucket.totalBytes, 0)); const totalBytes = computed(() => buckets.value.reduce((sum, bucket) => sum + bucket.totalBytes, 0));
const isReadonly = computed(() => connectionStore.getConfig(props.connectionId)?.read_only ?? false); const isReadonly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
function formatBytes(bytes: number): string { function formatBytes(bytes: number): string {
if (bytes < 1024) return `${bytes} B`; if (bytes < 1024) return `${bytes} B`;
@@ -60,6 +60,7 @@ import {
type DoltClientSessionScope, type DoltClientSessionScope,
} from "@/lib/dolt/doltVersionControl"; } from "@/lib/dolt/doltVersionControl";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useQueryStore } from "@/stores/queryStore"; import { useQueryStore } from "@/stores/queryStore";
import { useToast } from "@/composables/useToast"; import { useToast } from "@/composables/useToast";
import { copyToClipboard } from "@/lib/common/clipboard"; import { copyToClipboard } from "@/lib/common/clipboard";
@@ -240,7 +241,7 @@ const tableDiffPageSize = ref(DOLT_DIFF_DEFAULT_PAGE_SIZE);
const tableDiffTotalRows = ref(0); const tableDiffTotalRows = ref(0);
const tableDiffMaximumPage = computed(() => Math.max(1, Math.ceil(tableDiffTotalRows.value / tableDiffPageSize.value))); const tableDiffMaximumPage = computed(() => Math.max(1, Math.ceil(tableDiffTotalRows.value / tableDiffPageSize.value)));
const selectedRevisionKeySet = computed(() => new Set(selectedRevisionKeys.value)); const selectedRevisionKeySet = computed(() => new Set(selectedRevisionKeys.value));
const connectionReadOnly = computed(() => connectionStore.getConfig(props.connectionId)?.read_only ?? false); const connectionReadOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const createsNamedRef = computed(() => branchDialog.value === "create" || branchDialog.value === "create-tag"); const createsNamedRef = computed(() => branchDialog.value === "create" || branchDialog.value === "create-tag");
const mutationDialogTitle = computed(() => { const mutationDialogTitle = computed(() => {
if (branchDialog.value === "create") return t("doltVersionControl.createBranch"); if (branchDialog.value === "create") return t("doltVersionControl.createBranch");
@@ -8,6 +8,7 @@ import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle } from "
import { Input } from "@/components/ui/input"; import { Input } from "@/components/ui/input";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
type AccessView = "users" | "roles"; type AccessView = "users" | "roles";
type PermissionAccess = "read" | "write" | "readwrite"; type PermissionAccess = "read" | "write" | "readwrite";
@@ -52,7 +53,7 @@ const approvalExpected = ref("");
let pendingApproval: (() => Promise<void>) | null = null; let pendingApproval: (() => Promise<void>) | null = null;
let detailRequest = 0; let detailRequest = 0;
const readOnly = computed(() => Boolean(connectionStore.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const selectedUserRoles = computed(() => userDetail.value?.roles ?? []); const selectedUserRoles = computed(() => userDetail.value?.roles ?? []);
const grantableRoles = computed(() => roles.value.filter((role) => !selectedUserRoles.value.includes(role))); const grantableRoles = computed(() => roles.value.filter((role) => !selectedUserRoles.value.includes(role)));
const initialUserRoleLabel = computed(() => (newUserRoles.value.length ? t("etcd.access.createAndAssignRoles", { count: newUserRoles.value.length }) : t("etcd.access.createUserAction"))); const initialUserRoleLabel = computed(() => (newUserRoles.value.length ? t("etcd.access.createAndAssignRoles", { count: newUserRoles.value.length }) : t("etcd.access.createUserAction")));
@@ -17,6 +17,7 @@ import { isTauriRuntime } from "@/lib/backend/tauriRuntime";
import { isKeyInKvExportScope, kvExportFilenameStem, kvValueByteIdentity, type KvExportScopeKind, type KvExportScopeRequest } from "@/lib/kv/kvExportScope"; import { isKeyInKvExportScope, kvExportFilenameStem, kvValueByteIdentity, type KvExportScopeKind, type KvExportScopeRequest } from "@/lib/kv/kvExportScope";
import { detectKvValueFormat } from "@/lib/kv/kvValueFormat"; import { detectKvValueFormat } from "@/lib/kv/kvValueFormat";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
type WorkbenchMode = "keys" | "search" | "maintenance" | "watch" | "lease"; type WorkbenchMode = "keys" | "search" | "maintenance" | "watch" | "lease";
type SearchScope = "key" | "value" | "all"; type SearchScope = "key" | "value" | "all";
@@ -153,9 +154,9 @@ const transferLoadingDetail = ref("");
const transferPreviewLoaded = ref(false); const transferPreviewLoaded = ref(false);
const syncConfigurationExpanded = ref(true); const syncConfigurationExpanded = ref(true);
const readOnly = computed(() => Boolean(connectionStore.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const etcdConnections = computed(() => connectionStore.connections.filter((connection) => connection.db_type === "etcd")); const etcdConnections = computed(() => connectionStore.connections.filter((connection) => connection.db_type === "etcd"));
const targetReadOnly = computed(() => Boolean(connectionStore.getConfig(targetConnectionId.value)?.read_only)); const targetReadOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(targetConnectionId.value)));
const selectedTransferRows = computed(() => transferRows.value.filter((row) => row.selected && isTransferRowSelectable(row))); const selectedTransferRows = computed(() => transferRows.value.filter((row) => row.selected && isTransferRowSelectable(row)));
const selectableTransferRows = computed(() => transferRows.value.filter(isTransferRowSelectable)); const selectableTransferRows = computed(() => transferRows.value.filter(isTransferRowSelectable));
const filteredTransferRows = computed(() => { const filteredTransferRows = computed(() => {
@@ -17,6 +17,7 @@ import type { CellValue } from "@/lib/dataGrid/cellValue";
import { encodeHBaseTextInput, hbaseCellInput } from "@/lib/hbase/hbaseValues"; import { encodeHBaseTextInput, hbaseCellInput } from "@/lib/hbase/hbaseValues";
import { loadHBaseRowLimit, saveHBaseRowLimit } from "@/lib/hbase/hbaseBrowserPreferences"; import { loadHBaseRowLimit, saveHBaseRowLimit } from "@/lib/hbase/hbaseBrowserPreferences";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useQueryStore } from "@/stores/queryStore"; import { useQueryStore } from "@/stores/queryStore";
import type { QueryResult } from "@/types/database"; import type { QueryResult } from "@/types/database";
import type { HBaseCellInput, HBasePutRowInput, HBaseRow, HBaseTableSchema, HBaseValueEncoding } from "@/types/hbase"; import type { HBaseCellInput, HBasePutRowInput, HBaseRow, HBaseTableSchema, HBaseValueEncoding } from "@/types/hbase";
@@ -61,7 +62,7 @@ const deleteTableLoading = ref(false);
const deleteTableError = ref(""); const deleteTableError = ref("");
const hasTable = computed(() => props.table.trim().length > 0); const hasTable = computed(() => props.table.trim().length > 0);
const readOnly = computed(() => connectionStore.getConfig(props.connectionId)?.read_only === true); const readOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const qualifiedTableLabel = computed(() => { const qualifiedTableLabel = computed(() => {
if (!hasTable.value) return props.namespace; if (!hasTable.value) return props.namespace;
return props.namespace && props.namespace !== "default" ? `${props.namespace}:${props.table}` : props.table; return props.namespace && props.namespace !== "default" ? `${props.namespace}:${props.table}` : props.table;
@@ -10,6 +10,7 @@ import { Label } from "@/components/ui/label";
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select"; import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select";
import { AlertTriangle, ArrowLeft, ArrowRight, Check, CheckCircle2, FileCode, FileJson, FileSpreadsheet, FileText, FileUp, Loader2, RefreshCw, Square, Upload, X } from "@lucide/vue"; import { AlertTriangle, ArrowLeft, ArrowRight, Check, CheckCircle2, FileCode, FileJson, FileSpreadsheet, FileText, FileUp, Loader2, RefreshCw, Square, Upload, X } from "@lucide/vue";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { ensureReadOnlyWriteAccess } from "@/lib/database/readOnlyWriteAccess";
import { useSettingsStore } from "@/stores/settingsStore"; import { useSettingsStore } from "@/stores/settingsStore";
import { useToast } from "@/composables/useToast"; import { useToast } from "@/composables/useToast";
import { import {
@@ -713,6 +714,9 @@ async function goNext() {
async function startImport() { async function startImport() {
saveActiveBatchTask(); saveActiveBatchTask();
if (!(await ensureReadOnlyWriteAccess({ connection: store.getConfig(props.prefillConnectionId ?? ""), source: t("readOnlyUnlock.sourceImport"), treatAsMutation: true }))) {
return;
}
if (isBatchImport.value) { if (isBatchImport.value) {
await startBatchImport(); await startBatchImport();
return; return;
@@ -1,5 +1,5 @@
<script setup lang="ts"> <script setup lang="ts">
import { computed, watch, defineAsyncComponent } from "vue"; import { computed, ref, watch, defineAsyncComponent } from "vue";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle } from "@/components/ui/dialog"; import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle } from "@/components/ui/dialog";
@@ -24,6 +24,7 @@ const DataGenerateDialog = defineAsyncComponent(() => import("@/components/gener
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { useSqlExecutionDangerStore } from "@/stores/sqlExecutionDangerStore"; import { useSqlExecutionDangerStore } from "@/stores/sqlExecutionDangerStore";
import { useProductionSafetyStore } from "@/stores/productionSafetyStore"; import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
import { useReadOnlyUnlockStore, WRITE_UNLOCK_FIVE_MINUTES_SECS, WRITE_UNLOCK_ONE_MINUTE_SECS, type WriteUnlockDurationSecs } from "@/stores/readOnlyUnlockStore";
import { useDialogSources } from "@/composables/useDialogSources"; import { useDialogSources } from "@/composables/useDialogSources";
import type { ConnectionDeepLinkDraft } from "@/lib/connection/connectionDeepLink"; import type { ConnectionDeepLinkDraft } from "@/lib/connection/connectionDeepLink";
import type { DriverStoreFocus } from "@/lib/connection/agentDriverInstallHint"; import type { DriverStoreFocus } from "@/lib/connection/agentDriverInstallHint";
@@ -92,6 +93,8 @@ const emit = defineEmits<{
const { t } = useI18n(); const { t } = useI18n();
const connectionStore = useConnectionStore(); const connectionStore = useConnectionStore();
const productionSafetyStore = useProductionSafetyStore(); const productionSafetyStore = useProductionSafetyStore();
const readOnlyUnlockStore = useReadOnlyUnlockStore();
const unlockDuration = ref<WriteUnlockDurationSecs>(WRITE_UNLOCK_ONE_MINUTE_SECS);
const sqlExecutionDangerStore = useSqlExecutionDangerStore(); const sqlExecutionDangerStore = useSqlExecutionDangerStore();
const dialogs = useDialogSources(); const dialogs = useDialogSources();
const productionConfirmationDetails = computed(() => { const productionConfirmationDetails = computed(() => {
@@ -103,6 +106,20 @@ const productionConfirmationDetails = computed(() => {
source: request.source || "-", source: request.source || "-",
}); });
}); });
const readOnlyUnlockDetails = computed(() => {
const request = readOnlyUnlockStore.pending;
if (!request) return "";
return t("readOnlyUnlock.confirmDetails", {
connection: request.connectionName || "-",
source: request.source || "-",
});
});
watch(
() => readOnlyUnlockStore.pending,
(pending) => {
if (pending) unlockDuration.value = WRITE_UNLOCK_ONE_MINUTE_SECS;
},
);
const multiDbDangerDetails = computed(() => { const multiDbDangerDetails = computed(() => {
const request = sqlExecutionDangerStore.pending; const request = sqlExecutionDangerStore.pending;
if (!request) return ""; if (!request) return "";
@@ -178,6 +195,32 @@ watch(
@update:open="(open) => !open && productionSafetyStore.cancel()" @update:open="(open) => !open && productionSafetyStore.cancel()"
@confirm="productionSafetyStore.confirm()" @confirm="productionSafetyStore.confirm()"
/> />
<DangerConfirmDialog
v-if="readOnlyUnlockStore.pending"
:open="true"
:title="t('readOnlyUnlock.confirmTitle')"
:message="t('readOnlyUnlock.confirmMessage')"
:details-text="readOnlyUnlockDetails"
:sql="readOnlyUnlockStore.pending.sql"
:confirm-label="t('readOnlyUnlock.confirmAction')"
:close-on-confirm="false"
@update:open="(open) => !open && readOnlyUnlockStore.cancel()"
@confirm="readOnlyUnlockStore.confirm(unlockDuration)"
>
<template #options>
<fieldset class="mb-3 space-y-2 rounded-md border bg-muted/20 px-3 py-2">
<legend class="text-xs font-medium text-foreground">{{ t("readOnlyUnlock.durationLabel") }}</legend>
<label class="flex items-center gap-2 text-sm">
<input v-model="unlockDuration" type="radio" class="accent-primary" :value="WRITE_UNLOCK_ONE_MINUTE_SECS" />
{{ t("readOnlyUnlock.durationOneMinute") }}
</label>
<label class="flex items-center gap-2 text-sm">
<input v-model="unlockDuration" type="radio" class="accent-primary" :value="WRITE_UNLOCK_FIVE_MINUTES_SECS" />
{{ t("readOnlyUnlock.durationFiveMinutes") }}
</label>
</fieldset>
</template>
</DangerConfirmDialog>
<DangerConfirmDialog <DangerConfirmDialog
v-if="sqlExecutionDangerStore.pending" v-if="sqlExecutionDangerStore.pending"
:open="true" :open="true"
@@ -2,7 +2,7 @@
import { computed, ref, watch, nextTick, onUnmounted } from "vue"; import { computed, ref, watch, nextTick, onUnmounted } from "vue";
import type { CSSProperties } from "vue"; import type { CSSProperties } from "vue";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
import { X, Pin, ChevronDown, Search, Table2, Code2, TableProperties, PencilRuler, KeyRound, Pencil, Package, Lock, Copy, AlertTriangle, Network, Minimize2, Maximize2, Settings, CalendarClock, Activity, Gauge, ShieldCheck, Database, GitBranch, Crosshair } from "@lucide/vue"; import { X, Pin, ChevronDown, Search, Table2, Code2, TableProperties, PencilRuler, KeyRound, Pencil, Package, Copy, AlertTriangle, Network, Minimize2, Maximize2, Settings, CalendarClock, Activity, Gauge, ShieldCheck, Database, GitBranch, Crosshair } from "@lucide/vue";
import CustomContextMenu, { type ContextMenuItem } from "@/components/ui/CustomContextMenu.vue"; import CustomContextMenu, { type ContextMenuItem } from "@/components/ui/CustomContextMenu.vue";
import { Tooltip, TooltipTrigger, TooltipContent } from "@/components/ui/tooltip"; import { Tooltip, TooltipTrigger, TooltipContent } from "@/components/ui/tooltip";
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover"; import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";
@@ -16,7 +16,8 @@ import { useQueryStore } from "@/stores/queryStore";
import { useSettingsStore } from "@/stores/settingsStore"; import { useSettingsStore } from "@/stores/settingsStore";
import { useTabScroll } from "@/composables/useTabScroll"; import { useTabScroll } from "@/composables/useTabScroll";
import { useTabDrag } from "@/composables/useTabDrag"; import { useTabDrag } from "@/composables/useTabDrag";
import { connectionColor, isConnectionReadonly, tabDisplayTitle, tabTooltipLines } from "@/lib/tabs/tabPresentation"; import { connectionColor, tabDisplayTitle, tabTooltipLines } from "@/lib/tabs/tabPresentation";
import ReadOnlySessionControl from "@/components/connection/ReadOnlySessionControl.vue";
import { hexToRgba } from "@/lib/common/color"; import { hexToRgba } from "@/lib/common/color";
import { copyToClipboard } from "@/lib/common/clipboard"; import { copyToClipboard } from "@/lib/common/clipboard";
import { useToast } from "@/composables/useToast"; import { useToast } from "@/composables/useToast";
@@ -740,12 +741,7 @@ function onOverflowItemKeydown(event: KeyboardEvent, tabId: string, kind: "regul
<span v-if="isDirtyTab(tab)" aria-hidden="true" class="dirty-tab-marker">*</span> <span v-if="isDirtyTab(tab)" aria-hidden="true" class="dirty-tab-marker">*</span>
<span class="min-w-0 flex-1 truncate" :style="tabTitleStyle(tab)">{{ tabTitleText(tab) }}</span> <span class="min-w-0 flex-1 truncate" :style="tabTitleStyle(tab)">{{ tabTitleText(tab) }}</span>
</span> </span>
<Tooltip v-if="isConnectionReadonly(tab.connectionId)"> <ReadOnlySessionControl :connection-id="tab.connectionId" compact />
<TooltipTrigger as-child>
<Lock class="h-3 w-3 text-muted-foreground shrink-0" />
</TooltipTrigger>
<TooltipContent>{{ t("connection.readOnlyBadge") }}</TooltipContent>
</Tooltip>
<button class="rounded hover:bg-muted-foreground/20 p-0.5 shrink-0" @click.stop="queryStore.closeTab(tab.id)"> <button class="rounded hover:bg-muted-foreground/20 p-0.5 shrink-0" @click.stop="queryStore.closeTab(tab.id)">
<X class="h-3 w-3" /> <X class="h-3 w-3" />
</button> </button>
@@ -852,7 +848,7 @@ function onOverflowItemKeydown(event: KeyboardEvent, tabId: string, kind: "regul
<span v-if="isDirtyTab(tab)" aria-hidden="true" class="dirty-tab-marker">*</span> <span v-if="isDirtyTab(tab)" aria-hidden="true" class="dirty-tab-marker">*</span>
<span class="min-w-0 flex-1 truncate" :style="tabTitleStyle(tab)">{{ tabTitleText(tab) }}</span> <span class="min-w-0 flex-1 truncate" :style="tabTitleStyle(tab)">{{ tabTitleText(tab) }}</span>
</span> </span>
<Lock v-if="isConnectionReadonly(tab.connectionId)" class="h-3 w-3 shrink-0 text-muted-foreground" /> <ReadOnlySessionControl :connection-id="tab.connectionId" compact />
<Pin v-if="tab.pinned" class="h-3 w-3 shrink-0 fill-current text-primary" /> <Pin v-if="tab.pinned" class="h-3 w-3 shrink-0 fill-current text-primary" />
<span class="w-5 shrink-0"> <span class="w-5 shrink-0">
<button <button
@@ -950,12 +946,7 @@ function onOverflowItemKeydown(event: KeyboardEvent, tabId: string, kind: "regul
<span v-if="isDirtyTab(tab)" aria-hidden="true" class="dirty-tab-marker">*</span> <span v-if="isDirtyTab(tab)" aria-hidden="true" class="dirty-tab-marker">*</span>
<span class="min-w-0 flex-1 truncate" :style="tabTitleStyle(tab)">{{ tabTitleText(tab) }}</span> <span class="min-w-0 flex-1 truncate" :style="tabTitleStyle(tab)">{{ tabTitleText(tab) }}</span>
</span> </span>
<Tooltip v-if="isConnectionReadonly(tab.connectionId)"> <ReadOnlySessionControl :connection-id="tab.connectionId" compact />
<TooltipTrigger as-child>
<Lock class="h-3 w-3 text-muted-foreground shrink-0" />
</TooltipTrigger>
<TooltipContent>{{ t("connection.readOnlyBadge") }}</TooltipContent>
</Tooltip>
<button class="rounded p-0.5 text-primary hover:bg-muted-foreground/20 shrink-0" :aria-label="t('contextMenu.unfixTab')" :title="t('contextMenu.unfixTab')" @click.stop="queryStore.togglePinnedTab(tab.id)"> <button class="rounded p-0.5 text-primary hover:bg-muted-foreground/20 shrink-0" :aria-label="t('contextMenu.unfixTab')" :title="t('contextMenu.unfixTab')" @click.stop="queryStore.togglePinnedTab(tab.id)">
<Pin class="h-3 w-3 fill-current" aria-hidden="true" /> <Pin class="h-3 w-3 fill-current" aria-hidden="true" />
</button> </button>
@@ -1008,7 +999,7 @@ function onOverflowItemKeydown(event: KeyboardEvent, tabId: string, kind: "regul
<span v-if="isDirtyTab(tab)" aria-hidden="true" class="dirty-tab-marker">*</span> <span v-if="isDirtyTab(tab)" aria-hidden="true" class="dirty-tab-marker">*</span>
<span class="min-w-0 flex-1 truncate" :style="tabTitleStyle(tab)">{{ tabTitleText(tab) }}</span> <span class="min-w-0 flex-1 truncate" :style="tabTitleStyle(tab)">{{ tabTitleText(tab) }}</span>
</span> </span>
<Lock v-if="isConnectionReadonly(tab.connectionId)" class="h-3 w-3 shrink-0 text-muted-foreground" /> <ReadOnlySessionControl :connection-id="tab.connectionId" compact />
<Pin v-if="tab.pinned" class="h-3 w-3 shrink-0 fill-current text-primary" /> <Pin v-if="tab.pinned" class="h-3 w-3 shrink-0 fill-current text-primary" />
<span class="w-5 shrink-0"> <span class="w-5 shrink-0">
<button <button
@@ -162,6 +162,7 @@ import type { QueryTab, ConnectionConfig, TableInfoTab, TreeNode, VectorCollecti
import type { SqlObjectNavigationTarget } from "@/lib/sql/sqlNavigation"; import type { SqlObjectNavigationTarget } from "@/lib/sql/sqlNavigation";
import { sqlFormatDialectForDbType, type SqlFormatDialect } from "@/lib/sql/sqlFormatter"; import { sqlFormatDialectForDbType, type SqlFormatDialect } from "@/lib/sql/sqlFormatter";
import { productionContextForDatabase } from "@/lib/database/productionSafety"; import { productionContextForDatabase } from "@/lib/database/productionSafety";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
type DataGridHandle = DataGridColumnLayoutHandle & { type DataGridHandle = DataGridColumnLayoutHandle & {
onToolbarRefresh: () => Promise<void> | void; onToolbarRefresh: () => Promise<void> | void;
@@ -2226,7 +2227,7 @@ defineExpose({
<template v-else-if="activeTab.mode === 'nacos-access-control'"> <template v-else-if="activeTab.mode === 'nacos-access-control'">
<div class="flex-1 min-h-0"> <div class="flex-1 min-h-0">
<NacosAccessControlConsole :key="activeTab.id" :connection-id="activeTab.connectionId" :read-only="activeConnection?.read_only ?? false" /> <NacosAccessControlConsole :key="activeTab.id" :connection-id="activeTab.connectionId" :read-only="connectionIsEffectivelyReadOnly(activeConnection)" />
</div> </div>
</template> </template>
@@ -2297,7 +2298,7 @@ defineExpose({
<template v-else-if="activeTab.mode === 'mq'"> <template v-else-if="activeTab.mode === 'mq'">
<div class="flex-1 min-h-0"> <div class="flex-1 min-h-0">
<MqAdminConsole :key="activeTab.id" :connection-id="activeTab.connectionId" :initial-tenant="activeTab.mqTenant" :initial-tab="activeTab.mqInitialTab" :read-only="activeConnection?.read_only ?? false" /> <MqAdminConsole :key="activeTab.id" :connection-id="activeTab.connectionId" :initial-tenant="activeTab.mqTenant" :initial-tab="activeTab.mqInitialTab" :read-only="connectionIsEffectivelyReadOnly(activeConnection)" />
</div> </div>
</template> </template>
@@ -2318,7 +2319,7 @@ defineExpose({
:target-group="activeTab.nacosTargetGroup" :target-group="activeTab.nacosTargetGroup"
:target-keyword="activeTab.nacosTargetKeyword" :target-keyword="activeTab.nacosTargetKeyword"
:target-request-id="activeTab.nacosTargetRequestId" :target-request-id="activeTab.nacosTargetRequestId"
:read-only="activeConnection?.read_only ?? false" :read-only="connectionIsEffectivelyReadOnly(activeConnection)"
/> />
</div> </div>
</template> </template>
@@ -16,6 +16,7 @@ import * as api from "@/lib/backend/api";
import { copyToClipboard } from "@/lib/common/clipboard"; import { copyToClipboard } from "@/lib/common/clipboard";
import { loadMeilisearchKeyColumns, saveMeilisearchKeyColumns, type MeilisearchKeyColumnKey } from "@/lib/meilisearch/meilisearchKeyColumns"; import { loadMeilisearchKeyColumns, saveMeilisearchKeyColumns, type MeilisearchKeyColumnKey } from "@/lib/meilisearch/meilisearchKeyColumns";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useToast } from "@/composables/useToast"; import { useToast } from "@/composables/useToast";
import type { KeyCreateInput, KeyListItem } from "@/types/meilisearchManagement"; import type { KeyCreateInput, KeyListItem } from "@/types/meilisearchManagement";
@@ -53,7 +54,7 @@ const props = defineProps<{ connectionId: string }>();
const { t } = useI18n(); const { t } = useI18n();
const { toast } = useToast(); const { toast } = useToast();
const connectionStore = useConnectionStore(); const connectionStore = useConnectionStore();
const readOnly = computed(() => Boolean(connectionStore.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const rows = ref<KeyListItem[]>([]); const rows = ref<KeyListItem[]>([]);
const offset = ref(0); const offset = ref(0);
@@ -12,6 +12,7 @@ import ErrorBanner from "@/components/ui/ErrorBanner.vue";
import QueryLoadingState from "@/components/common/QueryLoadingState.vue"; import QueryLoadingState from "@/components/common/QueryLoadingState.vue";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { useToast } from "@/composables/useToast"; import { useToast } from "@/composables/useToast";
import { import {
formatMeilisearchTaskDateTime, formatMeilisearchTaskDateTime,
@@ -32,7 +33,7 @@ const props = defineProps<{ connectionId: string; fixedIndexUid?: string }>();
const { locale, t } = useI18n(); const { locale, t } = useI18n();
const { toast } = useToast(); const { toast } = useToast();
const connectionStore = useConnectionStore(); const connectionStore = useConnectionStore();
const readOnly = computed(() => Boolean(connectionStore.getConfig(props.connectionId)?.read_only)); const readOnly = computed(() => connectionIsEffectivelyReadOnly(connectionStore.getConfig(props.connectionId)));
const rows = ref<MeilisearchTask[]>([]); const rows = ref<MeilisearchTask[]>([]);
const total = ref(0); const total = ref(0);
@@ -55,6 +55,7 @@ import { useSettingsStore } from "@/stores/settingsStore";
import { useTheme } from "@/composables/useTheme"; import { useTheme } from "@/composables/useTheme";
import { executeWithProductionContextGuard } from "@/lib/database/productionExecutionGuard"; import { executeWithProductionContextGuard } from "@/lib/database/productionExecutionGuard";
import { productionContextForDatabase } from "@/lib/database/productionSafety"; import { productionContextForDatabase } from "@/lib/database/productionSafety";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import type { import type {
NacosBatchPreview, NacosBatchPreview,
NacosBatchReport, NacosBatchReport,
@@ -280,7 +281,7 @@ const namespace = computed(() => props.namespace ?? connectionInfo.value?.namesp
const nacosProductionContext = computed(() => productionContextForDatabase(connectionStore.getConfig(props.connectionId), namespace.value)); const nacosProductionContext = computed(() => productionContextForDatabase(connectionStore.getConfig(props.connectionId), namespace.value));
const batchTargetConnections = computed<NacosConfigTransferTarget[]>(() => const batchTargetConnections = computed<NacosConfigTransferTarget[]>(() =>
connectionStore.connections connectionStore.connections
.filter((connection) => connection.db_type === "nacos" && !connection.read_only) .filter((connection) => connection.db_type === "nacos" && !connectionIsEffectivelyReadOnly(connection))
.map((connection) => { .map((connection) => {
const address = [connection.host, connection.port].filter(Boolean).join(":"); const address = [connection.host, connection.port].filter(Boolean).join(":");
return { id: connection.id, label: connection.name ? `${connection.name} (${address})` : address || connection.id }; return { id: connection.id, label: connection.name ? `${connection.name} (${address})` : address || connection.id };
@@ -111,6 +111,7 @@ import MySqlEventEditor from "@/components/objects/MySqlEventEditor.vue";
import { sqlFormatDialectForDbType, type SqlFormatDialect } from "@/lib/sql/sqlFormatter"; import { sqlFormatDialectForDbType, type SqlFormatDialect } from "@/lib/sql/sqlFormatter";
import { isCancelSearchShortcut } from "@/lib/editor/keyboardShortcuts"; import { isCancelSearchShortcut } from "@/lib/editor/keyboardShortcuts";
import { executeWithProductionSqlGuard } from "@/lib/database/productionExecutionGuard"; import { executeWithProductionSqlGuard } from "@/lib/database/productionExecutionGuard";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { buildXuguCompileSql } from "@/lib/database/xuguCompileSql"; import { buildXuguCompileSql } from "@/lib/database/xuguCompileSql";
import { formatShortcut } from "@/lib/editor/shortcutRegistry"; import { formatShortcut } from "@/lib/editor/shortcutRegistry";
import { batchTableEmptyFeedback, buildBatchTableEmptyPlan, runBatchTableEmpty, type BatchTableEmptyPlanItem } from "@/lib/sidebar/batchTableEmpty"; import { batchTableEmptyFeedback, buildBatchTableEmptyPlan, runBatchTableEmpty, type BatchTableEmptyPlanItem } from "@/lib/sidebar/batchTableEmpty";
@@ -335,7 +336,7 @@ const canOpenStructureEditor = computed(() => supportsTableStructureEditing(tabl
const canOpenDiagram = computed(() => !!props.database && supportsSchemaDiagram(effectiveDatabaseType.value)); const canOpenDiagram = computed(() => !!props.database && supportsSchemaDiagram(effectiveDatabaseType.value));
const canOpenTableImport = computed(() => !!props.database && supportsTableImport(effectiveDatabaseType.value)); const canOpenTableImport = computed(() => !!props.database && supportsTableImport(effectiveDatabaseType.value));
const supportsTruncateTable = computed(() => supportsTableTruncate(effectiveDatabaseType.value)); const supportsTruncateTable = computed(() => supportsTableTruncate(effectiveDatabaseType.value));
const supportsVacuumTable = computed(() => !props.connection.read_only && supportsTableVacuum(effectiveDatabaseType.value)); const supportsVacuumTable = computed(() => !connectionIsEffectivelyReadOnly(props.connection) && supportsTableVacuum(effectiveDatabaseType.value));
const vacuumRiskMessage = computed(() => (vacuumExecuting.value ? t("contextMenu.vacuumTableRunningHint") : vacuumTableFull.value ? t("contextMenu.vacuumTableFullRisk") : vacuumTableAnalyze.value ? t("contextMenu.vacuumTableAnalyzeRisk") : t("contextMenu.vacuumTableDefaultRisk"))); const vacuumRiskMessage = computed(() => (vacuumExecuting.value ? t("contextMenu.vacuumTableRunningHint") : vacuumTableFull.value ? t("contextMenu.vacuumTableFullRisk") : vacuumTableAnalyze.value ? t("contextMenu.vacuumTableAnalyzeRisk") : t("contextMenu.vacuumTableDefaultRisk")));
const sourceDialect = computed(() => codeMirrorSqlDialect(effectiveDatabaseType.value)); const sourceDialect = computed(() => codeMirrorSqlDialect(effectiveDatabaseType.value));
const sourceFormatDialect = computed<SqlFormatDialect>(() => sqlFormatDialectForDbType(effectiveDatabaseType.value)); const sourceFormatDialect = computed<SqlFormatDialect>(() => sqlFormatDialectForDbType(effectiveDatabaseType.value));
@@ -2212,7 +2213,7 @@ function canTransferTableClipboard(): boolean {
if (isVictoriaMetrics.value) return false; if (isVictoriaMetrics.value) return false;
const entries = normalizedObjectBrowserTableClipboardEntries(); const entries = normalizedObjectBrowserTableClipboardEntries();
const target = pasteTableTargetContext(); const target = pasteTableTargetContext();
if (entries.length === 0 || props.connection.read_only) return false; if (entries.length === 0 || connectionIsEffectivelyReadOnly(props.connection)) return false;
const source = tableClipboardSourceContext(entries); const source = tableClipboardSourceContext(entries);
const sourceConfig = source ? connectionStore.getConfig(source.connectionId) : undefined; const sourceConfig = source ? connectionStore.getConfig(source.connectionId) : undefined;
return !!source && !!sourceConfig && supportsTransfer(sourceConfig.db_type) && supportsTransfer(props.connection.db_type) && !tableClipboardMatchesTarget(entries, target); return !!source && !!sourceConfig && supportsTransfer(sourceConfig.db_type) && supportsTransfer(props.connection.db_type) && !tableClipboardMatchesTarget(entries, target);
@@ -184,6 +184,7 @@ import { isSqlServerLinkedNode } from "@/lib/database/sqlServerLinkedServers";
import { flattenTree } from "@/composables/useFlatTree"; import { flattenTree } from "@/composables/useFlatTree";
import { createDatabaseCollationOptionsForCharset, nextCreateDatabaseCollation, normalizeCreateDatabaseCharset, parseCreateDatabaseCharsetMetadata } from "@/lib/database/createDatabaseCharsetOptions"; import { createDatabaseCollationOptionsForCharset, nextCreateDatabaseCollation, normalizeCreateDatabaseCharset, parseCreateDatabaseCharsetMetadata } from "@/lib/database/createDatabaseCharsetOptions";
import { executeWithProductionContextGuard, executeWithProductionSqlGuard } from "@/lib/database/productionExecutionGuard"; import { executeWithProductionContextGuard, executeWithProductionSqlGuard } from "@/lib/database/productionExecutionGuard";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { buildXuguCompileSql } from "@/lib/database/xuguCompileSql"; import { buildXuguCompileSql } from "@/lib/database/xuguCompileSql";
import type { SidebarDataOpenRequest } from "@/lib/sidebar/sidebarDataOpenCoordinator"; import type { SidebarDataOpenRequest } from "@/lib/sidebar/sidebarDataOpenCoordinator";
import { createSidebarActionTarget, findSidebarActionTarget, releaseRemovedSidebarActionTarget, type SidebarActionTarget } from "@/lib/sidebar/sidebarActionTarget"; import { createSidebarActionTarget, findSidebarActionTarget, releaseRemovedSidebarActionTarget, type SidebarActionTarget } from "@/lib/sidebar/sidebarActionTarget";
@@ -1153,7 +1154,7 @@ function canTransferTreeClipboardToCurrentNode(): boolean {
const source = tableClipboardSourceContext(entries); const source = tableClipboardSourceContext(entries);
const sourceConfig = source ? connectionStore.getConfig(source.connectionId) : undefined; const sourceConfig = source ? connectionStore.getConfig(source.connectionId) : undefined;
const targetConfig = connectionStore.getConfig(target.connectionId); const targetConfig = connectionStore.getConfig(target.connectionId);
return !!source && !!sourceConfig && !!targetConfig && supportsTransfer(sourceConfig.db_type) && supportsTransfer(targetConfig.db_type) && !targetConfig.read_only && !tableClipboardMatchesTarget(entries, target); return !!source && !!sourceConfig && !!targetConfig && supportsTransfer(sourceConfig.db_type) && supportsTransfer(targetConfig.db_type) && !connectionIsEffectivelyReadOnly(targetConfig) && !tableClipboardMatchesTarget(entries, target);
} }
function openTransferFromTreeClipboard(): boolean { function openTransferFromTreeClipboard(): boolean {
@@ -3013,7 +3014,7 @@ async function confirmBatchEmpty() {
const canCreateTable = computed(() => { const canCreateTable = computed(() => {
const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined; const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined;
const supportsHBaseTableCreation = config?.db_type === "hbase" && !config.read_only; const supportsHBaseTableCreation = config?.db_type === "hbase" && !connectionIsEffectivelyReadOnly(config);
return ( return (
(activeNode.value.type === "database" || activeNode.value.type === "schema" || activeNode.value.type === "group-tables") && (activeNode.value.type === "database" || activeNode.value.type === "schema" || activeNode.value.type === "group-tables") &&
!isSqlServerLinkedNode(activeNode.value) && !isSqlServerLinkedNode(activeNode.value) &&
@@ -3029,13 +3030,13 @@ const canCreateDatabase = computed(() => {
const canCreateNacosNamespace = computed(() => { const canCreateNacosNamespace = computed(() => {
const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined; const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined;
return activeNode.value.type === "connection" && config?.db_type === "nacos" && !config.read_only; return activeNode.value.type === "connection" && config?.db_type === "nacos" && !connectionIsEffectivelyReadOnly(config);
}); });
const canEditNacosNamespace = computed(() => { const canEditNacosNamespace = computed(() => {
if (activeNode.value.type !== "nacos-namespace" || !activeNode.value.connectionId || !activeNode.value.nacosNamespace) return false; if (activeNode.value.type !== "nacos-namespace" || !activeNode.value.connectionId || !activeNode.value.nacosNamespace) return false;
const config = connectionStore.getConfig(activeNode.value.connectionId); const config = connectionStore.getConfig(activeNode.value.connectionId);
return config?.db_type === "nacos" && !config.read_only; return config?.db_type === "nacos" && !connectionIsEffectivelyReadOnly(config);
}); });
const canDeleteNacosNamespace = computed(() => canEditNacosNamespace.value); const canDeleteNacosNamespace = computed(() => canEditNacosNamespace.value);
@@ -3083,7 +3084,7 @@ const canRenameDatabase = computed(() => {
const node = activeNode.value; const node = activeNode.value;
if (node.type !== "database" || !node.database) return false; if (node.type !== "database" || !node.database) return false;
const config = node.connectionId ? connectionStore.getConfig(node.connectionId) : undefined; const config = node.connectionId ? connectionStore.getConfig(node.connectionId) : undefined;
return !!config && !config.read_only && supportsDatabaseRename(config.db_type); return !!config && !connectionIsEffectivelyReadOnly(config) && supportsDatabaseRename(config.db_type);
}); });
const renameObjectDialogTitle = computed(() => { const renameObjectDialogTitle = computed(() => {
@@ -3104,7 +3105,7 @@ const canDropSchema = computed(() => {
const canEditSchemaComment = computed(() => { const canEditSchemaComment = computed(() => {
const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined; const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined;
return activeNode.value.type === "schema" && !!activeNode.value.database && !config?.read_only && supportsSchemaComment(effectiveDatabaseTypeForConnection(config)); return activeNode.value.type === "schema" && !!activeNode.value.database && !connectionIsEffectivelyReadOnly(config) && supportsSchemaComment(effectiveDatabaseTypeForConnection(config));
}); });
const canBatchDropCascade = computed(() => { const canBatchDropCascade = computed(() => {
@@ -5221,7 +5222,7 @@ function buildSpecialSidebarMenu(context: SidebarMenuFactoryContext): boolean {
icon: RefreshCw, icon: RefreshCw,
shortcut: shortcutRefresh, shortcut: shortcutRefresh,
}); });
if (!connectionStore.getConfig(node.connectionId || "")?.read_only) { if (!connectionIsEffectivelyReadOnly(connectionStore.getConfig(node.connectionId || ""))) {
items.push({ label: "", separator: true }); items.push({ label: "", separator: true });
items.push({ items.push({
label: t("hbase.deleteTable"), label: t("hbase.deleteTable"),
@@ -32,7 +32,6 @@ import {
CalendarClock, CalendarClock,
Gauge, Gauge,
ShieldCheck, ShieldCheck,
Lock,
Archive, Archive,
Square, Square,
Minus, Minus,
@@ -46,6 +45,7 @@ import { useSettingsStore } from "@/stores/settingsStore";
import { useToast } from "@/composables/useToast"; import { useToast } from "@/composables/useToast";
import DatabaseIcon from "@/components/icons/DatabaseIcon.vue"; import DatabaseIcon from "@/components/icons/DatabaseIcon.vue";
import ConnectionErrorIndicator from "@/components/connection/ConnectionErrorIndicator.vue"; import ConnectionErrorIndicator from "@/components/connection/ConnectionErrorIndicator.vue";
import ReadOnlySessionControl from "@/components/connection/ReadOnlySessionControl.vue";
import ProductionContextBadge from "@/components/common/ProductionContextBadge.vue"; import ProductionContextBadge from "@/components/common/ProductionContextBadge.vue";
import { Badge } from "@/components/ui/badge"; import { Badge } from "@/components/ui/badge";
import { Input } from "@/components/ui/input"; import { Input } from "@/components/ui/input";
@@ -1510,7 +1510,7 @@ function onKeydown(event: KeyboardEvent) {
</div> </div>
<span v-if="node.type === 'connection' && node.connectionId && connectionStore.connectedIds.has(node.connectionId)" class="w-1.5 h-1.5 rounded-full bg-green-500 shrink-0" /> <span v-if="node.type === 'connection' && node.connectionId && connectionStore.connectedIds.has(node.connectionId)" class="w-1.5 h-1.5 rounded-full bg-green-500 shrink-0" />
<span v-if="databaseOpenVisual.showsIndicator" class="w-1.5 h-1.5 rounded-full bg-green-500 shrink-0" /> <span v-if="databaseOpenVisual.showsIndicator" class="w-1.5 h-1.5 rounded-full bg-green-500 shrink-0" />
<Badge v-if="isConnectionReadonly" variant="secondary" class="h-4 px-1.5 text-[10px] gap-0.5"> <Lock class="w-2.5 h-2.5" />{{ t("connection.readOnlyBadge") }} </Badge> <ReadOnlySessionControl v-if="isConnectionReadonly && activeNode.connectionId" :connection-id="activeNode.connectionId" show-label />
<ConnectionErrorIndicator v-if="node.type === 'connection'" :connection-id="node.connectionId" trigger-class="h-4 w-4" /> <ConnectionErrorIndicator v-if="node.type === 'connection'" :connection-id="node.connectionId" trigger-class="h-4 w-4" />
<span v-if="formattedObjectStorage()" class="ml-auto shrink-0 text-right text-xs tabular-nums text-muted-foreground">{{ formattedObjectStorage() }}</span> <span v-if="formattedObjectStorage()" class="ml-auto shrink-0 text-right text-xs tabular-nums text-muted-foreground">{{ formattedObjectStorage() }}</span>
<button <button
@@ -16,6 +16,7 @@ import { useToast } from "@/composables/useToast";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { useProductionSafetyStore } from "@/stores/productionSafetyStore"; import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
import { productionContextForDatabase } from "@/lib/database/productionSafety"; import { productionContextForDatabase } from "@/lib/database/productionSafety";
import { connectionIsEffectivelyReadOnly, ensureReadOnlyWriteAccess } from "@/lib/database/readOnlyWriteAccess";
import { fetchSqlFileTargetOptions } from "@/composables/useDatabaseOptions"; import { fetchSqlFileTargetOptions } from "@/composables/useDatabaseOptions";
import { requiresSqlFileTargetDatabaseSelection } from "@/lib/connection/connectionLevelDatabaseBootstrap"; import { requiresSqlFileTargetDatabaseSelection } from "@/lib/connection/connectionLevelDatabaseBootstrap";
import { cancelSqlFileExecution, executeSqlFiles, listenSqlFileProgress, previewSqlFile, type SqlFilePreview, type SqlFileProgress, type SqlFileStatus } from "@/lib/backend/api"; import { cancelSqlFileExecution, executeSqlFiles, listenSqlFileProgress, previewSqlFile, type SqlFilePreview, type SqlFileProgress, type SqlFileStatus } from "@/lib/backend/api";
@@ -357,6 +358,12 @@ async function refreshTargetAfterImport() {
async function startExecution() { async function startExecution() {
if (!canStart.value || previews.value.length === 0) return; if (!canStart.value || previews.value.length === 0) return;
// Await the unlock guard only when it can actually prompt/block (effectively
// read-only); writable or already-unlocked connections stay synchronous so
// the running state flips in the same tick as the click.
if (connectionIsEffectivelyReadOnly(selectedConnection.value)) {
if (!(await ensureReadOnlyWriteAccess({ connection: selectedConnection.value, source: t("readOnlyUnlock.sourceSqlFile"), treatAsMutation: true }))) return;
}
const productionContext = productionContextForDatabase(selectedConnection.value, database.value); const productionContext = productionContextForDatabase(selectedConnection.value, database.value);
if (productionContext.active) { if (productionContext.active) {
// File previews are truncated, so production file execution is always reviewed instead of inferring safety from a partial preview. // File previews are truncated, so production file execution is always reviewed instead of inferring safety from a partial preview.
@@ -12,6 +12,7 @@ import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@
import SearchableSelect from "@/components/ui/searchable-select/SearchableSelect.vue"; import SearchableSelect from "@/components/ui/searchable-select/SearchableSelect.vue";
import ConnectionTreeSelect from "@/components/connection/ConnectionTreeSelect.vue"; import ConnectionTreeSelect from "@/components/connection/ConnectionTreeSelect.vue";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { ensureReadOnlyWriteAccess } from "@/lib/database/readOnlyWriteAccess";
import * as api from "@/lib/backend/api"; import * as api from "@/lib/backend/api";
import type { TransferContent, TransferMode, TransferObjectKind, TransferTableNameCase } from "@/lib/backend/api"; import type { TransferContent, TransferMode, TransferObjectKind, TransferTableNameCase } from "@/lib/backend/api";
import { crossFamilyTransferableKinds, isSameTransferFamily, transferObjectKindsForDatabase } from "@/lib/database/transferObjectKinds"; import { crossFamilyTransferableKinds, isSameTransferFamily, transferObjectKindsForDatabase } from "@/lib/database/transferObjectKinds";
@@ -735,6 +736,9 @@ function swapSourceAndTarget() {
async function startTransfer() { async function startTransfer() {
if (!canStart.value || isSubmitting.value) return; if (!canStart.value || isSubmitting.value) return;
if (!(await ensureReadOnlyWriteAccess({ connection: store.getConfig(targetConnectionId.value), source: t("readOnlyUnlock.sourceTransfer"), treatAsMutation: true }))) {
return;
}
isSubmitting.value = true; isSubmitting.value = true;
const effectiveSourceSchema = sourceSchema.value || sourceDatabaseName.value; const effectiveSourceSchema = sourceSchema.value || sourceDatabaseName.value;
@@ -19,6 +19,9 @@ vi.mock("@/lib/backend/api", () => ({
executeConditionalUpdate: mocks.executeConditionalUpdate, executeConditionalUpdate: mocks.executeConditionalUpdate,
cancelConditionalUpdate: mocks.cancelConditionalUpdate, cancelConditionalUpdate: mocks.cancelConditionalUpdate,
executeInTransaction: mocks.executeInTransaction, executeInTransaction: mocks.executeInTransaction,
unlockConnectionWrites: vi.fn(),
lockConnectionWrites: vi.fn(),
connectionWriteUnlockState: vi.fn().mockResolvedValue(0),
})); }));
vi.mock("@/stores/connectionStore", () => ({ vi.mock("@/stores/connectionStore", () => ({
useConnectionStore: () => ({ getConfig: mocks.getConfig }), useConnectionStore: () => ({ getConfig: mocks.getConfig }),
@@ -10,7 +10,7 @@ vi.mock("@/stores/connectionStore", () => ({
useConnectionStore: () => ({ useConnectionStore: () => ({
getConfig: (id: string) => { getConfig: (id: string) => {
if (id === "missing") return undefined; if (id === "missing") return undefined;
if (id === "readonly") return { name: "ro", read_only: true, is_production: false }; if (id === "readonly") return { id: "readonly", name: "ro", read_only: true, is_production: false, db_type: "mq" };
if (id === "prod") return { name: "prod-mq", read_only: false, is_production: true }; if (id === "prod") return { name: "prod-mq", read_only: false, is_production: true };
return { name: "dev-mq", read_only: false, is_production: false }; return { name: "dev-mq", read_only: false, is_production: false };
}, },
@@ -21,6 +21,12 @@ vi.mock("@/stores/productionSafetyStore", () => ({
useProductionSafetyStore: () => ({ requestConfirmation }), useProductionSafetyStore: () => ({ requestConfirmation }),
})); }));
vi.mock("@/lib/backend/api", () => ({
unlockConnectionWrites: vi.fn(),
lockConnectionWrites: vi.fn(),
connectionWriteUnlockState: vi.fn().mockResolvedValue(0),
}));
vi.mock("@/composables/useToast", () => ({ vi.mock("@/composables/useToast", () => ({
useToast: () => ({ toast }), useToast: () => ({ toast }),
})); }));
@@ -32,6 +38,7 @@ vi.mock("vue-i18n", () => ({
})); }));
import { useMqMutationGuard } from "@/composables/useMqMutationGuard"; import { useMqMutationGuard } from "@/composables/useMqMutationGuard";
import { useReadOnlyUnlockStore } from "@/stores/readOnlyUnlockStore";
describe("useMqMutationGuard", () => { describe("useMqMutationGuard", () => {
beforeEach(() => { beforeEach(() => {
@@ -41,14 +48,20 @@ describe("useMqMutationGuard", () => {
toast.mockReset(); toast.mockReset();
}); });
it("denies missing and read-only connections without prompting", async () => { it("denies missing connections and prompts to unlock read-only ones", async () => {
const missing = useMqMutationGuard("missing"); const missing = useMqMutationGuard("missing");
const readonly = useMqMutationGuard("readonly");
await expect(missing.confirmMqWrite("send")).resolves.toBe(false); await expect(missing.confirmMqWrite("send")).resolves.toBe(false);
await expect(readonly.confirmMqWrite("send")).resolves.toBe(false);
expect(requestConfirmation).not.toHaveBeenCalled();
expect(toast).toHaveBeenCalledWith("mqAdmin.connectionMissing"); expect(toast).toHaveBeenCalledWith("mqAdmin.connectionMissing");
expect(toast).toHaveBeenCalledWith("mqAdmin.writeDeniedReadOnly");
const unlockStore = useReadOnlyUnlockStore();
const readonly = useMqMutationGuard("readonly");
const pending = readonly.confirmMqWrite("send");
await vi.waitFor(() => {
expect(unlockStore.pending?.connectionId).toBe("readonly");
});
expect(requestConfirmation).not.toHaveBeenCalled();
unlockStore.cancel();
await expect(pending).resolves.toBe(false);
}); });
it("allows non-production writes immediately", async () => { it("allows non-production writes immediately", async () => {
@@ -17,6 +17,9 @@ vi.mock("vue-i18n", () => ({
vi.mock("@/lib/backend/api", () => ({ vi.mock("@/lib/backend/api", () => ({
saveEditorSettings: vi.fn(), saveEditorSettings: vi.fn(),
saveHistory: vi.fn(), saveHistory: vi.fn(),
unlockConnectionWrites: vi.fn(),
lockConnectionWrites: vi.fn(),
connectionWriteUnlockState: vi.fn().mockResolvedValue(0),
})); }));
function installLocalStorage() { function installLocalStorage() {
@@ -1199,8 +1202,9 @@ SELECT @value AS Message;`;
}); });
const pendingExecution = execution.tryExecute(); const pendingExecution = execution.tryExecute();
await Promise.resolve(); await vi.waitFor(() => {
expect(productionSafetyStore.pending?.sql).toContain("UPDATE users"); expect(productionSafetyStore.pending?.sql).toContain("UPDATE users");
});
expect(executeCurrentSql).not.toHaveBeenCalled(); expect(executeCurrentSql).not.toHaveBeenCalled();
productionSafetyStore.confirm(); productionSafetyStore.confirm();
@@ -28,6 +28,9 @@ vi.mock("vue-i18n", () => ({
vi.mock("@/lib/backend/api", () => ({ vi.mock("@/lib/backend/api", () => ({
saveEditorSettings: vi.fn(), saveEditorSettings: vi.fn(),
saveHistory: vi.fn(), saveHistory: vi.fn(),
unlockConnectionWrites: vi.fn(),
lockConnectionWrites: vi.fn(),
connectionWriteUnlockState: vi.fn().mockResolvedValue(0),
})); }));
function installLocalStorage() { function installLocalStorage() {
@@ -11,6 +11,7 @@ import { useConnectionStore } from "@/stores/connectionStore";
import { useHistoryStore } from "@/stores/historyStore"; import { useHistoryStore } from "@/stores/historyStore";
import { useProductionSafetyStore } from "@/stores/productionSafetyStore"; import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
import { assessProductionSql, productionContextForDatabase } from "@/lib/database/productionSafety"; import { assessProductionSql, productionContextForDatabase } from "@/lib/database/productionSafety";
import { ensureReadOnlyWriteAccess, isWriteUnlockActive } from "@/lib/database/readOnlyWriteAccess";
import type { ColumnInfo, DatabaseType } from "@/types/database"; import type { ColumnInfo, DatabaseType } from "@/types/database";
import { DBX_NEO4J_ELEMENT_ID_COLUMN, usesSyntheticRowIdKey } from "@/lib/table/tableEditing"; import { DBX_NEO4J_ELEMENT_ID_COLUMN, usesSyntheticRowIdKey } from "@/lib/table/tableEditing";
import { effectiveDatabaseTypeForConnection } from "@/lib/database/jdbcDialect"; import { effectiveDatabaseTypeForConnection } from "@/lib/database/jdbcDialect";
@@ -1598,6 +1599,7 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
saveError.value = ""; saveError.value = "";
const connection = connectionStore.getConfig(connectionId.value); const connection = connectionStore.getConfig(connectionId.value);
if (!(await ensureReadOnlyWriteAccess({ connection, sql: statement, source: i18n.global.t("readOnlyUnlock.sourceDataEditor") }))) return null;
const productionAssessment = assessProductionSql(statement, connection, database.value); const productionAssessment = assessProductionSql(statement, connection, database.value);
if (productionAssessment.active && productionAssessment.isMutation) { if (productionAssessment.active && productionAssessment.isMutation) {
const confirmed = await productionSafetyStore.requestConfirmation({ const confirmed = await productionSafetyStore.requestConfirmation({
@@ -1605,7 +1607,7 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
connectionName: connection?.name, connectionName: connection?.name,
database: database.value, database: database.value,
productionDatabases: productionAssessment.databases, productionDatabases: productionAssessment.databases,
source: "Data editor", source: i18n.global.t("readOnlyUnlock.sourceDataEditor"),
}); });
if (!confirmed) return null; if (!confirmed) return null;
} }
@@ -1701,6 +1703,12 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
} }
const customHandler = customSaveHandler?.value; const customHandler = customSaveHandler?.value;
const connection = connectionStore.getConfig(connectionId.value ?? ""); const connection = connectionStore.getConfig(connectionId.value ?? "");
if (connection?.read_only) {
if (saveOptions.autoSave && !isWriteUnlockActive(connection.id)) return;
if (!(await ensureReadOnlyWriteAccess({ connection, sql: describeDataGridChanges(snapshot), source: i18n.global.t("readOnlyUnlock.sourceDataEditor"), treatAsMutation: true }))) {
return;
}
}
const customHandlerProductionContext = productionContextForDatabase(connection, database.value); const customHandlerProductionContext = productionContextForDatabase(connection, database.value);
if (customHandler && customHandlerProductionContext.active) { if (customHandler && customHandlerProductionContext.active) {
// Custom data sources may not expose SQL, but their row mutations still need the same production interlock. // Custom data sources may not expose SQL, but their row mutations still need the same production interlock.
@@ -1712,7 +1720,7 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
connectionName: connection?.name, connectionName: connection?.name,
database: database.value, database: database.value,
productionDatabases: customHandlerProductionContext.databases, productionDatabases: customHandlerProductionContext.databases,
source: "Data editor", source: i18n.global.t("readOnlyUnlock.sourceDataEditor"),
}); });
if (!confirmed) return; if (!confirmed) return;
} }
@@ -1793,7 +1801,7 @@ export function useDataGridEditor(options: UseDataGridEditorOptions) {
connectionName: connection?.name, connectionName: connection?.name,
database: database.value, database: database.value,
productionDatabases: productionAssessment.databases, productionDatabases: productionAssessment.databases,
source: "Data editor", source: i18n.global.t("readOnlyUnlock.sourceDataEditor"),
}); });
if (!confirmed) { if (!confirmed) {
await finishInterruptedSaveChanges(snapshot); await finishInterruptedSaveChanges(snapshot);
@@ -2,6 +2,7 @@ import { toValue, type MaybeRefOrGetter } from "vue";
import { useI18n } from "vue-i18n"; import { useI18n } from "vue-i18n";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import { useProductionSafetyStore } from "@/stores/productionSafetyStore"; import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
import { ensureReadOnlyWriteAccess } from "@/lib/database/readOnlyWriteAccess";
import { useToast } from "@/composables/useToast"; import { useToast } from "@/composables/useToast";
/** /**
@@ -24,8 +25,7 @@ export function useMqMutationGuard(connectionId: MaybeRefOrGetter<string>) {
toast(t("mqAdmin.connectionMissing")); toast(t("mqAdmin.connectionMissing"));
return false; return false;
} }
if (config.read_only) { if (!(await ensureReadOnlyWriteAccess({ connection: config, sql: operation, source: t("production.sourceMq"), treatAsMutation: true }))) {
toast(t("mqAdmin.writeDeniedReadOnly"));
return false; return false;
} }
if (!config.is_production) return true; if (!config.is_production) return true;
@@ -4,6 +4,7 @@ import { useToast } from "@/composables/useToast";
import { useConnectionStore } from "@/stores/connectionStore"; import { useConnectionStore } from "@/stores/connectionStore";
import type { DatabaseType, TreeNode } from "@/types/database"; import type { DatabaseType, TreeNode } from "@/types/database";
import { supportsTableTruncate, supportsTableVacuum } from "@/lib/database/databaseCapabilities"; import { supportsTableTruncate, supportsTableVacuum } from "@/lib/database/databaseCapabilities";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
import { import {
buildDropTableSql, buildDropTableSql,
buildEmptyTableSql, buildEmptyTableSql,
@@ -66,7 +67,7 @@ export function useSidebarTableMutationRuntime(options: SidebarTableMutationRunt
const supportsTruncate = computed(() => supportsTableTruncate(currentDatabaseType())); const supportsTruncate = computed(() => supportsTableTruncate(currentDatabaseType()));
const supportsVacuum = computed(() => { const supportsVacuum = computed(() => {
const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined; const config = activeNode.value.connectionId ? connectionStore.getConfig(activeNode.value.connectionId) : undefined;
return activeNode.value.type === "table" && !config?.read_only && supportsTableVacuum(currentDatabaseType()); return activeNode.value.type === "table" && !connectionIsEffectivelyReadOnly(config) && supportsTableVacuum(currentDatabaseType());
}); });
const canDropTableCascade = computed(() => activeNode.value.type === "table" && supportsDropTableCascade(currentDatabaseType())); const canDropTableCascade = computed(() => activeNode.value.type === "table" && supportsDropTableCascade(currentDatabaseType()));
const canTruncateTableCascade = computed(() => activeNode.value.type === "table" && supportsTruncateTableCascade(currentDatabaseType())); const canTruncateTableCascade = computed(() => activeNode.value.type === "table" && supportsTruncateTableCascade(currentDatabaseType()));
@@ -19,6 +19,7 @@ import { extractSqlParameterDescriptors, type SqlParameterDescriptor, type SqlPa
import { expandSqlVariables } from "@/lib/sql/sqlVariables"; import { expandSqlVariables } from "@/lib/sql/sqlVariables";
import { enabledSqlParameterSyntaxes, resolveSqlVariableSyntaxToggles } from "@/lib/sql/sqlVariableSyntax"; import { enabledSqlParameterSyntaxes, resolveSqlVariableSyntaxToggles } from "@/lib/sql/sqlVariableSyntax";
import { assessProductionSql } from "@/lib/database/productionSafety"; import { assessProductionSql } from "@/lib/database/productionSafety";
import { ensureReadOnlyWriteAccess } from "@/lib/database/readOnlyWriteAccess";
import { useProductionSafetyStore } from "@/stores/productionSafetyStore"; import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
import type { SqlExecutionDangerRequest } from "@/stores/sqlExecutionDangerStore"; import type { SqlExecutionDangerRequest } from "@/stores/sqlExecutionDangerStore";
import type { ConnectionConfig, DatabaseType, QueryTab } from "@/types/database"; import type { ConnectionConfig, DatabaseType, QueryTab } from "@/types/database";
@@ -176,6 +177,7 @@ export function useSqlExecution(deps: {
} }
async function continueExecute(sql: string, sourceOffset?: number, options: SqlExecutionOptions = {}) { async function continueExecute(sql: string, sourceOffset?: number, options: SqlExecutionOptions = {}) {
if (!(await ensureReadOnlyWriteAccess({ connection: deps.activeConnection.value, sql, source: t("production.sourceSqlEditor") }))) return;
// Redis: block dangerous commands when toggle is on (scan entire batch for highest safety level) // Redis: block dangerous commands when toggle is on (scan entire batch for highest safety level)
if (deps.activeConnection.value?.db_type === "redis" && deps.blockDangerousRedisCommands?.value !== false) { if (deps.activeConnection.value?.db_type === "redis" && deps.blockDangerousRedisCommands?.value !== false) {
const commands = sql const commands = sql
@@ -358,6 +360,9 @@ export function useSqlExecution(deps: {
const tabCancelRequested = (count: number) => (tab.cancelRequestCount ?? 0) !== count; const tabCancelRequested = (count: number) => (tab.cancelRequestCount ?? 0) !== count;
if (cancelRequested()) return finish({ status: "cancelled" }); if (cancelRequested()) return finish({ status: "cancelled" });
if (!sql.trim()) return finish({ status: "failed", errorMessage: t("explain.emptySql") }); if (!sql.trim()) return finish({ status: "failed", errorMessage: t("explain.emptySql") });
if (!(await ensureReadOnlyWriteAccess({ connection, sql, source: t("production.sourceMultiDbSql") }))) {
return finish({ status: "skipped", errorMessage: t("dangerDialog.cancel") });
}
if (requiresDatabaseSelection(executionTab, connection, sql)) { if (requiresDatabaseSelection(executionTab, connection, sql)) {
return finish({ status: "failed", errorMessage: t("editor.selectDatabaseRequired") }); return finish({ status: "failed", errorMessage: t("editor.selectDatabaseRequired") });
} }
@@ -544,6 +549,7 @@ export function useSqlExecution(deps: {
settingsStore.updateEditorSettings({ confirmDangerousSqlExecution: false }); settingsStore.updateEditorSettings({ confirmDangerousSqlExecution: false });
} }
suppressDangerConfirm.value = false; suppressDangerConfirm.value = false;
if (!(await ensureReadOnlyWriteAccess({ connection: deps.activeConnection.value, sql, source: t("production.sourceSqlEditor") }))) return;
await doExecute(sql, sourceOffset, { openInNewResultTab, editorViewportRequestId }); await doExecute(sql, sourceOffset, { openInNewResultTab, editorViewportRequestId });
} }
+18
View File
@@ -5170,6 +5170,24 @@ export default {
sourceAdmin: "Database administration", sourceAdmin: "Database administration",
aiReviewRequired: "Production SQL was added to the editor. Review it and run it manually to confirm.", aiReviewRequired: "Production SQL was added to the editor. Review it and run it manually to confirm.",
}, },
readOnlyUnlock: {
confirmTitle: "Unlock writes",
confirmMessage: "This connection is read-only. Writes stay blocked unless you unlock them for a short window. The saved read-only setting will not be turned off.",
confirmDetails: "Connection: {connection}\nSource: {source}\nWrites will be allowed for the selected duration, then read-only resumes automatically.",
confirmAction: "Unlock writes",
durationLabel: "Allow writes for",
durationOneMinute: "1 minute",
durationFiveMinutes: "5 minutes",
remaining: "{time} left",
unlockedBadge: "Writes unlocked",
lockNow: "Lock writes now",
unlockAction: "Unlock writes…",
sourceImport: "Table import",
sourceTransfer: "Data transfer",
sourceSqlFile: "SQL file execution",
sourceStatus: "Read-only control",
sourceDataEditor: "Data editor",
},
sqlParameters: { sqlParameters: {
title: "SQL Parameters", title: "SQL Parameters",
description: "Fill values for SQL template placeholders. DBX replaces them before executing the SQL.", description: "Fill values for SQL template placeholders. DBX replaces them before executing the SQL.",
+18
View File
@@ -8100,6 +8100,24 @@ export default withEnglishFallback({
aiReviewRequired: "El SQL de producción se ha colocado en el editor. Revíselo primero y luego ejecútelo manualmente para confirmar.", aiReviewRequired: "El SQL de producción se ha colocado en el editor. Revíselo primero y luego ejecútelo manualmente para confirmar.",
sourceMultiDbSql: "Ejecución SQL multi-base de datos", sourceMultiDbSql: "Ejecución SQL multi-base de datos",
}, },
readOnlyUnlock: {
confirmTitle: "Desbloquear escrituras",
confirmMessage: "Esta conexión es de solo lectura. Las escrituras siguen bloqueadas a menos que las desbloquee durante un breve intervalo. El ajuste de solo lectura guardado no se desactivará.",
confirmDetails: "Conexión: {connection}\nOrigen: {source}\nLas escrituras se permitirán durante el tiempo seleccionado y luego se reanudará automáticamente el modo de solo lectura.",
confirmAction: "Desbloquear escrituras",
durationLabel: "Permitir escrituras durante",
durationOneMinute: "1 minuto",
durationFiveMinutes: "5 minutos",
remaining: "{time} restantes",
unlockedBadge: "Escrituras desbloqueadas",
lockNow: "Volver a bloquear ahora",
unlockAction: "Desbloquear escrituras…",
sourceImport: "Importación de tabla",
sourceTransfer: "Transferencia de datos",
sourceSqlFile: "Ejecución de archivo SQL",
sourceStatus: "Control de solo lectura",
sourceDataEditor: "Editor de datos",
},
processList: { processList: {
title: "Lista de procesos", title: "Lista de procesos",
sessionCount: "{count} sesiones", sessionCount: "{count} sesiones",
+18
View File
@@ -8101,6 +8101,24 @@ export default withEnglishFallback({
aiReviewRequired: "La SQL di produzione è stata inserita nell'editor. Controllare prima, quindi eseguire manualmente per confermare.", aiReviewRequired: "La SQL di produzione è stata inserita nell'editor. Controllare prima, quindi eseguire manualmente per confermare.",
sourceMultiDbSql: "Esecuzione SQL multi-DB", sourceMultiDbSql: "Esecuzione SQL multi-DB",
}, },
readOnlyUnlock: {
confirmTitle: "Sblocca scritture",
confirmMessage: "Questa connessione è in sola lettura. Le scritture restano bloccate a meno che non le sblocchi per un breve intervallo. L'impostazione di sola lettura salvata non verrà disattivata.",
confirmDetails: "Connessione: {connection}\nOrigine: {source}\nLe scritture saranno consentite per la durata selezionata, poi la sola lettura riprenderà automaticamente.",
confirmAction: "Sblocca scritture",
durationLabel: "Consenti scritture per",
durationOneMinute: "1 minuto",
durationFiveMinutes: "5 minuti",
remaining: "{time} rimanenti",
unlockedBadge: "Scritture sbloccate",
lockNow: "Blocca scritture ora",
unlockAction: "Sblocca scritture…",
sourceImport: "Importazione tabella",
sourceTransfer: "Trasferimento dati",
sourceSqlFile: "Esecuzione file SQL",
sourceStatus: "Controllo sola lettura",
sourceDataEditor: "Editor dati",
},
processList: { processList: {
title: "Elenco processi", title: "Elenco processi",
sessionCount: "{count} sessioni", sessionCount: "{count} sessioni",
+18
View File
@@ -8152,6 +8152,24 @@ export default withEnglishFallback({
aiReviewRequired: "本番SQLがエディターに配置されました。まず確認し、手動で実行して確定してください。", aiReviewRequired: "本番SQLがエディターに配置されました。まず確認し、手動で実行して確定してください。",
sourceMultiDbSql: "複数DB SQL実行", sourceMultiDbSql: "複数DB SQL実行",
}, },
readOnlyUnlock: {
confirmTitle: "書き込みのロックを解除",
confirmMessage: "この接続は読み取り専用です。短い時間だけロックを解除しない限り、書き込みはブロックされたままです。保存済みの読み取り専用設定はオフになりません。",
confirmDetails: "接続:{connection}\nソース:{source}\n選択した時間だけ書き込みが許可され、その後自動的に読み取り専用に戻ります。",
confirmAction: "書き込みのロックを解除",
durationLabel: "書き込みを許可する時間",
durationOneMinute: "1 分",
durationFiveMinutes: "5 分",
remaining: "残り {time}",
unlockedBadge: "書き込み解除中",
lockNow: "今すぐ再ロック",
unlockAction: "書き込みのロックを解除…",
sourceImport: "テーブルのインポート",
sourceTransfer: "データ転送",
sourceSqlFile: "SQL ファイル実行",
sourceStatus: "読み取り専用コントロール",
sourceDataEditor: "データエディター",
},
processList: { processList: {
title: "プロセス一覧", title: "プロセス一覧",
sessionCount: "{count} セッション", sessionCount: "{count} セッション",
+18
View File
@@ -4599,6 +4599,24 @@ export default withEnglishFallback({
sourceAdmin: "데이터베이스 관리", sourceAdmin: "데이터베이스 관리",
aiReviewRequired: "프로덕션 SQL이 편집기에 추가되었습니다. 확인하려면 검토 후 수동으로 실행하세요.", aiReviewRequired: "프로덕션 SQL이 편집기에 추가되었습니다. 확인하려면 검토 후 수동으로 실행하세요.",
}, },
readOnlyUnlock: {
confirmTitle: "쓰기 잠금 해제",
confirmMessage: "이 연결은 읽기 전용입니다. 짧은 시간 동안 잠금을 해제하지 않으면 쓰기가 계속 차단됩니다. 저장된 읽기 전용 설정은 꺼지지 않습니다.",
confirmDetails: "연결: {connection}\n출처: {source}\n선택한 시간 동안 쓰기가 허용된 뒤 자동으로 읽기 전용으로 돌아갑니다.",
confirmAction: "쓰기 잠금 해제",
durationLabel: "쓰기 허용 시간",
durationOneMinute: "1분",
durationFiveMinutes: "5분",
remaining: "{time} 남음",
unlockedBadge: "쓰기 잠금 해제됨",
lockNow: "지금 다시 잠금",
unlockAction: "쓰기 잠금 해제…",
sourceImport: "테이블 가져오기",
sourceTransfer: "데이터 이전",
sourceSqlFile: "SQL 파일 실행",
sourceStatus: "읽기 전용 컨트롤",
sourceDataEditor: "데이터 편집기",
},
sqlParameters: { sqlParameters: {
title: "SQL 매개변수", title: "SQL 매개변수",
description: "SQL 템플릿 자리표시자의 값을 입력하세요. DBX가 SQL을 실행하기 전에 대체합니다.", description: "SQL 템플릿 자리표시자의 값을 입력하세요. DBX가 SQL을 실행하기 전에 대체합니다.",
+18
View File
@@ -8102,6 +8102,24 @@ export default withEnglishFallback({
aiReviewRequired: "O SQL de produção foi colocado no editor. Verifique-o primeiro e execute manualmente para confirmar.", aiReviewRequired: "O SQL de produção foi colocado no editor. Verifique-o primeiro e execute manualmente para confirmar.",
sourceMultiDbSql: "Execução de SQL em múltiplos bancos de dados", sourceMultiDbSql: "Execução de SQL em múltiplos bancos de dados",
}, },
readOnlyUnlock: {
confirmTitle: "Desbloquear gravações",
confirmMessage: "Esta conexão é somente leitura. As gravações continuam bloqueadas a menos que você as desbloqueie por um curto intervalo. A configuração de somente leitura salva não será desativada.",
confirmDetails: "Conexão: {connection}\nOrigem: {source}\nAs gravações serão permitidas pela duração selecionada e, em seguida, o modo somente leitura será retomado automaticamente.",
confirmAction: "Desbloquear gravações",
durationLabel: "Permitir gravações por",
durationOneMinute: "1 minuto",
durationFiveMinutes: "5 minutos",
remaining: "{time} restantes",
unlockedBadge: "Gravações desbloqueadas",
lockNow: "Bloquear gravações agora",
unlockAction: "Desbloquear gravações…",
sourceImport: "Importação de tabela",
sourceTransfer: "Transferência de dados",
sourceSqlFile: "Execução de arquivo SQL",
sourceStatus: "Controle de somente leitura",
sourceDataEditor: "Editor de dados",
},
processList: { processList: {
title: "Lista de Processos", title: "Lista de Processos",
sessionCount: "{count} sessões", sessionCount: "{count} sessões",
+18
View File
@@ -5155,6 +5155,24 @@ export default withEnglishFallback({
sourceAdmin: "数据库管理", sourceAdmin: "数据库管理",
aiReviewRequired: "生产 SQL 已放入编辑器。请先检查,再手动执行以确认。", aiReviewRequired: "生产 SQL 已放入编辑器。请先检查,再手动执行以确认。",
}, },
readOnlyUnlock: {
confirmTitle: "临时解锁写入",
confirmMessage: "当前连接处于只读模式。写入会被阻止,除非你确认解锁一小段时间。已保存的只读设置不会被关闭。",
confirmDetails: "连接:{connection}\n入口:{source}\n写入仅在所选时长内允许,到期后自动恢复只读。",
confirmAction: "解锁写入",
durationLabel: "允许写入时长",
durationOneMinute: "1 分钟",
durationFiveMinutes: "5 分钟",
remaining: "剩余 {time}",
unlockedBadge: "写入已解锁",
lockNow: "立即重新锁定",
unlockAction: "解锁写入…",
sourceImport: "表导入",
sourceTransfer: "数据传输",
sourceSqlFile: "SQL 文件执行",
sourceStatus: "只读控制",
sourceDataEditor: "数据编辑器",
},
sqlParameters: { sqlParameters: {
title: "SQL 参数", title: "SQL 参数",
description: "为 SQL 模板占位符填写参数值,DBX 会在执行前替换为 SQL 字面量。", description: "为 SQL 模板占位符填写参数值,DBX 会在执行前替换为 SQL 字面量。",
+18
View File
@@ -8092,6 +8092,24 @@ export default withEnglishFallback({
aiReviewRequired: "生產 SQL 已放入編輯器。請先檢查,再手動執行以確認。", aiReviewRequired: "生產 SQL 已放入編輯器。請先檢查,再手動執行以確認。",
sourceMultiDbSql: "多庫 SQL 執行", sourceMultiDbSql: "多庫 SQL 執行",
}, },
readOnlyUnlock: {
confirmTitle: "暫時解鎖寫入",
confirmMessage: "目前連線處於唯讀模式。寫入會被阻擋,除非你確認解鎖一小段時間。已儲存的唯讀設定不會被關閉。",
confirmDetails: "連線:{connection}\n入口:{source}\n寫入僅在所選時長內允許,到期後自動恢復唯讀。",
confirmAction: "解鎖寫入",
durationLabel: "允許寫入時長",
durationOneMinute: "1 分鐘",
durationFiveMinutes: "5 分鐘",
remaining: "剩餘 {time}",
unlockedBadge: "寫入已解鎖",
lockNow: "立即重新鎖定",
unlockAction: "解鎖寫入…",
sourceImport: "資料表匯入",
sourceTransfer: "資料傳輸",
sourceSqlFile: "SQL 檔案執行",
sourceStatus: "唯讀控制",
sourceDataEditor: "資料編輯器",
},
processList: { processList: {
title: "處理程序清單", title: "處理程序清單",
sessionCount: "{count} 個會話", sessionCount: "{count} 個會話",
+3
View File
@@ -56,6 +56,9 @@ export const testConnectionWithInfo = forward("testConnectionWithInfo");
export const connectDb = forward("connectDb"); export const connectDb = forward("connectDb");
export const connectionDatabaseInfo = forward("connectionDatabaseInfo"); export const connectionDatabaseInfo = forward("connectionDatabaseInfo");
export const saveConnectionDatabaseInfo = forward("saveConnectionDatabaseInfo"); export const saveConnectionDatabaseInfo = forward("saveConnectionDatabaseInfo");
export const unlockConnectionWrites = forward("unlockConnectionWrites");
export const lockConnectionWrites = forward("lockConnectionWrites");
export const connectionWriteUnlockState = forward("connectionWriteUnlockState");
export const connectionFinalProxyPort = forward("connectionFinalProxyPort"); export const connectionFinalProxyPort = forward("connectionFinalProxyPort");
export const disconnectDb = forward("disconnectDb"); export const disconnectDb = forward("disconnectDb");
export const sessionCredentialStatus = forward("sessionCredentialStatus"); export const sessionCredentialStatus = forward("sessionCredentialStatus");
+14
View File
@@ -399,6 +399,20 @@ export async function saveConnectionDatabaseInfo(connectionId: string, databaseI
}); });
} }
export async function unlockConnectionWrites(connectionId: string, durationSecs: number): Promise<number> {
const state = await post<{ remainingMs: number }>("/api/connection/write-unlock", { connectionId, durationSecs });
return state.remainingMs;
}
export async function lockConnectionWrites(connectionId: string): Promise<void> {
return post("/api/connection/write-unlock/lock", { connectionId });
}
export async function connectionWriteUnlockState(connectionId: string): Promise<number> {
const state = await post<{ remainingMs: number }>("/api/connection/write-unlock/state", { connectionId });
return state.remainingMs;
}
export async function connectionFinalProxyPort(config: ConnectionConfig): Promise<number> { export async function connectionFinalProxyPort(config: ConnectionConfig): Promise<number> {
return post("/api/connection/final-proxy-port", { config }); return post("/api/connection/final-proxy-port", { config });
} }
+18
View File
@@ -1023,6 +1023,24 @@ export async function saveConnectionDatabaseInfo(connectionId: string, databaseI
}); });
} }
export interface WriteUnlockState {
remainingMs: number;
}
export async function unlockConnectionWrites(connectionId: string, durationSecs: number): Promise<number> {
const state = await invokeBackend<WriteUnlockState>("unlock_connection_writes", { connectionId, durationSecs });
return state.remainingMs;
}
export async function lockConnectionWrites(connectionId: string): Promise<void> {
return invokeBackend("lock_connection_writes", { connectionId });
}
export async function connectionWriteUnlockState(connectionId: string): Promise<number> {
const state = await invokeBackend<WriteUnlockState>("connection_write_unlock_state", { connectionId });
return state.remainingMs;
}
export async function connectionFinalProxyPort(config: ConnectionConfig): Promise<number> { export async function connectionFinalProxyPort(config: ConnectionConfig): Promise<number> {
return invokeBackend("connection_final_proxy_port", { config }); return invokeBackend("connection_final_proxy_port", { config });
} }
+4 -1
View File
@@ -1,4 +1,7 @@
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
type AgentTargetConnection = { type AgentTargetConnection = {
id?: string;
read_only?: boolean; read_only?: boolean;
transport_layers?: Array<{ enabled?: boolean }>; transport_layers?: Array<{ enabled?: boolean }>;
external_config?: unknown; external_config?: unknown;
@@ -32,7 +35,7 @@ export function consulAgentAddressesMatch(left: string, right: string): boolean
} }
export function consulAgentWriteTargetSafe(connection: AgentTargetConnection | undefined, identityNode: string | undefined): boolean { export function consulAgentWriteTargetSafe(connection: AgentTargetConnection | undefined, identityNode: string | undefined): boolean {
if (!connection || connection.read_only || connection.transport_layers?.some((layer) => layer.enabled !== false)) return false; if (!connection || connectionIsEffectivelyReadOnly(connection) || connection.transport_layers?.some((layer) => layer.enabled !== false)) return false;
const external = connection.external_config; const external = connection.external_config;
if (!external || typeof external !== "object" || Array.isArray(external)) return false; if (!external || typeof external !== "object" || Array.isArray(external)) return false;
const config = external as Record<string, unknown>; const config = external as Record<string, unknown>;
@@ -0,0 +1,118 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
import { createPinia, setActivePinia } from "pinia";
import { useReadOnlyUnlockStore } from "@/stores/readOnlyUnlockStore";
import { connectionIsEffectivelyReadOnly, ensureReadOnlyWriteAccess, formatWriteUnlockRemaining, sqlLooksLikeMutation } from "../readOnlyWriteAccess";
const unlockConnectionWrites = vi.fn();
const lockConnectionWrites = vi.fn();
const connectionWriteUnlockState = vi.fn();
vi.mock("@/lib/backend/api", () => ({
unlockConnectionWrites: (...args: unknown[]) => unlockConnectionWrites(...args),
lockConnectionWrites: (...args: unknown[]) => lockConnectionWrites(...args),
connectionWriteUnlockState: (...args: unknown[]) => connectionWriteUnlockState(...args),
}));
async function waitForPending(connectionId: string) {
const store = useReadOnlyUnlockStore();
await vi.waitFor(() => {
expect(store.pending?.connectionId).toBe(connectionId);
});
return store;
}
describe("read-only write unlock", () => {
beforeEach(() => {
setActivePinia(createPinia());
unlockConnectionWrites.mockReset().mockResolvedValue(60_000);
lockConnectionWrites.mockReset().mockResolvedValue(undefined);
connectionWriteUnlockState.mockReset().mockResolvedValue(0);
vi.useRealTimers();
});
it("formats remaining time as m:ss", () => {
expect(formatWriteUnlockRemaining(60_000)).toBe("1:00");
expect(formatWriteUnlockRemaining(5_000)).toBe("0:05");
expect(formatWriteUnlockRemaining(0)).toBe("0:00");
});
it("classifies SQL and Redis writes without treating reads as mutations", () => {
expect(sqlLooksLikeMutation("SELECT 1", "mysql")).toBe(false);
expect(sqlLooksLikeMutation("INSERT INTO t VALUES (1)", "mysql")).toBe(true);
expect(sqlLooksLikeMutation("UPDATE t SET a = 1", "postgres")).toBe(true);
expect(sqlLooksLikeMutation("DELETE FROM t", "mysql")).toBe(true);
expect(sqlLooksLikeMutation("CREATE TABLE t (id INT)", "mysql")).toBe(true);
expect(sqlLooksLikeMutation("GET k", "redis")).toBe(false);
expect(sqlLooksLikeMutation("SET k v", "redis")).toBe(true);
});
it("keeps the persistent read-only flag on while a window is active", async () => {
const connection = { id: "prod", name: "prod-db", read_only: true, db_type: "mysql" as const };
expect(connectionIsEffectivelyReadOnly(connection)).toBe(true);
const pending = ensureReadOnlyWriteAccess({ connection, sql: "INSERT INTO t VALUES (1)", source: "SQL editor" });
const store = await waitForPending("prod");
expect(unlockConnectionWrites).not.toHaveBeenCalled();
await store.confirm(60);
await expect(pending).resolves.toBe(true);
expect(unlockConnectionWrites).toHaveBeenCalledWith("prod", 60);
expect(connection.read_only).toBe(true);
expect(connectionIsEffectivelyReadOnly(connection)).toBe(false);
expect(store.isUnlocked("prod")).toBe(true);
expect(store.isUnlocked("other")).toBe(false);
});
it("cancels without unlocking and forgets the window when locked or expired", async () => {
const connection = { id: "prod", name: "prod-db", read_only: true, db_type: "mysql" as const };
const cancelled = ensureReadOnlyWriteAccess({ connection, sql: "DELETE FROM t", source: "SQL editor" });
const store = await waitForPending("prod");
store.cancel();
await expect(cancelled).resolves.toBe(false);
expect(unlockConnectionWrites).not.toHaveBeenCalled();
expect(connectionIsEffectivelyReadOnly(connection)).toBe(true);
const unlocked = ensureReadOnlyWriteAccess({ connection, sql: "DELETE FROM t", source: "SQL editor" });
await waitForPending("prod");
await store.confirm(60);
await expect(unlocked).resolves.toBe(true);
expect(await ensureReadOnlyWriteAccess({ connection, sql: "UPDATE t SET a = 1" })).toBe(true);
expect(unlockConnectionWrites).toHaveBeenCalledTimes(1);
await store.lockNow("prod");
expect(lockConnectionWrites).toHaveBeenCalledWith("prod");
expect(store.isUnlocked("prod")).toBe(false);
expect(connectionIsEffectivelyReadOnly(connection)).toBe(true);
});
it("does not prompt for reads or writable connections", async () => {
const store = useReadOnlyUnlockStore();
await expect(ensureReadOnlyWriteAccess({ connection: { id: "w", read_only: false, db_type: "mysql" }, sql: "INSERT INTO t VALUES (1)" })).resolves.toBe(true);
await expect(ensureReadOnlyWriteAccess({ connection: { id: "r", read_only: true, db_type: "mysql" }, sql: "SELECT 1" })).resolves.toBe(true);
expect(store.pending).toBeUndefined();
expect(connectionWriteUnlockState).not.toHaveBeenCalled();
});
it("reuses an existing backend window without prompting again", async () => {
connectionWriteUnlockState.mockResolvedValue(45_000);
const connection = { id: "prod", name: "prod-db", read_only: true, db_type: "mysql" as const };
await expect(ensureReadOnlyWriteAccess({ connection, sql: "INSERT INTO t VALUES (1)" })).resolves.toBe(true);
expect(unlockConnectionWrites).not.toHaveBeenCalled();
expect(useReadOnlyUnlockStore().pending).toBeUndefined();
expect(connectionIsEffectivelyReadOnly(connection)).toBe(false);
});
it("returns to effectively read-only when the local timer expires", async () => {
vi.useFakeTimers();
const store = useReadOnlyUnlockStore();
const connection = { id: "prod", name: "prod-db", read_only: true, db_type: "mysql" as const };
store.rememberWindow("prod", 60_000);
expect(connectionIsEffectivelyReadOnly(connection)).toBe(false);
await vi.advanceTimersByTimeAsync(60_000);
expect(store.isUnlocked("prod")).toBe(false);
expect(connectionIsEffectivelyReadOnly(connection)).toBe(true);
expect(connection.read_only).toBe(true);
});
});
@@ -1,5 +1,6 @@
import type { ConnectionConfig, DatabaseType, TreeNodeType } from "@/types/database"; import type { ConnectionConfig, DatabaseType, TreeNodeType } from "@/types/database";
import { isMongoLegacyDriverProfile } from "@/lib/mongo/mongoCapabilities"; import { isMongoLegacyDriverProfile } from "@/lib/mongo/mongoCapabilities";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
export type DatabaseNamespaceCreationTarget = "database" | "schema" | "attach" | "special"; export type DatabaseNamespaceCreationTarget = "database" | "schema" | "attach" | "special";
@@ -12,7 +13,7 @@ export interface DatabaseNamespaceCreationMatrixEntry {
deferred?: string; deferred?: string;
} }
type CreationConnection = (Pick<ConnectionConfig, "db_type" | "driver_profile" | "read_only"> & Partial<Pick<ConnectionConfig, "host" | "password">>) | undefined; type CreationConnection = (Pick<ConnectionConfig, "db_type" | "driver_profile" | "read_only"> & Partial<Pick<ConnectionConfig, "host" | "password" | "id">>) | undefined;
// Keep creation target-specific: many products expose schemas, files, or provider-managed namespaces instead of a top-level database. // Keep creation target-specific: many products expose schemas, files, or provider-managed namespaces instead of a top-level database.
export const DATABASE_NAMESPACE_CREATION_MATRIX = { export const DATABASE_NAMESPACE_CREATION_MATRIX = {
@@ -97,7 +98,7 @@ export const DATABASE_NAMESPACE_CREATION_MATRIX = {
} satisfies Record<DatabaseType, DatabaseNamespaceCreationMatrixEntry>; } satisfies Record<DatabaseType, DatabaseNamespaceCreationMatrixEntry>;
export function connectionNamespaceCreationTarget(connection: CreationConnection): ConnectionCreationTarget | null { export function connectionNamespaceCreationTarget(connection: CreationConnection): ConnectionCreationTarget | null {
if (!connection || connection.read_only) return null; if (!connection || connectionIsEffectivelyReadOnly(connection)) return null;
if (connection.db_type === "mongodb" && isMongoLegacyDriverProfile(connection.driver_profile)) return null; if (connection.db_type === "mongodb" && isMongoLegacyDriverProfile(connection.driver_profile)) return null;
if (connection.db_type === "sqlite" && (connection.host?.trim().toLowerCase() === ":memory:" || Boolean(connection.password))) { if (connection.db_type === "sqlite" && (connection.host?.trim().toLowerCase() === ":memory:" || Boolean(connection.password))) {
return null; return null;
@@ -107,7 +108,7 @@ export function connectionNamespaceCreationTarget(connection: CreationConnection
} }
export function databaseNodeNamespaceCreationTarget(connection: CreationConnection, node: Pick<{ type: TreeNodeType; database?: string | null }, "type" | "database">): DatabaseNodeCreationTarget | null { export function databaseNodeNamespaceCreationTarget(connection: CreationConnection, node: Pick<{ type: TreeNodeType; database?: string | null }, "type" | "database">): DatabaseNodeCreationTarget | null {
if (!connection || connection.read_only || node.type !== "database" || !node.database) return null; if (!connection || connectionIsEffectivelyReadOnly(connection) || node.type !== "database" || !node.database) return null;
const entry: DatabaseNamespaceCreationMatrixEntry = DATABASE_NAMESPACE_CREATION_MATRIX[connection.db_type]; const entry: DatabaseNamespaceCreationMatrixEntry = DATABASE_NAMESPACE_CREATION_MATRIX[connection.db_type];
return entry.database ?? null; return entry.database ?? null;
} }
@@ -1,5 +1,6 @@
import type { ConnectionConfig, DatabaseType, TreeNodeType } from "@/types/database"; import type { ConnectionConfig, DatabaseType, TreeNodeType } from "@/types/database";
import { supportsCreateDatabaseCharset } from "@/lib/database/createDatabaseSql"; import { supportsCreateDatabaseCharset } from "@/lib/database/createDatabaseSql";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
export type DatabasePropertyEditGroup = "charsetCollation" | "databaseComment" | "schemaComment"; export type DatabasePropertyEditGroup = "charsetCollation" | "databaseComment" | "schemaComment";
@@ -9,7 +10,7 @@ export interface DatabasePropertyEditingEntry {
deferred?: string; deferred?: string;
} }
type PropertyEditConnection = Pick<ConnectionConfig, "db_type" | "driver_profile" | "read_only"> | undefined; type PropertyEditConnection = (Pick<ConnectionConfig, "db_type" | "driver_profile" | "read_only"> & Partial<Pick<ConnectionConfig, "id">>) | undefined;
type DatabaseNode = Pick<{ type: TreeNodeType; database?: string | null }, "type" | "database">; type DatabaseNode = Pick<{ type: TreeNodeType; database?: string | null }, "type" | "database">;
type SchemaNode = Pick<{ type: TreeNodeType; database?: string | null; schema?: string | null }, "type" | "database" | "schema">; type SchemaNode = Pick<{ type: TreeNodeType; database?: string | null; schema?: string | null }, "type" | "database" | "schema">;
@@ -97,7 +98,7 @@ export const DATABASE_PROPERTY_EDITING_MATRIX = {
} satisfies Record<DatabaseType, DatabasePropertyEditingEntry>; } satisfies Record<DatabaseType, DatabasePropertyEditingEntry>;
function entryFor(connection: PropertyEditConnection): DatabasePropertyEditingEntry | null { function entryFor(connection: PropertyEditConnection): DatabasePropertyEditingEntry | null {
if (!connection || connection.read_only) return null; if (!connection || connectionIsEffectivelyReadOnly(connection)) return null;
return DATABASE_PROPERTY_EDITING_MATRIX[connection.db_type] ?? null; return DATABASE_PROPERTY_EDITING_MATRIX[connection.db_type] ?? null;
} }
@@ -1,5 +1,6 @@
import { useProductionSafetyStore } from "@/stores/productionSafetyStore"; import { useProductionSafetyStore } from "@/stores/productionSafetyStore";
import { assessProductionSql, productionContextForDatabase } from "@/lib/database/productionSafety"; import { assessProductionSql, productionContextForDatabase } from "@/lib/database/productionSafety";
import { ensureReadOnlyWriteAccess } from "@/lib/database/readOnlyWriteAccess";
import type { ConnectionConfig } from "@/types/database"; import type { ConnectionConfig } from "@/types/database";
export interface ProductionSqlExecutionGuardOptions<T> { export interface ProductionSqlExecutionGuardOptions<T> {
@@ -11,6 +12,9 @@ export interface ProductionSqlExecutionGuardOptions<T> {
} }
export async function executeWithProductionSqlGuard<T>(options: ProductionSqlExecutionGuardOptions<T>): Promise<T | undefined> { export async function executeWithProductionSqlGuard<T>(options: ProductionSqlExecutionGuardOptions<T>): Promise<T | undefined> {
if (!(await ensureReadOnlyWriteAccess({ connection: options.connection, sql: options.sql, source: options.source }))) {
return undefined;
}
const assessment = assessProductionSql(options.sql, options.connection, options.database); const assessment = assessProductionSql(options.sql, options.connection, options.database);
if (assessment.active && assessment.isMutation) { if (assessment.active && assessment.isMutation) {
// Centralize production write confirmation so secondary tool surfaces cannot // Centralize production write confirmation so secondary tool surfaces cannot
@@ -41,6 +45,9 @@ export interface ProductionContextExecutionGuardOptions<T> {
* connection/database production scope rather than SQL risk classification. * connection/database production scope rather than SQL risk classification.
*/ */
export async function executeWithProductionContextGuard<T>(options: ProductionContextExecutionGuardOptions<T>): Promise<T | undefined> { export async function executeWithProductionContextGuard<T>(options: ProductionContextExecutionGuardOptions<T>): Promise<T | undefined> {
if (!(await ensureReadOnlyWriteAccess({ connection: options.connection, sql: options.reviewText, source: options.source, treatAsMutation: true }))) {
return undefined;
}
const productionContext = productionContextForDatabase(options.connection, options.database); const productionContext = productionContextForDatabase(options.connection, options.database);
if (productionContext.active) { if (productionContext.active) {
const confirmed = await useProductionSafetyStore().requestConfirmation({ const confirmed = await useProductionSafetyStore().requestConfirmation({
@@ -0,0 +1,70 @@
import { getActivePinia } from "pinia";
import { useReadOnlyUnlockStore, type WriteUnlockDurationSecs } from "@/stores/readOnlyUnlockStore";
import { classifyRedisCommandSafety } from "@/lib/redis/redisCommandSafety";
import { classifySqlRisk, isSqlRiskMutation } from "@/lib/sql/sqlRisk";
import type { DatabaseType } from "@/types/database";
export type { WriteUnlockDurationSecs };
export const WRITE_UNLOCK_DURATIONS: WriteUnlockDurationSecs[] = [60, 300];
export function formatWriteUnlockRemaining(ms: number): string {
const totalSeconds = Math.max(0, Math.ceil(ms / 1000));
const minutes = Math.floor(totalSeconds / 60);
const seconds = totalSeconds % 60;
return `${minutes}:${String(seconds).padStart(2, "0")}`;
}
function unlockStoreOrNull() {
try {
if (!getActivePinia()) return null;
return useReadOnlyUnlockStore();
} catch {
return null;
}
}
export function isWriteUnlockActive(connectionId: string | undefined | null): boolean {
if (!connectionId) return false;
return unlockStoreOrNull()?.isUnlocked(connectionId) === true;
}
export function connectionIsEffectivelyReadOnly(connection?: { id?: string; read_only?: boolean } | null): boolean {
if (!connection?.read_only) return false;
return !isWriteUnlockActive(connection.id);
}
export function sqlLooksLikeMutation(sql: string | undefined, databaseType?: DatabaseType): boolean {
if (!sql?.trim()) return true;
if (databaseType === "redis") {
return sql.split("\n").some((line) => {
const command = line.trim();
return command.length > 0 && classifyRedisCommandSafety(command) !== "allowed";
});
}
return isSqlRiskMutation(classifySqlRisk(sql, { dialect: databaseType }).risk);
}
export interface ReadOnlyWriteAccessOptions {
connection?: { id?: string; name?: string; read_only?: boolean; db_type?: DatabaseType } | null;
sql?: string;
source?: string;
treatAsMutation?: boolean;
}
export async function ensureReadOnlyWriteAccess(options: ReadOnlyWriteAccessOptions): Promise<boolean> {
const connection = options.connection;
if (!connection?.read_only) return true;
if (!connection.id) return false;
const store = unlockStoreOrNull();
if (store?.isUnlocked(connection.id)) return true;
const isMutation = options.treatAsMutation === true || sqlLooksLikeMutation(options.sql, connection.db_type);
if (!isMutation) return true;
if (!store) return false;
return store.requestUnlock({
connectionId: connection.id,
connectionName: connection.name,
sql: options.sql,
source: options.source,
});
}
@@ -1,6 +1,7 @@
import type { ConnectionConfig } from "@/types/database"; import type { ConnectionConfig } from "@/types/database";
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
type MongoConnectionProfile = Pick<ConnectionConfig, "db_type" | "driver_profile" | "read_only">; type MongoConnectionProfile = Pick<ConnectionConfig, "db_type" | "driver_profile" | "read_only"> & Partial<Pick<ConnectionConfig, "id">>;
/** Accept historical Legacy profile spellings while persisted configs are normalized. */ /** Accept historical Legacy profile spellings while persisted configs are normalized. */
export function isMongoLegacyDriverProfile(driverProfile?: string): boolean { export function isMongoLegacyDriverProfile(driverProfile?: string): boolean {
@@ -10,7 +11,7 @@ export function isMongoLegacyDriverProfile(driverProfile?: string): boolean {
/** Capabilities implemented by both the native driver and the Legacy Agent. */ /** Capabilities implemented by both the native driver and the Legacy Agent. */
export function supportsMongoAllDriverMutations(connection?: MongoConnectionProfile): boolean { export function supportsMongoAllDriverMutations(connection?: MongoConnectionProfile): boolean {
return connection?.db_type === "mongodb" && !connection.read_only; return connection?.db_type === "mongodb" && !connectionIsEffectivelyReadOnly(connection);
} }
/** MongoDB views do not own indexes; collections and time-series collections do. */ /** MongoDB views do not own indexes; collections and time-series collections do. */
@@ -0,0 +1,178 @@
import { computed, ref } from "vue";
import { defineStore } from "pinia";
import * as api from "@/lib/backend/api";
export const WRITE_UNLOCK_ONE_MINUTE_SECS = 60;
export const WRITE_UNLOCK_FIVE_MINUTES_SECS = 300;
export type WriteUnlockDurationSecs = typeof WRITE_UNLOCK_ONE_MINUTE_SECS | typeof WRITE_UNLOCK_FIVE_MINUTES_SECS;
export interface ReadOnlyUnlockRequest {
connectionId: string;
connectionName?: string;
sql?: string;
source?: string;
}
interface QueuedUnlockRequest {
request: ReadOnlyUnlockRequest;
resolve: (confirmed: boolean) => void;
}
function applyRemaining(windows: Record<string, number>, connectionId: string, remainingMs: number, now = Date.now()): Record<string, number> {
const next = { ...windows };
if (remainingMs > 0) next[connectionId] = now + remainingMs;
else delete next[connectionId];
return next;
}
/**
* Coordinates the read-only write-unlock dialog and per-connection countdown.
* Expiry is compared against wall-clock `Date.now()` so backgrounded tabs still
* expire; the backend Instant gate remains authoritative for actual writes.
*/
export const useReadOnlyUnlockStore = defineStore("readOnlyUnlock", () => {
const pending = ref<ReadOnlyUnlockRequest>();
const windows = ref<Record<string, number>>({});
const nowMs = ref(Date.now());
const queue: QueuedUnlockRequest[] = [];
let resolvePending: ((confirmed: boolean) => void) | undefined;
let ticker: ReturnType<typeof setInterval> | undefined;
let unlockInFlight = false;
function touchNow() {
nowMs.value = Date.now();
}
function pruneExpired(now = Date.now()) {
const next: Record<string, number> = {};
for (const [connectionId, expiresAt] of Object.entries(windows.value)) {
if (expiresAt > now) next[connectionId] = expiresAt;
}
windows.value = next;
if (!Object.keys(next).length) stopTicker();
}
function startTicker() {
if (ticker !== undefined) return;
ticker = setInterval(() => {
touchNow();
pruneExpired();
}, 1000);
}
function stopTicker() {
if (ticker === undefined) return;
clearInterval(ticker);
ticker = undefined;
}
// Always compare against the wall clock at call time: the ticker-fed `nowMs`
// goes stale in throttled background tabs and would keep expired windows live.
function remainingMs(connectionId: string, now = Date.now()): number {
return Math.max(0, (windows.value[connectionId] ?? 0) - now);
}
function isUnlocked(connectionId: string, now = Date.now()): boolean {
return remainingMs(connectionId, now) > 0;
}
function rememberWindow(connectionId: string, remaining: number) {
windows.value = applyRemaining(windows.value, connectionId, remaining);
touchNow();
if (Object.keys(windows.value).length) startTicker();
else stopTicker();
}
async function refreshFromBackend(connectionId: string): Promise<number> {
const remaining = await api.connectionWriteUnlockState(connectionId);
rememberWindow(connectionId, remaining);
return remaining;
}
async function requestUnlock(request: ReadOnlyUnlockRequest): Promise<boolean> {
if (isUnlocked(request.connectionId)) return true;
try {
const remaining = await refreshFromBackend(request.connectionId);
if (remaining > 0) return true;
} catch {
// Backend remains the execution gate; continue to the confirm dialog.
}
return new Promise<boolean>((resolve) => {
if (pending.value) {
queue.push({ request, resolve });
return;
}
beginRequest(request, resolve);
});
}
function beginRequest(request: ReadOnlyUnlockRequest, resolve: (confirmed: boolean) => void) {
pending.value = request;
resolvePending = resolve;
}
function settle(confirmed: boolean) {
const resolve = resolvePending;
resolvePending = undefined;
pending.value = undefined;
resolve?.(confirmed);
const next = queue.shift();
if (next) {
if (confirmed && isUnlocked(next.request.connectionId)) next.resolve(true);
else beginRequest(next.request, next.resolve);
}
}
async function confirm(durationSecs: WriteUnlockDurationSecs) {
const request = pending.value;
if (!request || unlockInFlight) return;
unlockInFlight = true;
try {
const remaining = await api.unlockConnectionWrites(request.connectionId, durationSecs);
rememberWindow(request.connectionId, remaining);
settle(true);
} catch {
// Keep the dialog open so the user can retry or cancel.
} finally {
unlockInFlight = false;
}
}
function cancel() {
settle(false);
}
async function lockNow(connectionId: string) {
await api.lockConnectionWrites(connectionId);
rememberWindow(connectionId, 0);
}
if (typeof document !== "undefined") {
document.addEventListener("visibilitychange", () => {
touchNow();
pruneExpired();
if (document.visibilityState !== "visible") return;
for (const connectionId of Object.keys(windows.value)) {
void refreshFromBackend(connectionId);
}
});
}
const unlockedConnectionIds = computed(() => Object.keys(windows.value).filter((id) => isUnlocked(id)));
return {
pending,
windows,
nowMs,
unlockedConnectionIds,
remainingMs,
isUnlocked,
requestUnlock,
confirm,
cancel,
lockNow,
refreshFromBackend,
rememberWindow,
};
});
+3
View File
@@ -295,6 +295,8 @@ pub struct AppState {
/// Web 端 owner 为已认证会话 token,不同登录会话互不可见。建池/池重建/ /// Web 端 owner 为已认证会话 token,不同登录会话互不可见。建池/池重建/
/// AI/元数据从它读取,前端通过状态接口查询。 /// AI/元数据从它读取,前端通过状态接口查询。
pub session_credentials: SessionCredentialStore, pub session_credentials: SessionCredentialStore,
/// In-memory, never-persisted 1/5 minute write overrides for read-only connections.
pub write_unlock_windows: crate::write_unlock::WriteUnlockWindows,
metadata_gates: Arc<Mutex<HashMap<String, Arc<Semaphore>>>>, metadata_gates: Arc<Mutex<HashMap<String, Arc<Semaphore>>>>,
mongo_oidc_browser_opener: std::sync::RwLock<Option<MongoOidcBrowserOpener>>, mongo_oidc_browser_opener: std::sync::RwLock<Option<MongoOidcBrowserOpener>>,
#[cfg(feature = "mq-admin")] #[cfg(feature = "mq-admin")]
@@ -1237,6 +1239,7 @@ impl AppState {
postgres_cancel_contexts: Arc::new(RwLock::new(HashMap::new())), postgres_cancel_contexts: Arc::new(RwLock::new(HashMap::new())),
transaction_sessions: Arc::new(RwLock::new(HashMap::new())), transaction_sessions: Arc::new(RwLock::new(HashMap::new())),
session_credentials: SessionCredentialStore::new(), session_credentials: SessionCredentialStore::new(),
write_unlock_windows: crate::write_unlock::WriteUnlockWindows::default(),
metadata_gates: Arc::new(Mutex::new(HashMap::new())), metadata_gates: Arc::new(Mutex::new(HashMap::new())),
mongo_oidc_browser_opener: std::sync::RwLock::new(None), mongo_oidc_browser_opener: std::sync::RwLock::new(None),
#[cfg(feature = "mq-admin")] #[cfg(feature = "mq-admin")]
+1
View File
@@ -106,6 +106,7 @@ pub mod transfer;
pub mod two_phase_commit; pub mod two_phase_commit;
pub mod types; pub mod types;
pub mod update; pub mod update;
pub mod write_unlock;
pub mod xlsx_export; pub mod xlsx_export;
pub const R2_CDN_BASE: &str = "https://dl.dbxio.com/"; pub const R2_CDN_BASE: &str = "https://dl.dbxio.com/";
+13 -9
View File
@@ -872,17 +872,21 @@ pub fn resolve_kafka_launch_spec(mqc: &MqAdminConfig, state: &AppState) -> Optio
} }
async fn ensure_connection_writable(state: &AppState, conn_id: &str, operation: &str) -> Result<(), String> { async fn ensure_connection_writable(state: &AppState, conn_id: &str, operation: &str) -> Result<(), String> {
let configs = state.configs.read().await; let (name, read_only) = {
if let Some(config) = configs.get(conn_id) { let configs = state.configs.read().await;
if config.read_only { match configs.get(conn_id) {
return Err(format!( Some(config) => (config.name.clone(), config.read_only),
"Read-only mode: connection '{}' has read-only protection enabled. {} blocked.", None => return Ok(()),
config.name, operation
));
} }
// Production protection for desktop MQ uses UI confirmation; MCP enforces };
// is_production separately. Do not hard-block confirmed desktop writes here. if read_only && !state.write_unlock_windows.is_active(conn_id).await {
return Err(format!(
"Read-only mode: connection '{}' has read-only protection enabled. {} blocked.",
name, operation
));
} }
// Production protection for desktop MQ uses UI confirmation; MCP enforces
// is_production separately. Do not hard-block confirmed desktop writes here.
Ok(()) Ok(())
} }
+1 -1
View File
@@ -554,7 +554,7 @@ async fn get_admin_with_operation_fingerprint(
pub(crate) async fn ensure_connection_writable(state: &AppState, conn_id: &str, action: &str) -> Result<(), String> { pub(crate) async fn ensure_connection_writable(state: &AppState, conn_id: &str, action: &str) -> Result<(), String> {
let cfg = state.configs.read().await.get(conn_id).cloned().ok_or("Connection not found")?; let cfg = state.configs.read().await.get(conn_id).cloned().ok_or("Connection not found")?;
if cfg.read_only { if cfg.read_only && !state.write_unlock_windows.is_active(conn_id).await {
Err(format!("{action} is blocked because this connection is read-only")) Err(format!("{action} is blocked because this connection is read-only"))
} else { } else {
Ok(()) Ok(())
+23 -16
View File
@@ -723,10 +723,12 @@ pub async fn check_read_only_for_connection(state: &AppState, pool_key: &str, sq
let configs = state.configs.read().await; let configs = state.configs.read().await;
crate::connection::config_for_pool_key(pool_key, &configs) crate::connection::config_for_pool_key(pool_key, &configs)
.filter(|config| config.read_only) .filter(|config| config.read_only)
.map(|config| (config.name.clone(), config.db_type)) .map(|config| (config.id.clone(), config.name.clone(), config.db_type))
}; };
if let Some((name, database_type)) = connection { if let Some((connection_id, name, database_type)) = connection {
crate::query_execution_sql::check_read_only(sql, &name, database_type)?; if !state.write_unlock_windows.is_active(&connection_id).await {
crate::query_execution_sql::check_read_only(sql, &name, database_type)?;
}
} }
Ok(()) Ok(())
} }
@@ -741,11 +743,13 @@ pub async fn check_read_only_for_connection_multi(
let configs = state.configs.read().await; let configs = state.configs.read().await;
crate::connection::config_for_pool_key(pool_key, &configs) crate::connection::config_for_pool_key(pool_key, &configs)
.filter(|config| config.read_only) .filter(|config| config.read_only)
.map(|config| (config.name.clone(), config.db_type)) .map(|config| (config.id.clone(), config.name.clone(), config.db_type))
}; };
if let Some((name, database_type)) = connection { if let Some((connection_id, name, database_type)) = connection {
for sql in statements { if !state.write_unlock_windows.is_active(&connection_id).await {
crate::query_execution_sql::check_read_only(sql.as_ref(), &name, database_type)?; for sql in statements {
crate::query_execution_sql::check_read_only(sql.as_ref(), &name, database_type)?;
}
} }
} }
Ok(()) Ok(())
@@ -755,7 +759,14 @@ pub async fn check_read_only_for_connection_multi(
/// This uses connection_id directly (not pool_key), so it is safe to call at command entry points /// This uses connection_id directly (not pool_key), so it is safe to call at command entry points
/// before any pool key is constructed. /// before any pool key is constructed.
pub async fn connection_readonly_name(state: &AppState, connection_id: &str) -> Option<String> { pub async fn connection_readonly_name(state: &AppState, connection_id: &str) -> Option<String> {
state.configs.read().await.get(connection_id).filter(|c| c.read_only).map(|c| c.name.clone()) let name = {
let configs = state.configs.read().await;
configs.get(connection_id).filter(|c| c.read_only).map(|c| c.name.clone())?
};
if state.write_unlock_windows.is_active(connection_id).await {
return None;
}
Some(name)
} }
async fn connection_is_mongodb(state: &AppState, connection_id: &str) -> bool { async fn connection_is_mongodb(state: &AppState, connection_id: &str) -> bool {
@@ -1693,15 +1704,11 @@ async fn do_execute_typed(
let _activity_touch = state.pool_activity_touch(pool_key); let _activity_touch = state.pool_activity_touch(pool_key);
let query_timeout = resolve_query_timeout(options.timeout_secs); let query_timeout = resolve_query_timeout(options.timeout_secs);
let read_only_connection = { // Re-check at statement start so a write that becomes ready after the
let configs = state.configs.read().await; // temporary unlock window expires is still blocked, even if an earlier
let config = crate::connection::config_for_pool_key(pool_key, &configs); // statement in the same batch is still running.
config.filter(|config| config.read_only).map(|config| (config.name.clone(), config.db_type)) check_read_only_for_connection(state, pool_key, sql).await?;
};
let operation_budget = operation_budget_for_pool_key(state, pool_key, query_timeout).await; let operation_budget = operation_budget_for_pool_key(state, pool_key, query_timeout).await;
if let Some((name, database_type)) = read_only_connection {
crate::query_execution_sql::check_read_only(sql, &name, database_type)?;
}
let pool_db_type = connection_database_type_for_pool_key(state, pool_key).await; let pool_db_type = connection_database_type_for_pool_key(state, pool_key).await;
let mysql_catalog_dialect = connection_mysql_catalog_dialect_for_pool_key(state, pool_key).await; let mysql_catalog_dialect = connection_mysql_catalog_dialect_for_pool_key(state, pool_key).await;
let connections = state.connections.read().await; let connections = state.connections.read().await;
+8 -16
View File
@@ -1209,24 +1209,16 @@ async fn try_export_mysql_query_result_stream(
state.touch_pool_activity(&pool_key).await; state.touch_pool_activity(&pool_key).await;
let _activity_touch = state.pool_activity_touch(&pool_key); let _activity_touch = state.pool_activity_touch(&pool_key);
let (mysql_dialect, read_only_connection) = { let mysql_dialect = {
let configs = state.configs.read().await; let configs = state.configs.read().await;
let config = configs.get(&request.connection_id); configs
( .get(&request.connection_id)
config .map(|config| {
.map(|config| { crate::db::mysql::MySqlQueryDialect::for_connection(config.db_type, config.driver_profile.as_deref())
crate::db::mysql::MySqlQueryDialect::for_connection( })
config.db_type, .unwrap_or_default()
config.driver_profile.as_deref(),
)
})
.unwrap_or_default(),
config.filter(|config| config.read_only).map(|config| (config.name.clone(), config.db_type)),
)
}; };
if let Some((name, database_type)) = read_only_connection { crate::query::check_read_only_for_connection(state, &request.connection_id, &request.sql).await?;
crate::query_execution_sql::check_read_only(&request.sql, &name, database_type)?;
}
let row_limit = effective_row_limit(request); let row_limit = effective_row_limit(request);
let stream_row_limit = row_limit; let stream_row_limit = row_limit;
+203
View File
@@ -0,0 +1,203 @@
//! Temporary per-session write-unlock windows for persistently read-only connections.
//!
//! The saved `ConnectionConfig.read_only` flag is never flipped. A confirmed
//! desktop/web session may allow writes for 1 or 5 minutes; MCP and CLI keep
//! reading the persistent flag and cannot use this window.
use std::collections::HashMap;
use std::time::{Duration, Instant};
use tokio::sync::RwLock;
use crate::session_credentials::current_credential_owner;
pub const WRITE_UNLOCK_ONE_MINUTE_SECS: u64 = 60;
pub const WRITE_UNLOCK_FIVE_MINUTES_SECS: u64 = 300;
#[derive(Clone, Eq, Hash, PartialEq)]
struct WriteUnlockKey {
owner_scope: String,
connection_id: String,
}
impl WriteUnlockKey {
fn current(connection_id: &str) -> Self {
Self { owner_scope: current_credential_owner().unwrap_or_default(), connection_id: connection_id.to_string() }
}
}
#[derive(Default)]
pub struct WriteUnlockWindows {
inner: RwLock<HashMap<WriteUnlockKey, Instant>>,
}
impl WriteUnlockWindows {
pub fn parse_duration_secs(secs: u64) -> Result<Duration, String> {
match secs {
WRITE_UNLOCK_ONE_MINUTE_SECS => Ok(Duration::from_secs(WRITE_UNLOCK_ONE_MINUTE_SECS)),
WRITE_UNLOCK_FIVE_MINUTES_SECS => Ok(Duration::from_secs(WRITE_UNLOCK_FIVE_MINUTES_SECS)),
_ => Err("Write unlock duration must be 1 minute or 5 minutes.".to_string()),
}
}
pub async fn unlock(&self, connection_id: &str, duration_secs: u64) -> Result<u64, String> {
if connection_id.trim().is_empty() {
return Err("Connection id is required.".to_string());
}
let duration = Self::parse_duration_secs(duration_secs)?;
let expires_at = Instant::now() + duration;
self.inner.write().await.insert(WriteUnlockKey::current(connection_id), expires_at);
Ok(duration.as_millis() as u64)
}
pub async fn lock(&self, connection_id: &str) {
self.inner.write().await.remove(&WriteUnlockKey::current(connection_id));
}
pub async fn remaining_ms(&self, connection_id: &str) -> u64 {
let key = WriteUnlockKey::current(connection_id);
let expires_at = self.inner.read().await.get(&key).copied();
let Some(expires_at) = expires_at else {
return 0;
};
remaining_ms_from(expires_at, Instant::now(), &self.inner, key).await
}
pub async fn is_active(&self, connection_id: &str) -> bool {
self.remaining_ms(connection_id).await > 0
}
#[cfg(test)]
async fn force_expiry(&self, connection_id: &str) {
let key = WriteUnlockKey::current(connection_id);
self.inner
.write()
.await
.insert(key, Instant::now().checked_sub(Duration::from_secs(1)).unwrap_or_else(Instant::now));
}
}
async fn remaining_ms_from(
expires_at: Instant,
now: Instant,
inner: &RwLock<HashMap<WriteUnlockKey, Instant>>,
key: WriteUnlockKey,
) -> u64 {
if now >= expires_at {
inner.write().await.remove(&key);
return 0;
}
expires_at.duration_since(now).as_millis() as u64
}
#[cfg(test)]
mod tests {
use super::*;
use crate::connection::AppState;
use crate::models::connection::ConnectionConfig;
use crate::query::{check_read_only_for_connection, connection_readonly_name};
use crate::session_credentials::with_credential_owner;
use crate::storage::Storage;
fn mysql_config(id: &str, name: &str, read_only: bool) -> ConnectionConfig {
serde_json::from_value(serde_json::json!({
"id": id,
"name": name,
"db_type": "mysql",
"host": "localhost",
"port": 3306,
"username": "tester",
"password": "",
"database": "test",
"read_only": read_only
}))
.unwrap()
}
async fn test_state(configs: &[ConnectionConfig]) -> (AppState, tempfile::TempDir) {
let dir = tempfile::tempdir().unwrap();
let storage = Storage::open(&dir.path().join("storage.db")).await.expect("open storage");
let state = AppState::new_with_plugin_dir(storage, dir.path().join("plugins"));
{
let mut stored = state.configs.write().await;
for config in configs {
stored.insert(config.id.clone(), config.clone());
}
}
(state, dir)
}
#[test]
fn parse_duration_secs_accepts_one_and_five_minutes_only() {
assert_eq!(WriteUnlockWindows::parse_duration_secs(60).unwrap(), Duration::from_secs(60));
assert_eq!(WriteUnlockWindows::parse_duration_secs(300).unwrap(), Duration::from_secs(300));
assert!(WriteUnlockWindows::parse_duration_secs(0).is_err());
assert!(WriteUnlockWindows::parse_duration_secs(120).is_err());
assert!(WriteUnlockWindows::parse_duration_secs(600).is_err());
}
#[tokio::test]
async fn read_only_gate_blocks_until_unlock_and_after_expiry() {
let readonly = mysql_config("prod", "prod-db", true);
let other = mysql_config("other", "other-db", true);
let (state, _dir) = test_state(&[readonly, other]).await;
assert_eq!(connection_readonly_name(&state, "prod").await.as_deref(), Some("prod-db"));
check_read_only_for_connection(&state, "prod", "INSERT INTO t VALUES (1)")
.await
.expect_err("write blocked before unlock");
check_read_only_for_connection(&state, "prod", "SELECT 1").await.expect("reads still allowed");
let remaining = state.write_unlock_windows.unlock("prod", 60).await.expect("unlock");
assert!(remaining > 0 && remaining <= 60_000, "remaining={remaining}");
assert!(state.write_unlock_windows.is_active("prod").await);
assert!(!state.write_unlock_windows.is_active("other").await);
assert!(state.configs.read().await.get("prod").expect("config").read_only);
assert_eq!(connection_readonly_name(&state, "prod").await, None);
assert_eq!(connection_readonly_name(&state, "other").await.as_deref(), Some("other-db"));
check_read_only_for_connection(&state, "prod", "INSERT INTO t VALUES (1)")
.await
.expect("write allowed during window");
check_read_only_for_connection(&state, "other", "DELETE FROM t").await.expect_err("unlock is per connection");
state.write_unlock_windows.force_expiry("prod").await;
assert!(!state.write_unlock_windows.is_active("prod").await);
assert_eq!(connection_readonly_name(&state, "prod").await.as_deref(), Some("prod-db"));
check_read_only_for_connection(&state, "prod", "UPDATE t SET a = 1")
.await
.expect_err("write blocked after expiry");
assert_eq!(state.write_unlock_windows.remaining_ms("prod").await, 0);
assert!(state.configs.read().await.get("prod").expect("config").read_only);
}
#[tokio::test]
async fn lock_now_ends_the_window_without_clearing_read_only() {
let readonly = mysql_config("prod", "prod-db", true);
let (state, _dir) = test_state(&[readonly]).await;
state.write_unlock_windows.unlock("prod", 300).await.unwrap();
assert_eq!(connection_readonly_name(&state, "prod").await, None);
state.write_unlock_windows.lock("prod").await;
assert_eq!(connection_readonly_name(&state, "prod").await.as_deref(), Some("prod-db"));
assert!(state.configs.read().await.get("prod").expect("config").read_only);
}
#[tokio::test]
async fn web_session_owners_cannot_share_an_unlock_window() {
let readonly = mysql_config("prod", "prod-db", true);
let (state, _dir) = test_state(&[readonly]).await;
with_credential_owner(Some("token-a".to_string()), async {
state.write_unlock_windows.unlock("prod", 60).await.unwrap();
assert!(state.write_unlock_windows.is_active("prod").await);
})
.await;
with_credential_owner(Some("token-b".to_string()), async {
assert!(!state.write_unlock_windows.is_active("prod").await);
assert_eq!(connection_readonly_name(&state, "prod").await.as_deref(), Some("prod-db"));
})
.await;
}
}
+3
View File
@@ -331,6 +331,9 @@ async fn main() {
.route("/connection/connect", post(routes::connection::connect_db)) .route("/connection/connect", post(routes::connection::connect_db))
.route("/connection/database-info", post(routes::connection::connected_database_info)) .route("/connection/database-info", post(routes::connection::connected_database_info))
.route("/connection/database-info/save", post(routes::connection::save_connection_database_info)) .route("/connection/database-info/save", post(routes::connection::save_connection_database_info))
.route("/connection/write-unlock", post(routes::connection::unlock_connection_writes))
.route("/connection/write-unlock/lock", post(routes::connection::lock_connection_writes))
.route("/connection/write-unlock/state", post(routes::connection::connection_write_unlock_state))
.route("/connection/final-proxy-port", post(routes::connection::connection_final_proxy_port)) .route("/connection/final-proxy-port", post(routes::connection::connection_final_proxy_port))
.route("/connection/disconnect", post(routes::connection::disconnect_db)) .route("/connection/disconnect", post(routes::connection::disconnect_db))
.route("/connection/check-health", post(routes::connection::check_connection_health)) .route("/connection/check-health", post(routes::connection::check_connection_health))
+43 -1
View File
@@ -15,7 +15,7 @@ use dbx_core::runtime_config::{
release_runtime_config_on_disconnect, should_retain_runtime_config, TEST_PROBE_ID_PREFIX, release_runtime_config_on_disconnect, should_retain_runtime_config, TEST_PROBE_ID_PREFIX,
}; };
use dbx_core::session_credentials::{PurposeSessionCredentialWriteToken, SessionCredentialWriteToken}; use dbx_core::session_credentials::{PurposeSessionCredentialWriteToken, SessionCredentialWriteToken};
use serde::Deserialize; use serde::{Deserialize, Serialize};
use crate::auth::session_token_from_headers; use crate::auth::session_token_from_headers;
use crate::error::AppError; use crate::error::AppError;
@@ -141,6 +141,19 @@ pub struct SaveConnectionDatabaseInfoRequest {
pub database_info: Option<DatabaseConnectionInfo>, pub database_info: Option<DatabaseConnectionInfo>,
} }
#[derive(Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct UnlockConnectionWritesRequest {
pub connection_id: String,
pub duration_secs: u64,
}
#[derive(Serialize)]
#[serde(rename_all = "camelCase")]
pub struct WriteUnlockStateResponse {
pub remaining_ms: u64,
}
#[derive(Deserialize)] #[derive(Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct SaveConnectionsRequest { pub struct SaveConnectionsRequest {
@@ -441,6 +454,35 @@ pub async fn save_connection_database_info(
.map_err(AppError::from) .map_err(AppError::from)
} }
pub async fn unlock_connection_writes(
State(state): State<Arc<WebState>>,
Json(body): Json<UnlockConnectionWritesRequest>,
) -> Result<Json<WriteUnlockStateResponse>, AppError> {
if !state.app.configs.read().await.contains_key(&body.connection_id) {
return Err(AppError::from("Connection not found".to_string()));
}
let remaining_ms =
state.app.write_unlock_windows.unlock(&body.connection_id, body.duration_secs).await.map_err(AppError::from)?;
Ok(Json(WriteUnlockStateResponse { remaining_ms }))
}
pub async fn lock_connection_writes(
State(state): State<Arc<WebState>>,
Json(body): Json<ConnectionIdentifierQuoteRequest>,
) -> Result<Json<()>, AppError> {
state.app.write_unlock_windows.lock(&body.connection_id).await;
Ok(Json(()))
}
pub async fn connection_write_unlock_state(
State(state): State<Arc<WebState>>,
Json(body): Json<ConnectionIdentifierQuoteRequest>,
) -> Result<Json<WriteUnlockStateResponse>, AppError> {
Ok(Json(WriteUnlockStateResponse {
remaining_ms: state.app.write_unlock_windows.remaining_ms(&body.connection_id).await,
}))
}
pub async fn connection_final_proxy_port( pub async fn connection_final_proxy_port(
State(state): State<Arc<WebState>>, State(state): State<Arc<WebState>>,
headers: HeaderMap, headers: HeaderMap,
+17 -5
View File
@@ -12,7 +12,7 @@ DBX 将写入安全拆成多个相互独立的层级:数据库账号权限、
| 层级 | 作用 | 是否可以被上层工具绕过 | | 层级 | 作用 | 是否可以被上层工具绕过 |
| --- | --- | --- | | --- | --- | --- |
| 数据库账号权限 | 由数据库服务器最终决定允许读取、写入和管理哪些对象 | 不可以 | | 数据库账号权限 | 由数据库服务器最终决定允许读取、写入和管理哪些对象 | 不可以 |
| 连接只读 | 在 DBX 核心查询路径阻止可识别的写入,并禁用多个修改入口 | AI、CLI、MCP 和普通界面都不能放宽 | | 连接只读 | 在 DBX 核心查询路径阻止可识别的写入,并禁用多个修改入口 | AI、CLI 和 MCP 不能放宽。工作台可在明确确认后解锁 1 或 5 分钟;已保存的设置保持开启 |
| 生产环境保护 | 对整个连接或指定数据库启用生产标记,写入时要求每次重新确认 | 普通确认和 Agent 授权不能永久跳过 | | 生产环境保护 | 对整个连接或指定数据库启用生产标记,写入时要求每次重新确认 | 普通确认和 Agent 授权不能永久跳过 |
| 危险 SQL/命令确认 | 对 DDL、无条件修改、Redis 高风险命令等额外提示或阻止 | 取决于对应设置,但不会放宽只读或生产保护 | | 危险 SQL/命令确认 | 对 DDL、无条件修改、Redis 高风险命令等额外提示或阻止 | 取决于对应设置,但不会放宽只读或生产保护 |
| MCP 全局策略 | 用连接 allowlist 和三档执行权限约束所有 MCP 客户端 | 客户端环境变量不能扩大已保存的中央策略 | | MCP 全局策略 | 用连接 allowlist 和三档执行权限约束所有 MCP 客户端 | 客户端环境变量不能扩大已保存的中央策略 |
@@ -29,6 +29,18 @@ DBX 将写入安全拆成多个相互独立的层级:数据库账号权限、
只读保护不只是隐藏按钮。对于可识别的 SQL 写入,DBX 会在核心执行路径拒绝请求;MCP、MongoDB、Redis、消息队列和多个专项工作台也会重新检查连接只读状态。 只读保护不只是隐藏按钮。对于可识别的 SQL 写入,DBX 会在核心执行路径拒绝请求;MCP、MongoDB、Redis、消息队列和多个专项工作台也会重新检查连接只读状态。
### 临时解锁写入
在桌面端和 Web 工作台中,只读连接不会静默丢弃写入。发生修改操作时会弹出确认对话框,可选择 **1 分钟**或 **5 分钟**(默认 1 分钟)。确认后:
- 该连接在倒计时结束前可以继续写入,无需再次确认
- 只读控件会显示剩余时间;**立即重新锁定**可提前结束窗口
- 已保存的**只读连接**设置不会被关闭
- 解锁一个连接不会影响其他连接
- 窗口到期后,下一次写入会再次提示
MCP 和 CLI 没有确认界面,仍只读取已保存的只读标记,因此不能使用该窗口。
<Callout type="info">只读分类需要识别 SQL 或命令语义。最可靠的边界仍然是数据库账号本身没有写权限。</Callout> <Callout type="info">只读分类需要识别 SQL 或命令语义。最可靠的边界仍然是数据库账号本身没有写权限。</Callout>
## 配置生产环境保护 ## 配置生产环境保护
@@ -68,14 +80,14 @@ DBX 将写入安全拆成多个相互独立的层级:数据库账号权限、
| 入口 | 只读连接 | 生产环境保护 | | 入口 | 只读连接 | 生产环境保护 |
| --- | --- | --- | | --- | --- | --- |
| SQL 编辑器 | 核心执行路径拒绝可识别写入 | 写入前显示目标连接、数据库、入口和 SQL,逐次确认 | | SQL 编辑器 | 拒绝可识别写入,除非用户确认 1/5 分钟解锁窗口 | 写入前显示目标连接、数据库、入口和 SQL,逐次确认 |
| 数据表格 | 禁用或拒绝保存、删除等修改 | 保存行、删除行等操作进入统一生产确认 | | 数据表格 | 在确认同一解锁窗口前禁用或拒绝保存、删除等修改 | 保存行、删除行等操作进入统一生产确认 |
| 表结构与对象操作 | 隐藏或禁用可识别的修改入口 | DDL、对象源码保存、数据库管理等进入统一确认 | | 表结构与对象操作 | 在确认解锁窗口前隐藏或禁用可识别的修改入口 | DDL、对象源码保存、数据库管理等进入统一确认 |
| Schema 对比、SQL 文件、数据生成 | 目标只读时不允许写入 | 执行生成 SQL 或脚本前进入统一确认 | | Schema 对比、SQL 文件、数据生成 | 目标只读时不允许写入 | 执行生成 SQL 或脚本前进入统一确认 |
| Redis、MongoDB、etcd、消息队列等 | 按系统命令和操作重新检查只读 | 写入入口继续受生产保护和专项危险操作规则约束 | | Redis、MongoDB、etcd、消息队列等 | 按系统命令和操作重新检查只读 | 写入入口继续受生产保护和专项危险操作规则约束 |
| AI Ask | 不执行 SQL | 不执行 SQL | | AI Ask | 不执行 SQL | 不执行 SQL |
| AI Agent | 不能绕过只读 | 生产 SQL 返回编辑器,由用户检查并手动执行 | | AI Agent | 不能绕过只读 | 生产 SQL 返回编辑器,由用户检查并手动执行 |
| MCP | 连接只读是所有权限模式的上限 | 生产保护始终是 MCP 策略的上限 | | MCP | 连接只读是所有权限模式的上限;工作台解锁窗口不适用于 MCP | 生产保护始终是 MCP 策略的上限 |
## AI 的执行边界 ## AI 的执行边界
+17 -5
View File
@@ -12,7 +12,7 @@ DBX separates write safety into independent layers: database privileges, connect
| Layer | Purpose | Can a higher-level tool bypass it? | | Layer | Purpose | Can a higher-level tool bypass it? |
| --- | --- | --- | | --- | --- | --- |
| Database account privileges | The database server ultimately decides which objects can be read, changed, or administered | No | | Database account privileges | The database server ultimately decides which objects can be read, changed, or administered | No |
| Connection read-only | Blocks recognizable writes in the DBX core query path and disables multiple mutation entry points | AI, CLI, MCP, and the normal UI cannot widen it | | Connection read-only | Blocks recognizable writes in the DBX core query path and disables multiple mutation entry points | AI, CLI, and MCP cannot widen it. The workbench can unlock writes for 1 or 5 minutes after explicit confirmation; the saved setting stays on |
| Production protection | Marks an entire connection or selected databases as production and requires a fresh confirmation for writes | Normal confirmation and Agent authorization cannot permanently skip it | | Production protection | Marks an entire connection or selected databases as production and requires a fresh confirmation for writes | Normal confirmation and Agent authorization cannot permanently skip it |
| Dangerous SQL/command confirmation | Adds prompts or blocks for DDL, unbounded mutations, risky Redis commands, and similar operations | Controlled by its setting, but never widens read-only or production protection | | Dangerous SQL/command confirmation | Adds prompts or blocks for DDL, unbounded mutations, risky Redis commands, and similar operations | Controlled by its setting, but never widens read-only or production protection |
| Global MCP policy | Restricts all MCP clients through a connection allowlist and three execution modes | Client environment variables cannot widen the saved central policy | | Global MCP policy | Restricts all MCP clients through a connection allowlist and three execution modes | Client environment variables cannot widen the saved central policy |
@@ -29,6 +29,18 @@ Read-only connections are useful for:
Read-only protection is not only a hidden button. DBX rejects recognizable SQL writes in the core execution path, while MCP, MongoDB, Redis, message queues, and multiple specialized workspaces recheck the connection state. Read-only protection is not only a hidden button. DBX rejects recognizable SQL writes in the core execution path, while MCP, MongoDB, Redis, message queues, and multiple specialized workspaces recheck the connection state.
### Temporary write unlock
In the desktop and web workbench, a read-only connection does not silently drop writes. A mutating action opens a confirmation dialog. Choose **1 minute** or **5 minutes** (default 1 minute). After confirm:
- Writes on that connection succeed without another prompt until the timer ends
- Remaining time is shown on the read-only control; **Lock writes now** ends the window early
- The saved **Read-only connection** setting stays on
- Unlocking one connection does not unlock others
- When the window expires, the next write prompts again
MCP and CLI have no confirmation UI and keep using the saved read-only flag, so they cannot use this window.
<Callout type="info">Read-only enforcement still depends on classifying SQL or commands. The most reliable boundary is a database account that has no write permission.</Callout> <Callout type="info">Read-only enforcement still depends on classifying SQL or commands. The most reliable boundary is a database account that has no write permission.</Callout>
## Configure Production Protection ## Configure Production Protection
@@ -68,14 +80,14 @@ Every production write requires a new explicit decision. Confirmation is not per
| Entry point | Read-only connection | Production protection | | Entry point | Read-only connection | Production protection |
| --- | --- | --- | | --- | --- | --- |
| SQL editor | The core execution path rejects recognizable writes | Shows the target connection, database, source, and SQL for per-operation confirmation | | SQL editor | Rejects recognizable writes unless the user confirms a 1/5 minute unlock window | Shows the target connection, database, source, and SQL for per-operation confirmation |
| Data grid | Disables or rejects saves, deletes, and other mutations | Row saves and deletes enter the shared production confirmation flow | | Data grid | Disables or rejects saves, deletes, and other mutations until the same unlock window is confirmed | Row saves and deletes enter the shared production confirmation flow |
| Table structure and object actions | Hides or disables recognizable mutation entry points | DDL, source saves, and database administration enter the shared confirmation flow | | Table structure and object actions | Hides or disables recognizable mutation entry points until the unlock window is confirmed | DDL, source saves, and database administration enter the shared confirmation flow |
| Schema diff, SQL files, and data generation | Cannot write to a read-only target | Generated SQL or scripts require production confirmation before execution | | Schema diff, SQL files, and data generation | Cannot write to a read-only target | Generated SQL or scripts require production confirmation before execution |
| Redis, MongoDB, etcd, message queues, and similar systems | Rechecks read-only state for system-specific commands and actions | Mutation entry points remain subject to production and specialized danger rules | | Redis, MongoDB, etcd, message queues, and similar systems | Rechecks read-only state for system-specific commands and actions | Mutation entry points remain subject to production and specialized danger rules |
| AI Ask | Does not execute SQL | Does not execute SQL | | AI Ask | Does not execute SQL | Does not execute SQL |
| AI Agent | Cannot bypass read-only state | Returns production SQL to the editor for human review and manual execution | | AI Agent | Cannot bypass read-only state | Returns production SQL to the editor for human review and manual execution |
| MCP | Connection read-only is an upper bound for every mode | Production protection remains an upper bound for MCP policy | | MCP | Connection read-only is an upper bound for every mode; the workbench unlock window does not apply | Production protection remains an upper bound for MCP policy |
## AI Execution Boundaries ## AI Execution Boundaries
+33
View File
@@ -2108,6 +2108,39 @@ pub async fn save_connection_database_info(
state.save_connection_database_info(&connection_id, database_info).await state.save_connection_database_info(&connection_id, database_info).await
} }
#[derive(serde::Serialize)]
#[serde(rename_all = "camelCase")]
pub struct WriteUnlockState {
pub remaining_ms: u64,
}
#[tauri::command]
pub async fn unlock_connection_writes(
state: State<'_, Arc<AppState>>,
connection_id: String,
duration_secs: u64,
) -> Result<WriteUnlockState, String> {
if !state.configs.read().await.contains_key(&connection_id) {
return Err("Connection not found".to_string());
}
let remaining_ms = state.write_unlock_windows.unlock(&connection_id, duration_secs).await?;
Ok(WriteUnlockState { remaining_ms })
}
#[tauri::command]
pub async fn lock_connection_writes(state: State<'_, Arc<AppState>>, connection_id: String) -> Result<(), String> {
state.write_unlock_windows.lock(&connection_id).await;
Ok(())
}
#[tauri::command]
pub async fn connection_write_unlock_state(
state: State<'_, Arc<AppState>>,
connection_id: String,
) -> Result<WriteUnlockState, String> {
Ok(WriteUnlockState { remaining_ms: state.write_unlock_windows.remaining_ms(&connection_id).await })
}
/// Check whether a connection has read-only protection enabled. /// Check whether a connection has read-only protection enabled.
/// Returns an error if the connection is read-only, preventing write operations. /// Returns an error if the connection is read-only, preventing write operations.
pub async fn ensure_connection_writable( pub async fn ensure_connection_writable(
+3
View File
@@ -1879,6 +1879,9 @@ pub fn run() {
commands::connection::connection_identifier_quote, commands::connection::connection_identifier_quote,
commands::connection::connection_database_info, commands::connection::connection_database_info,
commands::connection::save_connection_database_info, commands::connection::save_connection_database_info,
commands::connection::unlock_connection_writes,
commands::connection::lock_connection_writes,
commands::connection::connection_write_unlock_state,
commands::connection::save_connections, commands::connection::save_connections,
commands::connection::load_connections, commands::connection::load_connections,
commands::connection::save_sidebar_layout, commands::connection::save_sidebar_layout,