fix(tabs): hide database tooltip for unsupported plugin tabs

This commit is contained in:
OOMEcho authored and GitHub committed 2026-09-28 13:12:48 +08:00
1 parent 2012b856f8
commit 9e17d465a0
3 files changed
+37 -2

No files matched your search

@@ -431,6 +431,25 @@ describe("tab group presentation", () => {
}
});
it("shows a database row for plugin tabs only when the tab or connection has a database", () => {
const store = useConnectionStore();
store.sidebarLayout = {
groups: [],
order: [{ type: "connection", id: "conn-1" }],
};
store.connections = [{ id: "conn-1", name: "SSH server", db_type: "plugin" } as ConnectionConfig];
const tab = queryTab({ mode: "plugin-workbench", database: "" });
expect(tabTooltipLines(tab, translate)).toEqual([
{ label: "Connection:", value: "SSH server" },
{ label: "Group:", value: "Ungrouped" },
]);
store.connections = [{ id: "conn-1", name: "Database plugin", db_type: "plugin", database: "analytics" } as ConnectionConfig];
expect(tabTooltipLines(tab, translate)).toContainEqual({ label: "Database:", value: "analytics" });
expect(tabTooltipLines(queryTab({ mode: "plugin-workbench", database: "reporting" }), translate)).toContainEqual({ label: "Database:", value: "reporting" });
});
it("labels a top-level connection as ungrouped", () => {
const store = useConnectionStore();
store.connections = [{ id: "conn-1", name: "PostgreSQL", db_type: "postgres", database: "app" } as ConnectionConfig];
+4 -1
View File
@@ -263,10 +263,13 @@ export function tabTooltipLines(tab: QueryTab, t: Translate): { label: string; v
const connName = connectionDisplayName(tab.connectionId);
const groupName = connectionGroupDisplayName(tab.connectionId, t);
const connection = useConnectionStore().getConfig(tab.connectionId);
const isPluginTab = tab.mode === "plugin-workbench" || tab.mode === "plugin-filesystem";
const database = isPluginTab ? tab.database || connection?.database || "" : tab.database;
const showDatabase = (!connection || supportsConnectionDatabaseInfo(connection.db_type)) && (!isPluginTab || Boolean(database.trim()));
const lines: { label: string; value: string }[] = [
{ label: t("tabs.tooltipConnection"), value: connName },
...(groupName ? [{ label: t("tabs.tooltipGroup"), value: groupName }] : []),
...(!connection || supportsConnectionDatabaseInfo(connection.db_type) ? [{ label: t("tabs.tooltipDatabase"), value: databaseDisplayNameForTab(tab.connectionId, tab.database, t) }] : []),
...(showDatabase ? [{ label: t("tabs.tooltipDatabase"), value: databaseDisplayNameForTab(tab.connectionId, database, t) }] : []),
];
if (tab.mode === "query" && queryTitle(tab)) {
lines.unshift({ label: t("tabs.tooltipTitle"), value: tab.title });