feat(oracle): support adding primary keys to existing tables
Closes #6922
This commit is contained in:
1 parent
946677a579
commit
a1e94d8228
8 files changed
+252
-23
No files matched your search
@@ -93,10 +93,21 @@ describe("tableStructureCapabilities", () => {
|
||||
expect(getTableStructureCapabilities("dameng", "dameng").comment).toBe(true);
|
||||
});
|
||||
|
||||
it("enables alter primary key for Dameng without enabling it for Oracle", () => {
|
||||
expect(getTableStructureCapabilities("dameng", "dameng").alterPrimaryKey).toBe(true);
|
||||
expect(getTableStructureCapabilities("oracle", "oracle").alterPrimaryKey).toBe(false);
|
||||
expect(getTableStructureCapabilities("oceanbase-oracle", "oceanbase-oracle").alterPrimaryKey).toBe(false);
|
||||
it("separates adding a primary key from replacing an existing one", () => {
|
||||
expect(getTableStructureCapabilities("dameng", "dameng")).toMatchObject({
|
||||
addPrimaryKey: true,
|
||||
alterPrimaryKey: true,
|
||||
});
|
||||
expect(getTableStructureCapabilities("oracle", "oracle")).toMatchObject({
|
||||
addPrimaryKey: true,
|
||||
alterPrimaryKey: false,
|
||||
});
|
||||
for (const databaseType of ["oceanbase-oracle", "iris"] as const) {
|
||||
expect(getTableStructureCapabilities(databaseType, databaseType)).toMatchObject({
|
||||
addPrimaryKey: false,
|
||||
alterPrimaryKey: false,
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
it("uses local-only column reordering for editable databases without physical reorder support", () => {
|
||||
|
||||
@@ -15,6 +15,7 @@ export interface TableStructureCapabilities {
|
||||
alterType: boolean;
|
||||
alterNullability: boolean;
|
||||
alterDefault: boolean;
|
||||
addPrimaryKey: boolean;
|
||||
alterPrimaryKey: boolean;
|
||||
reorderColumn: boolean;
|
||||
comment: boolean;
|
||||
@@ -40,6 +41,7 @@ const unsupportedCapabilities: TableStructureCapabilities = {
|
||||
alterType: false,
|
||||
alterNullability: false,
|
||||
alterDefault: false,
|
||||
addPrimaryKey: false,
|
||||
alterPrimaryKey: false,
|
||||
reorderColumn: false,
|
||||
comment: false,
|
||||
@@ -59,6 +61,9 @@ function capabilities(overrides: Partial<TableStructureCapabilities>): TableStru
|
||||
if (overrides.alterStrategy === undefined && resolved.alterExistingColumn) {
|
||||
resolved.alterStrategy = "direct";
|
||||
}
|
||||
if (resolved.alterPrimaryKey) {
|
||||
resolved.addPrimaryKey = true;
|
||||
}
|
||||
return resolved;
|
||||
}
|
||||
|
||||
@@ -129,6 +134,7 @@ const redshiftCapabilities = capabilities({
|
||||
indexInclude: false,
|
||||
indexFilter: false,
|
||||
indexComment: false,
|
||||
addPrimaryKey: false,
|
||||
alterPrimaryKey: false,
|
||||
});
|
||||
|
||||
@@ -182,7 +188,7 @@ const sqlserverCapabilities = capabilities({
|
||||
indexComment: true,
|
||||
});
|
||||
|
||||
const oracleCapabilities = capabilities({
|
||||
const oracleCompatibleCapabilities = capabilities({
|
||||
dialect: "oracle",
|
||||
createTable: true,
|
||||
addColumn: true,
|
||||
@@ -199,15 +205,20 @@ const oracleCapabilities = capabilities({
|
||||
indexType: true,
|
||||
});
|
||||
|
||||
const oracleCapabilities = capabilities({
|
||||
...oracleCompatibleCapabilities,
|
||||
addPrimaryKey: true,
|
||||
});
|
||||
|
||||
// Dameng (DM8): ALTER TABLE ... DROP PRIMARY KEY / ADD PRIMARY KEY is official DDL.
|
||||
// Keep separate from oracleCapabilities so UI cannot enable PK edit without BE drop SQL.
|
||||
// Keep separate from Oracle-compatible engines so UI cannot enable PK edits without verified DDL.
|
||||
const damengCapabilities = capabilities({
|
||||
...oracleCapabilities,
|
||||
...oracleCompatibleCapabilities,
|
||||
alterPrimaryKey: true,
|
||||
});
|
||||
|
||||
const irisCapabilities = capabilities({
|
||||
...oracleCapabilities,
|
||||
...oracleCompatibleCapabilities,
|
||||
// IRIS exposes %DESCRIPTION at definition time but cannot alter persisted descriptions.
|
||||
comment: false,
|
||||
});
|
||||
@@ -340,10 +351,10 @@ const capabilityByType: Partial<Record<DatabaseType, TableStructureCapabilities>
|
||||
sqlserver: sqlserverCapabilities,
|
||||
oracle: oracleCapabilities,
|
||||
dameng: damengCapabilities,
|
||||
"oceanbase-oracle": oracleCapabilities,
|
||||
"oceanbase-oracle": oracleCompatibleCapabilities,
|
||||
iris: irisCapabilities,
|
||||
yashandb: oracleCapabilities,
|
||||
xugu: oracleCapabilities,
|
||||
yashandb: oracleCompatibleCapabilities,
|
||||
xugu: oracleCompatibleCapabilities,
|
||||
h2: h2Capabilities,
|
||||
access: accessCapabilities,
|
||||
clickhouse: clickhouseCapabilities,
|
||||
|
||||
Reference in new issue
Block a user