github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 06:51:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(grid): restore long cell values in the detail editor

Browse Source
This commit is contained in:
jearhe authored and GitHub committed 2026-09-11 10:52:19 +08:00
1 parent 15d451d43a
commit a216e0938e
6 files changed
+177 -7
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/components/grid/DataGrid.vue
+11 -2
View File
@@ -5786,7 +5786,16 @@ watch(valueEditorContainer, async (el) => {
fontSize: editorFontSize,
fontFamily: detailEditorFontFamily,
});
await valueDetailEditor.create(el, detailEditValue.value, activeCellDetail.value?.type);
const editor = valueDetailEditor;
await editor.create(el, detailEditValue.value, activeCellDetail.value?.type);
// The editor initializes asynchronously (theme loading can yield here), so
// detailEditValue may have changed before CodeMirror owns the document.
// Reconcile the latest value after create and ignore an editor replaced by
// a fast tab unmount/remount.
if (valueDetailEditor !== editor) return;
if (editor.getValue() !== detailEditValue.value) {
editor.setValue(detailEditValue.value, activeCellDetail.value?.type);
}
} else if (!el && valueDetailEditor) {
valueDetailEditor.destroy();
valueDetailEditor = null;
@@ -5809,7 +5818,7 @@ const detailEdit = useDataGridCellDetailEdit({
restoreCellValue,
syncEditor: (value, columnType) => {
const editor = getDetailEditor();
if (editor) editor.setValue(value, columnType);
if (editor && editor.getValue() !== value) editor.setValue(value, columnType);
},
refreshDetail: () => {
detailCell.value = detailCell.value ? { ...detailCell.value } : null;
apps/desktop/src/components/grid/__tests__/DataGridSurfaces.spec.ts
Vendored
+8
View File
@@ -1392,6 +1392,14 @@ describe("cell detail surfaces", () => {
}
expect(dataGridSource).not.toContain("activeCellDetailTabsGridClass");
const valueEditorLifecycleStart = dataGridSource.indexOf("watch(valueEditorContainer");
const valueEditorLifecycleEnd = dataGridSource.indexOf("const detailEdit = useDataGridCellDetailEdit", valueEditorLifecycleStart);
const valueEditorLifecycle = dataGridSource.slice(valueEditorLifecycleStart, valueEditorLifecycleEnd);
expect(valueEditorLifecycle).toContain("const editor = valueDetailEditor;");
expect(valueEditorLifecycle).toContain("if (valueDetailEditor !== editor) return;");
expect(valueEditorLifecycle).toContain("if (editor.getValue() !== detailEditValue.value)");
expect(valueEditorLifecycle).toContain("editor.setValue(detailEditValue.value, activeCellDetail.value?.type);");
const valueEditorStart = dataGridSource.indexOf("<TabsContent v-if=\"activeCellDetailTabs.includes('valueEditor')\"");
const valueEditorEnd = dataGridSource.indexOf("</TabsContent>", valueEditorStart);
const valueEditor = dataGridSource.slice(valueEditorStart, valueEditorEnd);