github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 14:52:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(grid): dim null cells consistently without type colors

Browse Source
This commit is contained in:
zipg authored and GitHub committed 2026-09-13 19:46:12 +08:00
1 parent 45ed1047a8
commit a33768ef6e
2 files changed
+15 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/lib/__tests__/dataGrid/dataGridCellTypeVisual.spec.ts
Vendored
+9 -4
View File
@@ -98,15 +98,20 @@ describe("data grid cell text visual priority", () => {
expect(resolveDataGridCellTextRole({ ...ordinaryInteger, ...override })).toBe("muted");
});
it("keeps NULL muted when type colors are disabled", () => {
expect(resolveDataGridCellTextRole({ ...ordinaryInteger, colorizeTypes: false, isNull: true })).toBe("muted");
});
it("uses a neutral foreground on editable DOM hover surfaces", () => {
expect(dataGridSource).toContain("'hover:bg-gray-200 hover:text-foreground dark:hover:bg-gray-800':");
expect(dataGridSource).toContain("'cursor-text hover:bg-gray-200 hover:text-foreground dark:hover:bg-gray-800':");
});
it("keeps Mongo BSON null muted when type colors are disabled", () => {
const mongoNullPriority = 'const isMongoDocumentNull = props.mongoCollectionGrid === true && value === MONGO_DOCUMENT_GRID_NULL;\n if (isMongoDocumentNull) return "text-muted-foreground italic";\n if (!colorizeDataGridCellTypes.value) return "text-foreground";';
expect(dataGridSource.split(mongoNullPriority)).toHaveLength(3);
it("checks NULL before applying the optional type-color setting", () => {
expect(dataGridSource).toContain("function gridCellTextColorClass(item: RowItem, actualColIdx: number, visibleColIdx: number): string {\n const value = item.data[actualColIdx];");
expect(dataGridSource).toContain("function transposeCellTextColorClass(recordIndex: number, actualColIdx: number): string {\n const item = displayItems.value[recordIndex];");
expect(dataGridSource).not.toContain('function gridCellTextColorClass(item: RowItem, actualColIdx: number, visibleColIdx: number): string {\n if (!colorizeDataGridCellTypes.value) return "text-foreground";');
expect(dataGridSource).not.toContain('function transposeCellTextColorClass(recordIndex: number, actualColIdx: number): string {\n if (!colorizeDataGridCellTypes.value) return "text-foreground";');
});
it("places data-grid type selectors in the components layer", () => {