fix(sqlserver): generate procedure output parameters
This commit is contained in:
3 files changed
+209
-13
No files matched your search
@@ -0,0 +1,91 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { buildProcedureExecutionSqlFromValues } from "@/lib/table/routineExecutionSql";
|
||||
import { routineParametersFromResult, routineParametersQuery } from "@/lib/table/routineParameters";
|
||||
import type { QueryResult } from "@/types/database";
|
||||
|
||||
function queryResult(columns: string[], rows: unknown[][]): QueryResult {
|
||||
return { columns, rows, affected_rows: 0, execution_time_ms: 0 };
|
||||
}
|
||||
|
||||
describe("SQL Server routine execution SQL", () => {
|
||||
it("declares and selects OUT parameters", () => {
|
||||
const sql = buildProcedureExecutionSqlFromValues({
|
||||
databaseType: "sqlserver",
|
||||
schema: "dbo",
|
||||
routineName: "Sys_CreatePrimaryKeyValue",
|
||||
parameters: [
|
||||
{ name: "@tableName", dataType: "varchar(64)", mode: "IN", ordinal: 1, value: "users" },
|
||||
{ name: "@returnValue", dataType: "varchar(128)", mode: "OUT", ordinal: 2, value: "" },
|
||||
],
|
||||
});
|
||||
|
||||
expect(sql).toBe(["DECLARE @dbx_output_2 varchar(128);", "EXEC [dbo].[Sys_CreatePrimaryKeyValue] @tableName = 'users', @returnValue = @dbx_output_2 OUTPUT;", "SELECT @dbx_output_2 AS [returnValue];"].join("\n"));
|
||||
});
|
||||
|
||||
it("initializes INOUT parameters and keeps numeric values unquoted", () => {
|
||||
const sql = buildProcedureExecutionSqlFromValues({
|
||||
databaseType: "sqlserver",
|
||||
schema: "dbo",
|
||||
routineName: "adjust_amount",
|
||||
parameters: [{ name: "@amount", dataType: "decimal(18,4)", mode: "INOUT", ordinal: 1, value: "12.5000" }],
|
||||
});
|
||||
|
||||
expect(sql).toBe(["DECLARE @dbx_output_1 decimal(18,4) = 12.5000;", "EXEC [dbo].[adjust_amount] @amount = @dbx_output_1 OUTPUT;", "SELECT @dbx_output_1 AS [amount];"].join("\n"));
|
||||
});
|
||||
|
||||
it("preserves IN parameters and omission of requested defaults", () => {
|
||||
const sql = buildProcedureExecutionSqlFromValues({
|
||||
databaseType: "sqlserver",
|
||||
schema: "dbo",
|
||||
routineName: "refresh_cache",
|
||||
parameters: [
|
||||
{ name: "@scope", dataType: "varchar(32)", mode: "IN", ordinal: 1, value: "all" },
|
||||
{ name: "@timeout", dataType: "int", mode: "IN", ordinal: 2, value: "30", hasDefault: true, useDefault: true },
|
||||
],
|
||||
});
|
||||
|
||||
expect(sql).toBe("EXEC [dbo].[refresh_cache] @scope = 'all';");
|
||||
});
|
||||
|
||||
it("keeps no-parameter procedures valid and ignores RETURN metadata", () => {
|
||||
expect(buildProcedureExecutionSqlFromValues({ databaseType: "sqlserver", schema: "dbo", routineName: "ping", parameters: [] })).toBe("EXEC [dbo].[ping];");
|
||||
expect(
|
||||
buildProcedureExecutionSqlFromValues({
|
||||
databaseType: "sqlserver",
|
||||
schema: "dbo",
|
||||
routineName: "ping",
|
||||
parameters: [{ name: "return_status", dataType: "int", mode: "RETURN", ordinal: 0, value: "" }],
|
||||
}),
|
||||
).toBe("EXEC [dbo].[ping];");
|
||||
});
|
||||
|
||||
it("preserves SQL Server declaration lengths, MAX, and decimal precision", () => {
|
||||
const parameters = routineParametersFromResult(
|
||||
queryResult(
|
||||
["name", "data_type", "mode", "ordinal", "has_default", "max_length", "precision", "scale", "type_schema", "is_user_defined"],
|
||||
[
|
||||
["@short", "varchar", "OUT", 1, false, 64, 0, 0, "sys", false],
|
||||
["@long", "varchar", "OUT", 2, false, -1, 0, 0, "sys", false],
|
||||
["@amount", "decimal", "OUT", 3, false, 17, 18, 4, "sys", false],
|
||||
],
|
||||
),
|
||||
"sqlserver",
|
||||
);
|
||||
|
||||
expect(parameters.map((parameter) => parameter.dataType)).toEqual(["varchar(64)", "varchar(max)", "decimal(18,4)"]);
|
||||
expect(
|
||||
buildProcedureExecutionSqlFromValues({
|
||||
databaseType: "sqlserver",
|
||||
schema: "dbo",
|
||||
routineName: "collect_outputs",
|
||||
parameters: parameters.map((parameter) => ({ ...parameter, value: "" })),
|
||||
}),
|
||||
).toContain(["DECLARE @dbx_output_1 varchar(64);", "DECLARE @dbx_output_2 varchar(max);", "DECLARE @dbx_output_3 decimal(18,4);"].join("\n"));
|
||||
|
||||
const metadataSql = routineParametersQuery({ database: "app", databaseType: "sqlserver", schema: "dbo", routineName: "save" });
|
||||
expect(metadataSql).toContain("JOIN sys.types t ON t.user_type_id = p.user_type_id");
|
||||
expect(metadataSql).toContain("p.max_length AS max_length");
|
||||
expect(metadataSql).toContain("p.precision AS precision");
|
||||
expect(metadataSql).toContain("p.scale AS scale");
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user