feat(impala): add full database support

apps/desktop/src/components/connection/ConnectionDialog.vue

@@ -1133,6 +1133,7 @@ const driverProfiles: Record<
   trino: { type: "trino", port: 8080, user: "", label: "Trino", icon: "trino" },
   prestosql: { type: "prestosql", port: 8080, user: "", label: "PrestoSQL", icon: "presto" },
   hive: { type: "hive", port: 10000, user: "", label: "Apache Hive", icon: "hive" },
+  impala: { type: "impala", port: 21050, user: "", label: "Apache Impala", icon: "impala", urlParams: "auth=noSasl" },
   spark: { type: "spark", port: 10015, user: "", label: "Apache Spark", icon: "spark" },
   db2: { type: "db2", port: 50000, user: "db2inst1", label: "IBM DB2", icon: "db2" },
   informix: { type: "informix", port: 9088, user: "informix", label: "Informix", icon: "informix" },
@@ -2386,7 +2387,7 @@ function applyProfile(val: string, preserveConnectionFields = false) {
       form.value.connection_string = undefined;
       form.value.url_params = "";
     }
-    resetHiveKerberosFields(profile.type === "hive" ? form.value : undefined);
+    resetHiveKerberosFields(profile.type === "hive" || profile.type === "impala" ? form.value : undefined);
   }
 }
 
@@ -2512,7 +2513,7 @@ watch(
         resetVictoriaMetricsFields();
       }
       resetElasticsearchProxyFields(config.db_type === "elasticsearch" ? config.external_config : undefined);
-      resetHiveKerberosFields(config.db_type === "hive" ? config : undefined);
+      resetHiveKerberosFields(config.db_type === "hive" || config.db_type === "impala" ? config : undefined);
       resetDamengJvmOptions(config.db_type === "dameng" ? config : undefined);
       h2ConnectionMode.value = h2ConnectionModeForConfig(config);
       customColorInput.value = config.color || "";
@@ -2766,6 +2767,7 @@ const iconTypeMap: Record<string, string> = {
   trino: "trino",
   prestosql: "prestosql",
   hive: "hive",
+  impala: "impala",
   spark: "spark",
   db2: "db2",
   informix: "informix",
@@ -2846,6 +2848,7 @@ const dbOptions: DbOption[] = [
   { value: "trino", label: "Trino" },
   { value: "prestosql", label: "PrestoSQL" },
   { value: "hive", label: "Hive" },
+  { value: "impala", label: "Apache Impala" },
   { value: "spark", label: "Apache Spark" },
   { value: "db2", label: "DB2" },
   { value: "informix", label: "Informix" },
@@ -2891,7 +2894,7 @@ const dbCategoryDefinitions: Array<{
   {
     key: "analytics",
     titleKey: "connection.databaseCategoryAnalytics",
-    optionValues: ["cloudberry", "clickhouse", "doris", "starrocks", "databend", "selectdb", "databricks", "saphana", "teradata", "vertica", "exasol", "redshift", "snowflake", "trino", "prestosql", "hive", "spark", "bigquery", "kylin", "dremio"],
+    optionValues: ["cloudberry", "clickhouse", "doris", "starrocks", "databend", "selectdb", "databricks", "saphana", "teradata", "vertica", "exasol", "redshift", "snowflake", "trino", "prestosql", "hive", "impala", "spark", "bigquery", "kylin", "dremio"],
   },
   {
     key: "domestic",
@@ -3728,7 +3731,7 @@ function connectionConfigForSubmit(id: string, generatedName = ""): ConnectionCo
     config.ssl = !!config.ssl || damengSsl.enabled;
     config.url_params = applyDamengSslUrlParams(config.url_params, config.ssl, damengSsl.sslFilesPath, damengSsl.sslKeystorePassword, damengSsl.sslProtocol);
   }
-  if (config.db_type === "hive") {
+  if (config.db_type === "hive" || config.db_type === "impala") {
     if (hiveAuthMode.value === "kerberos" && !hivePrincipal.value.trim()) {
       throw new Error(t("connection.hiveKerberosPrincipalRequired"));
     }
@@ -6998,7 +7001,7 @@ function openExternalUrl(url: string) {
                     <p class="col-span-3 text-xs text-muted-foreground">{{ t("connection.oracleTnsPathHint") }}</p>
                   </div>
 
-                  <template v-if="form.db_type === 'hive'">
+                  <template v-if="form.db_type === 'hive' || form.db_type === 'impala'">
                     <div class="grid grid-cols-4 items-center gap-4">
                       <Label :class="connectionLabelClass">{{ t("connection.hiveAuthMode") }}</Label>
                       <div class="col-span-3 grid h-8 grid-cols-2 overflow-hidden rounded-md border border-input bg-muted/30 p-0.5">
@@ -7020,7 +7023,7 @@ function openExternalUrl(url: string) {
                     <template v-if="hiveAuthMode === 'kerberos'">
                       <div class="grid grid-cols-4 items-center gap-4">
                         <Label :class="connectionLabelSmallClass">{{ t("connection.hivePrincipal") }}</Label>
-                        <Input v-model="hivePrincipal" class="col-span-3" placeholder="hive/_HOST@EXAMPLE.COM" />
+                        <Input v-model="hivePrincipal" class="col-span-3" :placeholder="form.db_type === 'impala' ? 'impala/_HOST@EXAMPLE.COM' : 'hive/_HOST@EXAMPLE.COM'" />
                       </div>
                       <div class="grid grid-cols-4 items-center gap-4">
                         <Label :class="connectionLabelSmallClass">krb5.conf</Label>

apps/desktop/src/components/connection/ConnectionPasswordPromptDialog.vue

@@ -31,7 +31,7 @@ watch(
 );
 
 function submit() {
-  if (resolving.value || !password.value) return;
+  if (resolving.value) return;
   resolving.value = true;
   promptStore.submit(password.value, rememberPassword.value);
 }
@@ -67,7 +67,7 @@ function cancel() {
         <Button variant="outline" :disabled="resolving" @click="cancel">
           {{ t("connection.promptPasswordCancel") }}
         </Button>
-        <Button :disabled="resolving || !password" @click="submit">
+        <Button :disabled="resolving" @click="submit">
           {{ t("connection.promptPasswordSubmit") }}
         </Button>
       </DialogFooter>

apps/desktop/src/components/icons/DatabaseIcon.spec.ts

@@ -31,6 +31,19 @@ describe("DatabaseIcon", () => {
     app.unmount();
   });
 
+  it("uses the Apache Impala asset instead of the Hive asset", async () => {
+    const container = document.createElement("div");
+    document.body.appendChild(container);
+    const app = createApp(DatabaseIcon, { dbType: "impala" });
+    app.mount(container);
+    await nextTick();
+
+    const icon = container.querySelector("img");
+    expect(icon?.getAttribute("src")).toBe("/icons/database/impala.svg");
+    expect(icon?.classList.contains("database-logo-impala")).toBe(true);
+    app.unmount();
+  });
+
   it("uses the Meilisearch asset", async () => {
     const container = document.createElement("div");
     document.body.appendChild(container);

apps/desktop/src/components/icons/DatabaseIcon.vue

@@ -55,6 +55,7 @@ const assetIcons: Record<string, string> = {
   presto: "presto",
   prestosql: "presto",
   hive: "hive",
+  impala: "impala",
   hbase: "hbase",
   phoenix: "phoenix",
   spark: "spark-logo.png",
@@ -122,7 +123,7 @@ const assetSrc = computed(() => {
 </script>
 
 <template>
-  <img v-if="assetName" :src="assetSrc" alt="" class="database-logo object-contain" :class="{ 'database-logo-light': useLightIconInDarkMode }" aria-hidden="true" />
+  <img v-if="assetName" :src="assetSrc" alt="" class="database-logo object-contain" :class="{ 'database-logo-light': useLightIconInDarkMode, 'database-logo-impala': normalizedType === 'impala' }" aria-hidden="true" />
   <Database v-else class="text-blue-400" />
 </template>
 
@@ -135,4 +136,8 @@ const assetSrc = computed(() => {
 .database-logo-light {
   filter: brightness(0) invert(82%);
 }
+
+.database-logo-impala {
+  transform: scale(1.55);
+}
 </style>