fix(dameng): use valid LIKE escape for metadata search

This commit is contained in:
zipg authored and GitHub committed 2026-07-27 22:46:17 +08:00
1 parent a96cf11942
commit a77e089848
4 files changed
+42 -6

No files matched your search

@@ -408,8 +408,8 @@ public final class DamengAgent extends BaseDatabaseAgent {
if (!constraints.hasFilter()) {
return;
}
sql.append(" AND UPPER(").append(column).append(") LIKE ? ESCAPE '\\\\'");
args.add(constraints.fuzzyLikePattern().toUpperCase(Locale.ROOT));
sql.append(" AND UPPER(").append(column).append(") LIKE ? ESCAPE '~'");
args.add(constraints.fuzzyLikePattern('~').toUpperCase(Locale.ROOT));
}
private static void appendLimitOffset(StringBuilder sql, List<Object> args, MetadataListConstraints constraints) {
@@ -140,7 +140,7 @@ class DamengAgentTest extends JdbcFakeExecutionBehaviorTest {
assertTrue(query.sql().contains("o.OBJECT_TYPE = 'MATERIALIZED VIEW'"));
assertTrue(query.sql().contains("mv.MVIEW_NAME IS NOT NULL"));
assertTrue(query.sql().contains("IN (?, ?)"));
assertTrue(query.sql().contains("UPPER(o.OBJECT_NAME) LIKE ? ESCAPE '\\\\'"));
assertTrue(query.sql().contains("UPPER(o.OBJECT_NAME) LIKE ? ESCAPE '~'"));
assertTrue(query.sql().endsWith("LIMIT ? OFFSET ?"));
assertEquals(List.of("APP", "TABLE", "VIEW", "%O%R%D%", 50, 100), query.args());
}
@@ -186,7 +186,7 @@ class DamengAgentTest extends JdbcFakeExecutionBehaviorTest {
assertFalse(query.sql().contains("USER_MVIEWS"));
assertFalse(query.sql().contains("DBMS_METADATA.GET_DDL"));
assertTrue(query.sql().contains("mv.MVIEW_NAME IS NOT NULL"));
assertTrue(query.sql().contains("UPPER(o.OBJECT_NAME) LIKE ? ESCAPE '\\\\'"));
assertTrue(query.sql().contains("UPPER(o.OBJECT_NAME) LIKE ? ESCAPE '~'"));
assertTrue(query.sql().endsWith("LIMIT ? OFFSET ?"));
assertEquals(List.of("REPORTING", "VIEW", "MATERIALIZED_VIEW", "%S%A%L%E%S%", 20, 40), query.args());
}
@@ -220,6 +220,17 @@ class DamengAgentTest extends JdbcFakeExecutionBehaviorTest {
assertEquals(List.of("APP", "PROCEDURE", "FUNCTION", "%S%Y%N%C%", 20), query.args());
}
@Test
void constrainedTableQueryEscapesDamengLikeWildcardsWithSingleCharacter() {
DamengAgent.MetadataQuery query = DamengAgent.buildConstrainedTablesQuery(
"APP",
new MetadataListConstraints("a_%~\\", 20, null, List.of("TABLE"))
);
assertTrue(query.sql().contains("UPPER(o.OBJECT_NAME) LIKE ? ESCAPE '~'"));
assertEquals(List.of("APP", "TABLE", "%A%~_%~%%~~%\\%", 20), query.args());
}
@Test
void accessibleObjectQueryBulkClassifiesViewsAndPreservesPaging() {
DamengAgent.MetadataQuery query = DamengAgent.buildAccessibleConstrainedObjectsQuery(