fix(mongodb): classify shell reads as read-only

This commit is contained in:
t8y2 authored and GitHub committed 2026-09-02 18:17:26 +08:00
1 parent fdea607efd
commit ac22ada8d0
3 files changed
+92

No files matched your search

@@ -0,0 +1,37 @@
import { describe, expect, it } from "vitest";
import { classifySqlRisk } from "@/lib/sql/sqlRisk";
describe("MongoDB shell statement risk", () => {
it("treats supported read commands as reads", () => {
for (const sql of [
'db.getCollection("demo").find({}).skip(0).limit(100)',
'db.getCollection("demo").findOne({"active": true})',
'db.getCollection("demo").countDocuments({})',
'db.getCollection("demo").aggregate([{$match: {"active": true}}])',
'db.getCollection("demo").distinct("status")',
'db.getCollection("demo").getIndexes()',
'db.getCollection("demo").stats()',
"db.version()",
"show databases",
]) {
expect(classifySqlRisk(sql, { dialect: "mongodb" }).risk, sql).toBe("read");
}
});
it("keeps MongoDB writes and aggregate output stages unsafe", () => {
for (const sql of ['db.getCollection("demo").insertOne({"active": true})', 'db.getCollection("demo").updateOne({"_id": 1}, {$set: {"active": true}})', 'db.getCollection("demo").deleteOne({"_id": 1})', 'db.getCollection("demo").aggregate([{$merge: {into: "archive"}}])']) {
expect(classifySqlRisk(sql, { dialect: "mongodb" }).risk, sql).not.toBe("read");
}
});
it("retains per-command assessments for shell batches", () => {
const assessment = classifySqlRisk('db.getCollection("demo").find({}); db.getCollection("demo").insertOne({"active": true})', { dialect: "mongodb" });
expect(assessment.risk).toBe("write");
expect(assessment.statements.map((statement) => statement.risk)).toEqual(["read", "write"]);
});
it("keeps unsupported Mongo shell commands conservative", () => {
expect(classifySqlRisk("db.runCommand({ping: 1})", { dialect: "mongodb" }).risk).toBe("unknown");
expect(classifySqlRisk("db.customReadHelper()", { dialect: "mongodb" }).risk).toBe("unknown");
});
});