fix(sqlite): run remote batch saves in a worker transaction

This commit is contained in:
64673a authored and GitHub committed 2026-09-24 16:27:03 +08:00
1 parent 4b5d4e6aa7
commit ad18b8b4ea
3 files changed
+176 -24

No files matched your search

+18 -3
View File
@@ -28,6 +28,11 @@ pub struct WorkerResponse {
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
#[serde(untagged)]
pub enum WorkerBody {
// Untagged variants are tried in order. `Ok` accepts any object because all of
// its fields are optional, so `Err` must come first or error payloads decode as success.
Err {
error: String,
},
Ok {
#[serde(default, skip_serializing_if = "Option::is_none")]
columns: Option<Vec<String>>,
@@ -42,9 +47,6 @@ pub enum WorkerBody {
#[serde(default, skip_serializing_if = "Option::is_none")]
pong: Option<bool>,
},
Err {
error: String,
},
}
impl WorkerBody {
@@ -97,4 +99,17 @@ mod tests {
let decoded: WorkerRequest = serde_json::from_str(&encoded).unwrap();
assert_eq!(decoded, request);
}
#[test]
fn response_roundtrip_keeps_errors_distinct_from_success() {
for body in [
WorkerBody::err("no such table: t"),
WorkerBody::ok(),
WorkerBody::query(vec!["id".into()], Vec::new(), vec![vec![serde_json::json!(1)]], 0, false),
] {
let encoded = serde_json::to_string(&WorkerResponse { id: 7, body: body.clone() }).unwrap();
let decoded: WorkerResponse = serde_json::from_str(&encoded).unwrap();
assert_eq!(decoded.body, body, "{encoded}");
}
}
}