From b0856e51bc7c393e742d0d672d640c5e31a0533b Mon Sep 17 00:00:00 2001 From: t8y2 <1156263951@qq.com> Date: Tue, 2 Jun 2026 23:41:11 +0800 Subject: [PATCH] perf(app): pause cached tab background work --- apps/desktop/src/App.vue | 2 +- .../src/components/editor/QueryEditor.vue | 43 ++++++++++-- apps/desktop/src/components/grid/DataGrid.vue | 70 +++++++++++++++---- .../src/components/redis/RedisKeyBrowser.vue | 46 +++++++++--- 4 files changed, 132 insertions(+), 29 deletions(-) diff --git a/apps/desktop/src/App.vue b/apps/desktop/src/App.vue index a13bdf9c7e..8ae399bbbd 100644 --- a/apps/desktop/src/App.vue +++ b/apps/desktop/src/App.vue @@ -1032,7 +1032,7 @@ onUnmounted(() => { @set-default-database="setActiveDatabaseAsDefault" @clear-default-database="clearActiveDefaultDatabase" /> - + -import { ref, onMounted, onBeforeUnmount, watch, shallowRef, computed } from "vue"; +import { ref, onMounted, onBeforeUnmount, onActivated, onDeactivated, watch, shallowRef, computed } from "vue"; import { Play, Copy, TextSelect } from "lucide-vue-next"; import { useI18n } from "vue-i18n"; import type { CompletionContext } from "@codemirror/autocomplete"; @@ -192,6 +192,8 @@ let setSqlDiagnosticsEffect: import("@codemirror/state").StateEffectType | null = null; let semanticDiagnosticRunId = 0; +let editorIsActive = true; +let tableReferenceDropListenerRegistered = false; function editorThemeAppearance() { return isDark.value ? "dark" : "light"; @@ -724,6 +726,7 @@ async function refreshSemanticDiagnostics() { } function scheduleSemanticDiagnostics(delay = 500) { + if (!editorIsActive) return; if (semanticDiagnosticTimer) clearTimeout(semanticDiagnosticTimer); semanticDiagnosticTimer = setTimeout(() => { semanticDiagnosticTimer = null; @@ -809,6 +812,18 @@ function onTableReferenceDropEvent(event: Event) { } } +function registerTableReferenceDropListener() { + if (tableReferenceDropListenerRegistered) return; + window.addEventListener(DBX_TABLE_REFERENCE_DROP_EVENT, onTableReferenceDropEvent); + tableReferenceDropListenerRegistered = true; +} + +function unregisterTableReferenceDropListener() { + if (!tableReferenceDropListenerRegistered) return; + window.removeEventListener(DBX_TABLE_REFERENCE_DROP_EVENT, onTableReferenceDropEvent); + tableReferenceDropListenerRegistered = false; +} + let completionEpoch = 0; let completionDebounceTimer: ReturnType | null = null; @@ -1528,7 +1543,7 @@ onMounted(async () => { view.value = new EditorView({ state, parent: editorRef.value }); syncContextMenuState(view.value); syncEditorFontCssVars(liveFontSize.value, ss.fontFamily); - window.addEventListener(DBX_TABLE_REFERENCE_DROP_EVENT, onTableReferenceDropEvent); + registerTableReferenceDropListener(); cachedTables = []; scheduleSemanticDiagnostics(); @@ -1625,10 +1640,28 @@ watch( { deep: true }, ); -onBeforeUnmount(() => { - zoomCommitScheduler.dispose(); +function pauseQueryEditorBackgroundWork() { + editorIsActive = false; + semanticDiagnosticRunId++; if (semanticDiagnosticTimer) clearTimeout(semanticDiagnosticTimer); - window.removeEventListener(DBX_TABLE_REFERENCE_DROP_EVENT, onTableReferenceDropEvent); + semanticDiagnosticTimer = null; + completionEpoch++; + unregisterTableReferenceDropListener(); +} + +function resumeQueryEditorBackgroundWork() { + editorIsActive = true; + registerTableReferenceDropListener(); + scheduleSemanticDiagnostics(); +} + +onActivated(resumeQueryEditorBackgroundWork); + +onDeactivated(pauseQueryEditorBackgroundWork); + +onBeforeUnmount(() => { + pauseQueryEditorBackgroundWork(); + zoomCommitScheduler.dispose(); view.value?.destroy(); }); diff --git a/apps/desktop/src/components/grid/DataGrid.vue b/apps/desktop/src/components/grid/DataGrid.vue index 47b9e0ebb5..fbeea038a7 100644 --- a/apps/desktop/src/components/grid/DataGrid.vue +++ b/apps/desktop/src/components/grid/DataGrid.vue @@ -4,7 +4,17 @@ const globalDdlOpen = ref(false);