feat(editor): batch-select and insert SQL completion columns

This commit is contained in:
二丫讲梵 authored and GitHub committed 2026-08-30 00:47:57 +08:00
1 parent 1637948023
commit bd3e585628
15 files changed
+440 -14

No files matched your search

@@ -98,3 +98,33 @@ describe("QueryEditor context menu lifecycle", () => {
container.remove();
});
});
describe("QueryEditor batch column selection", () => {
it("keeps the confirmation action visible during pinyin filtering and supports keyboard toggling", () => {
const bypassFilterStart = source.indexOf("function completionItemsForBypassedFilter");
const bypassFilterEnd = source.indexOf("\n}\n\nfunction localCompletionDatabaseNames", bypassFilterStart);
const bypassFilterSource = source.slice(bypassFilterStart, bypassFilterEnd);
expect(bypassFilterStart).toBeGreaterThanOrEqual(0);
expect(bypassFilterEnd).toBeGreaterThan(bypassFilterStart);
expect(bypassFilterSource).toContain("if (isBatchColumnSelectionAction(item)) return true;");
expect(source).toContain('key: "Space"');
expect(source).toContain("run: toggleSelectedBatchColumnSelection");
expect(source).toContain("codeMirrorSelectedCompletion?.(view.state)");
});
it("applies checked columns directly through Enter and the completion Tab shortcut", () => {
const handleEnterStart = source.indexOf("function handleEnter");
const handleEnterEnd = source.indexOf("\n}\n\nfunction clearPendingCompletionEnter", handleEnterStart);
const tabStart = source.indexOf("function acceptCompletionOrNextSnippetField");
const tabEnd = source.indexOf("\n}\n\nfunction clearPendingCompletionTab", tabStart);
expect(source).toContain("function applySelectedBatchColumnSelection");
expect(source.slice(handleEnterStart, handleEnterEnd)).toContain("if (applySelectedBatchColumnSelection(view)) return true;");
expect(source.slice(handleEnterStart, handleEnterEnd)).toContain("if (codeMirrorAcceptCompletion?.(view)) return true;");
expect(source.slice(tabStart, tabEnd)).toContain("if (applySelectedBatchColumnSelection(view)) return true;");
expect(source).toContain("defaultKeymap: false");
expect(source).toContain('{ key: "ArrowDown", run: (view) => moveCompletion(view, true) }');
expect(source).toContain('{ key: "ArrowUp", run: (view) => moveCompletion(view, false) }');
});
});