From bd83ee189b21d78d918aba0f4e840117b4c0f31b Mon Sep 17 00:00:00 2001
From: t8y2 <1156263951@qq.com>
Date: Wed, 12 Aug 2026 18:55:57 +0000
Subject: [PATCH] fix(generate): honor explicit unique value generation

Refs: #5958
---
 .../generate/DataGenerateDialog.vue           |  65 ++++---
 apps/desktop/src/i18n/locales/en.ts           |   1 +
 apps/desktop/src/i18n/locales/es.ts           |   1 +
 apps/desktop/src/i18n/locales/it.ts           |   1 +
 apps/desktop/src/i18n/locales/ja.ts           |   1 +
 apps/desktop/src/i18n/locales/ko.ts           |   1 +
 apps/desktop/src/i18n/locales/pt-BR.ts        |   1 +
 apps/desktop/src/i18n/locales/zh-CN.ts        |   1 +
 apps/desktop/src/i18n/locales/zh-TW.ts        |   1 +
 apps/desktop/src/lib/dataGrid/dataGenerate.ts |  46 ++++-
 packages/app-tests/dataGenerate.test.ts       | 171 +++++++++++++++++-
 11 files changed, 263 insertions(+), 27 deletions(-)

diff --git a/apps/desktop/src/components/generate/DataGenerateDialog.vue b/apps/desktop/src/components/generate/DataGenerateDialog.vue
index 759bc147af..ca9ee9a92b 100644
--- a/apps/desktop/src/components/generate/DataGenerateDialog.vue
+++ b/apps/desktop/src/components/generate/DataGenerateDialog.vue
@@ -4,7 +4,7 @@ import { useI18n } from "vue-i18n";
 import { useConnectionStore } from "@/stores/connectionStore";
 import * as api from "@/lib/backend/api";
 import type { GenerateResult, TableGenerateConfig } from "@/lib/dataGrid/dataGenerate";
-import { displayGeneratedValue, findGeneratorKey, formatGeneratedValue, generateTableData, defaultGeneratorParams, supportsGeneratedMultiRowValues } from "@/lib/dataGrid/dataGenerate";
+import { displayGeneratedValue, findGeneratorKey, formatGeneratedValue, generateTableData, defaultGeneratorParams, supportsGeneratedMultiRowValues, UniqueValueGenerationError } from "@/lib/dataGrid/dataGenerate";
 import { qualifiedTableName, quoteTableIdentifier } from "@/lib/table/tableSelectSql";
 import { isTauriRuntime } from "@/lib/backend/tauriRuntime";
 import { effectiveDatabaseTypeForConnection } from "@/lib/database/jdbcDialect";
@@ -61,6 +61,7 @@ interface GeneratedTableResult extends GenerateResult {
   schema: string;
 }
 const generatedResults = ref<GeneratedTableResult[]>([]);
+const generationError = ref("");
 
 const connectionName = computed(() => (props.prefillConnectionId ? store.getConfig(props.prefillConnectionId)?.name : ""));
 
@@ -396,25 +397,31 @@ async function fetchMaxValues(cfg: TableGenerateConfig): Promise<Record<string,
 
 async function doGenerate() {
   if (!Object.values(checkedTables).some(Boolean)) return;
+  generationError.value = "";
   const results: GeneratedTableResult[] = [];
-  const order = tableOrder.value.length > 0 ? tableOrder.value : Object.keys(configs);
-  for (const key of order) {
-    if (!checkedTables[key]) continue;
-    const cfg = configs[key];
-    let columns = cfg.columns.filter((col) => checkedColumns[colKey(cfg.schema, cfg.tableName, col.columnName)] !== false);
-    if (columns.length === 0) continue;
-    const aiStarts = await fetchMaxValues(cfg);
-    if (Object.keys(aiStarts).length > 0) {
-      columns = columns.map((col) => {
-        const start = aiStarts[col.columnName];
-        if (start !== undefined) {
-          return { ...col, generatorKey: "sequence", generatorParams: { startValue: start, increment: 1 } };
-        }
-        return col;
-      });
+  try {
+    const order = tableOrder.value.length > 0 ? tableOrder.value : Object.keys(configs);
+    for (const key of order) {
+      if (!checkedTables[key]) continue;
+      const cfg = configs[key];
+      let columns = cfg.columns.filter((col) => checkedColumns[colKey(cfg.schema, cfg.tableName, col.columnName)] !== false);
+      if (columns.length === 0) continue;
+      const aiStarts = await fetchMaxValues(cfg);
+      if (Object.keys(aiStarts).length > 0) {
+        columns = columns.map((col) => {
+          const start = aiStarts[col.columnName];
+          if (start !== undefined) {
+            return { ...col, generatorKey: "sequence", generatorParams: { startValue: start, increment: 1 } };
+          }
+          return col;
+        });
+      }
+      const result = generateTableData({ ...cfg, columns }, dbType.value);
+      results.push({ tableName: cfg.tableName, schema: cfg.schema, ...result });
     }
-    const result = generateTableData({ ...cfg, columns }, dbType.value);
-    results.push({ tableName: cfg.tableName, schema: cfg.schema, ...result });
+  } catch (error) {
+    generationError.value = generationErrorMessage(error);
+    return;
   }
   generatedResults.value = results;
   previewTableIndex.value = 0;
@@ -438,8 +445,20 @@ async function regenerate() {
       return col;
     });
   }
-  const result = generateTableData({ ...cfg, columns }, dbType.value);
-  generatedResults.value[previewTableIndex.value] = { tableName: cfg.tableName, schema: cfg.schema, ...result };
+  generationError.value = "";
+  try {
+    const result = generateTableData({ ...cfg, columns }, dbType.value);
+    generatedResults.value[previewTableIndex.value] = { tableName: cfg.tableName, schema: cfg.schema, ...result };
+  } catch (error) {
+    generationError.value = generationErrorMessage(error);
+  }
+}
+
+function generationErrorMessage(error: unknown): string {
+  if (error instanceof UniqueValueGenerationError) {
+    return t("dataGenerate.uniqueExhausted", { table: error.tableName, column: error.columnName, attempts: error.attempts });
+  }
+  return error instanceof Error ? error.message : String(error);
 }
 
 function copyAllSql() {
@@ -498,7 +517,7 @@ function allSqlStatements(): string[] {
 }
 
 async function startInsert() {
-  if (executing.value) return;
+  if (executing.value || generationError.value) return;
   const cid = props.prefillConnectionId;
   const db = props.prefillDatabase;
   if (!cid || !db) return;
@@ -807,6 +826,8 @@ async function onFileSelected(event: Event) {
         <span class="ml-1 font-medium">{{ connectionName || props.prefillDatabase }}</span>
       </div>
 
+      <div v-if="generationError" class="rounded-md border border-destructive/40 bg-destructive/10 px-3 py-2 text-xs text-destructive" role="alert">{{ generationError }}</div>
+
       <template v-if="currentStep === 'config'">
         <div class="flex gap-4 min-h-[400px]">
           <!-- left: schema tree -->
@@ -1024,7 +1045,7 @@ async function onFileSelected(event: Event) {
           </template>
           <template v-else-if="currentStep === 'preview'">
             <Button variant="outline" size="sm" class="h-7 text-xs" @click="currentStep = 'config'">{{ t("dataGenerate.prevStep") }}</Button>
-            <Button variant="default" size="sm" class="h-7 text-xs" :disabled="executing" @click="startInsert">
+            <Button variant="default" size="sm" class="h-7 text-xs" :disabled="executing || !!generationError" @click="startInsert">
               <Loader2 v-if="executing" class="mr-1 h-3 w-3 animate-spin" />
               {{ t("dataGenerate.startInsert") }}
             </Button>
diff --git a/apps/desktop/src/i18n/locales/en.ts b/apps/desktop/src/i18n/locales/en.ts
index e73616d7dd..fb6c451a48 100644
--- a/apps/desktop/src/i18n/locales/en.ts
+++ b/apps/desktop/src/i18n/locales/en.ts
@@ -4819,6 +4819,7 @@ export default {
     includeDefault: "Include DEFAULT",
     includeNull: "Include NULL",
     unique: "Set unique",
+    uniqueExhausted: "Could not generate a distinct value for {table}.{column} within {attempts} attempts. Increase the available value range or generate fewer rows.",
     disableLinks: "Disable data links between columns",
     imageMode: "Mode",
     generate: "Generate",
diff --git a/apps/desktop/src/i18n/locales/es.ts b/apps/desktop/src/i18n/locales/es.ts
index be61d40062..5f23600b6d 100644
--- a/apps/desktop/src/i18n/locales/es.ts
+++ b/apps/desktop/src/i18n/locales/es.ts
@@ -4600,6 +4600,7 @@ export default withEnglishFallback({
     includeDefault: "Include DEFAULT",
     includeNull: "Include NULL",
     unique: "Set unique",
+    uniqueExhausted: "No se pudo generar un valor distinto para {table}.{column} en {attempts} intentos. Amplía el rango de valores o genera menos filas.",
     disableLinks: "Disable data links between columns",
     imageMode: "Mode",
     generate: "Generate",
diff --git a/apps/desktop/src/i18n/locales/it.ts b/apps/desktop/src/i18n/locales/it.ts
index 6149805388..7470684c5f 100644
--- a/apps/desktop/src/i18n/locales/it.ts
+++ b/apps/desktop/src/i18n/locales/it.ts
@@ -4598,6 +4598,7 @@ export default withEnglishFallback({
     includeDefault: "Include DEFAULT",
     includeNull: "Include NULL",
     unique: "Set unique",
+    uniqueExhausted: "Impossibile generare un valore distinto per {table}.{column} in {attempts} tentativi. Amplia l'intervallo dei valori o genera meno righe.",
     disableLinks: "Disable data links between columns",
     imageMode: "Mode",
     generate: "Generate",
diff --git a/apps/desktop/src/i18n/locales/ja.ts b/apps/desktop/src/i18n/locales/ja.ts
index 3b1d6b9a3f..340269508d 100644
--- a/apps/desktop/src/i18n/locales/ja.ts
+++ b/apps/desktop/src/i18n/locales/ja.ts
@@ -4637,6 +4637,7 @@ export default withEnglishFallback({
     includeDefault: "DEFAULTを含める",
     includeNull: "NULLを含める",
     unique: "一意に設定",
+    uniqueExhausted: "{attempts} 回の試行で {table}.{column} の重複しない値を生成できませんでした。値の範囲を広げるか、生成行数を減らしてください。",
     disableLinks: "列間のデータリンクを無効化",
     imageMode: "モード",
     generate: "生成",
diff --git a/apps/desktop/src/i18n/locales/ko.ts b/apps/desktop/src/i18n/locales/ko.ts
index 8979eaa31a..f5e4c94468 100644
--- a/apps/desktop/src/i18n/locales/ko.ts
+++ b/apps/desktop/src/i18n/locales/ko.ts
@@ -4318,6 +4318,7 @@ export default withEnglishFallback({
     includeDefault: "DEFAULT 포함",
     includeNull: "NULL 포함",
     unique: "고유 설정",
+    uniqueExhausted: "{attempts}번 시도했지만 {table}.{column}의 중복되지 않는 값을 생성하지 못했습니다. 값 범위를 늘리거나 생성 행 수를 줄이세요.",
     disableLinks: "컬럼 간 데이터 연결 비활성화",
     imageMode: "모드",
     generate: "생성",
diff --git a/apps/desktop/src/i18n/locales/pt-BR.ts b/apps/desktop/src/i18n/locales/pt-BR.ts
index ac72bdc437..9f4f718da7 100644
--- a/apps/desktop/src/i18n/locales/pt-BR.ts
+++ b/apps/desktop/src/i18n/locales/pt-BR.ts
@@ -4600,6 +4600,7 @@ export default withEnglishFallback({
     includeDefault: "Include DEFAULT",
     includeNull: "Include NULL",
     unique: "Set unique",
+    uniqueExhausted: "Não foi possível gerar um valor distinto para {table}.{column} em {attempts} tentativas. Aumente o intervalo de valores ou gere menos linhas.",
     disableLinks: "Disable data links between columns",
     imageMode: "Mode",
     generate: "Generate",
diff --git a/apps/desktop/src/i18n/locales/zh-CN.ts b/apps/desktop/src/i18n/locales/zh-CN.ts
index 2005e1e1ae..2a8de1484d 100644
--- a/apps/desktop/src/i18n/locales/zh-CN.ts
+++ b/apps/desktop/src/i18n/locales/zh-CN.ts
@@ -4742,6 +4742,7 @@ export default withEnglishFallback({
     includeDefault: "包含默认值",
     includeNull: "包含 NULL",
     unique: "设置唯一",
+    uniqueExhausted: "无法在 {attempts} 次尝试内为表 {table} 的字段 {column} 生成不重复值，请增大可选值范围或减少生成行数。",
     disableLinks: "禁用字段之间的数据链接",
     imageMode: "模式",
     generate: "生成",
diff --git a/apps/desktop/src/i18n/locales/zh-TW.ts b/apps/desktop/src/i18n/locales/zh-TW.ts
index 74a26f8312..9f262c2dd2 100644
--- a/apps/desktop/src/i18n/locales/zh-TW.ts
+++ b/apps/desktop/src/i18n/locales/zh-TW.ts
@@ -3945,6 +3945,7 @@ export default withEnglishFallback({
     includeDefault: "包含預設值",
     includeNull: "包含 NULL",
     unique: "設定唯一",
+    uniqueExhausted: "無法在 {attempts} 次嘗試內為資料表 {table} 的欄位 {column} 產生不重複值，請增加可選值範圍或減少產生列數。",
     disableLinks: "禁用欄位之間的資料連結",
     imageMode: "模式",
     generate: "生成",
diff --git a/apps/desktop/src/lib/dataGrid/dataGenerate.ts b/apps/desktop/src/lib/dataGrid/dataGenerate.ts
index 52fab7fed4..72b978581e 100644
--- a/apps/desktop/src/lib/dataGrid/dataGenerate.ts
+++ b/apps/desktop/src/lib/dataGrid/dataGenerate.ts
@@ -1774,6 +1774,29 @@ export interface GenerateResult {
   statements: string[];
 }
 
+const MAX_UNIQUE_GENERATION_ATTEMPTS = 100;
+
+export class UniqueValueGenerationError extends Error {
+  constructor(
+    public readonly tableName: string,
+    public readonly columnName: string,
+    public readonly attempts: number,
+  ) {
+    super(`Unable to generate a unique value for column "${columnName}" in table "${tableName}" after ${attempts} attempts.`);
+    this.name = "UniqueValueGenerationError";
+  }
+}
+
+function generatedValueIdentity(value: unknown): string {
+  if (isGeneratedSqlExpression(value)) return `sql:${value.sql}`;
+  if (value === null) return "null";
+  if (value === undefined) return "undefined";
+  if (typeof value === "number") return `number:${value}`;
+  if (typeof value === "boolean") return `boolean:${value}`;
+  if (typeof value === "string") return `string:${value}`;
+  return `${typeof value}:${JSON.stringify(value)}`;
+}
+
 export function supportsGeneratedMultiRowValues(databaseType?: DatabaseType): boolean {
   return databaseType !== "oracle" && databaseType !== "oceanbase-oracle" && databaseType !== "iris";
 }
@@ -1810,15 +1833,34 @@ export function generateTableData(config: TableGenerateConfig, databaseType?: Da
   const shouldAddTbname = isTdengineStable && !hasTbnameColumn;
   const tdengineChildTableName = shouldAddTbname ? generateTdengineChildTableName() : null;
   const tagValues = new Map<string, unknown>();
+  const uniqueValues = config.columns.map((column) => (column.generatorParams?.unique ? new Set<string>() : null));
   const colNames = shouldAddTbname ? ["tbname", ...config.columns.map((c) => c.columnName)] : config.columns.map((c) => c.columnName);
   const rows: unknown[][] = [];
 
   for (let i = 0; i < config.rowCount; i++) {
-    const row = config.columns.map((col) => {
+    const row = config.columns.map((col, columnIndex) => {
       if (isTdengineStable && col.isTag && tagValues.has(col.columnName)) {
         return tagValues.get(col.columnName);
       }
-      const value = generateValue(col.columnName, col.dataType, col.generatorKey, i, col.generatorParams, col.isAutoIncrement ? null : col.columnDefault);
+      let value: unknown;
+      if (col.generatorParams?.unique) {
+        const seen = uniqueValues[columnIndex]!;
+        let found = false;
+        for (let attempt = 0; attempt < MAX_UNIQUE_GENERATION_ATTEMPTS; attempt++) {
+          value = generateValue(col.columnName, col.dataType, col.generatorKey, i, col.generatorParams, col.isAutoIncrement ? null : col.columnDefault);
+          const identity = generatedValueIdentity(value);
+          if (!seen.has(identity)) {
+            seen.add(identity);
+            found = true;
+            break;
+          }
+        }
+        if (!found) {
+          throw new UniqueValueGenerationError(config.tableName, col.columnName, MAX_UNIQUE_GENERATION_ATTEMPTS);
+        }
+      } else {
+        value = generateValue(col.columnName, col.dataType, col.generatorKey, i, col.generatorParams, col.isAutoIncrement ? null : col.columnDefault);
+      }
       if (isTdengineStable && col.isTag) {
         tagValues.set(col.columnName, value);
       }
diff --git a/packages/app-tests/dataGenerate.test.ts b/packages/app-tests/dataGenerate.test.ts
index 7a397a288a..e1facf194c 100644
--- a/packages/app-tests/dataGenerate.test.ts
+++ b/packages/app-tests/dataGenerate.test.ts
@@ -1,5 +1,5 @@
 import { strict as assert } from "node:assert";
-import { test } from "vitest";
+import { test, vi } from "vitest";
 import { defaultGeneratorParams, displayGeneratedValue, generateTableData, generateValue, supportsGeneratedMultiRowValues } from "../../apps/desktop/src/lib/dataGrid/dataGenerate.ts";
 
 test("enables default values for columns with schema defaults", () => {
@@ -99,6 +99,171 @@ test("includeDefault without a schema default no longer emits NULL", () => {
   assert.notEqual(value, undefined);
 });
 
+test("fails before producing SQL when an explicitly unique generator is exhausted", () => {
+  assert.throws(
+    () =>
+      generateTableData(
+        {
+          tableName: "users",
+          schema: "public",
+          database: "app",
+          rowCount: 2,
+          columns: [
+            {
+              columnName: "status",
+              dataType: "text",
+              rowCount: 2,
+              generatorKey: "enum",
+              generatorParams: { values: "active", unique: true },
+            },
+          ],
+        },
+        "postgres",
+      ),
+    /unique value.*status.*users/i,
+  );
+});
+
+test("retries collisions for an explicitly unique generator", () => {
+  const random = vi.spyOn(Math, "random").mockReturnValueOnce(0).mockReturnValueOnce(0).mockReturnValueOnce(0.99);
+  try {
+    const result = generateTableData(
+      {
+        tableName: "users",
+        schema: "public",
+        database: "app",
+        rowCount: 2,
+        columns: [
+          {
+            columnName: "rank",
+            dataType: "integer",
+            rowCount: 2,
+            generatorKey: "number",
+            generatorParams: { min: 1, max: 2, unique: true },
+          },
+        ],
+      },
+      "postgres",
+    );
+
+    assert.deepEqual(result.rows, [[1], [2]]);
+  } finally {
+    random.mockRestore();
+  }
+});
+
+test("keeps explicit uniqueness scoped independently to each column", () => {
+  const result = generateTableData(
+    {
+      tableName: "pairs",
+      schema: "public",
+      database: "app",
+      rowCount: 2,
+      columns: ["left_id", "right_id"].map((columnName) => ({
+        columnName,
+        dataType: "integer",
+        rowCount: 2,
+        generatorKey: "sequence",
+        generatorParams: { startValue: 1, increment: 1, unique: true },
+      })),
+    },
+    "postgres",
+  );
+
+  assert.deepEqual(result.rows, [
+    [1, 1],
+    [2, 2],
+  ]);
+});
+
+test("keeps duplicate values unchanged when explicit uniqueness is disabled", () => {
+  const result = generateTableData(
+    {
+      tableName: "users",
+      schema: "public",
+      database: "app",
+      rowCount: 2,
+      columns: [
+        {
+          columnName: "status",
+          dataType: "text",
+          rowCount: 2,
+          generatorKey: "enum",
+          generatorParams: { values: "active", unique: false },
+        },
+      ],
+    },
+    "postgres",
+  );
+
+  assert.deepEqual(result.rows, [["active"], ["active"]]);
+});
+
+test("generates 1000 distinct emails when explicit uniqueness is enabled", () => {
+  const result = generateTableData(
+    {
+      tableName: "users",
+      schema: "public",
+      database: "app",
+      rowCount: 1000,
+      columns: [
+        {
+          columnName: "email",
+          dataType: "text",
+          rowCount: 1000,
+          generatorKey: "email",
+          generatorParams: { unique: true },
+        },
+      ],
+    },
+    "postgres",
+  );
+
+  assert.equal(new Set(result.rows.map((row) => row[0])).size, 1000);
+});
+
+test("treats repeated null, default, and SQL expression values as unique-domain exhaustion", () => {
+  const cases = [
+    {
+      columnName: "optional_name",
+      dataType: "text",
+      generatorKey: "text",
+      generatorParams: { includeNull: true, nullPercent: 100, unique: true },
+    },
+    {
+      columnName: "status",
+      dataType: "text",
+      generatorKey: "text",
+      generatorParams: { includeDefault: true, defaultPercent: 100, unique: true },
+      columnDefault: "active",
+    },
+    {
+      columnName: "created_at",
+      dataType: "timestamp",
+      generatorKey: "datetime",
+      generatorParams: { includeDefault: true, defaultPercent: 100, unique: true },
+      columnDefault: "CURRENT_TIMESTAMP",
+    },
+  ];
+
+  for (const column of cases) {
+    assert.throws(
+      () =>
+        generateTableData(
+          {
+            tableName: "events",
+            schema: "public",
+            database: "app",
+            rowCount: 2,
+            columns: [{ ...column, rowCount: 2 }],
+          },
+          "postgres",
+        ),
+      new RegExp(`unique value.*${column.columnName}.*events`, "i"),
+    );
+  }
+});
+
 test("generates Oracle-compatible single-row inserts with explicit temporal literals", () => {
   const result = generateTableData(
     {
@@ -154,7 +319,7 @@ test("batches large Oracle data generation statements", () => {
           dataType: "NUMBER",
           rowCount: 101,
           generatorKey: "sequence",
-          generatorParams: { startValue: 1, increment: 1 },
+          generatorParams: { startValue: 1, increment: 1, unique: true },
         },
       ],
     },
@@ -194,7 +359,7 @@ test("generates TDengine stable rows with one child table identity and stable ta
           dataType: "BINARY(64)",
           rowCount: 2,
           generatorKey: "sequence",
-          generatorParams: { startValue: 100, increment: 1 },
+          generatorParams: { startValue: 100, increment: 1, unique: true },
           isTag: true,
         },
       ],