fix(mcp): preserve SQL literals during execution
This commit is contained in:
1 parent
8cebc4a366
commit
c19f3e201b
3 files changed
+140
-2
No files matched your search
+19
-1
@@ -1,6 +1,6 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { test } from "vitest";
|
||||
import { evaluateSqlSafety, sqlSafetyFromEnv } from "../src/sql-safety.js";
|
||||
import { evaluateSqlSafety, splitSqlStatements, sqlSafetyFromEnv } from "../src/sql-safety.js";
|
||||
|
||||
test("allows read-only SQL by default", () => {
|
||||
const decision = evaluateSqlSafety("select * from users limit 5");
|
||||
@@ -79,6 +79,24 @@ test("checks every statement in a multi-statement SQL string", () => {
|
||||
assert.match(decision.reason ?? "", /WHERE/i);
|
||||
});
|
||||
|
||||
test("splits statements without altering SQL literals or comments", () => {
|
||||
const sql = "SELECT 'a;b' AS value, ''abc'' AS quoted; -- keep comment\nSELECT $$c;d$$ AS dollar;";
|
||||
|
||||
assert.deepEqual(splitSqlStatements(sql), [
|
||||
"SELECT 'a;b' AS value, ''abc'' AS quoted",
|
||||
"-- keep comment\nSELECT $$c;d$$ AS dollar",
|
||||
]);
|
||||
});
|
||||
|
||||
test("keeps tagged dollar quotes and quoted identifiers intact", () => {
|
||||
const sql = 'SELECT $body$begin; end$body$ AS body, "semi;colon" AS "quoted;column"; SELECT 2;';
|
||||
|
||||
assert.deepEqual(splitSqlStatements(sql), [
|
||||
'SELECT $body$begin; end$body$ AS body, "semi;colon" AS "quoted;column"',
|
||||
"SELECT 2",
|
||||
]);
|
||||
});
|
||||
|
||||
test("sqlSafetyFromEnv allows writes by default but keeps dangerous SQL blocked", () => {
|
||||
const options = sqlSafetyFromEnv({});
|
||||
|
||||
|
||||
Reference in new issue
Block a user