feat(ai): bind each conversation to its own connection
This commit is contained in:
1 parent
47e7f56b14
commit
c373f322d2
35 files changed
+1584
-272
No files matched your search
@@ -187,6 +187,7 @@ import { sqlFormatDialectForDbType, type SqlFormatDialect } from "@/lib/sql/sqlF
|
||||
import { productionContextForDatabase } from "@/lib/database/productionSafety";
|
||||
import { sqlStatementParameterOptionsForCompatibility } from "@/lib/sql/sqlStatementRanges";
|
||||
import { connectionIsEffectivelyReadOnly } from "@/lib/database/readOnlyWriteAccess";
|
||||
import { isAiRedisConsoleTarget, type AiConversationBinding } from "@/lib/ai/aiConversationBinding";
|
||||
|
||||
type DataGridHandle = DataGridColumnLayoutHandle & {
|
||||
onToolbarRefresh: () => Promise<void> | void;
|
||||
@@ -1359,13 +1360,19 @@ function applyTableStructureChanges() {
|
||||
return tableStructureEditorRef.value?.applyChanges() ?? Promise.resolve(false);
|
||||
}
|
||||
|
||||
async function insertRedisCommand(command: string): Promise<boolean> {
|
||||
if (props.activeTab.mode !== "redis") return false;
|
||||
// The Redis console is bound to the visible tab and logical database. Refuse
|
||||
// any other AI target before passing a command to the key browser (#9902).
|
||||
function isRedisConsoleReady(target: AiConversationBinding): boolean {
|
||||
return isAiRedisConsoleTarget(props.activeTab, target) && !!redisKeyBrowserRef.value;
|
||||
}
|
||||
|
||||
async function insertRedisCommand(command: string, target: AiConversationBinding): Promise<boolean> {
|
||||
if (!isRedisConsoleReady(target)) return false;
|
||||
return (await redisKeyBrowserRef.value?.insertCommand?.(command)) ?? false;
|
||||
}
|
||||
|
||||
async function executeRedisCommand(command: string): Promise<boolean> {
|
||||
if (props.activeTab.mode !== "redis") return false;
|
||||
async function executeRedisCommand(command: string, target: AiConversationBinding): Promise<boolean> {
|
||||
if (!isRedisConsoleReady(target)) return false;
|
||||
return (await redisKeyBrowserRef.value?.executeCommand?.(command)) ?? false;
|
||||
}
|
||||
|
||||
@@ -1470,6 +1477,7 @@ defineExpose({
|
||||
applyTableStructureChanges,
|
||||
insertRedisCommand,
|
||||
executeRedisCommand,
|
||||
isRedisConsoleReady,
|
||||
previewStatementRange,
|
||||
focusStatementRange,
|
||||
focusErrorPosition,
|
||||
|
||||
@@ -17,6 +17,7 @@ import { usesProvenReadOnlyStickyTransactionState } from "@/lib/database/databas
|
||||
import { GROUP_TAB_BAR_PORTAL } from "./groupTabBarPortal";
|
||||
import type { ContentAreaSurfaceEmits, ContentAreaSurfaceProps, QueryEditorSurfaceHandle, StatementRange } from "./querySurfaces";
|
||||
import type { QueryTab } from "@/types/database";
|
||||
import type { AiConversationBinding } from "@/lib/ai/aiConversationBinding";
|
||||
|
||||
defineOptions({ inheritAttrs: false });
|
||||
|
||||
@@ -85,8 +86,9 @@ defineExpose({
|
||||
acceptQueryEditorExecutionViewport: (requestId: number) => activeSurfaceRef.value?.acceptQueryEditorExecutionViewport(requestId) ?? false,
|
||||
pasteClipboardAsSqlInCondition: () => activeSurfaceRef.value?.pasteClipboardAsSqlInCondition() ?? Promise.resolve(false),
|
||||
applyTableStructureChanges: () => activeSurfaceRef.value?.applyTableStructureChanges() ?? Promise.resolve(false),
|
||||
insertRedisCommand: (command: string) => activeSurfaceRef.value?.insertRedisCommand(command) ?? Promise.resolve(false),
|
||||
executeRedisCommand: (command: string) => activeSurfaceRef.value?.executeRedisCommand(command) ?? Promise.resolve(false),
|
||||
insertRedisCommand: (command: string, target: AiConversationBinding) => activeSurfaceRef.value?.insertRedisCommand(command, target) ?? Promise.resolve(false),
|
||||
executeRedisCommand: (command: string, target: AiConversationBinding) => activeSurfaceRef.value?.executeRedisCommand(command, target) ?? Promise.resolve(false),
|
||||
isRedisConsoleReady: (target: AiConversationBinding) => activeSurfaceRef.value?.isRedisConsoleReady(target) ?? false,
|
||||
previewStatementRange: (tabId: string, range: StatementRange | null) => (activeTab.value?.id === tabId ? (activeSurfaceRef.value?.previewStatementRange(range) ?? false) : false),
|
||||
focusStatementRange: (tabId: string, range: StatementRange | null) => (activeTab.value?.id === tabId ? (activeSurfaceRef.value?.focusStatementRange(range) ?? false) : false),
|
||||
focusErrorPosition: (tabId: string, offset: number) => (activeTab.value?.id === tabId ? (activeSurfaceRef.value?.focusErrorPosition(offset) ?? false) : false),
|
||||
|
||||
@@ -3,6 +3,7 @@ import { computed, ref } from "vue";
|
||||
import ContentArea from "./ContentArea.vue";
|
||||
import { createContentSurfaceEventForwarders } from "@/lib/tabs/contentSurfaceEvents";
|
||||
import type { ContentAreaSurfaceEmits, ContentAreaSurfaceProps, QueryEditorSurfaceHandle, StatementRange } from "./querySurfaces";
|
||||
import type { AiConversationBinding } from "@/lib/ai/aiConversationBinding";
|
||||
|
||||
const props = defineProps<ContentAreaSurfaceProps & { autoFocus?: boolean }>();
|
||||
const emit = defineEmits<ContentAreaSurfaceEmits>();
|
||||
@@ -37,8 +38,9 @@ defineExpose<QueryEditorSurfaceHandle>({
|
||||
acceptQueryEditorExecutionViewport: (requestId: number) => contentAreaRef.value?.acceptQueryEditorExecutionViewport(requestId) ?? false,
|
||||
pasteClipboardAsSqlInCondition: () => contentAreaRef.value?.pasteClipboardAsSqlInCondition() ?? Promise.resolve(false),
|
||||
applyTableStructureChanges: () => contentAreaRef.value?.applyTableStructureChanges() ?? Promise.resolve(false),
|
||||
insertRedisCommand: (command: string) => contentAreaRef.value?.insertRedisCommand(command) ?? Promise.resolve(false),
|
||||
executeRedisCommand: (command: string) => contentAreaRef.value?.executeRedisCommand(command) ?? Promise.resolve(false),
|
||||
insertRedisCommand: (command: string, target: AiConversationBinding) => contentAreaRef.value?.insertRedisCommand(command, target) ?? Promise.resolve(false),
|
||||
executeRedisCommand: (command: string, target: AiConversationBinding) => contentAreaRef.value?.executeRedisCommand(command, target) ?? Promise.resolve(false),
|
||||
isRedisConsoleReady: (target: AiConversationBinding) => contentAreaRef.value?.isRedisConsoleReady(target) ?? false,
|
||||
previewStatementRange: (range: StatementRange | null) => contentAreaRef.value?.previewStatementRange(range) ?? false,
|
||||
focusStatementRange: (range: StatementRange | null) => contentAreaRef.value?.focusStatementRange(range) ?? false,
|
||||
focusErrorPosition: (offset: number) => contentAreaRef.value?.focusErrorPosition(offset) ?? false,
|
||||
|
||||
@@ -16,6 +16,7 @@ import QueryResultSurface from "./QueryResultSurface.vue";
|
||||
import { createContentSurfaceEventForwarders } from "@/lib/tabs/contentSurfaceEvents";
|
||||
import type { ContentAreaSurfaceEmits, ContentAreaSurfaceProps, StatementRange } from "./querySurfaces";
|
||||
import type { QueryTab } from "@/types/database";
|
||||
import type { AiConversationBinding } from "@/lib/ai/aiConversationBinding";
|
||||
|
||||
defineOptions({ inheritAttrs: false });
|
||||
|
||||
@@ -107,8 +108,11 @@ defineExpose({
|
||||
const group = groupForElement(commandTargetElement(null));
|
||||
return group?.applyTableStructureChanges() ?? activeEditorGroup()?.applyTableStructureChanges() ?? Promise.resolve(false);
|
||||
},
|
||||
insertRedisCommand: (command: string) => (groupForElement(commandTargetElement(null)) ?? activeEditorGroup())?.insertRedisCommand(command) ?? Promise.resolve(false),
|
||||
executeRedisCommand: (command: string) => (groupForElement(commandTargetElement(null)) ?? activeEditorGroup())?.executeRedisCommand(command) ?? Promise.resolve(false),
|
||||
// Redis's logical DB is part of the target, so a visible tab on another DB
|
||||
// must be refused even when it shares the same connection.
|
||||
insertRedisCommand: (command: string, target: AiConversationBinding) => (groupForElement(commandTargetElement(null)) ?? activeEditorGroup())?.insertRedisCommand(command, target) ?? Promise.resolve(false),
|
||||
executeRedisCommand: (command: string, target: AiConversationBinding) => (groupForElement(commandTargetElement(null)) ?? activeEditorGroup())?.executeRedisCommand(command, target) ?? Promise.resolve(false),
|
||||
isRedisConsoleReady: (target: AiConversationBinding) => (groupForElement(commandTargetElement(null)) ?? activeEditorGroup())?.isRedisConsoleReady(target) ?? false,
|
||||
});
|
||||
|
||||
const { t } = useI18n();
|
||||
|
||||
@@ -3,6 +3,7 @@ import type { DataGridReloadIntent } from "@/lib/dataGrid/dataGridToolbar";
|
||||
import type { DataGridSortMode } from "@/lib/dataGrid/dataGridSort";
|
||||
import type { SqlObjectNavigationTarget } from "@/lib/sql/sqlNavigation";
|
||||
import type { SqlExecutionOverride, SqlExecutionSnapshot } from "@/lib/sql/sqlExecutionTarget";
|
||||
import type { AiConversationBinding } from "@/lib/ai/aiConversationBinding";
|
||||
|
||||
export interface StatementRange {
|
||||
from: number;
|
||||
@@ -25,8 +26,17 @@ export interface QueryEditorSurfaceHandle {
|
||||
acceptQueryEditorExecutionViewport(requestId: number): boolean;
|
||||
pasteClipboardAsSqlInCondition(): Promise<boolean>;
|
||||
applyTableStructureChanges(): Promise<boolean>;
|
||||
insertRedisCommand(command: string): Promise<boolean>;
|
||||
executeRedisCommand(command: string): Promise<boolean>;
|
||||
/** A Redis logical database is part of the execution target. */
|
||||
insertRedisCommand(command: string, target: AiConversationBinding): Promise<boolean>;
|
||||
executeRedisCommand(command: string, target: AiConversationBinding): Promise<boolean>;
|
||||
/**
|
||||
* Whether this surface's Redis console is mounted, on screen, and pointed at
|
||||
* `target`. Side-effect free — the AI panel polls it before routing a
|
||||
* command, because the console is a lazily-loaded component rendered only for
|
||||
* the active tab, and retrying the *command* to detect readiness could run it
|
||||
* twice.
|
||||
*/
|
||||
isRedisConsoleReady(target: AiConversationBinding): boolean;
|
||||
previewStatementRange(range: StatementRange | null): boolean;
|
||||
focusStatementRange(range: StatementRange | null): boolean;
|
||||
focusErrorPosition(offset: number): boolean;
|
||||
|
||||
Reference in new issue
Block a user