fix(ai): preserve last-used model during app session

This commit is contained in:
Abeautifulsnow authored and GitHub committed 2026-07-17 18:14:49 +08:00
1 parent c88fad6bd8
commit c417e54698
3 files changed
+142 -14

No files matched your search

+134 -1
View File
@@ -1,5 +1,7 @@
import { describe, expect, it } from "vitest";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { normalizeDesktopSettings, normalizeEditorSettings } from "@/stores/settingsStore";
import { createPinia, setActivePinia } from "pinia";
import type { AiConfigItem } from "@/types/ai";
describe("normalizeEditorSettings", () => {
it("enables automatic table aliases by default", () => {
@@ -162,3 +164,134 @@ describe("normalizeEditorSettings - tabLayout", () => {
expect(normalizeEditorSettings({ tabLayout: 123 } as any).tabLayout).toBe("scroll");
});
});
// --- Helpers for Pinia store tests ---
function makeTestConfig(overrides: Partial<AiConfigItem> & { id: string }): AiConfigItem {
return {
provider: "openai",
apiKey: "",
authMethod: "api-key",
endpoint: "https://api.openai.com/v1/chat/completions",
model: "gpt-4o-mini",
apiStyle: "completions",
name: overrides.id,
...overrides,
} as AiConfigItem;
}
// --- activeModel lifecycle tests ---
describe("settingsStore activeModel lifecycle", () => {
beforeEach(() => {
vi.resetModules();
setActivePinia(createPinia());
});
it("updateActiveModel persists the model and does not change any config isDefault", async () => {
vi.doMock("@/lib/backend/api", () => ({
loadAiConfigs: vi.fn().mockResolvedValue([]),
loadAiConfig: vi.fn().mockResolvedValue(null),
loadAiProviderConfigs: vi.fn().mockResolvedValue(null),
}));
const { useSettingsStore } = await import("@/stores/settingsStore");
const store = useSettingsStore();
store.aiConfigs = [makeTestConfig({ id: "c1", model: "model-a", isDefault: true }), makeTestConfig({ id: "c2", model: "model-b", isDefault: false })];
store.isAiConfigLoaded = true;
store.updateActiveModel({ configId: "c1", modelId: "model-a" });
expect(store.activeModel).toEqual({ configId: "c1", modelId: "model-a" });
store.updateActiveModel({ configId: "c2", modelId: "model-b" });
expect(store.activeModel).toEqual({ configId: "c2", modelId: "model-b" });
// 核心保障:不改变任何配置的 isDefault
expect(store.aiConfigs[0].isDefault).toBe(true);
expect(store.aiConfigs[1].isDefault).toBe(false);
});
it("setDefaultAiConfig(id) on success points activeModel to the new default config", async () => {
const setDefaultAiConfig = vi.fn().mockResolvedValue(undefined);
vi.doMock("@/lib/backend/api", () => ({
loadAiConfigs: vi.fn().mockResolvedValue([]),
loadAiConfig: vi.fn().mockResolvedValue(null),
loadAiProviderConfigs: vi.fn().mockResolvedValue(null),
setDefaultAiConfig,
}));
const { useSettingsStore } = await import("@/stores/settingsStore");
const store = useSettingsStore();
store.aiConfigs = [makeTestConfig({ id: "c1", model: "model-a", isDefault: true }), makeTestConfig({ id: "c2", model: "model-b", isDefault: false })];
store.isAiConfigLoaded = true;
// 先手动切到非默认的配置
store.updateActiveModel({ configId: "c2", modelId: "model-b" });
expect(store.activeModel).toEqual({ configId: "c2", modelId: "model-b" });
await store.setDefaultAiConfig("c2");
expect(setDefaultAiConfig).toHaveBeenCalledWith("c2");
expect(store.aiConfigs[0].isDefault).toBe(false);
expect(store.aiConfigs[1].isDefault).toBe(true);
expect(store.activeModel).toEqual({ configId: "c2", modelId: "model-b" });
});
it("setDefaultAiConfig does not mutate state when backend call fails", async () => {
const error = new Error("backend error");
const setDefaultAiConfig = vi.fn().mockRejectedValue(error);
vi.doMock("@/lib/backend/api", () => ({
loadAiConfigs: vi.fn().mockResolvedValue([]),
loadAiConfig: vi.fn().mockResolvedValue(null),
loadAiProviderConfigs: vi.fn().mockResolvedValue(null),
setDefaultAiConfig,
}));
const { useSettingsStore } = await import("@/stores/settingsStore");
const store = useSettingsStore();
store.aiConfigs = [makeTestConfig({ id: "c1", model: "model-a", isDefault: true }), makeTestConfig({ id: "c2", model: "model-b", isDefault: false })];
store.isAiConfigLoaded = true;
store.updateActiveModel({ configId: "c1", modelId: "model-a" });
await expect(store.setDefaultAiConfig("c2")).rejects.toThrow("backend error");
// isDefault 不变
expect(store.aiConfigs[0].isDefault).toBe(true);
expect(store.aiConfigs[1].isDefault).toBe(false);
// activeModel 不变
expect(store.activeModel).toEqual({ configId: "c1", modelId: "model-a" });
});
it("reloadAiConfigs sets activeModel to null when config list is empty", async () => {
vi.doMock("@/lib/backend/api", () => ({
loadAiConfigs: vi.fn().mockResolvedValue([]),
loadAiConfig: vi.fn().mockResolvedValue(null),
loadAiProviderConfigs: vi.fn().mockResolvedValue(null),
}));
const { useSettingsStore } = await import("@/stores/settingsStore");
const store = useSettingsStore();
store.isAiConfigLoaded = false;
await store.reloadAiConfigs();
expect(store.activeModel).toBeNull();
});
it("reloadAiConfigs points activeModel to isDefault config, not first in list", async () => {
const configs = [makeTestConfig({ id: "c1", model: "model-a", isDefault: false }), makeTestConfig({ id: "c2", model: "model-b", isDefault: true }), makeTestConfig({ id: "c3", model: "model-c", isDefault: false })];
vi.doMock("@/lib/backend/api", () => ({
loadAiConfigs: vi.fn().mockResolvedValue(configs),
}));
const { useSettingsStore } = await import("@/stores/settingsStore");
const store = useSettingsStore();
store.isAiConfigLoaded = false;
await store.reloadAiConfigs();
expect(store.activeModel).toEqual({ configId: "c2", modelId: "model-b" });
});
});