fix(transfer): recover unsupported MySQL collations

Closes #6023
This commit is contained in:
t8y2 committed 2026-08-12 12:20:45 +00:00
1 parent 6429334549
commit c570517fe0
2 files changed
+450 -30

No files matched your search

@@ -32,6 +32,35 @@ fn live_mysql_config(id: &str) -> ConnectionConfig {
.expect("live MySQL transfer config should deserialize")
}
fn live_cross_version_mysql_config(id: &str, prefix: &str) -> ConnectionConfig {
let host = std::env::var(format!("DBX_LIVE_MYSQL_TRANSFER_{prefix}_HOST"))
.unwrap_or_else(|_| panic!("DBX_LIVE_MYSQL_TRANSFER_{prefix}_HOST"));
let port = std::env::var(format!("DBX_LIVE_MYSQL_TRANSFER_{prefix}_PORT"))
.ok()
.and_then(|value| value.parse::<u16>().ok())
.unwrap_or(3306);
let username =
std::env::var(format!("DBX_LIVE_MYSQL_TRANSFER_{prefix}_USER")).unwrap_or_else(|_| "root".to_string());
let password = std::env::var(format!("DBX_LIVE_MYSQL_TRANSFER_{prefix}_PASSWORD"))
.unwrap_or_else(|_| panic!("DBX_LIVE_MYSQL_TRANSFER_{prefix}_PASSWORD"));
serde_json::from_value(json!({
"id": id,
"name": id,
"db_type": DatabaseType::Mysql,
"host": host,
"port": port,
"username": username,
"password": password,
"database": null,
"connect_timeout_secs": 10,
"query_timeout_secs": 30,
"idle_timeout_secs": 60,
"keepalive_interval_secs": 0
}))
.expect("live cross-version MySQL transfer config should deserialize")
}
fn mysql_url(config: &ConnectionConfig) -> String {
format!("mysql://{}:{}@{}:{}", config.username, config.password, config.host, config.port)
}
@@ -68,6 +97,183 @@ async fn query_text(pool: &mysql::MySqlPool, sql: &str) -> String {
mysql::execute_query(pool, sql, false).await.unwrap().rows[0][0].as_str().unwrap().to_string()
}
#[tokio::test]
#[ignore = "requires disposable MySQL 8 source and 5.7 target endpoints via DBX_LIVE_MYSQL_TRANSFER_SOURCE_*/TARGET_* variables"]
async fn live_mysql_transfer_downgrades_unsupported_source_collations() {
let suffix = uuid::Uuid::new_v4().simple().to_string();
let source_connection_id = format!("live-mysql8-transfer-{suffix}");
let target_connection_id = format!("live-mysql57-transfer-{suffix}");
let source_database = format!("dbx_6023_src_{}", &suffix[..12]);
let target_database = format!("dbx_6023_dst_{}", &suffix[..12]);
let modern_target_database = format!("dbx_6023_modern_{}", &suffix[..12]);
let source_config = live_cross_version_mysql_config(&source_connection_id, "SOURCE");
let target_config = live_cross_version_mysql_config(&target_connection_id, "TARGET");
let source_setup_pool = mysql::connect(&mysql_url(&source_config), Duration::from_secs(10)).await.unwrap();
let target_setup_pool = mysql::connect(&mysql_url(&target_config), Duration::from_secs(10)).await.unwrap();
mysql::execute_query(
&source_setup_pool,
&format!(
"CREATE DATABASE `{source_database}` CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;\
CREATE DATABASE `{modern_target_database}` CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;\
CREATE TABLE `{source_database}`.`transfer_probe` (\
id BIGINT NOT NULL AUTO_INCREMENT,\
code VARCHAR(64) COLLATE utf8mb4_0900_ai_ci NOT NULL DEFAULT 'x' COMMENT 'probe',\
legacy VARCHAR(64) COLLATE utf8mb4_unicode_ci NOT NULL,\
normalized VARCHAR(64) GENERATED ALWAYS AS (lower(code)) STORED,\
updated_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,\
PRIMARY KEY (id), UNIQUE KEY uk_code (code), KEY idx_legacy (legacy)\
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci COMMENT='issue 6023';\
INSERT INTO `{source_database}`.`transfer_probe` (code, legacy) VALUES ('AbC', 'legacy')"
),
true,
)
.await
.unwrap();
mysql::execute_query(
&target_setup_pool,
&format!("CREATE DATABASE `{target_database}` CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci"),
false,
)
.await
.unwrap();
let task_tmp = std::path::PathBuf::from(
std::env::var("DBX_LIVE_MYSQL_TRANSFER_TMP_DIR").expect("DBX_LIVE_MYSQL_TRANSFER_TMP_DIR"),
);
let dir = task_tmp.join(format!("live-mysql-collation-transfer-{suffix}"));
std::fs::create_dir_all(&dir).unwrap();
let storage = Storage::open(&dir.join("storage.db")).await.unwrap();
let state = AppState::new(storage);
state.configs.write().await.insert(source_connection_id.clone(), source_config);
state.configs.write().await.insert(target_connection_id.clone(), target_config);
let source_pool_key = state.get_or_create_pool(&source_connection_id, Some(&source_database)).await.unwrap();
let target_pool_key = state.get_or_create_pool(&target_connection_id, Some(&target_database)).await.unwrap();
let modern_target_pool_key =
state.get_or_create_pool(&source_connection_id, Some(&modern_target_database)).await.unwrap();
let request = TransferRequest {
transfer_id: format!("live-mysql-collation-transfer-{suffix}"),
source_connection_id,
source_database: source_database.clone(),
source_schema: source_database.clone(),
source_catalog: None,
target_connection_id,
target_database: target_database.clone(),
target_schema: target_database.clone(),
target_catalog: None,
tables: vec!["transfer_probe".to_string()],
create_table: true,
content: TransferContent::default(),
objects: Vec::new(),
mode: TransferMode::Append,
target_table_name_case: TransferTableNameCase::Preserve,
ownership_policy: TransferOwnershipPolicy::Preserve,
batch_size: 10,
};
let test_result = async {
let transferred = transfer_table(
&state,
&request,
"transfer_probe",
0,
&DatabaseType::Mysql,
&DatabaseType::Mysql,
&source_pool_key,
&target_pool_key,
|_| {},
)
.await?;
assert_eq!(transferred, 1);
let ddl_result = mysql::execute_query(
&target_setup_pool,
&format!("SHOW CREATE TABLE `{target_database}`.`transfer_probe`"),
false,
)
.await?;
let target_ddl = ddl_result.rows[0][1].as_str().unwrap();
assert!(!target_ddl.contains("utf8mb4_0900_ai_ci"), "ddl: {target_ddl}");
assert!(target_ddl.contains("COLLATE utf8mb4_unicode_ci"), "ddl: {target_ddl}");
assert!(target_ddl.contains("AUTO_INCREMENT"), "ddl: {target_ddl}");
assert!(target_ddl.contains("GENERATED ALWAYS AS"), "ddl: {target_ddl}");
assert!(target_ddl.contains("ON UPDATE CURRENT_TIMESTAMP"), "ddl: {target_ddl}");
assert!(target_ddl.contains("UNIQUE KEY `uk_code`"), "ddl: {target_ddl}");
assert!(target_ddl.contains("KEY `idx_legacy`"), "ddl: {target_ddl}");
assert!(target_ddl.contains("COMMENT='issue 6023'"), "ddl: {target_ddl}");
assert_eq!(
query_text(
&target_setup_pool,
&format!("SELECT CONCAT(code, ':', legacy, ':', normalized) FROM `{target_database}`.`transfer_probe`"),
)
.await,
"AbC:legacy:abc"
);
let modern_request = TransferRequest {
transfer_id: format!("live-mysql-modern-collation-transfer-{suffix}"),
source_connection_id: request.source_connection_id.clone(),
source_database: source_database.clone(),
source_schema: source_database.clone(),
source_catalog: None,
target_connection_id: request.source_connection_id.clone(),
target_database: modern_target_database.clone(),
target_schema: modern_target_database.clone(),
target_catalog: None,
tables: vec!["transfer_probe".to_string()],
create_table: true,
content: TransferContent::default(),
objects: Vec::new(),
mode: TransferMode::Append,
target_table_name_case: TransferTableNameCase::Preserve,
ownership_policy: TransferOwnershipPolicy::Preserve,
batch_size: 10,
};
assert_eq!(
transfer_table(
&state,
&modern_request,
"transfer_probe",
0,
&DatabaseType::Mysql,
&DatabaseType::Mysql,
&source_pool_key,
&modern_target_pool_key,
|_| {},
)
.await?,
1
);
let modern_ddl = mysql::execute_query(
&source_setup_pool,
&format!("SHOW CREATE TABLE `{modern_target_database}`.`transfer_probe`"),
false,
)
.await?
.rows[0][1]
.as_str()
.unwrap()
.to_string();
assert!(modern_ddl.contains("utf8mb4_0900_ai_ci"), "ddl: {modern_ddl}");
Ok::<_, String>(())
}
.await;
let source_cleanup = mysql::execute_query(
&source_setup_pool,
&format!("DROP DATABASE `{source_database}`; DROP DATABASE `{modern_target_database}`"),
true,
)
.await;
let target_cleanup =
mysql::execute_query(&target_setup_pool, &format!("DROP DATABASE `{target_database}`"), false).await;
source_setup_pool.disconnect().await.unwrap();
target_setup_pool.disconnect().await.unwrap();
let _ = std::fs::remove_dir_all(dir);
source_cleanup.unwrap();
target_cleanup.unwrap();
test_result.unwrap();
}
#[tokio::test]
#[ignore = "requires a disposable MySQL 5.7+ endpoint via DBX_LIVE_MYSQL_TRANSFER_* variables"]
async fn live_mysql_transfer_preserves_spatial_values_and_modes() {