From c7797b4be10da9d6fb939b0c16ea7dd2b9a915d7 Mon Sep 17 00:00:00 2001 From: dadong <102886401+mr-dadong@users.noreply.github.com> Date: Thu, 20 Aug 2026 09:28:29 +0800 Subject: [PATCH] feat(table): support openGauss object renaming --- .../table/objectSourceEditor.spec.ts | 14 +++++++- apps/desktop/src/lib/table/objectRenameSql.ts | 3 +- crates/dbx-core/src/db_admin_sql.rs | 32 +++++++++++++++++++ 3 files changed, 47 insertions(+), 2 deletions(-) diff --git a/apps/desktop/src/lib/__tests__/table/objectSourceEditor.spec.ts b/apps/desktop/src/lib/__tests__/table/objectSourceEditor.spec.ts index 957dfa1cc1..9b74def20a 100644 --- a/apps/desktop/src/lib/__tests__/table/objectSourceEditor.spec.ts +++ b/apps/desktop/src/lib/__tests__/table/objectSourceEditor.spec.ts @@ -1,6 +1,7 @@ import { beforeEach, describe, expect, it, vi } from "vitest"; import * as api from "@/lib/backend/api"; -import { executeObjectSourceSave, formatObjectSourceSaveError, resolveObjectSourceEditDraft } from "@/lib/table/objectSourceEditor"; +import { executeObjectSourceSave, formatObjectSourceSaveError, resolveObjectSourceEditDraft, supportsSourceBackedRoutineRename } from "@/lib/table/objectSourceEditor"; +import { supportsObjectRename } from "@/lib/table/objectRenameSql"; import { formatSqlForDisplay } from "@/lib/sql/sqlFormatter"; vi.mock("@/lib/backend/api", () => ({ @@ -13,6 +14,17 @@ beforeEach(() => { vi.clearAllMocks(); }); +describe("openGauss rename capabilities", () => { + it("keeps direct object renames without enabling source-backed routine rebuilds", () => { + expect(supportsObjectRename("opengauss", "TABLE")).toBe(true); + expect(supportsObjectRename("opengauss", "VIEW")).toBe(true); + expect(supportsObjectRename("opengauss", "MATERIALIZED_VIEW")).toBe(true); + expect(supportsSourceBackedRoutineRename("opengauss", "FUNCTION")).toBe(false); + expect(supportsSourceBackedRoutineRename("opengauss", "PROCEDURE")).toBe(false); + expect(supportsSourceBackedRoutineRename("postgres", "FUNCTION")).toBe(true); + }); +}); + describe("executeObjectSourceSave", () => { it("runs multi-statement Informix source saves in a transaction", async () => { await executeObjectSourceSave("conn-1", "stores", "informix", ["CREATE TEMP VIEW v AS SELECT 1", " ", "DROP VIEW v", "CREATE VIEW v AS SELECT 2"], "app"); diff --git a/apps/desktop/src/lib/table/objectRenameSql.ts b/apps/desktop/src/lib/table/objectRenameSql.ts index 60095d4060..c20fd4d87b 100644 --- a/apps/desktop/src/lib/table/objectRenameSql.ts +++ b/apps/desktop/src/lib/table/objectRenameSql.ts @@ -11,7 +11,8 @@ export interface BuildRenameObjectSqlOptions { newName: string; } -const postgresLikeRenameTypes = new Set(["postgres", "redshift", "gaussdb", "kwdb", "kingbase", "highgo", "uxdb", "vastbase"]); +// openGauss 兼容 PostgreSQL 的 ALTER TABLE/VIEW ... RENAME TO 语法,需与 gaussdb 等 PG 系数据库同等开放重命名能力 +const postgresLikeRenameTypes = new Set(["postgres", "redshift", "gaussdb", "kwdb", "opengauss", "kingbase", "highgo", "uxdb", "vastbase"]); const oracleLikeRenameTypes = new Set(["oracle", "dameng"]); diff --git a/crates/dbx-core/src/db_admin_sql.rs b/crates/dbx-core/src/db_admin_sql.rs index 053fbaeb85..3fb04d2172 100644 --- a/crates/dbx-core/src/db_admin_sql.rs +++ b/crates/dbx-core/src/db_admin_sql.rs @@ -816,12 +816,14 @@ pub fn build_rename_object_sql(options: RenameObjectSqlOptions) -> Result bool { + // openGauss 兼容 PG 的 ALTER TABLE/VIEW ... RENAME TO 语法,与 gaussdb 等同开放重命名能力。 matches!( database_type, DatabaseType::Postgres | DatabaseType::Redshift | DatabaseType::Gaussdb | DatabaseType::Kwdb + | DatabaseType::OpenGauss | DatabaseType::Kingbase | DatabaseType::Highgo | DatabaseType::Uxdb @@ -2040,6 +2042,36 @@ mod tests { ); } + #[test] + fn builds_opengauss_table_and_view_rename_sql() { + // openGauss 兼容 PG 重命名语法,与 gaussdb 等 PG 系数据库保持一致(右键“重命名”菜单入口)。 + assert!(supports_object_rename(Some(DatabaseType::OpenGauss), DatabaseObjectType::Table)); + assert!(supports_object_rename(Some(DatabaseType::OpenGauss), DatabaseObjectType::View)); + assert!(supports_object_rename(Some(DatabaseType::OpenGauss), DatabaseObjectType::MaterializedView)); + assert_eq!( + build_rename_object_sql(RenameObjectSqlOptions { + database_type: Some(DatabaseType::OpenGauss), + object_type: DatabaseObjectType::Table, + schema: Some("public".to_string()), + old_name: "orders".to_string(), + new_name: "archived orders".to_string(), + }) + .unwrap(), + "ALTER TABLE \"public\".\"orders\" RENAME TO \"archived orders\";" + ); + assert_eq!( + build_rename_object_sql(RenameObjectSqlOptions { + database_type: Some(DatabaseType::OpenGauss), + object_type: DatabaseObjectType::View, + schema: Some("public".to_string()), + old_name: "active_users".to_string(), + new_name: "enabled_users".to_string(), + }) + .unwrap(), + "ALTER VIEW \"public\".\"active_users\" RENAME TO \"enabled_users\";" + ); + } + #[test] fn builds_sqlserver_routine_rename_sql() { assert_eq!(