From c95e01e48cc14bbca7afaf268053c3a1e47937db Mon Sep 17 00:00:00 2001 From: vrustx <279631638@qq.com> Date: Sat, 30 May 2026 19:06:34 +0800 Subject: [PATCH] fix(sidebar): restore SQL Server object browser entry (#549) --- apps/desktop/src/lib/databaseFeatureSupport.ts | 2 +- packages/app-tests/databaseCapabilities.test.ts | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/desktop/src/lib/databaseFeatureSupport.ts b/apps/desktop/src/lib/databaseFeatureSupport.ts index 6a7f3e753d..4be10e89b0 100644 --- a/apps/desktop/src/lib/databaseFeatureSupport.ts +++ b/apps/desktop/src/lib/databaseFeatureSupport.ts @@ -74,7 +74,7 @@ export function supportsObjectBrowser(dbType?: DatabaseType): boolean { export function supportsObjectBrowserTreeNode(dbType: DatabaseType | undefined, nodeType: TreeNodeType): boolean { if (!supportsObjectBrowser(dbType)) return false; - if (nodeType === "database" && isSchemaAware(dbType)) return false; + if (nodeType === "database" && isSchemaAware(dbType) && dbType !== "sqlserver") return false; return nodeType === "database" || nodeType === "schema" || nodeType === "object-browser"; } diff --git a/packages/app-tests/databaseCapabilities.test.ts b/packages/app-tests/databaseCapabilities.test.ts index c466f2c366..dac6f8b743 100644 --- a/packages/app-tests/databaseCapabilities.test.ts +++ b/packages/app-tests/databaseCapabilities.test.ts @@ -204,9 +204,11 @@ test("describes feature support through capability helpers", () => { assert.equal(supportsTableTruncate("duckdb"), false); }); -test("schema-aware database nodes do not open an object browser tab", () => { +test("object browser entry follows database tree shape", () => { assert.equal(supportsObjectBrowserTreeNode("postgres", "database"), false); assert.equal(supportsObjectBrowserTreeNode("postgres", "schema"), true); + assert.equal(supportsObjectBrowserTreeNode("sqlserver", "database"), true); + assert.equal(supportsObjectBrowserTreeNode("sqlserver", "schema"), true); assert.equal(supportsObjectBrowserTreeNode("mysql", "database"), true); assert.equal(supportsObjectBrowserTreeNode("mongodb", "database"), false); });