feat(xugu): expose detailed trigger metadata

This commit is contained in:
Elias authored and GitHub committed 2026-08-11 03:33:17 +08:00
1 parent 5351fc5066
commit d0535f94d4
32 files changed
+618 -26

No files matched your search

@@ -49,7 +49,7 @@ import { Badge } from "@/components/ui/badge";
import { Input } from "@/components/ui/input";
import { Switch } from "@/components/ui/switch";
import LightTooltip from "@/components/ui/LightTooltip.vue";
import type { ColumnInfo, ConnectionConfig, DatabaseType, TreeNode } from "@/types/database";
import type { ColumnInfo, ConnectionConfig, DatabaseType, TreeNode, TriggerInfo } from "@/types/database";
import { alignedCommentLeadingWidth, canTreeNodePin, canTreeNodeShowExpander, sidebarTreeNodeComment, trailingCommentAvailableWidth, trailingCommentGapPx, treeItemPaddingLeft, treeLabelWidthClass, usesFullWidthTreeLabel } from "@/lib/sidebar/sidebarTreeItemLayout";
import { clearActiveTableReferencePayload, createTableReferencePayload, createTableReferenceDropEvent, setActiveTableReferencePayload, type QueryEditorTableReferencePayload } from "@/lib/editor/queryEditorTableDrop";
import { formatSidebarObjectStorage } from "@/lib/sidebar/sidebarDatabaseStorage";
@@ -451,6 +451,24 @@ const detailTooltip = computed(() => {
].filter((row) => row.value);
return { rows };
}
if (node.type === "trigger" && node.meta && node.connectionId && effectiveDatabaseTypeForConnection(connectionStore.getConfig(node.connectionId)) === "xugu") {
const trigger = node.meta as TriggerInfo;
const hasXuguDetails = trigger.level != null || trigger.condition != null || trigger.language != null || trigger.enabled != null || trigger.valid != null || trigger.created_at != null || trigger.comment != null;
if (!hasXuguDetails) return null;
const rows: DetailTooltipRow[] = [
{ label: t("objects.name"), value: visibleLabel(node) },
{ label: t("objects.triggerTiming"), value: cleanTooltipValue(trigger.timing) },
{ label: t("objects.triggerEvent"), value: cleanTooltipValue(trigger.event) },
{ label: t("objects.triggerLevel"), value: cleanTooltipValue(trigger.level) },
{ label: t("objects.triggerStatus"), value: trigger.enabled == null ? "" : t(trigger.enabled ? "objects.enabled" : "objects.disabled") },
{ label: t("objects.validity"), value: trigger.valid == null ? "" : t(trigger.valid ? "objects.valid" : "objects.invalid") },
{ label: t("objects.triggerCondition"), value: cleanTooltipValue(trigger.condition), multiline: true },
{ label: t("objects.triggerLanguage"), value: cleanTooltipValue(trigger.language) },
{ label: t("objects.createdAt"), value: cleanTooltipValue(trigger.created_at) },
{ label: t("objects.comment"), value: cleanTooltipValue(trigger.comment), multiline: true },
].filter((row) => row.value);
return rows.length ? { rows } : null;
}
const comment = node.type === "column" && node.meta && "comment" in node.meta ? (node.meta as ColumnInfo).comment : node.comment;
if (!comment || (node.type !== "schema" && node.type !== "table" && node.type !== "view" && node.type !== "column")) return null;
const rows: DetailTooltipRow[] = [
+11
View File
@@ -3061,6 +3061,17 @@ export default {
procedure: "Procedure",
function: "Function",
trigger: "Trigger",
triggerTiming: "Timing",
triggerEvent: "Event",
triggerLevel: "Level",
triggerStatus: "Status",
triggerCondition: "Condition",
triggerLanguage: "Language",
enabled: "Enabled",
disabled: "Disabled",
validity: "Validity",
valid: "Valid",
invalid: "Invalid",
sequence: "Sequence",
package: "Package",
packageBody: "Package Body",
+11
View File
@@ -2960,6 +2960,17 @@ export default withEnglishFallback({
trigger: "disparador",
typeDefinition: "definición de tipo",
typeBody: "cuerpo de tipo",
triggerTiming: "momento de activación",
triggerEvent: "evento de activación",
triggerLevel: "nivel de activación",
triggerStatus: "estado",
triggerCondition: "condición",
triggerLanguage: "idioma",
enabled: "habilitado",
disabled: "deshabilitado",
validity: "validez",
valid: "válido",
invalid: "inválido",
},
structureEditor: {
mysqlDataTypeHelp: {
+11
View File
@@ -2958,6 +2958,17 @@ export default withEnglishFallback({
trigger: "Trigger",
typeDefinition: "Definizione del tipo",
typeBody: "Corpo del tipo",
triggerTiming: "momento di attivazione",
triggerEvent: "evento trigger",
triggerLevel: "livello di attivazione",
triggerStatus: "stato",
triggerCondition: "condizione",
triggerLanguage: "lingua",
enabled: "abilitato",
disabled: "disabilitato",
validity: "validità",
valid: "valido",
invalid: "non valido",
},
structureEditor: {
mysqlDataTypeHelp: {
+11
View File
@@ -3020,6 +3020,17 @@ export default withEnglishFallback({
trigger: "トリガー",
typeDefinition: "タイプ",
typeBody: "タイプ本体",
triggerTiming: "トリガータイミング",
triggerEvent: "トリガーイベント",
triggerLevel: "トリガーレベル",
triggerStatus: "状態",
triggerCondition: "条件",
triggerLanguage: "言語",
enabled: "有効",
disabled: "無効",
validity: "有効性",
valid: "有効",
invalid: "無効",
},
structureEditor: {
mysqlDataTypeHelp: {
+11
View File
@@ -2960,6 +2960,17 @@ export default withEnglishFallback({
trigger: "Gatilho",
typeDefinition: "Definição de tipo",
typeBody: "Corpo do tipo",
triggerTiming: "Momento do gatilho",
triggerEvent: "Evento do gatilho",
triggerLevel: "Nível do gatilho",
triggerStatus: "Status",
triggerCondition: "Condição",
triggerLanguage: "Idioma",
enabled: "Habilitado",
disabled: "Desabilitado",
validity: "Validade",
valid: "Válido",
invalid: "Inválido",
},
structureEditor: {
mysqlDataTypeHelp: {
+11
View File
@@ -2985,6 +2985,17 @@ export default withEnglishFallback({
procedure: "存储过程",
function: "函数",
trigger: "触发器",
triggerTiming: "触发时机",
triggerEvent: "触发事件",
triggerLevel: "触发级别",
triggerStatus: "状态",
triggerCondition: "条件",
triggerLanguage: "语言",
enabled: "启用",
disabled: "禁用",
validity: "有效性",
valid: "有效",
invalid: "无效",
sequence: "序列",
package: "包",
packageBody: "包体",
+11
View File
@@ -2828,6 +2828,17 @@ export default withEnglishFallback({
trigger: "觸發器",
typeDefinition: "類型",
typeBody: "類型體",
triggerTiming: "觸發時機",
triggerEvent: "觸發事件",
triggerLevel: "觸發級別",
triggerStatus: "狀態",
triggerCondition: "條件",
triggerLanguage: "語言",
enabled: "啟用",
disabled: "停用",
validity: "有效性",
valid: "有效",
invalid: "無效",
},
structureEditor: {
mysqlDataTypeHelp: {
+31
View File
@@ -116,6 +116,37 @@ describe("programmable database objects", () => {
);
});
it("preserves Xugu trigger details for the schema trigger group", () => {
const trigger = {
name: "TRG_AUDIT",
event: "INSERT OR UPDATE",
timing: "BEFORE",
level: "FOR EACH ROW",
enabled: false,
valid: false,
condition: "NEW_VALUE >= 0",
language: "PL/SQL",
comment: "row audit trigger",
created_at: "2026-08-10 09:30:00",
};
const groups = buildGroupedObjectTreeNodes({
...context,
schema: "APP",
objects: [{ name: trigger.name, object_type: "TRIGGER", schema: "APP", valid: false, comment: trigger.comment, trigger }],
});
const triggerGroup = groups.find((node) => node.type === "group-triggers");
expect(triggerGroup?.children).toEqual([
expect.objectContaining({
type: "trigger",
objectName: trigger.name,
valid: false,
comment: trigger.comment,
meta: trigger,
}),
]);
});
it("groups Xugu private synonyms as source objects", () => {
const objects: ObjectInfo[] = [{ name: "SYN_SHOP_USERS", object_type: "SYNONYM", schema: "SYSDBA", valid: true }];
+2
View File
@@ -587,6 +587,7 @@ export function buildSimpleObjectTreeNodes({ nodeId, connectionId, database, sch
signature: signature || undefined,
comment: obj.comment,
valid: obj.valid ?? undefined,
meta: objectType === "TRIGGER" ? (obj.trigger ?? undefined) : undefined,
xuguTypeMembersExpandable: objectType === "TYPE" && obj.xugu_type_members_expandable === true,
connectionId,
database,
@@ -761,6 +762,7 @@ export function buildGroupedObjectTreeNodes({ nodeId, connectionId, database, sc
signature: signature || undefined,
comment: obj.comment,
valid: obj.valid ?? undefined,
meta: objectType === "TRIGGER" ? (obj.trigger ?? undefined) : undefined,
xuguTypeMembersExpandable: objectType === "TYPE" && obj.xugu_type_members_expandable === true,
connectionId,
database,
@@ -42,6 +42,7 @@ async function setup(dbType: ConnectionConfig["db_type"], overrides: Record<stri
listInstalledAgentsLocal: vi.fn().mockResolvedValue([{ db_type: "xugu", installed: true, installed_version: "0.1.23" }]),
listPartitions: vi.fn().mockResolvedValue([]),
listSubpartitions: vi.fn().mockResolvedValue([]),
listTriggers: vi.fn().mockResolvedValue([]),
loadSchemaCache: vi.fn().mockResolvedValue(null),
saveSchemaCache: vi.fn().mockResolvedValue(undefined),
saveConnections: vi.fn().mockResolvedValue(undefined),
@@ -159,4 +160,45 @@ describe("connectionStore Xugu table child metadata", () => {
expect(partitions.isExpanded).toBe(false);
expect(partitions.children).toEqual([]);
});
it("shows Xugu trigger level and status without changing other database labels", async () => {
const trigger = {
name: "TR_EVENTS_ROW",
timing: "BEFORE",
event: "INSERT",
level: "FOR EACH ROW",
enabled: false,
valid: false,
condition: "NEW_VALUE >= 0",
language: "PL/SQL",
comment: "row audit trigger",
created_at: "2026-08-10 09:30:00",
};
const xugu = await setup("xugu", { listTriggers: vi.fn().mockResolvedValue([trigger]) });
const xuguGroup = findNode(xugu.store.treeNodes, `${xugu.tableId}:__triggers`)!;
await xugu.store.loadTreeNodeChildren(xuguGroup);
expect(xugu.api.listTriggers).toHaveBeenCalledWith(xugu.config.id, "SHOP_DEMO", "SYSDBA", "SHOP_ORDERS", undefined);
expect(xuguGroup.children?.[0]).toMatchObject({
type: "trigger",
label: "TR_EVENTS_ROW (BEFORE · INSERT · FOR EACH ROW · Disabled · Invalid)",
valid: false,
comment: "row audit trigger",
meta: trigger,
});
vi.resetModules();
setActivePinia(createPinia());
const postgres = await setup("postgres", { listTriggers: vi.fn().mockResolvedValue([trigger]) });
const postgresGroup = findNode(postgres.store.treeNodes, `${postgres.tableId}:__triggers`)!;
await postgres.store.loadTreeNodeChildren(postgresGroup);
expect(postgresGroup.children?.[0]).toMatchObject({
type: "trigger",
label: "TR_EVENTS_ROW (BEFORE INSERT)",
meta: trigger,
});
expect(postgresGroup.children?.[0]?.valid).toBeUndefined();
expect(postgresGroup.children?.[0]?.comment).toBeUndefined();
});
});
+17 -11
View File
@@ -5162,19 +5162,25 @@ export const useConnectionStore = defineStore("connection", () => {
const triggers = await api.listTriggers(connectionId, database, querySchema, table, catalog);
const targetNode = treeNodeLoadTarget(load);
if (!targetNode) return;
const isXugu = effectiveDatabaseTypeForConnection(getConfig(connectionId)) === "xugu";
setChildren(
targetNode,
triggers.map((tr) => ({
id: `${parentId}:${tr.name}`,
label: `${tr.name} (${tr.timing} ${tr.event})`,
objectName: tr.name,
type: "trigger" as const,
connectionId,
database,
schema,
tableName: table,
meta: tr,
})),
triggers.map((tr) => {
const xuguDetails = isXugu ? [tr.timing, tr.event, tr.level, tr.enabled === false ? i18n.global.t("objects.disabled") : null, tr.valid === false ? i18n.global.t("objects.invalid") : null].filter(Boolean).join(" · ") : `${tr.timing} ${tr.event}`;
return {
id: `${parentId}:${tr.name}`,
label: `${tr.name} (${xuguDetails})`,
objectName: tr.name,
type: "trigger" as const,
connectionId,
database,
schema,
tableName: table,
comment: isXugu ? tr.comment : undefined,
valid: isXugu ? tr.valid : undefined,
meta: tr,
};
}),
);
targetNode.isExpanded = true;
} catch (e) {
+8
View File
@@ -434,6 +434,7 @@ export interface ObjectInfo {
updated_at?: string | null;
parent_schema?: string | null;
parent_name?: string | null;
trigger?: TriggerInfo | null;
xugu_type_members_expandable?: boolean | null;
}
@@ -503,6 +504,13 @@ export interface TriggerInfo {
name: string;
event: string;
timing: string;
level?: string | null;
condition?: string | null;
language?: string | null;
enabled?: boolean | null;
valid?: boolean | null;
comment?: string | null;
created_at?: string | null;
statement?: string | null;
}