fix(databricks): use backticks for generated identifiers

Closes #6915
This commit is contained in:
t8y2 committed 2026-08-22 02:18:10 +00:00
1 parent 5ca99c632b
commit d33161bb71
4 files changed
+33

No files matched your search

@@ -68,6 +68,12 @@ describe("quoteTableIdentifier", () => {
expect(quoteTableIdentifier("kyuubi", "order`items")).toBe("`order``items`"); expect(quoteTableIdentifier("kyuubi", "order`items")).toBe("`order``items`");
}); });
it("backtick-quotes Databricks identifiers", () => {
expect(quoteTableIdentifier("databricks", "order`items")).toBe("`order``items`");
expect(quoteTableDataIdentifier("databricks", "order`items")).toBe("`order``items`");
expect(qualifiedTableName({ databaseType: "databricks", schema: "sales", tableName: "ads_veeva_target_customer_df" })).toBe("`sales`.`ads_veeva_target_customer_df`");
});
it("uses BigQuery quoted identifiers and escape sequences", () => { it("uses BigQuery quoted identifiers and escape sequences", () => {
expect(quoteTableIdentifier("bigquery", "order")).toBe("`order`"); expect(quoteTableIdentifier("bigquery", "order")).toBe("`order`");
expect(quoteTableIdentifier("bigquery", "a`b")).toBe("`a\\`b`"); expect(quoteTableIdentifier("bigquery", "a`b")).toBe("`a\\`b`");
@@ -44,6 +44,7 @@ export function quoteTableIdentifier(databaseType: DatabaseType | undefined, nam
databaseType === "kyuubi" || databaseType === "kyuubi" ||
databaseType === "impala" || databaseType === "impala" ||
databaseType === "spark" || databaseType === "spark" ||
databaseType === "databricks" ||
databaseType === "databend" || databaseType === "databend" ||
databaseType === "tdengine" || databaseType === "tdengine" ||
databaseType === "access" || databaseType === "access" ||
@@ -132,6 +132,7 @@ pub fn quote_table_identifier(database_type: Option<DatabaseType>, name: &str) -
| DatabaseType::Kyuubi | DatabaseType::Kyuubi
| DatabaseType::Impala | DatabaseType::Impala
| DatabaseType::Spark | DatabaseType::Spark
| DatabaseType::Databricks
| DatabaseType::Databend | DatabaseType::Databend
| DatabaseType::Tdengine | DatabaseType::Tdengine
| DatabaseType::Access | DatabaseType::Access
@@ -708,6 +708,31 @@ mod tests {
} }
} }
#[test]
fn databricks_table_select_uses_backtick_identifiers() {
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(DatabaseType::Databricks),
schema: Some("sales".to_string()),
table_name: "ads_veeva_target_customer_df".to_string(),
limit: Some(100),
..Default::default()
}),
"SELECT * FROM `sales`.`ads_veeva_target_customer_df` LIMIT 100;"
);
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(DatabaseType::Databricks),
identifier_quote: Some("\"".to_string()),
schema: Some("sales`west".to_string()),
table_name: "ads`target".to_string(),
limit: Some(100),
..Default::default()
}),
"SELECT * FROM `sales``west`.`ads``target` LIMIT 100;"
);
}
#[test] #[test]
fn doris_external_catalog_prefixes_from_clause() { fn doris_external_catalog_prefixes_from_clause() {
let sql = let sql =