github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 22:53:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(query): keep Oracle NUM column results editable

Browse Source
This commit is contained in:
onenewcode authored and GitHub committed 2026-09-15 14:51:44 +08:00
1 parent 715d834c32
commit d79dc05cf5
5 files changed
+124 -9
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/lib/__tests__/sql/editableQueryHiddenKeys.spec.ts
Vendored
+14
View File
@@ -216,6 +216,20 @@ describe("editable query hidden primary keys", () => {
expect(analyzeEditableQueryEditability("select id from jobs union select id from archived_jobs")).toEqual({ editable: false, reason: "set-operation" });
});
it("keeps Oracle NUM columns and aliases mapped when result labels disagree", () => {
const named = analyzeEditableQueryEditability("select id, num from users");
expect(named.editable).toBe(true);
if (!named.editable) return;
expect(sourceColumnsForResult(named.analysis, ["ID", "NUM"], undefined, "oracle")).toEqual(["id", "num"]);
expect(sourceColumnsForResult(named.analysis, ["ID", "ROWNUM"], undefined, "oracle")).toEqual(["id", undefined]);
const aliased = analyzeEditableQueryEditability("select id, amount as num from users");
expect(aliased.editable).toBe(true);
if (!aliased.editable) return;
expect(sourceColumnsForResult(aliased.analysis, ["ID", "AMOUNT"], undefined, "oracle")).toEqual(["id", "amount"]);
expect(sourceColumnsForResult(aliased.analysis, ["ID", "NUM", "ROWNUM"], undefined, "oracle")).toEqual(["id", "amount", undefined]);
});
it("maps a qualified Oracle ROWID projection to the synthetic row key", () => {
const analysis: EditableQueryInfo = {
schema: "APP",