fix(connection): show built-in driver update hint on connection failure (#2111)

This commit is contained in:
zipg authored and GitHub committed 2026-06-30 01:52:37 +08:00
1 parent 96f265507d
commit dab1d145bc
6 files changed
+99 -28

No files matched your search

@@ -1,6 +1,6 @@
import assert from "node:assert/strict";
import { test } from "vitest";
import { showAgentDriverInstallHint } from "../../apps/desktop/src/lib/agentDriverInstallHint.ts";
import { appendAgentDriverUpdateHint, hasAgentDriverUpdate, showAgentDriverInstallHint } from "../../apps/desktop/src/lib/agentDriverInstallHint.ts";
test("hides the agent driver install hint when the selected driver is installed", () => {
assert.equal(showAgentDriverInstallHint("informix", [{ db_type: "informix", installed: true }]), false);
@@ -23,30 +23,9 @@ test("does not show agent driver install hints for built-in database types", ()
});
test("uses the unified Oracle driver for legacy Oracle profiles", () => {
assert.equal(
showAgentDriverInstallHint(
"oracle",
[{ db_type: "oracle", installed: false }],
"oracle-10g",
),
true,
);
assert.equal(
showAgentDriverInstallHint(
"oracle",
[{ db_type: "oracle", installed: true }],
"oracle",
),
false,
);
assert.equal(
showAgentDriverInstallHint(
"oracle",
[{ db_type: "oracle", installed: true }],
"oracle-legacy",
),
false,
);
assert.equal(showAgentDriverInstallHint("oracle", [{ db_type: "oracle", installed: false }], "oracle-10g"), true);
assert.equal(showAgentDriverInstallHint("oracle", [{ db_type: "oracle", installed: true }], "oracle"), false);
assert.equal(showAgentDriverInstallHint("oracle", [{ db_type: "oracle", installed: true }], "oracle-legacy"), false);
assert.equal(showAgentDriverInstallHint("oracle", [{ db_type: "oracle", installed: false }], "oracle"), true);
});
@@ -74,3 +53,31 @@ test("uses selected non-Oracle agent driver profiles for install hints", () => {
false,
);
});
test("detects available updates for the selected agent driver", () => {
assert.equal(hasAgentDriverUpdate("dameng", [{ db_type: "dameng", installed: true, update_available: true }], "dm"), true);
assert.equal(hasAgentDriverUpdate("dameng", [{ db_type: "dameng", installed: true, update_available: false }], "dm"), false);
assert.equal(hasAgentDriverUpdate("mysql", [{ db_type: "mysql", installed: true, update_available: true }]), false);
});
test("uses unified Oracle and selected profile keys for update hints", () => {
assert.equal(hasAgentDriverUpdate("oracle", [{ db_type: "oracle", installed: true, update_available: true }], "oracle-10g"), true);
assert.equal(
hasAgentDriverUpdate(
"gbase",
[
{ db_type: "gbase", installed: true, update_available: false },
{ db_type: "gbase8s", installed: true, update_available: true },
],
"gbase8s",
),
true,
);
});
test("appends agent driver update hints once", () => {
const hint = "Driver update available.";
assert.equal(appendAgentDriverUpdateHint("Original error", hint), "Original error\n\nDriver update available.");
assert.equal(appendAgentDriverUpdateHint("Original error\n\nDriver update available.", hint), "Original error\n\nDriver update available.");
assert.equal(appendAgentDriverUpdateHint("", hint), hint);
});