fix(grid): refresh comments for restored data tabs

This commit is contained in:
zipg authored and GitHub committed 2026-07-17 15:30:12 +08:00
1 parent f6ecd3c881
commit de25229cdc
3 files changed
+87 -54

No files matched your search

@@ -1,5 +1,5 @@
import { describe, expect, it } from "vitest";
import { canApplyDataTabMetadata, dataTabOpenModeFromTreeClick, findExistingDataTabCandidate } from "@/lib/sidebar/dataTabOpenPolicy";
import { canApplyDataTabMetadata, dataTabMetadataNeedsRefresh, dataTabOpenModeFromTreeClick, findExistingDataTabCandidate } from "@/lib/sidebar/dataTabOpenPolicy";
import type { QueryTab } from "@/types/database";
function click(modifiers: Partial<Pick<MouseEvent, "metaKey" | "ctrlKey" | "altKey" | "shiftKey">> = {}) {
@@ -88,4 +88,26 @@ describe("dataTabOpenPolicy", () => {
expect(canApplyDataTabMetadata(tab, usersTarget, new AbortController().signal)).toBe(false);
});
it("refreshes missing, restored, and expired table metadata", () => {
const now = 100_000;
const ttl = 30_000;
const tab = dataTab("users", "users");
expect(dataTabMetadataNeedsRefresh(tab, ttl, now)).toBe(true);
tab.tableMeta = {
schema: "public",
tableName: "users",
columns: [{ name: "id", data_type: "integer", is_nullable: false, column_default: null, is_primary_key: true, extra: null }],
primaryKeys: ["id"],
};
expect(dataTabMetadataNeedsRefresh(tab, ttl, now)).toBe(true);
tab.tableMetaUpdatedAt = now - ttl + 1;
expect(dataTabMetadataNeedsRefresh(tab, ttl, now)).toBe(false);
tab.tableMetaUpdatedAt = now - ttl;
expect(dataTabMetadataNeedsRefresh(tab, ttl, now)).toBe(true);
});
});
@@ -3,7 +3,7 @@ import type { QueryTab, TreeNodeType } from "@/types/database";
export type DataTabOpenMode = "default" | "new-tab";
type DataTabLike = Pick<QueryTab, "id" | "mode" | "connectionId" | "database" | "schema" | "title" | "tableMeta">;
type DataTabLike = Pick<QueryTab, "id" | "mode" | "connectionId" | "database" | "schema" | "title" | "tableMeta" | "tableMetaUpdatedAt">;
export interface DataTabTarget {
connectionId: string;
@@ -41,6 +41,11 @@ export function canApplyDataTabMetadata(tab: DataTabLike | undefined, target: Da
return signal?.aborted !== true && tab !== undefined && isSameTable(tab, target);
}
export function dataTabMetadataNeedsRefresh(tab: DataTabLike, maxAgeMs: number, now = Date.now()): boolean {
if (!tab.tableMeta?.columns.length || tab.tableMetaUpdatedAt === undefined) return true;
return now - tab.tableMetaUpdatedAt >= maxAgeMs;
}
export function findExistingDataTabCandidate<T extends DataTabLike>(tabs: T[], target: DataTabTarget, options: { openMode: DataTabOpenMode; reuseDataTab: boolean }): ExistingDataTabCandidate<T> | undefined {
if (options.openMode === "new-tab") return undefined;