From dee5bb2fd8961b6fa207c4ea36bbba3431ab4177 Mon Sep 17 00:00:00 2001 From: t8y2 <1156263951@qq.com> Date: Sun, 5 Jul 2026 21:10:25 +0800 Subject: [PATCH] fix(core): remove unused DuckDB isolation helper --- crates/dbx-core/src/connection.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/crates/dbx-core/src/connection.rs b/crates/dbx-core/src/connection.rs index 2668e24262..37c821a388 100644 --- a/crates/dbx-core/src/connection.rs +++ b/crates/dbx-core/src/connection.rs @@ -505,10 +505,6 @@ impl AppState { } } - fn duckdb_worker_process_isolation_enabled(&self) -> bool { - self.duckdb_worker_process_isolation.load(Ordering::Relaxed) - } - pub async fn test_external_driver(&self, driver_id: &str, config: &ConnectionConfig) -> Result { let params = serde_json::json!({ "connection": config }); let env = self.external_driver_runtime_env(driver_id)?; @@ -944,7 +940,7 @@ impl AppState { } #[cfg(feature = "duckdb-bundled")] DatabaseType::DuckDb => { - if self.duckdb_worker_process_isolation_enabled() { + if self.duckdb_worker_process_isolation.load(Ordering::Relaxed) { let attached_databases = db_config .attached_databases .iter() @@ -1770,7 +1766,7 @@ impl AppState { #[cfg(feature = "duckdb-bundled")] async fn remove_pool_if_duckdb_isolation_mismatch(&self, pool_key: &str) -> bool { - let isolation_enabled = self.duckdb_worker_process_isolation_enabled(); + let isolation_enabled = self.duckdb_worker_process_isolation.load(Ordering::Relaxed); let mismatch = { let connections = self.connections.read().await; match connections.get(pool_key) {