feat(sidebar): expose visible object filters in the connection tree

* feat(sidebar): expose visible object filter

* fix(sidebar): refine visible filter status

* refactor(sidebar): move visible filter status to details

* fix(sidebar): clarify visible filter action
This commit is contained in:
Guoyu Su authored and GitHub committed 2026-08-07 03:24:25 +08:00
1 parent cc5a4068d2
commit dfb9971849
26 files changed
+793 -9

No files matched your search

@@ -18,6 +18,7 @@ export interface SidebarTreeRuntimeHost {
handleRowClick(node: TreeNode, clickDetail: number): void;
handleRowDoubleClick(node: TreeNode, event: MouseEvent): void;
handleRowKeydown(node: TreeNode, event: KeyboardEvent): void;
openPrimaryVisibleFilter(node: TreeNode): void;
openDataInNewTab(node: TreeNode): void;
requestPaste(node: TreeNode): boolean;
toggleNode(node: TreeNode): void;
@@ -38,6 +39,7 @@ export interface SidebarTreeRuntime {
handleRowClick(node: TreeNode, clickDetail: number): void;
handleRowDoubleClick(node: TreeNode, event: MouseEvent): void;
handleRowKeydown(node: TreeNode, event: KeyboardEvent): void;
openPrimaryVisibleFilter(node: TreeNode): void;
openDataInNewTab(node: TreeNode): void;
requestPaste(node: TreeNode): boolean;
toggleNode(node: TreeNode): void;
@@ -97,6 +99,9 @@ export function createSidebarTreeRuntime(): SidebarTreeRuntime {
handleRowKeydown(node, event) {
currentHost()?.handleRowKeydown(node, event);
},
openPrimaryVisibleFilter(node) {
currentHost()?.openPrimaryVisibleFilter(node);
},
openDataInNewTab(node) {
currentHost()?.openDataInNewTab(node);
},
@@ -1,8 +1,21 @@
import type { DatabaseType } from "@/types/database";
import { connectionCanChooseVisibleDatabases } from "@/lib/connection/connectionVisibleDatabases";
const CATALOG_SCOPED_VISIBLE_DATABASE_TYPES = new Set<DatabaseType>(["doris", "starrocks"]);
export type SidebarVisibleFilterMenuEntry = {
label: "objects" | "schemas";
target: "visible-databases" | "visible-schemas";
};
export function connectionCanConfigureSidebarVisibleDatabases(databaseType: DatabaseType | undefined): boolean {
// Doris and StarRocks can expose the same database name in multiple catalogs,
// while `visible_databases` is still a flat name list. Keep the sidebar entry
// unavailable until the persisted selection can preserve catalog identity.
if (databaseType && CATALOG_SCOPED_VISIBLE_DATABASE_TYPES.has(databaseType)) return false;
return connectionCanChooseVisibleDatabases(databaseType ? { db_type: databaseType } : undefined);
}
export function sidebarConnectionVisibleFilterMenu(options: { canConfigureVisibleDatabases: boolean; canConfigureVisibleSchemas: boolean; databaseFilterUsesSchemas: boolean }): SidebarVisibleFilterMenuEntry[] {
if (!options.canConfigureVisibleDatabases) {
return options.canConfigureVisibleSchemas ? [{ label: "schemas", target: "visible-schemas" }] : [];
@@ -0,0 +1,42 @@
import type { ConnectionConfig } from "@/types/database";
import { connectionUsesVisibleSchemaFilter, filterDatabaseNamesForVisiblePicker, filterSchemaNamesForVisiblePicker, normalizeVisibleDatabaseSelection } from "@/lib/database/visibleDatabases";
type SidebarVisibleFilterConnection = Pick<ConnectionConfig, "database" | "db_type" | "driver_profile" | "show_system_schemas" | "username" | "visible_databases" | "visible_schemas">;
export type SidebarVisibleFilterSummary = {
mode: "database" | "schema";
isActive: boolean;
selected: number | null;
total: number | null;
};
export function connectionHasConfiguredSidebarVisibleFilter(connection: SidebarVisibleFilterConnection): boolean {
if (connectionUsesVisibleSchemaFilter(connection)) {
return Array.isArray(connection.visible_schemas?.[connection.database || ""]);
}
return Array.isArray(connection.visible_databases);
}
export function sidebarVisibleFilterSummary(connection: SidebarVisibleFilterConnection, objectNames?: readonly string[]): SidebarVisibleFilterSummary {
const mode = connectionUsesVisibleSchemaFilter(connection) ? "schema" : "database";
const configured = mode === "schema" ? connection.visible_schemas?.[connection.database || ""] : connection.visible_databases;
const isExplicit = Array.isArray(configured);
if (!objectNames) return { mode, isActive: false, selected: null, total: null };
const names = [...objectNames];
const defaultNames = mode === "schema" ? filterSchemaNamesForVisiblePicker(names, connection) : filterDatabaseNamesForVisiblePicker(names, connection);
if (!isExplicit) {
return { mode, isActive: false, selected: defaultNames.length, total: defaultNames.length };
}
const selectedNames = normalizeVisibleDatabaseSelection(configured, names);
const defaultNameSet = new Set(defaultNames);
const includesSystemObject = selectedNames.some((name) => !defaultNameSet.has(name));
const total = includesSystemObject ? names.length : defaultNames.length;
return {
mode,
isActive: selectedNames.length < total,
selected: selectedNames.length,
total,
};
}