feat(sidebar): expose visible object filters in the connection tree
* feat(sidebar): expose visible object filter * fix(sidebar): refine visible filter status * refactor(sidebar): move visible filter status to details * fix(sidebar): clarify visible filter action
This commit is contained in:
1 parent
cc5a4068d2
commit
dfb9971849
26 files changed
+793
-9
No files matched your search
@@ -0,0 +1,127 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { test } from "vitest";
|
||||
import type { ConnectionConfig } from "../../apps/desktop/src/types/database.ts";
|
||||
import { connectionHasConfiguredSidebarVisibleFilter, sidebarVisibleFilterSummary } from "../../apps/desktop/src/lib/sidebar/sidebarVisibleFilterSummary.ts";
|
||||
|
||||
function connection(overrides: Partial<ConnectionConfig> = {}): ConnectionConfig {
|
||||
return {
|
||||
id: "connection-1",
|
||||
name: "Connection",
|
||||
db_type: "mysql",
|
||||
host: "localhost",
|
||||
port: 3306,
|
||||
username: "root",
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
test("summary remains inactive before primary namespace metadata is loaded", () => {
|
||||
assert.deepEqual(sidebarVisibleFilterSummary(connection({ visible_databases: ["app"] })), {
|
||||
mode: "database",
|
||||
isActive: false,
|
||||
selected: null,
|
||||
total: null,
|
||||
});
|
||||
});
|
||||
|
||||
test("configured filter detection follows the connection's primary namespace mode", () => {
|
||||
assert.equal(connectionHasConfiguredSidebarVisibleFilter(connection()), false);
|
||||
assert.equal(connectionHasConfiguredSidebarVisibleFilter(connection({ visible_databases: [] })), true);
|
||||
assert.equal(
|
||||
connectionHasConfiguredSidebarVisibleFilter(
|
||||
connection({
|
||||
db_type: "oracle",
|
||||
database: "ORCL",
|
||||
visible_databases: ["ignored-for-schema-mode"],
|
||||
visible_schemas: { ORCL: ["APP"] },
|
||||
}),
|
||||
),
|
||||
true,
|
||||
);
|
||||
assert.equal(
|
||||
connectionHasConfiguredSidebarVisibleFilter(
|
||||
connection({
|
||||
db_type: "oracle",
|
||||
database: "ORCL",
|
||||
visible_databases: ["ignored-for-schema-mode"],
|
||||
}),
|
||||
),
|
||||
false,
|
||||
);
|
||||
});
|
||||
|
||||
test("unfiltered database summary uses the picker's default non-system scope", () => {
|
||||
assert.deepEqual(sidebarVisibleFilterSummary(connection(), ["app", "analytics", "mysql", "sys"]), {
|
||||
mode: "database",
|
||||
isActive: false,
|
||||
selected: 2,
|
||||
total: 2,
|
||||
});
|
||||
});
|
||||
|
||||
test("explicit full database selection returns to the inactive visual state", () => {
|
||||
assert.deepEqual(sidebarVisibleFilterSummary(connection({ visible_databases: ["app", "analytics"] }), ["app", "analytics", "mysql", "sys"]), {
|
||||
mode: "database",
|
||||
isActive: false,
|
||||
selected: 2,
|
||||
total: 2,
|
||||
});
|
||||
});
|
||||
|
||||
test("explicit database summary ignores stale names and retains the default denominator", () => {
|
||||
assert.deepEqual(sidebarVisibleFilterSummary(connection({ visible_databases: ["app", "removed"] }), ["app", "analytics", "mysql"]), {
|
||||
mode: "database",
|
||||
isActive: true,
|
||||
selected: 1,
|
||||
total: 2,
|
||||
});
|
||||
});
|
||||
|
||||
test("selecting a system database expands the denominator like the picker", () => {
|
||||
assert.deepEqual(sidebarVisibleFilterSummary(connection({ visible_databases: ["app", "mysql"] }), ["app", "analytics", "mysql", "sys"]), {
|
||||
mode: "database",
|
||||
isActive: true,
|
||||
selected: 2,
|
||||
total: 4,
|
||||
});
|
||||
});
|
||||
|
||||
test("schema-mode summary reads the primary schema filter for the configured database", () => {
|
||||
assert.deepEqual(
|
||||
sidebarVisibleFilterSummary(
|
||||
connection({
|
||||
db_type: "oracle",
|
||||
database: "ORCL",
|
||||
username: "APP",
|
||||
visible_schemas: { ORCL: ["APP"] },
|
||||
}),
|
||||
["APP", "REPORTING", "SYS"],
|
||||
),
|
||||
{
|
||||
mode: "schema",
|
||||
isActive: true,
|
||||
selected: 1,
|
||||
total: 2,
|
||||
},
|
||||
);
|
||||
});
|
||||
|
||||
test("schema-mode summary includes system schemas when they are explicitly selected", () => {
|
||||
assert.deepEqual(
|
||||
sidebarVisibleFilterSummary(
|
||||
connection({
|
||||
db_type: "oracle",
|
||||
database: "ORCL",
|
||||
username: "APP",
|
||||
visible_schemas: { ORCL: ["APP", "SYS"] },
|
||||
}),
|
||||
["APP", "REPORTING", "SYS"],
|
||||
),
|
||||
{
|
||||
mode: "schema",
|
||||
isActive: true,
|
||||
selected: 2,
|
||||
total: 3,
|
||||
},
|
||||
);
|
||||
});
|
||||
Reference in new issue
Block a user