feat(saved-sql): run queries in the current database

This commit is contained in:
zhangyc authored and GitHub committed 2026-07-31 01:57:39 +08:00
1 parent 4062f11a26
commit e2ba75b102
22 files changed
+501 -51

No files matched your search

@@ -21,6 +21,7 @@ function makeSettings(overrides: Partial<EditorSettings> = {}): EditorSettings {
confirmDangerousSqlExecution: true,
continueOnErrorOnBatch: false,
confirmUnsavedSqlClose: true,
savedSqlOpenTargetMode: "saved",
objectBrowserViewMode: "list",
sqlVariableSyntaxOverrides: {},
tabLayout: "scroll",
@@ -36,6 +37,10 @@ describe("EDITOR_SETTINGS_DRAFT_KEYS", () => {
it("includes the table-open page size", () => {
expect(EDITOR_SETTINGS_DRAFT_KEYS).toContain("tableOpenPageSize");
});
it("includes the saved SQL open target mode", () => {
expect(EDITOR_SETTINGS_DRAFT_KEYS).toContain("savedSqlOpenTargetMode");
});
});
describe("editorSettingsDraftFromSettings", () => {
@@ -54,6 +59,10 @@ describe("editorSettingsDraftFromSettings", () => {
delete (settings as Partial<EditorSettings>).tableOpenPageSize;
expect(editorSettingsDraftFromSettings(settings).tableOpenPageSize).toBe(100);
});
it("maps the saved SQL open target mode", () => {
expect(editorSettingsDraftFromSettings(makeSettings({ savedSqlOpenTargetMode: "current" })).savedSqlOpenTargetMode).toBe("current");
});
});
describe("normalizeTableOpenPageSizeDraft", () => {
@@ -94,6 +103,14 @@ describe("editorSettingsDraftChanged", () => {
draft.tableOpenPageSize = Number.NaN;
expect(editorSettingsDraftChanged(draft, base)).toBe(false);
});
it("detects a saved SQL open target change", () => {
const settings = makeSettings({ savedSqlOpenTargetMode: "saved" });
const draft = editorSettingsDraftFromSettings(settings);
const base = editorSettingsDraftFromSettings(settings);
draft.savedSqlOpenTargetMode = "current";
expect(editorSettingsDraftChanged(draft, base)).toBe(true);
});
});
describe("editorSettingsPatchFromDraft", () => {
@@ -121,6 +138,14 @@ describe("editorSettingsPatchFromDraft", () => {
draft.tableOpenPageSize = 200000.9;
expect(editorSettingsPatchFromDraft(draft, base).tableOpenPageSize).toBe(100000);
});
it("includes the saved SQL open target when changed", () => {
const settings = makeSettings({ savedSqlOpenTargetMode: "saved" });
const draft = editorSettingsDraftFromSettings(settings);
const base = editorSettingsDraftFromSettings(settings);
draft.savedSqlOpenTargetMode = "current";
expect(editorSettingsPatchFromDraft(draft, base).savedSqlOpenTargetMode).toBe("current");
});
});
describe("EDITOR_SETTINGS_DRAFT_KEYS - tabLayout", () => {
@@ -23,6 +23,7 @@ export const EDITOR_SETTINGS_DRAFT_KEYS = [
"sqlSemanticDiagnosticsMode",
"confirmDangerousSqlExecution",
"confirmUnsavedSqlClose",
"savedSqlOpenTargetMode",
"appLayout",
"tabLayout",
"showColumnCommentsInHeader",