fix(xugu): align capability flags with implemented features
This commit is contained in:
1 parent
8cc3e91e65
commit
e6c7baa2d9
4 files changed
+41
-7
No files matched your search
@@ -1,7 +1,32 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { databaseConnectionFormKind, databaseDefaultPort, databaseManifestEntry, databaseRuntimeMode, usesAgentCursorForQuery, usesAgentCursorForTableData } from "@/lib/database/databaseDriverManifest";
|
||||
import { databaseConnectionFormKind, databaseDefaultPort, databaseManifestEntry, databaseProductCapabilities, databaseRuntimeMode, supportsDatabaseFeature, usesAgentCursorForQuery, usesAgentCursorForTableData } from "@/lib/database/databaseDriverManifest";
|
||||
|
||||
describe("databaseDriverManifest", () => {
|
||||
it("advertises implemented Xugu capabilities without enabling unsupported features", () => {
|
||||
expect(databaseProductCapabilities("xugu")).toEqual({
|
||||
queryExecution: true,
|
||||
metadataBrowse: true,
|
||||
objectBrowser: true,
|
||||
objectSource: true,
|
||||
schemaSearch: true,
|
||||
diagram: true,
|
||||
tableDataEdit: true,
|
||||
tableStructureEdit: true,
|
||||
tableImport: true,
|
||||
dataTransfer: false,
|
||||
sqlFileExecution: true,
|
||||
databaseCreate: false,
|
||||
fieldLineage: false,
|
||||
sqlExplain: false,
|
||||
userAdmin: true,
|
||||
driverManagement: true,
|
||||
});
|
||||
for (const capability of ["objectSource", "tableDataEdit", "userAdmin"] as const) {
|
||||
expect(supportsDatabaseFeature("xugu", capability), capability).toBe(true);
|
||||
}
|
||||
expect(supportsDatabaseFeature("xugu", "sqlExplain")).toBe(false);
|
||||
});
|
||||
|
||||
it("uses agent cursor only for agent or external runtimes", () => {
|
||||
expect(databaseRuntimeMode("gaussdb")).toBe("native");
|
||||
expect(databaseRuntimeMode("meilisearch")).toBe("native");
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { supportsDatabaseFeature } from "@/lib/database/databaseDriverManifest";
|
||||
import {
|
||||
dorisGrantPrivilegesSql,
|
||||
dorisGrantsResult,
|
||||
@@ -15,6 +16,7 @@ import {
|
||||
postgresUserAdminProvider,
|
||||
resolveDatabaseUserAdminProviderForConnection,
|
||||
starrocksTableGrantsResult,
|
||||
supportsDatabaseUserAdmin,
|
||||
} from "@/lib/database/databaseUserAdmin";
|
||||
import type { ConnectionConfig, QueryResult } from "@/types/database";
|
||||
|
||||
@@ -84,6 +86,13 @@ describe("MySQL grant privilege selection", () => {
|
||||
});
|
||||
|
||||
describe("database user admin providers", () => {
|
||||
it("keeps Xugu on its dedicated permission surface despite the product capability", () => {
|
||||
expect(supportsDatabaseFeature("xugu", "userAdmin")).toBe(true);
|
||||
expect(supportsDatabaseUserAdmin("xugu")).toBe(false);
|
||||
expect(getDatabaseUserAdminProvider("xugu")).toBeNull();
|
||||
expect(resolveDatabaseUserAdminProviderForConnection(connection("xugu"))).toBeNull();
|
||||
});
|
||||
|
||||
it("opts only native MySQL connections into account Host changes", () => {
|
||||
const legacyNative = resolveDatabaseUserAdminProviderForConnection(connection("mysql"));
|
||||
const blankLegacyNative = resolveDatabaseUserAdminProviderForConnection(connection("mysql", " "));
|
||||
|
||||
Reference in new issue
Block a user