fix(xugu): align capability flags with implemented features

This commit is contained in:
Elias authored and GitHub committed 2026-10-01 15:22:04 +08:00
1 parent 8cc3e91e65
commit e6c7baa2d9
4 files changed
+41 -7

No files matched your search

@@ -1,7 +1,32 @@
import { describe, expect, it } from "vitest"; import { describe, expect, it } from "vitest";
import { databaseConnectionFormKind, databaseDefaultPort, databaseManifestEntry, databaseRuntimeMode, usesAgentCursorForQuery, usesAgentCursorForTableData } from "@/lib/database/databaseDriverManifest"; import { databaseConnectionFormKind, databaseDefaultPort, databaseManifestEntry, databaseProductCapabilities, databaseRuntimeMode, supportsDatabaseFeature, usesAgentCursorForQuery, usesAgentCursorForTableData } from "@/lib/database/databaseDriverManifest";
describe("databaseDriverManifest", () => { describe("databaseDriverManifest", () => {
it("advertises implemented Xugu capabilities without enabling unsupported features", () => {
expect(databaseProductCapabilities("xugu")).toEqual({
queryExecution: true,
metadataBrowse: true,
objectBrowser: true,
objectSource: true,
schemaSearch: true,
diagram: true,
tableDataEdit: true,
tableStructureEdit: true,
tableImport: true,
dataTransfer: false,
sqlFileExecution: true,
databaseCreate: false,
fieldLineage: false,
sqlExplain: false,
userAdmin: true,
driverManagement: true,
});
for (const capability of ["objectSource", "tableDataEdit", "userAdmin"] as const) {
expect(supportsDatabaseFeature("xugu", capability), capability).toBe(true);
}
expect(supportsDatabaseFeature("xugu", "sqlExplain")).toBe(false);
});
it("uses agent cursor only for agent or external runtimes", () => { it("uses agent cursor only for agent or external runtimes", () => {
expect(databaseRuntimeMode("gaussdb")).toBe("native"); expect(databaseRuntimeMode("gaussdb")).toBe("native");
expect(databaseRuntimeMode("meilisearch")).toBe("native"); expect(databaseRuntimeMode("meilisearch")).toBe("native");
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vitest"; import { describe, expect, it } from "vitest";
import { supportsDatabaseFeature } from "@/lib/database/databaseDriverManifest";
import { import {
dorisGrantPrivilegesSql, dorisGrantPrivilegesSql,
dorisGrantsResult, dorisGrantsResult,
@@ -15,6 +16,7 @@ import {
postgresUserAdminProvider, postgresUserAdminProvider,
resolveDatabaseUserAdminProviderForConnection, resolveDatabaseUserAdminProviderForConnection,
starrocksTableGrantsResult, starrocksTableGrantsResult,
supportsDatabaseUserAdmin,
} from "@/lib/database/databaseUserAdmin"; } from "@/lib/database/databaseUserAdmin";
import type { ConnectionConfig, QueryResult } from "@/types/database"; import type { ConnectionConfig, QueryResult } from "@/types/database";
@@ -84,6 +86,13 @@ describe("MySQL grant privilege selection", () => {
}); });
describe("database user admin providers", () => { describe("database user admin providers", () => {
it("keeps Xugu on its dedicated permission surface despite the product capability", () => {
expect(supportsDatabaseFeature("xugu", "userAdmin")).toBe(true);
expect(supportsDatabaseUserAdmin("xugu")).toBe(false);
expect(getDatabaseUserAdminProvider("xugu")).toBeNull();
expect(resolveDatabaseUserAdminProviderForConnection(connection("xugu"))).toBeNull();
});
it("opts only native MySQL connections into account Host changes", () => { it("opts only native MySQL connections into account Host changes", () => {
const legacyNative = resolveDatabaseUserAdminProviderForConnection(connection("mysql")); const legacyNative = resolveDatabaseUserAdminProviderForConnection(connection("mysql"));
const blankLegacyNative = resolveDatabaseUserAdminProviderForConnection(connection("mysql", " ")); const blankLegacyNative = resolveDatabaseUserAdminProviderForConnection(connection("mysql", " "));
@@ -2496,10 +2496,10 @@
"queryExecution": true, "queryExecution": true,
"metadataBrowse": true, "metadataBrowse": true,
"objectBrowser": true, "objectBrowser": true,
"objectSource": false, "objectSource": true,
"schemaSearch": true, "schemaSearch": true,
"diagram": true, "diagram": true,
"tableDataEdit": false, "tableDataEdit": true,
"tableStructureEdit": true, "tableStructureEdit": true,
"tableImport": true, "tableImport": true,
"dataTransfer": false, "dataTransfer": false,
@@ -2507,7 +2507,7 @@
"databaseCreate": false, "databaseCreate": false,
"fieldLineage": false, "fieldLineage": false,
"sqlExplain": false, "sqlExplain": false,
"userAdmin": false, "userAdmin": true,
"driverManagement": true "driverManagement": true
} }
}, },
+3 -3
View File
@@ -21,10 +21,10 @@ capabilities:
queryExecution: true queryExecution: true
metadataBrowse: true metadataBrowse: true
objectBrowser: true objectBrowser: true
objectSource: false objectSource: true
schemaSearch: true schemaSearch: true
diagram: true diagram: true
tableDataEdit: false tableDataEdit: true
tableStructureEdit: true tableStructureEdit: true
tableImport: true tableImport: true
dataTransfer: false dataTransfer: false
@@ -32,5 +32,5 @@ capabilities:
databaseCreate: false databaseCreate: false
fieldLineage: false fieldLineage: false
sqlExplain: false sqlExplain: false
userAdmin: false userAdmin: true
driverManagement: true driverManagement: true