fix(sql): remember external file data sources

Closes #5234

apps/desktop/src/lib/__tests__/sql/externalSqlFileTarget.spec.ts

@@ -0,0 +1,52 @@
+// @vitest-environment happy-dom
+
+import { beforeEach, describe, expect, it } from "vitest";
+import { EXTERNAL_SQL_FILE_TARGETS_STORAGE_KEY, MAX_EXTERNAL_SQL_FILE_TARGETS, rememberExternalSqlFileTarget, resolveExternalSqlFileTarget } from "@/lib/sql/externalSqlFileTarget";
+
+describe("external SQL file targets", () => {
+  beforeEach(() => {
+    localStorage.clear();
+  });
+
+  it("restores the saved data source across normalized file paths", () => {
+    rememberExternalSqlFileTarget(" C:\\work\\report.sql ", { connectionId: "saved-connection", database: "analytics" });
+
+    expect(resolveExternalSqlFileTarget("C:/work/report.sql", () => true, { connectionId: "fallback", database: "default" })).toEqual({
+      connectionId: "saved-connection",
+      database: "analytics",
+    });
+  });
+
+  it("falls back when the saved connection no longer exists", () => {
+    rememberExternalSqlFileTarget("/work/report.sql", { connectionId: "deleted-connection", database: "analytics" });
+
+    expect(resolveExternalSqlFileTarget("/work/report.sql", () => false, { connectionId: "fallback", database: "default" })).toEqual({
+      connectionId: "fallback",
+      database: "default",
+    });
+  });
+
+  it("ignores malformed persisted state", () => {
+    localStorage.setItem(EXTERNAL_SQL_FILE_TARGETS_STORAGE_KEY, "not-json");
+
+    expect(resolveExternalSqlFileTarget("/work/report.sql", () => true, { connectionId: "fallback", database: "default" })).toEqual({
+      connectionId: "fallback",
+      database: "default",
+    });
+  });
+
+  it("keeps only the most recently saved targets", () => {
+    for (let index = 0; index <= MAX_EXTERNAL_SQL_FILE_TARGETS; index += 1) {
+      rememberExternalSqlFileTarget(`/work/report-${index}.sql`, { connectionId: `connection-${index}`, database: `database-${index}` });
+    }
+
+    expect(resolveExternalSqlFileTarget("/work/report-0.sql", () => true, { connectionId: "fallback", database: "default" })).toEqual({
+      connectionId: "fallback",
+      database: "default",
+    });
+    expect(resolveExternalSqlFileTarget(`/work/report-${MAX_EXTERNAL_SQL_FILE_TARGETS}.sql`, () => true, { connectionId: "fallback", database: "default" })).toEqual({
+      connectionId: `connection-${MAX_EXTERNAL_SQL_FILE_TARGETS}`,
+      database: `database-${MAX_EXTERNAL_SQL_FILE_TARGETS}`,
+    });
+  });
+});

apps/desktop/src/lib/sql/externalSqlFileTarget.ts

@@ -0,0 +1,48 @@
+import { normalizeExternalSqlPath } from "@/lib/sql/sqlFileOpen";
+
+export const EXTERNAL_SQL_FILE_TARGETS_STORAGE_KEY = "dbx-external-sql-file-targets-v1";
+export const MAX_EXTERNAL_SQL_FILE_TARGETS = 200;
+
+export interface ExternalSqlFileTarget {
+  connectionId: string;
+  database: string;
+}
+
+interface StoredExternalSqlFileTarget extends ExternalSqlFileTarget {
+  path: string;
+  updatedAt: number;
+}
+
+function loadExternalSqlFileTargets(): StoredExternalSqlFileTarget[] {
+  try {
+    const parsed = JSON.parse(localStorage.getItem(EXTERNAL_SQL_FILE_TARGETS_STORAGE_KEY) || "[]");
+    if (!Array.isArray(parsed)) return [];
+    return parsed.filter((item): item is StoredExternalSqlFileTarget => typeof item?.path === "string" && typeof item?.connectionId === "string" && typeof item?.database === "string" && typeof item?.updatedAt === "number");
+  } catch {
+    return [];
+  }
+}
+
+function saveExternalSqlFileTargets(targets: StoredExternalSqlFileTarget[]) {
+  try {
+    localStorage.setItem(EXTERNAL_SQL_FILE_TARGETS_STORAGE_KEY, JSON.stringify(targets));
+  } catch {}
+}
+
+export function rememberExternalSqlFileTarget(path: string, target: ExternalSqlFileTarget) {
+  const normalizedPath = normalizeExternalSqlPath(path);
+  if (!normalizedPath) return;
+  const remaining = loadExternalSqlFileTargets().filter((item) => item.path !== normalizedPath);
+  if (!target.connectionId) {
+    saveExternalSqlFileTargets(remaining);
+    return;
+  }
+  saveExternalSqlFileTargets([{ path: normalizedPath, ...target, updatedAt: Date.now() }, ...remaining].slice(0, MAX_EXTERNAL_SQL_FILE_TARGETS));
+}
+
+export function resolveExternalSqlFileTarget(path: string, connectionExists: (connectionId: string) => boolean, fallback: ExternalSqlFileTarget): ExternalSqlFileTarget {
+  const normalizedPath = normalizeExternalSqlPath(path);
+  const saved = loadExternalSqlFileTargets().find((item) => item.path === normalizedPath);
+  if (!saved || !connectionExists(saved.connectionId)) return fallback;
+  return { connectionId: saved.connectionId, database: saved.database };
+}