feat(docs): database documentation viewer and DBML export
* feat(docs): add SchemaSnapshot model * feat(docs): infer relationship cardinality from foreign keys * fix(docs): resolve foreign keys within the source schema * feat(docs): convert group hue to sRGB hex for DBML * feat(docs): add DBML lexical primitives * feat(docs): render DBML table blocks * feat(docs): render DBML refs, enums and table groups * feat(docs): assemble complete DBML documents * feat(docs): collect schema snapshots with bounded fan-out * fix(docs): gate FK warning on engine capability and reference synthesized enums * fix(docs): qualify synthesized enum references in multi-schema output * test(docs): anchor the multi-schema enum reference assertion * feat(docs): add snapshot collection route * feat(docs): add collect_docs_snapshot to DbxBackend * feat(docs): add dbx dbml command * test(docs): add live snapshot and DBML verification Runs collect_snapshot + to_dbml against a real PostgreSQL database (organon, 47 tables) and asserts structural DBML validity: Project header, every table present, balanced braces, trailing newline. * refactor(docs): use sort_by_key for snapshot table ordering * docs(docs): add database documentation design and implementation plan Records the Part 1 design (SchemaSnapshot + DBML export) and the plan that produced it. The plan carries an appendix listing the thirteen assumptions that proved wrong during execution, so the corrected facts are not re-derived from the surrounding prose. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKcC15gEuQBHMidPCFFYwn * fix(docs): use native enum names, canonical engine labels, and surface metadata failures Final review fix wave covering four findings: - PostgreSQL named enums (e.g. `ConversationStatus`) now keep their own type name and synthesized: false, instead of being renamed to `{table}_{column}` and losing identity. A type shared by several columns now dedupes to a single Enum block instead of colliding or duplicating. `synthesize_enum` and `render_type` route through one shared `enum_type_name` helper so the two can't drift apart again. - `database_type` (and the CommentsUnsupported/NoForeignKeyMetadata warnings) now use the same canonical engine label already used throughout table_structure_sql's own warning prose, instead of a raw Rust Debug string (`Postgres`, `SqlServer`, `MongoDb`). - An index-fetch failure during collection now surfaces as a TableSkipped warning instead of silently degrading to an empty index list, which relations.rs uses to infer relationship cardinality. - A schema-enumeration failure now surfaces as a warning instead of silently proceeding against schema "". - Removed the redundant Arc<Semaphore>; buffer_unordered already caps concurrency at MAX_CONCURRENT_TABLES. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKcC15gEuQBHMidPCFFYwn * feat(docs): add annotation file model * test(docs): assert full round-trip fidelity for the annotation model * feat(docs): add per-engine annotation key folding * fix(docs): do not fold identifiers on case-sensitive engines * feat(docs): load and validate the notes file * fix(docs): report a version mismatch before unknown-field errors * feat(docs): merge annotations into the schema snapshot * feat(docs): detect orphaned annotations without deleting them * feat(docs): add --notes to dbx dbml * feat(docs): remember a notes file path per connection Adds docs_notes_path to ConnectionConfig so the desktop app (Part 3) can persist where a connection's documentation notes file lives. The CLI is unaffected — it takes an explicit --notes path. ConnectionConfig has a hand-written Deserialize impl that delegates to a mirror struct, ConnectionConfigData, and converts via From. Adding the field only to ConnectionConfig would compile but never populate from stored JSON, since ConnectionConfigData's fields are what serde actually reads. The field is threaded through all three places: ConnectionConfig, ConnectionConfigData, and the From impl, mirroring the existing `color` field. * test(docs): verify annotations against a live database * test(docs): assert exactly one orphaned annotation * feat(docs): add snapshot types for the docs viewer * fix(docs): correct snapshot type nullability and add missing column fields * feat(docs): add a real-output fixture and drift conformance test The fixture is generated by dump_docs_fixture.rs from a live collect_snapshot run against the keycloak database in the shared local-infra stack, with annotations applied so a LOCAL note, column note, group and orphanedNotes warning are all present. fixtureConformance.spec.ts asserts against that real JSON rather than a hand-written literal, so a change to the Rust snapshot shape breaks the test instead of silently drifting from the hand-maintained types.ts. Keycloak is used because its schema is public open-source knowledge, so the committed fixture carries no private schema. The kept tables are an explicit allowlist rather than an alphabetical slice, because the conformance test needs a connected foreign-key subgraph: protocol_mapper has two foreign keys to different tables and composite_role has two to the same one. * feat(docs): add index grouping for the docs viewer * feat(docs): describe snapshot warnings for the viewer * feat(docs): add client-side search for the docs viewer * test(docs): make the search fixture able to fail * feat(docs): expose group hue as a CSS custom property * docs(plan): add annotations and viewer plans, correct Task 7 Parts 2 and 3a were planned after the first plan was committed and were never tracked. docs/superpowers/ is gitignored, so both needed -f, matching how the existing specs and plans in that directory were added. The viewer plan's Task 7 is corrected against the installed marked@18.0.4. Its original text carried four defects, found by probing the library rather than by review: an assertion that fails against a correct implementation, a pre-escaping approach that double-escapes entities, a javascript: blocklist with live bypasses (entity-encoded, vbscript:, data:text/html, and <img src>, which was never covered at all), and a link renderer whose text property is raw markdown source rather than parsed HTML — an XSS hole found while verifying the fix for the previous defect. The viewer plan also gains a corrections appendix grouping defects by failure mode. The annotations plan is committed as written; its defects are recorded in a follow-up. * feat(docs): render note markdown with raw HTML escaped * fix(docs): drop protocol-relative URLs in note markdown The URL allowlist permitted anything starting with / so relative paths work, and //evil.com qualifies. Over https that grants nothing a note author could not do with an ordinary https link, but the Part 3b standalone export is opened via file://, where //host/path is a UNC path. On Windows that opens an SMB connection and leaks an NTLM hash, with no click required since images auto-load, and it is plantable from a COMMENT ON value. Found by an adversarial probe of the committed module rather than by review; the backslash form was already dropped, only the slash form slipped through. * docs(plan): add corrections appendix to the annotations plan Groups the defects found executing Part 2 by failure mode, matching the form of the viewer plan's appendix. The notable one is Mode A: docs_notes_path had to be added in three places because ConnectionConfig has a serde mirror struct, and adding it in one place compiles, passes a round-trip test written against the same struct, and then reads None forever after every load. Also records a controller hypothesis that turned out to be wrong, since checking it cost one read. * fix(docs): reject backslash protocol-relative URLs in notes The // guard from the previous commit was itself a blocklist: /\evil.com starts with a single slash, so it passed, and the WHATWG URL spec treats /\ identically to // for special schemes. Browsers normalise the backslash, so it reaches the same file:// UNC path and the same no-click NTLM leak. Rejecting both separator characters in both positions closes it. Found by probing what String(raw).trim() leaves unnormalised before the prefix checks; the third defect on this file found by probing rather than by reading. * feat(docs): add docs viewer components Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKcC15gEuQBHMidPCFFYwn * test(docs): pin each theme's legacy colour base independently The ordering check indexOf(hsl) < indexOf(@supports) quantified over any occurrence, so deleting the light .docs-group block left the dark block's hsl satisfying it. The test passed while every table group rendered colourless on light-theme WebViews without oklch. Asserting each selector's own base block catches deleting either one. Found by the task implementer, which deleted one block and then both to show the guard pinned 'some base exists' rather than 'each selector has a base'. * fix(docs): escape single quotes in note attribute values escapeHtml covered & < > and double quotes but not single quotes. Not exploitable today because every attribute in this file is double-quoted, but that is a formatting convention enforced nowhere and living in a different part of the file from the escaper. A future edit writing title='...' would turn a formatting choice into an attribute breakout. Raised by review as latent fragility rather than a defect; fixed because the escaper should be correct on its own rather than correct-given-an-invariant. * test(docs): match single-quoted v-html bindings in the contract guard The guard matched /v-html\s*=\s*"([^"]*)"/ — double quotes only. A binding written `v-html='table.note'` produced zero matches and passed, handing a database COMMENT ON value straight to the DOM with the renderNote sanitiser bypassed. Both quote styles are valid Vue and nothing in the repo enforces one, so the guard had a hole exactly where it mattered most. Verified by temporarily rewriting a real WikiIndex binding as `v-html='table.note'`: the test now fails with "WikiIndex.vue: v-html must render renderNote output: expected 'table.note' to contain 'renderNote'". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKcC15gEuQBHMidPCFFYwn * fix(docs): cap search results per kind instead of overall DocsSearch sliced searchDocs output to 40 AFTER concatenation, and the concatenation order is tables -> columns -> groups -> enums. Columns always flooded the list, so the cap deleted the tail — every group and enum hit. Against the real fixture, "e" produced 155 hits (9 table, 133 column, 1 group, 12 enum) and rendered 9 tables, 31 columns and nothing else; groups and enums were structurally unreachable through search. Cap each kind against its own limit inside docsSearch.ts, where the logic is tested, and drop the slice from the template so exactly one place limits results. Ranking is unchanged: tables still precede columns. Verified by reverting to a single .slice(0, 40) over the concatenation: the new tests fail with "enums must survive a column flood: expected false to be true" and "expected 30 to be 20". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKcC15gEuQBHMidPCFFYwn * fix(docs): move the index card note out of its button The card rendered renderNote output with v-html inside the <button>. A note containing a markdown link — [spec](https://example.com) — put an <a> inside a <button>: invalid nesting, and the anchor was not keyboard reachable because the button swallows it in the tab order. The <li> now carries the card's border, background and hover, the button holds only the table name and kind, and the note is its sibling. Visually identical — same padding, same 0.5 gap, previously mt-0.5 — and the name row still spans the full width as the click target. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKcC15gEuQBHMidPCFFYwn * test(docs): pin every fixture struct's key set in both directions The guard pinned ColumnInfo and IndexInfo plus three DocTable keys, and only in the "no missing key" direction. Relationship, FieldRef, DocEnum, ProjectMeta, ColumnNote, ForeignKeyInfo, TableGroup and 10 of 13 DocTable keys were unchecked. Renaming Relationship::to to `target` in Rust kept the suite at 67/67 and vue-tsc at exit 0 while RelationshipList read `field.table` on undefined and every table page rendered blank. Every struct in the fixture is now pinned both ways — no missing key, no unexpected key — over every instance rather than element [0]. Each direction catches a different half of a rename. Object.hasOwn throughout, so a key that is present and null stays distinguishable from one skip_serializing_if omitted. ForeignKeyInfo, TableGroup and the SchemaSnapshot root are included beyond the list the review gave: they are equally present in the fixture and equally unpinned. Verified against a modified copy of the fixture outside the repo with Relationship::to renamed: "Relationship[0] must always carry to: expected false to be true". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKcC15gEuQBHMidPCFFYwn * fix(cli): error when an explicit --notes path does not exist load_annotations returns Ok(None) for a missing file, which is right for the implicit per-connection notes path — it may legitimately not exist yet. It is wrong for --notes, where the user named a specific file: a mistyped path produced DBML with every note silently absent and no diagnostic at all, indistinguishable from a database that has no documentation. Both final reviewers independently ruled this must-fix-before-merge. * fix(docs): treat an explicit FK ref_schema as authoritative find_target tried the explicit ref_schema, then fell through to the source table's own schema on failure. When the referenced schema was not collected — routine, since users select schemas — an FK from sales.orders to archive.customers resolved to sales.customers instead: a different table, and a diagram that is confidently wrong rather than visibly incomplete. The function's own doc comment already promised that keys pointing outside the collected set are dropped. Now it does that. This is a regression of the defect found in Part 1: the three-tier lookup was added then, but tier one was written to fall through rather than to decide. * fix(docs): corroborate engine capability warnings against what was collected supports_comments and supports_foreign_keys delegate to the structure editor's DDL-generation capabilities, not to introspection support. IRIS is the proven divergence: it reports %DESCRIPTION on introspection but DBX cannot ALTER an existing one, so the flag is false while the collector reads and includes those comments — producing a snapshot that warned comments were unsupported alongside the comments themselves. Each warning now fires only when the flag says the engine cannot AND collection found nothing of the kind to contradict it. ClickHouse and Doris, which genuinely report no foreign keys, still warn. The doc comments now say what the functions actually measure. Found by final review, which traced every other caller to establish the flag's real semantics. * docs(fixture): finish repointing the fixture source to keycloak Follows the rebase that replaced the fixture at its origin commit. Repoints the live annotation test's project identity and both plans, and records the one capability keycloak costs us. Keycloak declares no PostgreSQL enum types, so the fixture cannot exercise DocEnum — a Rust-side rename of a DocEnum field would pass every test here and break the viewer's enum rendering silently. Rather than delete the test, it now asserts the gap, so it fails the day the fixture source gains an enum and prompts restoring the pin. * docs(spec): design for in-app database documentation (Part 3b) Mounts the Part 3a viewer in DBX and makes it editable: table/column notes, table groups, and per-group colour, autosaved to a notes file that can live in the user's repository. Two findings shaped the scope. DBX already ships SchemaDiagramDialog, so the viewer links to it rather than building a second ER diagram — only the Part 3c export needs its own minimal renderer, because that dialog reaches into stores and cannot be inlined. And nothing currently reads docs_notes_path or writes annotations at all, so 'in-app editing' needs new Rust rather than frontend wiring alone. The standalone export, dbx docs verb and hash routing are deferred to 3c. * docs(plan): implementation plan for in-app database documentation Ten tasks: atomic annotation save and path resolution, Tauri commands, web route parity, the frontend facade, pure edit transforms, the i18n namespace with a parity guard, editing components, the enum page, edit plumbing through the viewer, and the dialog with debounced autosave. Self-review caught three defects before dispatch, all the same class that cost Part 3a ten fix rounds: a return type named DescribedWarning that does not exist (it is WarningNotice), a test calling emptySnapshot() which does not exist, and a table() helper invoked with columns when its real signature takes a groupId. Every identifier the plan names is a claim about the codebase. * docs(plan): resolve the data directory without a dbx-mcp dependency Tasks 2 and 3 called dbx_mcp::paths::app_data_dir(), but neither src-tauri nor dbx-web depends on dbx-mcp, so neither would have compiled. Both already have a better source: AppState.storage.data_dir() honours a custom data dir, and WebState already carries data_dir. Found by the pre-flight scan before any implementer saw it. * docs(plan): fix Task 1 against the real crate (no Default, no tempfile) ConnectionConfig has no Default derive and ~60 fields, so resolve_notes_path now takes the connection id and the optional override directly — the two fields it actually reads. The test pain was pointing at the signature. dbx-core has no dev-dependencies, so the tests use the temp_dir + uuid idiom already present in annotations.rs rather than tempfile. * feat(docs): add atomic annotation save and notes path resolution * docs(plan): guard the autosave against concurrent writes flush() cleared the debounce timer but not an in-flight write, so closing the dialog while a debounced save was awaiting the backend started a second one. Two concurrent saves of the same file waste a round trip, race to land stale, and are the exact concurrency that corrupts the notes file when the temp path is not unique per writer. Found while adjudicating the Task 1 review, which demonstrated the Rust half of the same problem. * fix(docs): make temp paths unique to prevent concurrent save corruption * fix(docs): replace vacuous atomicity test with inode-based verification * docs(plan): correct the apply_annotations import path dbx_core::docs re-exports collector, color, dbml, keys, relations and snapshot but NOT annotations, so apply_annotations and friends are only reachable at dbx_core::docs::annotations. Tasks 2 and 3 both used the shorter path and would not have compiled. Verified against crates/dbx-core/src/docs/mod.rs before either was dispatched. * fix(docs): truncate temp filename to stay within 255-byte filesystem limit * feat(docs): add Tauri commands for docs snapshot and annotations * docs(plan): propagate the resolve_notes_path signature to its callers Pre-flight changed resolve_notes_path to take (connection_id, docs_notes_path, data_dir) instead of a ConnectionConfig, but only Task 1 was updated. Tasks 2 and 3 still called it with the old signature and would not have compiled. The Task 2 implementer caught it and used the correct form from its dispatch note. Task 3 had the identical stale call and had not been dispatched yet. The plan's self-review checks signature consistency across tasks; this changed AFTER that review, during pre-flight, and nothing re-ran the check. * docs(plan): pin Task 4's http.ts idiom and the Tauri argument names http.ts uses a post<T>(url, body) helper at line 222; the plan said only 'match the existing idiom', which is delegating verification to someone with less context. Written out concretely now. Also records what Task 2's review flagged as unverifiable from its own diff: Tauri serialises command arguments by name, so the invoke object keys must match the Rust parameter names. That mismatch compiles cleanly on both sides and fails only when a user clicks — and it falls in the gap between two task-scoped reviews, since neither diff contains both halves. * feat(docs): add web routes for annotation load, apply and save Mirrors the Tauri commands (docs_load_annotations, docs_apply_annotations, docs_save_annotations) added in the previous task: collect returns the raw snapshot, apply is separate so the shadowedNote rule stays in one place. * docs(plan): make the i18n parity guard actually observable Every non-English locale is export default withEnglishFallback({...}) — the fallback is applied at module level, inside the locale file. Only en.ts is a bare object. So importing a locale's default export yields the ALREADY-MERGED object, and the parity test would have found every key present in every locale and passed while translations were missing. The test written to catch silent English fallback would have been silently defeated by that fallback. Task 6 now puts the new namespace in per-locale modules under locales/docs/, which the test imports directly and unwrapped. Scoped entirely to the new namespace; the existing 315 KB of keys are untouched. Step 6 also asks the implementer to demonstrate the trap: point the imports back at the merged modules and watch a missing key pass. * feat(docs): expose docs snapshot and annotations to the frontend * docs(plan): locate the duplicated table-key rule correctly in Task 8 The plan said docsIndex.ts builds the qualified table key inline. It does not — it groups by table.schema, a section key. The table key rule lives in a private qualified() in docsSearch.ts and in a hand-rolled tableKey() in DocsApp.vue, DocsSidebar.vue and WikiIndex.vue. Part 3a's final review flagged that duplication as a Minor and it was deferred. Task 8 was about to add a fifth copy, so it now extracts docsKeys.ts first and replaces the existing ones. This is the key annotations are stored under, so two call sites disagreeing attaches a note to the wrong table. * feat(docs): add pure annotation edit transforms * docs(plan): ground the group hue picker in DBX's existing swatch idiom ConnectionDialog.vue already has a swatch row — h-6 w-6 rounded-full buttons, ring-2 selected state, i18n titles. Task 7 now points at it so the new picker looks native. With an explicit warning not to copy the fill mechanism: connection colours are hex painted via Tailwind classes, group colours are hues rendered through docs.css. A naive copy introduces hex literals and fails the contract test — correctly, since a hardcoded hex cannot stay legible on both grounds, which is why groups store a hue at all. * docs(plan): make Task 10's dialog wiring concrete Five exact locations, all verified: the store ref and its export, the useDialogSources watcher, the AppDialogs import and render, and the ObjectBrowser trigger plus its context-menu entry. Records the non-obvious part: the watcher clears the source back to null after firing, and that clearing is what makes the dialog re-openable — without it, setting the same value twice does not re-trigger the watch. ObjectBrowser is the entry point rather than the connection tree, because the tree has no diagram entry either and ObjectBrowser already supplies exactly the prefills the docs dialog needs. * feat(docs): add the docs i18n namespace with a parity guard * fix(docs): ban vue-i18n from standalone-exportable docs components WarningBanner.vue used useI18n() directly, which throws with no Vue app instance -- exactly the standalone HTML export case describeWarning's translator parameter exists to avoid. Thread translate as a prop from DocsApp instead, and add vue-i18n/useI18n( to the component contract's forbidden list so the constraint is enforced, not just documented. * docs(plan): note that DocsApp already has snapshot and translate Task 6's fix added translate to DocsApp when describeWarning started taking a translator. Task 9 said to add it, which would have been a duplicate prop. It now says to add only annotations and readonly to the existing defineProps. * feat(docs): add note editor, group editor and group picker * docs(plan): give Task 10 the dialog shell from SchemaDiagramDialog Exact Dialog primitives, the get/set computed every dialog here uses to bridge the open prop, and the sizing class copied verbatim from SchemaDiagramDialog.vue:827 — the docs viewer is the same kind of full-window workspace, not a form, so it should not invent dimensions. Also states explicitly that this component lives outside src/docs/ and so may and must use useI18n(): it is what supplies the translate prop the viewer components need, since they are banned from importing vue-i18n themselves. * test(docs): guard the light-ground group tokens too * feat(docs): add the enum page and a shared table-key helper EnumPage renders an enum's values and every column declared with that type. It is read-only on purpose: AnnotationFile has no `enums` key, so an edited note would have nowhere to be saved. qualifiedTableKey moves the `schema.name` rule — bare name on schema-less engines like SQLite and MySQL — into docsKeys, where the call sites that had each copied it can share one definition. It is the key annotations are stored under, so two call sites disagreeing would attach a note to the wrong table. columnsUsingEnum matches data_type exactly rather than by substring: an enum named `state` would otherwise claim every `estado` and `statement` column. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTBWnT4goXLA9iqDrfTPqk * refactor(docs): share one qualified table key across the viewer Six call sites had each copied the `schema.name` rule; they now import qualifiedTableKey from docsKeys instead. Two were not in the plan's list: TablePage.vue and RelationshipList.vue. RelationshipList passes a remapped FieldRef rather than a DocTable, which is why the helper takes Pick<DocTable, "schema" | "name"> — that widening is what let every call site be adapted directly instead of keeping a thin delegating wrapper. Also strengthens the columnsUsingEnum substring guard, which was not guarding anything. Its only column had type `integer`, and "integer".includes("state") is false, so replacing the exact match with includes() left all 8 tests green. Adds a `statement` column — the only type here that really contains `state` — and drops `estado` from the doc comment, since it does not. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTBWnT4goXLA9iqDrfTPqk * feat(docs): thread editing through the viewer as emitted events DocsApp gains `annotations` and `readonly` and re-emits a DocsEdit for every change its children request. Nothing under src/docs/ persists anything, which is what keeps the directory bundleable into the standalone HTML export; a new contract guard now pins that by rejecting any component that names save/load/applyDocsAnnotations. NoteEditor is fed the MERGED snapshot note, not the local annotation layer. It renders and edits one value, so seeding it locally would show nothing for a note that came from a database comment. Writing over one shadows it, which is what noteSource and shadowedNote already exist to disclose. `annotations` is threaded for what the merge erases: `groups` carries the editable GroupAnnotation records, while snapshot.groups carries resolved TableGroups that GroupPicker and GroupEditor cannot write back to. Also makes enums reachable. EnumPage rendered nowhere and search returned enum hits that DocsSearch deliberately disabled, since enums carry no table key; they now navigate by bare name, which is how columnsUsingEnum resolves them too. Groups remain unclickable — they still have no page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTBWnT4goXLA9iqDrfTPqk * feat(docs): mount the documentation viewer in DBX with autosaved editing DatabaseDocsDialog hosts DocsApp outside src/docs/, which is what lets it use useI18n() and supply the `translate` prop the viewer components are banned from importing for themselves. It collects the snapshot, loads the notes file (falling back to emptyAnnotations), and holds the raw snapshot so every edit can re-derive the merged view through applyDocsAnnotations. createAutosave debounces writes and, above all, makes a failure visible: a silently swallowed write is the worst outcome here, because the user keeps typing and believes their notes are saved. It also refuses to run two writes at once — flush() clearing the timer does not stop a write already awaiting save, and two concurrent writes of the same file is the exact race that corrupted the notes file before the Rust side used a unique temp path. Both properties are pinned by tests I confirmed fail when the guard is removed. Loads and re-derivations carry a generation number so a slow response cannot overwrite a newer one, and closing flushes the debounce rather than dropping a note typed a moment earlier. Trigger mirrors the schema diagram's wiring: docsSource on connectionStore, a watch in useDialogSources that clears the source so the dialog is re-openable, an async component in AppDialogs, and openDocs in ObjectBrowser. The context entry is added at BOTH object menus — the plan named only the table one, but views offer diagram.open too and documentation is no less relevant there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTBWnT4goXLA9iqDrfTPqk * docs(plan): record Tasks 1-10 as done The plan carried 58 unticked boxes after ten completed tasks, so progress had to be reconstructed from the commit trail instead of read off the document. Tasks 1-7 are ticked from that commit evidence rather than from step-by-step observation — they landed in earlier sessions. Tasks 8-10 were executed and verified directly. Task 8 Step 2 stays open on purpose. `columnsUsingEnum` was already implemented and committed before that step was reached, so its failure was never observed; the exact-match guard was verified by Step 5 instead, which is what exposed that the test could not detect a substring match at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTBWnT4goXLA9iqDrfTPqk * feat(docs): print snapshot warnings as prose from the CLI `dbx dbml` printed `{warning:?}`, so a skipped table surfaced as `TableSkipped { table: "public.orders", reason: "permission denied" }` — the struct shape, reading like a panic rather than like advice. The prose lives in Rust rather than in the `docs.warnings` i18n namespace because the CLI has no i18n runtime. That is the same constraint that made `describeWarning` take a translator instead of importing vue-i18n: the viewer translates, the CLI cannot, so each needs its own source for the same text. A second test asserts the rendering is not the Debug form, because reverting the CLI to `{warning:?}` is a one-character edit that still compiles and still prints something. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ro4mfGEmsbbH32WYsvxsfH * feat(docs): let a connection point its notes file at a repository `docs_notes_path` has existed on `ConnectionConfig` since Part 2 and has been read by `resolve_notes_path` since Part 3b, but nothing ever set it — so every connection silently used the app data directory default and the override was unreachable. The field is what makes schema documentation reviewable: pointing it at a file inside a repository puts notes in the same diff as the migration that changed the schema. Gated on `isSchemaAware`, matching the row above it, since documentation is a relational-only feature. A cleared field is normalised to absent rather than "" — `resolve_notes_path` treats blank as unset, but an empty string would still be persisted as though a path had been chosen. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ro4mfGEmsbbH32WYsvxsfH * docs: document database documentation and DBML export Covers opening the viewer, notes and groups, the LOCAL/database-comment rule, the notes file format and where it lives, every warning the viewer can raise, and the `dbx dbml` verb including the CI drift check. States the boundaries explicitly — relational engines only, no triggers or procedures, and DBML export is one-way — because each of those is a question the feature invites and would otherwise be answered by trying it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ro4mfGEmsbbH32WYsvxsfH --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: t8y2 <t8y2@users.noreply.github.com>
This commit is contained in:
117 files changed
+18546
-3
No files matched your search
@@ -0,0 +1,74 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { emptyAnnotations, removeGroup, setColumnNote, setProjectNote, setTableGroup, setTableNote, upsertGroup } from "../annotationEdits";
|
||||
|
||||
const base = emptyAnnotations();
|
||||
|
||||
describe("annotationEdits", () => {
|
||||
it("starts from a valid empty file", () => {
|
||||
expect(emptyAnnotations()).toEqual({ formatVersion: 1 });
|
||||
});
|
||||
|
||||
it("never mutates its input", () => {
|
||||
// Every function returns a new file. Mutating in place would make Vue's
|
||||
// reactivity miss the change and make undo impossible to add later.
|
||||
const before = JSON.stringify(base);
|
||||
setTableNote(base, "public.orders", "hello");
|
||||
expect(JSON.stringify(base)).toBe(before);
|
||||
});
|
||||
|
||||
it("sets and clears a table note", () => {
|
||||
const withNote = setTableNote(base, "public.orders", "One row per checkout.");
|
||||
expect(withNote.tables?.["public.orders"].note).toBe("One row per checkout.");
|
||||
|
||||
const cleared = setTableNote(withNote, "public.orders", " ");
|
||||
expect(cleared.tables?.["public.orders"]).toBeUndefined();
|
||||
});
|
||||
|
||||
it("keeps a table entry when it still carries a group after the note clears", () => {
|
||||
// Dropping the whole entry here would silently unassign the group.
|
||||
const grouped = setTableGroup(setTableNote(base, "public.orders", "n"), "public.orders", "g1");
|
||||
const cleared = setTableNote(grouped, "public.orders", "");
|
||||
expect(cleared.tables?.["public.orders"].group).toBe("g1");
|
||||
expect(cleared.tables?.["public.orders"].note).toBeUndefined();
|
||||
});
|
||||
|
||||
it("sets and clears a column note", () => {
|
||||
const withNote = setColumnNote(base, "public.orders", "status", "Lifecycle state.");
|
||||
expect(withNote.tables?.["public.orders"].columns?.status.note).toBe("Lifecycle state.");
|
||||
|
||||
const cleared = setColumnNote(withNote, "public.orders", "status", "");
|
||||
expect(cleared.tables?.["public.orders"]).toBeUndefined();
|
||||
});
|
||||
|
||||
it("upserts a group by id", () => {
|
||||
const created = upsertGroup(base, { id: "g1", name: "Core", hue: 28 });
|
||||
expect(created.groups).toEqual([{ id: "g1", name: "Core", hue: 28 }]);
|
||||
|
||||
const renamed = upsertGroup(created, { id: "g1", name: "Core Accounts", hue: 200 });
|
||||
expect(renamed.groups).toHaveLength(1);
|
||||
expect(renamed.groups?.[0]).toEqual({ id: "g1", name: "Core Accounts", hue: 200 });
|
||||
});
|
||||
|
||||
it("removing a group also clears every table that referenced it", () => {
|
||||
// A dangling groupId renders as no group at all, so the file would look
|
||||
// correct while carrying a reference to something that does not exist.
|
||||
const withGroup = setTableGroup(upsertGroup(base, { id: "g1", name: "Core", hue: 28 }), "public.orders", "g1");
|
||||
const removed = removeGroup(withGroup, "g1");
|
||||
|
||||
expect(removed.groups ?? []).toEqual([]);
|
||||
expect(removed.tables?.["public.orders"]).toBeUndefined();
|
||||
});
|
||||
|
||||
it("removing a group keeps a table that still has a note", () => {
|
||||
const seeded = setTableNote(setTableGroup(upsertGroup(base, { id: "g1", name: "Core", hue: 28 }), "public.orders", "g1"), "public.orders", "keep me");
|
||||
const removed = removeGroup(seeded, "g1");
|
||||
expect(removed.tables?.["public.orders"].note).toBe("keep me");
|
||||
expect(removed.tables?.["public.orders"].group).toBeUndefined();
|
||||
});
|
||||
|
||||
it("sets and clears the project note", () => {
|
||||
const withNote = setProjectNote(base, "# Sales\n\nThe billing schema.");
|
||||
expect(withNote.project?.note).toBe("# Sales\n\nThe billing schema.");
|
||||
expect(setProjectNote(withNote, "").project).toBeUndefined();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,36 @@
|
||||
import { readFileSync } from "node:fs";
|
||||
import path from "node:path";
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { ANNOTATION_FILE_KEYS, COLUMN_ANNOTATION_KEYS, GROUP_ANNOTATION_KEYS, PROJECT_ANNOTATION_KEYS, TABLE_ANNOTATION_KEYS } from "../types";
|
||||
|
||||
// The Rust structs carry deny_unknown_fields, so any property TypeScript adds
|
||||
// that Rust does not declare turns every save into a deserialization error at
|
||||
// runtime. vue-tsc cannot see across the language boundary, so this reads the
|
||||
// Rust source and compares the field sets directly.
|
||||
const rustSource = readFileSync(path.resolve(__dirname, "../../../../../crates/dbx-core/src/docs/annotations.rs"), "utf8");
|
||||
|
||||
function rustFields(structName: string): string[] {
|
||||
const start = rustSource.indexOf(`pub struct ${structName} {`);
|
||||
expect(start, `struct ${structName} not found in annotations.rs`).toBeGreaterThan(-1);
|
||||
const body = rustSource.slice(start, rustSource.indexOf("\n}", start));
|
||||
return [...body.matchAll(/^\s{4}pub ([a-z_]+):/gm)].map((match) => toCamel(match[1])).sort();
|
||||
}
|
||||
|
||||
function toCamel(value: string): string {
|
||||
return value.replace(/_([a-z])/g, (_, letter: string) => letter.toUpperCase());
|
||||
}
|
||||
|
||||
describe("annotation types match the Rust structs", () => {
|
||||
it.each([
|
||||
["AnnotationFile", ANNOTATION_FILE_KEYS],
|
||||
["ProjectAnnotation", PROJECT_ANNOTATION_KEYS],
|
||||
["GroupAnnotation", GROUP_ANNOTATION_KEYS],
|
||||
["TableAnnotation", TABLE_ANNOTATION_KEYS],
|
||||
["ColumnAnnotation", COLUMN_ANNOTATION_KEYS],
|
||||
])("%s", (structName, witness) => {
|
||||
// Rust source on one side, the TS interface's own keys on the other —
|
||||
// so this fails whichever side drifts. Comparing Rust against a hardcoded
|
||||
// list would only ever catch the Rust side.
|
||||
expect(rustFields(structName as string)).toEqual(Object.keys(witness).sort());
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,157 @@
|
||||
import { readdirSync, readFileSync } from "node:fs";
|
||||
import path from "node:path";
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { parse } from "vue/compiler-sfc";
|
||||
|
||||
const docsRoot = path.resolve(__dirname, "..");
|
||||
|
||||
function vueFiles(): string[] {
|
||||
const found: string[] = [];
|
||||
const walk = (dir: string) => {
|
||||
for (const entry of readdirSync(dir, { withFileTypes: true })) {
|
||||
const full = path.join(dir, entry.name);
|
||||
if (entry.isDirectory() && entry.name !== "__tests__" && entry.name !== "fixtures") {
|
||||
walk(full);
|
||||
} else if (entry.isFile() && entry.name.endsWith(".vue")) {
|
||||
found.push(full);
|
||||
}
|
||||
}
|
||||
};
|
||||
walk(docsRoot);
|
||||
return found;
|
||||
}
|
||||
|
||||
function scriptOf(file: string): string {
|
||||
const { descriptor } = parse(readFileSync(file, "utf8"), { filename: file });
|
||||
return `${descriptor.script?.content ?? ""}\n${descriptor.scriptSetup?.content ?? ""}`;
|
||||
}
|
||||
|
||||
const EXPECTED = ["ColumnTable.vue", "DocsApp.vue", "DocsSearch.vue", "DocsSidebar.vue", "EnumPage.vue", "GroupEditor.vue", "GroupPicker.vue", "NoteEditor.vue", "RelationshipList.vue", "TablePage.vue", "WarningBanner.vue", "WikiIndex.vue"];
|
||||
|
||||
describe("docs viewer component contract", () => {
|
||||
it("finds every expected component", () => {
|
||||
expect(
|
||||
vueFiles()
|
||||
.map((file) => path.basename(file))
|
||||
.sort(),
|
||||
).toEqual(EXPECTED);
|
||||
});
|
||||
|
||||
// Every test below loops over vueFiles(). On an empty set those loops run zero
|
||||
// assertions and pass while proving nothing, so each one asserts the set is
|
||||
// populated first. Without this, deleting every component turns the whole
|
||||
// contract green.
|
||||
it("makes no backend calls", () => {
|
||||
const files = vueFiles();
|
||||
expect(files.length).toBe(EXPECTED.length);
|
||||
// vue-i18n belongs here for the same reason as the backend imports: these
|
||||
// components are bundled into a standalone HTML file with no Vue app
|
||||
// around them, and useI18n() throws without a provided instance. Strings
|
||||
// arrive as a `translate` prop from the host instead.
|
||||
const forbidden = ["@/lib/backend", "@tauri-apps", "invoke(", "useConnectionStore", "useQueryStore", "useSettingsStore", "fetch(", "axios", "vue-i18n", "useI18n("];
|
||||
for (const file of files) {
|
||||
const script = scriptOf(file);
|
||||
for (const needle of forbidden) {
|
||||
expect(script.includes(needle), `${path.basename(file)} must not reference ${needle}`).toBe(false);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("keeps colour decisions out of templates", () => {
|
||||
const files = vueFiles();
|
||||
expect(files.length).toBe(EXPECTED.length);
|
||||
for (const file of files) {
|
||||
const source = readFileSync(file, "utf8");
|
||||
expect(source.includes("oklch("), `${path.basename(file)} must not compute colour`).toBe(false);
|
||||
expect(/#[0-9a-fA-F]{6}\b/.test(source), `${path.basename(file)} must not hardcode a hex colour`).toBe(false);
|
||||
}
|
||||
});
|
||||
|
||||
it("only ever feeds renderNote output to v-html", () => {
|
||||
// The single most dangerous thing a template here can do. Task 7 escapes
|
||||
// author HTML, but `v-html="table.note"` bypasses it entirely and hands a
|
||||
// COMMENT ON value straight to the DOM. Every v-html binding must name
|
||||
// renderNote, and no component may build HTML any other way.
|
||||
const files = vueFiles();
|
||||
expect(files.length).toBe(EXPECTED.length);
|
||||
for (const file of files) {
|
||||
const source = readFileSync(file, "utf8");
|
||||
// Either quote style. A double-quote-only pattern finds zero matches in
|
||||
// `v-html='table.note'` and passes it, which is the exact binding this
|
||||
// test exists to catch.
|
||||
for (const match of source.matchAll(/v-html\s*=\s*(["'])(.*?)\1/g)) {
|
||||
expect(match[2], `${path.basename(file)}: v-html must render renderNote output`).toContain("renderNote");
|
||||
}
|
||||
expect(source.includes("innerHTML"), `${path.basename(file)} must not touch innerHTML`).toBe(false);
|
||||
}
|
||||
});
|
||||
|
||||
it("the viewer emits edits rather than persisting them", () => {
|
||||
// src/docs/ must stay free of I/O so Part 3c can bundle it. Editing works
|
||||
// by emitting upward; the dialog outside this directory does the saving.
|
||||
const files = vueFiles();
|
||||
expect(files.length).toBe(EXPECTED.length);
|
||||
for (const file of files) {
|
||||
const source = readFileSync(file, "utf8");
|
||||
for (const needle of ["saveDocsAnnotations", "loadDocsAnnotations", "applyDocsAnnotations"]) {
|
||||
expect(source.includes(needle), `${path.basename(file)} must not call ${needle}`).toBe(false);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("editing components accept a readonly mode", () => {
|
||||
// Part 3c renders these same components with editing off inside an
|
||||
// exported HTML file. A component that cannot be made read-only would
|
||||
// have to be forked for the export.
|
||||
const files = vueFiles();
|
||||
expect(files.length).toBe(EXPECTED.length);
|
||||
const editors = files.filter((file) => path.basename(file) === "NoteEditor.vue");
|
||||
expect(editors.length).toBe(1);
|
||||
expect(readFileSync(editors[0], "utf8")).toContain("readonly");
|
||||
});
|
||||
|
||||
it('uses <script setup lang="ts">', () => {
|
||||
const files = vueFiles();
|
||||
expect(files.length).toBe(EXPECTED.length);
|
||||
for (const file of files) {
|
||||
const { descriptor } = parse(readFileSync(file, "utf8"), { filename: file });
|
||||
expect(descriptor.scriptSetup, `${path.basename(file)} must use <script setup>`).toBeTruthy();
|
||||
expect(descriptor.scriptSetup?.lang, `${path.basename(file)} must be TypeScript`).toBe("ts");
|
||||
}
|
||||
});
|
||||
|
||||
it("defines the group colour tokens for WebViews without oklch", () => {
|
||||
// DBX supports legacy WebViews with no oklch (globals.css carries an
|
||||
// `@supports not (color: oklch(...))` block). The repo's convention is
|
||||
// progressive enhancement: a legacy-safe base value first, then the same
|
||||
// token redefined inside `@supports (color: oklch(1 0 0))`. Without the
|
||||
// base, every table group renders colourless on those WebViews.
|
||||
//
|
||||
// Assert each selector's base block separately. An ordering check like
|
||||
// `indexOf(hsl) < indexOf(@supports)` quantifies over ANY occurrence, so
|
||||
// deleting the light block leaves the dark block's hsl satisfying it — the
|
||||
// test passes while light-theme legacy WebViews render every group
|
||||
// colourless.
|
||||
//
|
||||
// `.docs-ground-light` is here for the same reason as the other two, not as
|
||||
// a third theme: GroupEditor previews a hue on a light ground whatever the
|
||||
// app's theme, so that ground needs its own legacy-safe base. Without this
|
||||
// entry the whole block could be deleted with the suite still green, and
|
||||
// the preview would quietly show dark-theme colours on white in dark mode.
|
||||
const css = readFileSync(path.join(docsRoot, "docs.css"), "utf8");
|
||||
const enhanced = css.indexOf("@supports (color: oklch(1 0 0))");
|
||||
expect(enhanced).toBeGreaterThan(-1);
|
||||
const legacyBase = css.slice(0, enhanced);
|
||||
|
||||
for (const selector of [".docs-group", ".dark .docs-group", ".docs-ground-light .docs-group"]) {
|
||||
// `^` with the m flag anchors to a line start, so `.docs-group` cannot
|
||||
// match inside `.dark .docs-group`, and neither matches the indented
|
||||
// copies inside the @supports block.
|
||||
const pattern = new RegExp(`^${selector.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}\\s*\\{([^}]*)\\}`, "m");
|
||||
const block = pattern.exec(legacyBase)?.[1];
|
||||
expect(block, `${selector} needs a legacy-safe base block before @supports`).toBeTruthy();
|
||||
expect(block, `${selector} must define --group-c without oklch`).toContain("--group-c: hsl(");
|
||||
expect(block, `${selector} must define --group-tint without oklch`).toContain("--group-tint: hsl(");
|
||||
}
|
||||
});
|
||||
});
|
||||
+152
@@ -0,0 +1,152 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { columnsUsingEnum, groupBySchema, groupByTableGroup } from "../docsIndex";
|
||||
import type { DocTable, SchemaSnapshot, TableGroup } from "../types";
|
||||
|
||||
function table(schema: string | null, name: string, groupId: string | null = null): DocTable {
|
||||
return {
|
||||
schema,
|
||||
name,
|
||||
kind: "TABLE",
|
||||
columns: [],
|
||||
indexes: [],
|
||||
foreignKeys: [],
|
||||
groupId,
|
||||
note: null,
|
||||
noteSource: "NONE",
|
||||
shadowedNote: null,
|
||||
columnNotes: {},
|
||||
estimatedRows: null,
|
||||
viewDefinition: null,
|
||||
};
|
||||
}
|
||||
|
||||
function snapshot(tables: DocTable[], groups: TableGroup[] = []): SchemaSnapshot {
|
||||
return {
|
||||
formatVersion: 1,
|
||||
project: { name: "p", databaseType: "postgres", database: null, schemas: [], generatedAt: "", note: null },
|
||||
tables,
|
||||
relationships: [],
|
||||
groups,
|
||||
enums: [],
|
||||
warnings: [],
|
||||
};
|
||||
}
|
||||
|
||||
describe("groupBySchema", () => {
|
||||
it("groups tables under their schema, sorted by schema then name", () => {
|
||||
const sections = groupBySchema(snapshot([table("public", "orders"), table("analytics", "daily_sales"), table("public", "customers")]));
|
||||
|
||||
expect(sections.map((section) => section.key)).toEqual(["analytics", "public"]);
|
||||
expect(sections[1].tables.map((t) => t.name)).toEqual(["customers", "orders"]);
|
||||
});
|
||||
|
||||
it("puts schema-less tables in a single bare section", () => {
|
||||
const sections = groupBySchema(snapshot([table(null, "orders")]));
|
||||
expect(sections).toHaveLength(1);
|
||||
expect(sections[0].tables[0].name).toBe("orders");
|
||||
});
|
||||
});
|
||||
|
||||
describe("groupByTableGroup", () => {
|
||||
const groups: TableGroup[] = [
|
||||
{ id: "order-mgmt", name: "Order Management", hue: 28, note: "Checkout." },
|
||||
{ id: "product-mgmt", name: "Product Management", hue: 148, note: null },
|
||||
];
|
||||
|
||||
it("groups tables by their group, preserving the snapshot's group order", () => {
|
||||
const sections = groupByTableGroup(snapshot([table("product", "products", "product-mgmt"), table("core", "orders", "order-mgmt")], groups));
|
||||
|
||||
expect(sections.map((section) => section.key)).toEqual(["order-mgmt", "product-mgmt"]);
|
||||
expect(sections[0].label).toBe("Order Management");
|
||||
expect(sections[0].hue).toBe(28);
|
||||
expect(sections[0].note).toBe("Checkout.");
|
||||
});
|
||||
|
||||
it("collects ungrouped tables into a trailing (no group) section", () => {
|
||||
const sections = groupByTableGroup(snapshot([table("core", "orders", "order-mgmt"), table("core", "users", null)], groups));
|
||||
|
||||
const last = sections[sections.length - 1];
|
||||
expect(last.key).toBe("");
|
||||
expect(last.hue).toBeNull();
|
||||
expect(last.tables.map((t) => t.name)).toEqual(["users"]);
|
||||
});
|
||||
|
||||
it("omits a group that has no members", () => {
|
||||
// render_group in the serializer skips empty groups; the viewer must not
|
||||
// show an empty header where the DBML shows nothing.
|
||||
const sections = groupByTableGroup(snapshot([table("core", "orders", "order-mgmt")], groups));
|
||||
expect(sections.map((section) => section.key)).not.toContain("product-mgmt");
|
||||
});
|
||||
|
||||
it("treats a table whose groupId names no group as ungrouped", () => {
|
||||
const sections = groupByTableGroup(snapshot([table("core", "orders", "ghost")], groups));
|
||||
expect(sections).toHaveLength(1);
|
||||
expect(sections[0].key).toBe("");
|
||||
});
|
||||
});
|
||||
|
||||
describe("columnsUsingEnum", () => {
|
||||
// The file's existing helper is `table(schema, name, groupId)` and builds a
|
||||
// table with NO columns, so these tests need columns attached. Add this
|
||||
// helper beside it rather than changing the existing signature — the other
|
||||
// tests in this file call it positionally.
|
||||
function withColumns(base: DocTable, columns: Array<{ name: string; type: string }>): DocTable {
|
||||
return {
|
||||
...base,
|
||||
columns: columns.map((column) => ({
|
||||
name: column.name,
|
||||
data_type: column.type,
|
||||
is_nullable: false,
|
||||
column_default: null,
|
||||
is_primary_key: false,
|
||||
extra: "",
|
||||
comment: null,
|
||||
numeric_precision: null,
|
||||
numeric_scale: null,
|
||||
character_maximum_length: null,
|
||||
})),
|
||||
};
|
||||
}
|
||||
|
||||
function snapshotOf(tables: DocTable[], enums: SchemaSnapshot["enums"]): SchemaSnapshot {
|
||||
return {
|
||||
formatVersion: 1,
|
||||
project: { name: "p", databaseType: "postgres", database: null, schemas: [], generatedAt: "", note: null },
|
||||
tables,
|
||||
relationships: [],
|
||||
groups: [],
|
||||
enums,
|
||||
warnings: [],
|
||||
};
|
||||
}
|
||||
|
||||
it("finds every column using an enum, across tables", () => {
|
||||
const snapshot = snapshotOf(
|
||||
[withColumns(table("public", "orders"), [{ name: "status", type: "order_status" }]), withColumns(table("public", "returns"), [{ name: "state", type: "order_status" }]), withColumns(table("public", "users"), [{ name: "id", type: "integer" }])],
|
||||
[{ schema: "public", name: "order_status", values: ["new"], note: null, synthesized: false }],
|
||||
);
|
||||
|
||||
expect(columnsUsingEnum(snapshot, "order_status")).toEqual([
|
||||
{ tableKey: "public.orders", table: "orders", column: "status" },
|
||||
{ tableKey: "public.returns", table: "returns", column: "state" },
|
||||
]);
|
||||
});
|
||||
|
||||
it("returns nothing for an enum no column references", () => {
|
||||
// Must not fall back to "every column". The `statement` column is the one
|
||||
// that matters: it is the only type here that *contains* `state`, so a
|
||||
// substring match would claim it while an unrelated type like `integer`
|
||||
// would not. Drop it and this test passes against `includes()` too, which
|
||||
// makes it stop guarding anything.
|
||||
const snapshot = snapshotOf(
|
||||
[
|
||||
withColumns(table("public", "users"), [
|
||||
{ name: "id", type: "integer" },
|
||||
{ name: "body", type: "statement" },
|
||||
]),
|
||||
],
|
||||
[{ schema: "public", name: "state", values: ["a"], note: null, synthesized: false }],
|
||||
);
|
||||
expect(columnsUsingEnum(snapshot, "state")).toEqual([]);
|
||||
});
|
||||
});
|
||||
+149
@@ -0,0 +1,149 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { searchDocs, type SearchHit } from "../docsSearch";
|
||||
import type { DocTable, SchemaSnapshot } from "../types";
|
||||
|
||||
function column(name: string) {
|
||||
return {
|
||||
name,
|
||||
data_type: "text",
|
||||
is_nullable: true,
|
||||
column_default: null,
|
||||
is_primary_key: false,
|
||||
extra: null,
|
||||
};
|
||||
}
|
||||
|
||||
function table(schema: string, name: string, columns: string[] = []): DocTable {
|
||||
return {
|
||||
schema,
|
||||
name,
|
||||
kind: "TABLE",
|
||||
columns: columns.map(column),
|
||||
indexes: [],
|
||||
foreignKeys: [],
|
||||
groupId: null,
|
||||
note: null,
|
||||
noteSource: "NONE",
|
||||
shadowedNote: null,
|
||||
columnNotes: {},
|
||||
estimatedRows: null,
|
||||
viewDefinition: null,
|
||||
};
|
||||
}
|
||||
|
||||
const snapshot: SchemaSnapshot = {
|
||||
formatVersion: 1,
|
||||
project: { name: "p", databaseType: "postgres", database: null, schemas: [], generatedAt: "", note: null },
|
||||
tables: [
|
||||
table("public", "orders", ["status", "total"]),
|
||||
// `orders_count` contains "orders", so a query for "orders" matches BOTH
|
||||
// a table and a column — which is what makes the ranking test able to fail.
|
||||
table("public", "customers", ["status", "orders_count"]),
|
||||
// Mixed case, so a mutant that lowercases only the needle and not the
|
||||
// candidate would fail the case-insensitivity test.
|
||||
table("public", "Invoices", ["Amount"]),
|
||||
],
|
||||
relationships: [],
|
||||
groups: [{ id: "g1", name: "Order Management", hue: 28, note: null }],
|
||||
enums: [{ schema: "public", name: "order_status", values: ["pending"], note: null, synthesized: false }],
|
||||
warnings: [],
|
||||
};
|
||||
|
||||
// Columns outnumber every other kind by two orders of magnitude in a real
|
||||
// database — the fixture answers "e" with 133 columns against 1 group and 12
|
||||
// enums. This snapshot reproduces that shape: one term matching more of each
|
||||
// kind than its cap allows.
|
||||
const flooded: SchemaSnapshot = {
|
||||
formatVersion: 1,
|
||||
project: { name: "p", databaseType: "postgres", database: null, schemas: [], generatedAt: "", note: null },
|
||||
tables: [
|
||||
table(
|
||||
"public",
|
||||
"notes",
|
||||
Array.from({ length: 30 }, (_, index) => `note_${index}`),
|
||||
),
|
||||
],
|
||||
relationships: [],
|
||||
groups: Array.from({ length: 12 }, (_, index) => ({ id: `g${index}`, name: `note group ${index}`, hue: 28, note: null })),
|
||||
enums: Array.from({ length: 12 }, (_, index) => ({ schema: "public", name: `note_enum_${index}`, values: ["pending"], note: null, synthesized: false })),
|
||||
warnings: [],
|
||||
};
|
||||
|
||||
describe("searchDocs", () => {
|
||||
it("returns nothing for an empty query", () => {
|
||||
expect(searchDocs(snapshot, "")).toEqual([]);
|
||||
expect(searchDocs(snapshot, " ")).toEqual([]);
|
||||
});
|
||||
|
||||
it("matches table names case-insensitively", () => {
|
||||
const hits = searchDocs(snapshot, "ORD");
|
||||
expect(hits.some((hit) => hit.kind === "table" && hit.label === "orders")).toBe(true);
|
||||
});
|
||||
|
||||
it("matches columns and reports which table they belong to", () => {
|
||||
const hits = searchDocs(snapshot, "total");
|
||||
const hit = hits.find((candidate) => candidate.kind === "column");
|
||||
expect(hit).toBeDefined();
|
||||
expect(hit!.label).toBe("total");
|
||||
expect(hit!.context).toContain("orders");
|
||||
});
|
||||
|
||||
it("returns one hit per table for a column name shared by several tables", () => {
|
||||
const hits = searchDocs(snapshot, "status").filter((hit) => hit.kind === "column");
|
||||
expect(hits).toHaveLength(2);
|
||||
expect(hits.map((hit) => hit.context).sort()).toEqual(["public.customers", "public.orders"]);
|
||||
});
|
||||
|
||||
it("matches groups and enums", () => {
|
||||
expect(searchDocs(snapshot, "Order Man").some((hit) => hit.kind === "group")).toBe(true);
|
||||
expect(searchDocs(snapshot, "order_status").some((hit) => hit.kind === "enum")).toBe(true);
|
||||
});
|
||||
|
||||
it("ranks table matches above column matches for the same term", () => {
|
||||
// "orders" now matches the `orders` table AND the `orders_count` column
|
||||
// on `customers`. Reversing the concatenation order must fail this.
|
||||
const hits = searchDocs(snapshot, "orders");
|
||||
const firstTable = hits.findIndex((hit) => hit.kind === "table");
|
||||
const firstColumn = hits.findIndex((hit) => hit.kind === "column");
|
||||
expect(firstTable).toBeGreaterThanOrEqual(0);
|
||||
expect(firstColumn).toBeGreaterThanOrEqual(0);
|
||||
expect(firstTable).toBeLessThan(firstColumn);
|
||||
});
|
||||
|
||||
it("carries a tableKey so a hit can navigate", () => {
|
||||
const hit = searchDocs(snapshot, "total").find((candidate) => candidate.kind === "column");
|
||||
expect(hit!.tableKey).toBe("public.orders");
|
||||
});
|
||||
|
||||
it("still returns group and enum hits when columns flood the results", () => {
|
||||
// A single cap applied after concatenation deletes the tail of the list,
|
||||
// and groups and enums are the tail — making them unreachable through
|
||||
// search no matter what the user types.
|
||||
const hits = searchDocs(flooded, "note");
|
||||
expect(
|
||||
hits.some((hit) => hit.kind === "group"),
|
||||
"groups must survive a column flood",
|
||||
).toBe(true);
|
||||
expect(
|
||||
hits.some((hit) => hit.kind === "enum"),
|
||||
"enums must survive a column flood",
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
it("caps each kind independently", () => {
|
||||
const hits = searchDocs(flooded, "note");
|
||||
const count = (kind: SearchHit["kind"]) => hits.filter((hit) => hit.kind === kind).length;
|
||||
expect(count("table")).toBe(1);
|
||||
expect(count("column")).toBe(20);
|
||||
expect(count("group")).toBe(10);
|
||||
expect(count("enum")).toBe(10);
|
||||
});
|
||||
|
||||
it("matches a mixed-case identifier from a lowercase query", () => {
|
||||
// The candidate, not just the needle, must be lowercased — otherwise
|
||||
// search silently becomes case-sensitive for databases with quoted or
|
||||
// uppercase identifiers.
|
||||
expect(searchDocs(snapshot, "invoice").some((hit) => hit.label === "Invoices")).toBe(true);
|
||||
expect(searchDocs(snapshot, "amount").some((hit) => hit.label === "Amount")).toBe(true);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,70 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { describeWarning, type Translate } from "../docsWarnings";
|
||||
import type { SnapshotWarning } from "../types";
|
||||
|
||||
// A fake translator that echoes the key and params back rather than English
|
||||
// prose. This is what actually matters now: that describeWarning calls
|
||||
// translate with the right key and the right params, not what the English
|
||||
// copy says — the copy itself lives in the i18n namespace and is covered by
|
||||
// the parity test.
|
||||
const translate: Translate = (key, params) => `${key}|${JSON.stringify(params ?? {})}`;
|
||||
|
||||
describe("describeWarning", () => {
|
||||
it("explains a skipped table as a warning naming the table and reason", () => {
|
||||
const notice = describeWarning({ kind: "tableSkipped", table: "public.secret", reason: "permission denied" }, translate);
|
||||
expect(notice.severity).toBe("warning");
|
||||
expect(notice.title).toBe("docs.warnings.tableSkipped.title|{}");
|
||||
expect(notice.detail).toBe('docs.warnings.tableSkipped.detail|{"table":"public.secret","reason":"permission denied"}');
|
||||
});
|
||||
|
||||
it("explains missing foreign-key metadata as an engine limitation, not a fault", () => {
|
||||
const notice = describeWarning({ kind: "noForeignKeyMetadata", engine: "ClickHouse" }, translate);
|
||||
expect(notice.severity).toBe("info");
|
||||
expect(notice.title).toBe("docs.warnings.noForeignKeyMetadata.title|{}");
|
||||
expect(notice.detail).toBe('docs.warnings.noForeignKeyMetadata.detail|{"engine":"ClickHouse"}');
|
||||
});
|
||||
|
||||
it("explains unsupported comments", () => {
|
||||
const notice = describeWarning({ kind: "commentsUnsupported", engine: "SQLite" }, translate);
|
||||
expect(notice.severity).toBe("info");
|
||||
expect(notice.title).toBe("docs.warnings.commentsUnsupported.title|{}");
|
||||
expect(notice.detail).toBe('docs.warnings.commentsUnsupported.detail|{"engine":"SQLite"}');
|
||||
});
|
||||
|
||||
it("reports orphaned notes with the count", () => {
|
||||
const notice = describeWarning({ kind: "orphanedNotes", count: 3 }, translate);
|
||||
expect(notice.severity).toBe("warning");
|
||||
expect(notice.title).toBe("docs.warnings.orphanedNotes.title|{}");
|
||||
expect(notice.detail).toBe('docs.warnings.orphanedNotes.detail|{"count":3}');
|
||||
});
|
||||
|
||||
it("explains a DBML omission naming the item", () => {
|
||||
const notice = describeWarning(
|
||||
{
|
||||
kind: "dbmlOmitted",
|
||||
table: "public.orders",
|
||||
item: "idx_orders_open",
|
||||
reason: "partial index filter has no DBML equivalent",
|
||||
},
|
||||
translate,
|
||||
);
|
||||
expect(notice.severity).toBe("info");
|
||||
expect(notice.title).toBe("docs.warnings.dbmlOmitted.title|{}");
|
||||
expect(notice.detail).toBe('docs.warnings.dbmlOmitted.detail|{"item":"idx_orders_open","table":"public.orders","reason":"partial index filter has no DBML equivalent"}');
|
||||
});
|
||||
|
||||
it("never returns an empty title or detail for any known kind", () => {
|
||||
const samples: SnapshotWarning[] = [
|
||||
{ kind: "tableSkipped", table: "t", reason: "r" },
|
||||
{ kind: "noForeignKeyMetadata", engine: "e" },
|
||||
{ kind: "commentsUnsupported", engine: "e" },
|
||||
{ kind: "orphanedNotes", count: 1 },
|
||||
{ kind: "dbmlOmitted", table: "t", item: "i", reason: "r" },
|
||||
];
|
||||
for (const sample of samples) {
|
||||
const notice = describeWarning(sample, translate);
|
||||
expect(notice.title.length, `empty title for ${sample.kind}`).toBeGreaterThan(0);
|
||||
expect(notice.detail.length, `empty detail for ${sample.kind}`).toBeGreaterThan(0);
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,158 @@
|
||||
import { readFileSync } from "node:fs";
|
||||
import path from "node:path";
|
||||
import { describe, expect, it } from "vitest";
|
||||
import type { SchemaSnapshot } from "../types";
|
||||
|
||||
const fixturePath = path.resolve(__dirname, "../fixtures/keycloak.snapshot.json");
|
||||
|
||||
function loadFixture(): SchemaSnapshot {
|
||||
return JSON.parse(readFileSync(fixturePath, "utf8")) as SchemaSnapshot;
|
||||
}
|
||||
|
||||
describe("fixture conformance", () => {
|
||||
// This fixture is generated by the REAL Rust serializer. Its job is to fail
|
||||
// when the Rust model changes shape, so the hand-maintained types.ts cannot
|
||||
// drift silently.
|
||||
|
||||
it("has the shape types.ts declares", () => {
|
||||
const snapshot = loadFixture();
|
||||
expect(snapshot.formatVersion).toBe(1);
|
||||
expect(Array.isArray(snapshot.tables)).toBe(true);
|
||||
expect(snapshot.tables.length).toBeGreaterThan(0);
|
||||
expect(typeof snapshot.project.databaseType).toBe("string");
|
||||
expect(Array.isArray(snapshot.project.schemas)).toBe(true);
|
||||
});
|
||||
|
||||
it("uses camelCase for snapshot-owned fields", () => {
|
||||
const raw = JSON.parse(readFileSync(fixturePath, "utf8")) as Record<string, unknown>;
|
||||
expect(raw).toHaveProperty("formatVersion");
|
||||
expect(raw).not.toHaveProperty("format_version");
|
||||
|
||||
const table = (raw.tables as Record<string, unknown>[])[0];
|
||||
expect(table).toHaveProperty("noteSource");
|
||||
expect(table).toHaveProperty("columnNotes");
|
||||
expect(table).toHaveProperty("foreignKeys");
|
||||
expect(table).not.toHaveProperty("note_source");
|
||||
});
|
||||
|
||||
it("keeps snake_case on columns, which come from crate::types", () => {
|
||||
const snapshot = loadFixture();
|
||||
const withColumns = snapshot.tables.find((table) => table.columns.length > 0);
|
||||
expect(withColumns, "fixture must contain at least one table with columns").toBeDefined();
|
||||
const column = withColumns!.columns[0] as unknown as Record<string, unknown>;
|
||||
expect(column).toHaveProperty("data_type");
|
||||
expect(column).toHaveProperty("is_nullable");
|
||||
expect(column).not.toHaveProperty("dataType");
|
||||
});
|
||||
|
||||
it("carries an annotated note, a group and an orphan warning", () => {
|
||||
const snapshot = loadFixture();
|
||||
|
||||
const annotated = snapshot.tables.find((table) => table.noteSource === "LOCAL");
|
||||
expect(annotated, "fixture must include a LOCAL-sourced note").toBeDefined();
|
||||
expect(annotated!.note).toBeTruthy();
|
||||
|
||||
expect(snapshot.groups.length).toBeGreaterThan(0);
|
||||
expect(typeof snapshot.groups[0].hue).toBe("number");
|
||||
|
||||
const orphan = snapshot.warnings.find((warning) => warning.kind === "orphanedNotes");
|
||||
expect(orphan, "fixture must include an orphanedNotes warning").toBeDefined();
|
||||
});
|
||||
|
||||
it("every warning discriminant is one types.ts knows", () => {
|
||||
const known = new Set(["tableSkipped", "noForeignKeyMetadata", "commentsUnsupported", "orphanedNotes", "dbmlOmitted"]);
|
||||
for (const warning of loadFixture().warnings) {
|
||||
expect(known.has(warning.kind), `unknown warning kind: ${warning.kind}`).toBe(true);
|
||||
}
|
||||
});
|
||||
|
||||
// Every struct below is pinned in BOTH directions — no missing key, no
|
||||
// unexpected key — because each direction catches a different drift. A
|
||||
// missing key is a removal or a rename's old name; an unexpected key is the
|
||||
// rename's new name. Pinning only "required keys present" lets a rename of
|
||||
// Relationship::to slip through the whole suite AND vue-tsc while
|
||||
// RelationshipList reads `field.table` on undefined and every table page
|
||||
// renders blank.
|
||||
//
|
||||
// `Object.hasOwn`, never truthiness: most of these keys are legitimately
|
||||
// null, and "present and null" must stay distinguishable from "absent",
|
||||
// which is what skip_serializing_if produces.
|
||||
function pinShape(label: string, instances: unknown[], required: string[], optional: string[] = []): void {
|
||||
// An empty instance list runs zero assertions and passes while proving
|
||||
// nothing, so every struct has to actually appear in the fixture.
|
||||
expect(instances.length, `fixture must contain at least one ${label}`).toBeGreaterThan(0);
|
||||
const allowed = new Set([...required, ...optional]);
|
||||
for (const [position, instance] of instances.entries()) {
|
||||
const record = instance as Record<string, unknown>;
|
||||
for (const key of required) {
|
||||
expect(Object.hasOwn(record, key), `${label}[${position}] must always carry ${key}`).toBe(true);
|
||||
}
|
||||
for (const key of Object.keys(record)) {
|
||||
expect(allowed.has(key), `${label}[${position}] carries unexpected key ${key}`).toBe(true);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
it("the snapshot root has exactly the keys types.ts declares", () => {
|
||||
pinShape("SchemaSnapshot", [loadFixture()], ["formatVersion", "project", "tables", "relationships", "groups", "enums", "warnings"]);
|
||||
});
|
||||
|
||||
it("ProjectMeta has exactly the keys types.ts declares", () => {
|
||||
pinShape("ProjectMeta", [loadFixture().project], ["name", "databaseType", "database", "schemas", "generatedAt", "note"]);
|
||||
});
|
||||
|
||||
it("DocTable has exactly the keys types.ts declares", () => {
|
||||
pinShape("DocTable", loadFixture().tables, ["schema", "name", "kind", "columns", "indexes", "foreignKeys", "groupId", "note", "noteSource", "shadowedNote", "columnNotes", "estimatedRows", "viewDefinition"]);
|
||||
});
|
||||
|
||||
it("ColumnInfo has exactly the keys types.ts declares", () => {
|
||||
// The required ten are required because Rust has no skip_serializing_if on
|
||||
// them. The optional three DO carry one, so the key is absent rather than
|
||||
// null when there is no value.
|
||||
const columns = loadFixture().tables.flatMap((table) => table.columns);
|
||||
pinShape("ColumnInfo", columns, ["name", "data_type", "is_nullable", "column_default", "is_primary_key", "extra", "comment", "numeric_precision", "numeric_scale", "character_maximum_length"], ["enum_values", "character_set", "collation"]);
|
||||
});
|
||||
|
||||
it("IndexInfo has exactly the keys types.ts declares", () => {
|
||||
const indexes = loadFixture().tables.flatMap((table) => table.indexes);
|
||||
pinShape("IndexInfo", indexes, ["name", "columns", "is_unique", "is_primary", "filter", "index_type", "included_columns", "comment"]);
|
||||
});
|
||||
|
||||
it("ForeignKeyInfo has exactly the keys types.ts declares", () => {
|
||||
const foreignKeys = loadFixture().tables.flatMap((table) => table.foreignKeys);
|
||||
pinShape("ForeignKeyInfo", foreignKeys, ["name", "column", "ref_table", "ref_column"], ["ref_schema", "on_update", "on_delete"]);
|
||||
});
|
||||
|
||||
it("ColumnNote has exactly the keys types.ts declares", () => {
|
||||
const notes = loadFixture().tables.flatMap((table) => Object.values(table.columnNotes));
|
||||
pinShape("ColumnNote", notes, ["note", "source", "shadowed"]);
|
||||
});
|
||||
|
||||
it("Relationship and FieldRef have exactly the keys types.ts declares", () => {
|
||||
const relationships = loadFixture().relationships;
|
||||
pinShape("Relationship", relationships, ["id", "name", "from", "to", "cardinality", "onUpdate", "onDelete"]);
|
||||
pinShape(
|
||||
"FieldRef",
|
||||
relationships.flatMap((relationship) => [relationship.from, relationship.to]),
|
||||
["schema", "table", "column"],
|
||||
);
|
||||
});
|
||||
|
||||
it("TableGroup has exactly the keys types.ts declares", () => {
|
||||
pinShape("TableGroup", loadFixture().groups, ["id", "name", "hue", "note"]);
|
||||
});
|
||||
|
||||
it("records that the fixture source declares no enum types, leaving DocEnum unpinned", () => {
|
||||
// Keycloak's schema has no PostgreSQL enum types, so this fixture cannot
|
||||
// exercise DocEnum. That is a real gap: a Rust-side rename of a DocEnum
|
||||
// field would pass every test in this file and break the viewer's enum
|
||||
// rendering silently.
|
||||
//
|
||||
// Asserting the gap rather than deleting the test keeps it visible and
|
||||
// makes it self-correcting — the day the fixture source gains an enum this
|
||||
// fails, and the pin below should replace it:
|
||||
//
|
||||
// pinShape("DocEnum", loadFixture().enums, ["schema", "name", "values", "note", "synthesized"]);
|
||||
expect(loadFixture().enums, "fixture gained enums — restore the DocEnum pinShape here").toEqual([]);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,32 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { groupStyle } from "../groupColor";
|
||||
|
||||
describe("groupStyle", () => {
|
||||
it("exposes the hue as a CSS custom property", () => {
|
||||
expect(groupStyle(28)).toEqual({ "--h": "28" });
|
||||
});
|
||||
|
||||
it("returns no custom property for an ungrouped section", () => {
|
||||
expect(groupStyle(null)).toEqual({});
|
||||
});
|
||||
|
||||
it("wraps hues into 0-359 rather than emitting an out-of-range value", () => {
|
||||
expect(groupStyle(360)).toEqual({ "--h": "0" });
|
||||
expect(groupStyle(388)).toEqual({ "--h": "28" });
|
||||
expect(groupStyle(-1)).toEqual({ "--h": "359" });
|
||||
});
|
||||
|
||||
it("never emits a colour value", () => {
|
||||
// Lightness and chroma belong to the theme. If this function ever returns
|
||||
// a hex or oklch string, the dark-mode contrast guarantee is gone.
|
||||
const style = groupStyle(200);
|
||||
const serialized = JSON.stringify(style);
|
||||
expect(serialized).not.toContain("#");
|
||||
expect(serialized).not.toContain("oklch");
|
||||
expect(serialized).not.toContain("rgb");
|
||||
});
|
||||
|
||||
it("coerces a non-integer hue to an integer", () => {
|
||||
expect(groupStyle(28.7)).toEqual({ "--h": "28" });
|
||||
});
|
||||
});
|
||||
+100
@@ -0,0 +1,100 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { renderNote } from "../renderNote";
|
||||
|
||||
describe("renderNote", () => {
|
||||
it("renders ordinary markdown", () => {
|
||||
expect(renderNote("One row per **checkout**.")).toContain("<strong>checkout</strong>");
|
||||
});
|
||||
|
||||
it("renders inline code and fenced blocks", () => {
|
||||
expect(renderNote("see `order_status`")).toContain("<code>order_status</code>");
|
||||
expect(renderNote("```sql\nSELECT 1;\n```")).toContain("<pre>");
|
||||
});
|
||||
|
||||
it("returns an empty string for null or blank input", () => {
|
||||
expect(renderNote(null)).toBe("");
|
||||
expect(renderNote(" ")).toBe("");
|
||||
});
|
||||
|
||||
it("escapes a script tag rather than rendering it", () => {
|
||||
const html = renderNote("<script>alert(1)</script>");
|
||||
expect(html).not.toContain("<script>");
|
||||
expect(html).toContain("<script>");
|
||||
});
|
||||
|
||||
it("escapes an img onerror payload", () => {
|
||||
// NB: asserting !contains("onerror=") would FAIL against a correct
|
||||
// implementation — the escaped text legitimately still contains that
|
||||
// substring. What matters is that no <img> ELEMENT is produced.
|
||||
const html = renderNote('<img src=x onerror="alert(1)">');
|
||||
expect(html.toLowerCase()).not.toContain("<img");
|
||||
expect(html).toContain("<img");
|
||||
});
|
||||
|
||||
it("escapes raw HTML even when it looks harmless", () => {
|
||||
// Blanket rule: no author-supplied HTML is rendered, ever. A rule with
|
||||
// exceptions is a rule someone will find a way around.
|
||||
const html = renderNote("<b>bold</b>");
|
||||
expect(html).not.toContain("<b>bold</b>");
|
||||
expect(html).toContain("<b>");
|
||||
});
|
||||
|
||||
it("does not preserve HTML entities twice", () => {
|
||||
// Guards the pre-escaping approach, which turns "a & b" into
|
||||
// "a &amp; b" and renders the entity visibly to the reader.
|
||||
expect(renderNote("a & b")).toContain("a & b");
|
||||
expect(renderNote("a & b")).not.toContain("&amp;");
|
||||
});
|
||||
|
||||
it.each([
|
||||
["javascript:alert(1)", "javascript"],
|
||||
["JaVaScRiPt:alert(1)", "javascript"],
|
||||
["javascript:alert(1)", "avascript"],
|
||||
["vbscript:alert(1)", "vbscript"],
|
||||
["data:text/html;base64,PHNjcmlwdD4=", "data:"],
|
||||
])("drops the unsafe link scheme %s", (href, forbidden) => {
|
||||
const html = renderNote(`[click](${href})`).toLowerCase();
|
||||
expect(html).not.toContain(forbidden);
|
||||
expect(html).toContain("click"); // the text survives; only the href is dropped
|
||||
});
|
||||
|
||||
it("drops an unsafe image scheme", () => {
|
||||
const html = renderNote(")").toLowerCase();
|
||||
expect(html).not.toContain("javascript");
|
||||
expect(html).not.toContain("<img");
|
||||
});
|
||||
|
||||
it.each(["//evil.example.com", "//evil.example.com/a.png", "/\\evil.example.com", "/\\evil.example.com/a.png", "\\\\evil.example.com"])("drops the protocol-relative URL %s", (href) => {
|
||||
// The URL spec treats /\ like //, so both separators must be rejected.
|
||||
expect(renderNote(`[x](${href})`)).not.toContain("evil.example.com");
|
||||
expect(renderNote(``)).not.toContain("evil.example.com");
|
||||
});
|
||||
|
||||
it("escapes single quotes so the escaper does not rely on double-quoted attributes", () => {
|
||||
// Not exploitable while every attribute here is double-quoted, but that is
|
||||
// a formatting convention enforced nowhere. Escaping ' keeps escapeHtml
|
||||
// correct on its own rather than correct-given-a-distant-invariant.
|
||||
const html = renderNote(`[x](https://example.com "it's here")`);
|
||||
expect(html).toContain("'");
|
||||
expect(html).not.toContain("it's here");
|
||||
});
|
||||
|
||||
it("still allows an ordinary root-relative path", () => {
|
||||
// The // guard must not break the single-slash relative case it sits in
|
||||
// front of.
|
||||
expect(renderNote("[x](/docs/page.html)")).toContain('href="/docs/page.html"');
|
||||
});
|
||||
|
||||
it.each(["https://example.com", "http://example.com", "mailto:a@b.com", "#anchor", "./rel.html"])("keeps the safe link target %s", (href) => {
|
||||
expect(renderNote(`[ok](${href})`)).toContain(`href="${href}"`);
|
||||
});
|
||||
|
||||
it("parses markdown inside link text instead of emitting it raw", () => {
|
||||
// marked hands the renderer the RAW source text. Emitting it directly
|
||||
// both breaks formatting and injects unescaped HTML.
|
||||
expect(renderNote("[**keep**](https://example.com)")).toContain("<strong>keep</strong>");
|
||||
const dropped = renderNote('[<img src=x onerror="alert(1)">](javascript:alert(1))');
|
||||
expect(dropped.toLowerCase()).not.toContain("<img");
|
||||
expect(dropped).toContain("<img");
|
||||
});
|
||||
});
|
||||
+95
@@ -0,0 +1,95 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import type { ColumnInfo, IndexInfo, SchemaSnapshot, SnapshotWarning } from "../types";
|
||||
|
||||
describe("snapshot types", () => {
|
||||
it("accepts a minimal snapshot shaped like the Rust output", () => {
|
||||
const snapshot: SchemaSnapshot = {
|
||||
formatVersion: 1,
|
||||
project: {
|
||||
name: "Ecommerce",
|
||||
databaseType: "postgres",
|
||||
database: "shop",
|
||||
schemas: ["public"],
|
||||
generatedAt: "2026-08-03T00:00:00Z",
|
||||
note: null,
|
||||
},
|
||||
tables: [
|
||||
{
|
||||
schema: "public",
|
||||
name: "orders",
|
||||
kind: "TABLE",
|
||||
columns: [],
|
||||
indexes: [],
|
||||
foreignKeys: [],
|
||||
groupId: null,
|
||||
note: "Checkout rows.",
|
||||
noteSource: "DATABASE",
|
||||
shadowedNote: null,
|
||||
columnNotes: {},
|
||||
estimatedRows: null,
|
||||
viewDefinition: null,
|
||||
},
|
||||
],
|
||||
relationships: [],
|
||||
groups: [],
|
||||
enums: [],
|
||||
warnings: [],
|
||||
};
|
||||
|
||||
expect(snapshot.tables[0].noteSource).toBe("DATABASE");
|
||||
expect(snapshot.tables[0].kind).toBe("TABLE");
|
||||
});
|
||||
|
||||
it("discriminates warnings on a camelCase kind", () => {
|
||||
// Rust: #[serde(rename_all = "camelCase", tag = "kind")] — so the
|
||||
// discriminant is camelCase even though sibling enums are SCREAMING_SNAKE.
|
||||
const warning: SnapshotWarning = {
|
||||
kind: "tableSkipped",
|
||||
table: "public.secret",
|
||||
reason: "permission denied",
|
||||
};
|
||||
expect(warning.kind).toBe("tableSkipped");
|
||||
|
||||
const orphans: SnapshotWarning = { kind: "orphanedNotes", count: 3 };
|
||||
if (orphans.kind === "orphanedNotes") {
|
||||
expect(orphans.count).toBe(3);
|
||||
} else {
|
||||
throw new Error("discriminated union must narrow on kind");
|
||||
}
|
||||
});
|
||||
|
||||
it("requires the always-serialized column and index fields", () => {
|
||||
// These keys have no skip_serializing_if in Rust, so they are always
|
||||
// present in the JSON. Typing them optional would let `undefined` reach
|
||||
// code that checks `=== null`.
|
||||
const column: ColumnInfo = {
|
||||
name: "status",
|
||||
data_type: "text",
|
||||
is_nullable: false,
|
||||
column_default: null,
|
||||
is_primary_key: false,
|
||||
extra: null,
|
||||
comment: null,
|
||||
numeric_precision: null,
|
||||
numeric_scale: null,
|
||||
character_maximum_length: null,
|
||||
};
|
||||
expect(column.comment).toBeNull();
|
||||
|
||||
const index: IndexInfo = {
|
||||
name: "idx",
|
||||
columns: ["status"],
|
||||
is_unique: false,
|
||||
is_primary: false,
|
||||
filter: null,
|
||||
index_type: null,
|
||||
included_columns: null,
|
||||
comment: null,
|
||||
};
|
||||
expect(index.filter).toBeNull();
|
||||
|
||||
// The skip_serializing_if fields may simply be absent.
|
||||
const minimal: ColumnInfo = { ...column, enum_values: undefined };
|
||||
expect(minimal.character_set).toBeUndefined();
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user