fix(editor): bound dangerous SQL preview size
This commit is contained in:
1 parent
1cf594eac3
commit
f6bba1cb6b
12 files changed
+287
-6
No files matched your search
@@ -0,0 +1,86 @@
|
||||
// @vitest-environment happy-dom
|
||||
|
||||
import { createApp, defineComponent, h, nextTick, reactive, type App } from "vue";
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import i18n from "@/i18n";
|
||||
import DangerConfirmDialog from "@/components/editor/DangerConfirmDialog.vue";
|
||||
import { copyToClipboard } from "@/lib/common/clipboard";
|
||||
|
||||
const DANGER_PREVIEW_MAX_CHARACTERS = 8192;
|
||||
const DANGER_PREVIEW_MAX_LINES = 200;
|
||||
const highlight = vi.fn((sql: string) => `<span>${sql}</span>`);
|
||||
|
||||
vi.mock("@/composables/useSqlHighlighter", () => ({
|
||||
useSqlHighlighter: () => ({ highlight }),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/common/clipboard", () => ({
|
||||
copyToClipboard: vi.fn(),
|
||||
}));
|
||||
|
||||
const mountedApps: App[] = [];
|
||||
|
||||
async function mountDialog(sql: string) {
|
||||
const state = reactive({ open: true });
|
||||
const container = document.createElement("div");
|
||||
document.body.append(container);
|
||||
const app = createApp(
|
||||
defineComponent({
|
||||
setup: () => () =>
|
||||
h(DangerConfirmDialog, {
|
||||
open: state.open,
|
||||
sql,
|
||||
"onUpdate:open": (value: boolean) => {
|
||||
state.open = value;
|
||||
},
|
||||
}),
|
||||
}),
|
||||
);
|
||||
mountedApps.push(app);
|
||||
app.use(i18n);
|
||||
app.mount(container);
|
||||
await nextTick();
|
||||
await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
}
|
||||
|
||||
afterEach(() => {
|
||||
for (const app of mountedApps.splice(0)) app.unmount();
|
||||
document.body.innerHTML = "";
|
||||
highlight.mockClear();
|
||||
vi.mocked(copyToClipboard).mockClear();
|
||||
});
|
||||
|
||||
describe("DangerConfirmDialog SQL preview", () => {
|
||||
it("fully highlights short SQL without a truncation notice", async () => {
|
||||
const sql = "DROP TABLE IF EXISTS users;";
|
||||
|
||||
await mountDialog(sql);
|
||||
|
||||
expect(highlight).toHaveBeenCalledOnce();
|
||||
expect(highlight).toHaveBeenCalledWith(sql);
|
||||
expect(document.body.querySelector('[data-testid="danger-preview-truncated"]')).toBeNull();
|
||||
});
|
||||
|
||||
it("highlights only bounded head and tail fragments for huge SQL", async () => {
|
||||
const sql = Array.from({ length: 40_000 }, (_, index) => `INSERT INTO t VALUES (${index});`).join("\n");
|
||||
|
||||
await mountDialog(sql);
|
||||
|
||||
const highlightedCharacters = highlight.mock.calls.reduce((total, [fragment]) => total + fragment.length, 0);
|
||||
expect(highlight).toHaveBeenCalledTimes(2);
|
||||
expect(highlightedCharacters).toBeLessThanOrEqual(DANGER_PREVIEW_MAX_CHARACTERS);
|
||||
expect(highlight.mock.calls.flatMap(([fragment]) => fragment.split("\n"))).toHaveLength(DANGER_PREVIEW_MAX_LINES);
|
||||
expect(document.body.querySelector('[data-testid="danger-preview-truncated"]')?.textContent).toContain("Preview truncated");
|
||||
});
|
||||
|
||||
it("copies the full SQL instead of the bounded preview", async () => {
|
||||
const sql = Array.from({ length: 40_000 }, (_, index) => `INSERT INTO t VALUES (${index});`).join("\n");
|
||||
|
||||
await mountDialog(sql);
|
||||
const copyButton = Array.from(document.body.querySelectorAll("button")).find((button) => button.title === "Copy full text");
|
||||
copyButton?.click();
|
||||
await nextTick();
|
||||
|
||||
expect(copyToClipboard).toHaveBeenCalledWith(sql);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user