feat(grid): support batch pasting into new rows
This commit is contained in:
1 parent
9173cb754d
commit
ffde91499a
10 files changed
+380
-6
No files matched your search
@@ -0,0 +1,222 @@
|
||||
import { computed, ref } from "vue";
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { DATA_GRID_QUICK_ENTRY_DRAFT_ROW_ID, useDataGridEditor } from "@/composables/useDataGridEditor";
|
||||
import type { CellValue } from "@/lib/dataGrid/cellValue";
|
||||
|
||||
const mocks = vi.hoisted(() => ({
|
||||
getConfig: vi.fn(),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/backend/api", () => ({}));
|
||||
vi.mock("@/stores/connectionStore", () => ({
|
||||
useConnectionStore: () => ({ getConfig: mocks.getConfig }),
|
||||
}));
|
||||
vi.mock("@/stores/historyStore", () => ({
|
||||
useHistoryStore: () => ({}),
|
||||
}));
|
||||
vi.mock("@/stores/productionSafetyStore", () => ({
|
||||
useProductionSafetyStore: () => ({}),
|
||||
}));
|
||||
|
||||
function createEditor(sourceColumns?: Array<string | undefined>) {
|
||||
let editor: ReturnType<typeof useDataGridEditor>;
|
||||
const result = ref<{ columns: string[]; rows: CellValue[][] }>({
|
||||
columns: ["first", "hidden", "last"],
|
||||
rows: [],
|
||||
});
|
||||
|
||||
editor = useDataGridEditor({
|
||||
result: computed(() => result.value),
|
||||
editable: computed(() => true),
|
||||
databaseType: computed(() => "postgres"),
|
||||
connectionId: computed(() => "connection-1"),
|
||||
database: computed(() => "app"),
|
||||
tableMeta: computed(() => ({
|
||||
tableName: "people",
|
||||
columns: [
|
||||
{ name: "first", data_type: "varchar" },
|
||||
{ name: "hidden", data_type: "varchar" },
|
||||
{ name: "last", data_type: "varchar" },
|
||||
],
|
||||
primaryKeys: [],
|
||||
})),
|
||||
sourceColumns: computed(() => sourceColumns),
|
||||
onExecuteSql: computed(() => undefined),
|
||||
sql: computed(() => undefined),
|
||||
searchText: ref(""),
|
||||
whereFilterInput: ref(""),
|
||||
currentWhereInput: computed(() => undefined),
|
||||
orderByInput: ref(""),
|
||||
rowStatusFilter: ref("all"),
|
||||
pageSize: ref(100),
|
||||
currentPage: ref(1),
|
||||
getRowItem: (rowId) => {
|
||||
if (rowId === DATA_GRID_QUICK_ENTRY_DRAFT_ROW_ID) {
|
||||
return {
|
||||
id: rowId,
|
||||
data: editor.quickEntryDraftRow.value,
|
||||
isNew: false,
|
||||
isDraft: true,
|
||||
isDeleted: false,
|
||||
isDirtyCol: [false, false, false],
|
||||
status: "draft",
|
||||
};
|
||||
}
|
||||
const newIndex = -rowId - 1;
|
||||
const row = editor.newRows.value[newIndex];
|
||||
if (!row) return undefined;
|
||||
return {
|
||||
id: rowId,
|
||||
newIndex,
|
||||
data: row,
|
||||
isNew: true,
|
||||
isDeleted: false,
|
||||
isDirtyCol: [false, false, false],
|
||||
status: "new",
|
||||
};
|
||||
},
|
||||
emit: vi.fn(),
|
||||
});
|
||||
|
||||
editor.newRows.value = [[null, null, null]];
|
||||
return editor;
|
||||
}
|
||||
|
||||
describe("useDataGridEditor appendPastedRowsToNewRow", () => {
|
||||
beforeEach(() => {
|
||||
mocks.getConfig.mockReturnValue({ id: "connection-1", db_type: "postgres" });
|
||||
});
|
||||
|
||||
it("fills the selected blank new row and appends remaining rows using visible columns", () => {
|
||||
const editor = createEditor();
|
||||
|
||||
const result = editor.appendPastedRowsToNewRow(
|
||||
-1,
|
||||
[
|
||||
["Ada", "Lovelace"],
|
||||
["Grace", "Hopper"],
|
||||
],
|
||||
[0, 2],
|
||||
);
|
||||
|
||||
expect(result).toEqual({ ok: true, rowCount: 2 });
|
||||
expect(editor.newRows.value).toEqual([
|
||||
["Ada", null, "Lovelace"],
|
||||
["Grace", null, "Hopper"],
|
||||
]);
|
||||
expect(editor.hasPendingChanges.value).toBe(true);
|
||||
});
|
||||
|
||||
it("fills following blank new rows before adding more rows", () => {
|
||||
const editor = createEditor();
|
||||
editor.newRows.value = [
|
||||
[null, null, null],
|
||||
[null, null, null],
|
||||
];
|
||||
|
||||
const result = editor.appendPastedRowsToNewRow(-1, [["Ada"], ["Grace"]], [0, 2]);
|
||||
|
||||
expect(result).toEqual({ ok: true, rowCount: 2 });
|
||||
expect(editor.newRows.value).toEqual([
|
||||
["Ada", null, null],
|
||||
["Grace", null, null],
|
||||
]);
|
||||
});
|
||||
|
||||
it("turns rows pasted into the terminal new-row draft into pending rows", () => {
|
||||
const editor = createEditor();
|
||||
editor.newRows.value = [];
|
||||
|
||||
const result = editor.appendPastedRowsToNewRow(
|
||||
DATA_GRID_QUICK_ENTRY_DRAFT_ROW_ID,
|
||||
[
|
||||
["Ada", "Lovelace"],
|
||||
["Grace", "Hopper"],
|
||||
],
|
||||
[0, 2],
|
||||
);
|
||||
|
||||
expect(result).toEqual({ ok: true, rowCount: 2 });
|
||||
expect(editor.newRows.value).toEqual([
|
||||
["Ada", null, "Lovelace"],
|
||||
["Grace", null, "Hopper"],
|
||||
]);
|
||||
expect(editor.quickEntryDraftRow.value).toEqual([null, null, null]);
|
||||
expect(editor.hasPendingChanges.value).toBe(true);
|
||||
|
||||
editor.undoPendingChange();
|
||||
expect(editor.newRows.value).toEqual([]);
|
||||
expect(editor.quickEntryDraftRow.value).toEqual([null, null, null]);
|
||||
|
||||
editor.redoPendingChange();
|
||||
expect(editor.newRows.value).toEqual([
|
||||
["Ada", null, "Lovelace"],
|
||||
["Grace", null, "Hopper"],
|
||||
]);
|
||||
});
|
||||
|
||||
it("rejects a non-empty terminal new-row draft", () => {
|
||||
const editor = createEditor();
|
||||
editor.newRows.value = [];
|
||||
editor.quickEntryDraftRow.value = ["already", null, null];
|
||||
|
||||
const result = editor.appendPastedRowsToNewRow(DATA_GRID_QUICK_ENTRY_DRAFT_ROW_ID, [["Ada"]], [0, 2]);
|
||||
|
||||
expect(result).toEqual({ ok: false, reason: "target-not-empty" });
|
||||
expect(editor.newRows.value).toEqual([]);
|
||||
expect(editor.quickEntryDraftRow.value).toEqual(["already", null, null]);
|
||||
});
|
||||
|
||||
it("truncates pasted columns that exceed the visible table columns", () => {
|
||||
const editor = createEditor();
|
||||
|
||||
const result = editor.appendPastedRowsToNewRow(-1, [["Ada", "Byron", "Lovelace"]], [0, 2]);
|
||||
|
||||
expect(result).toEqual({ ok: true, rowCount: 1 });
|
||||
expect(editor.newRows.value).toEqual([["Ada", null, "Byron"]]);
|
||||
expect(editor.canUndoPendingChange.value).toBe(true);
|
||||
});
|
||||
|
||||
it("rejects an empty textual clipboard payload without changing pending rows", () => {
|
||||
const editor = createEditor();
|
||||
|
||||
const result = editor.appendPastedRowsToNewRow(-1, [[""]], [0, 2]);
|
||||
|
||||
expect(result).toEqual({ ok: false, reason: "empty-paste" });
|
||||
expect(editor.newRows.value).toEqual([[null, null, null]]);
|
||||
expect(editor.canUndoPendingChange.value).toBe(false);
|
||||
});
|
||||
|
||||
it("rejects a paste that targets a read-only visible column", () => {
|
||||
const editor = createEditor(["first", undefined, "last"]);
|
||||
|
||||
const result = editor.appendPastedRowsToNewRow(-1, [["Ada"]], [1]);
|
||||
|
||||
expect(result).toEqual({ ok: false, reason: "readonly-column" });
|
||||
expect(editor.newRows.value).toEqual([[null, null, null]]);
|
||||
});
|
||||
|
||||
it("does not overwrite an existing new row selected as the append target", () => {
|
||||
const editor = createEditor();
|
||||
editor.newRows.value = [["already", null, null]];
|
||||
|
||||
const result = editor.appendPastedRowsToNewRow(-1, [["Ada"]], [0, 2]);
|
||||
|
||||
expect(result).toEqual({ ok: false, reason: "target-not-empty" });
|
||||
expect(editor.newRows.value).toEqual([["already", null, null]]);
|
||||
});
|
||||
|
||||
it("treats a batch append as one undoable change", () => {
|
||||
const editor = createEditor();
|
||||
|
||||
editor.appendPastedRowsToNewRow(-1, [["Ada"], ["Grace"]], [0, 2]);
|
||||
editor.undoPendingChange();
|
||||
expect(editor.newRows.value).toEqual([[null, null, null]]);
|
||||
|
||||
editor.redoPendingChange();
|
||||
expect(editor.newRows.value).toEqual([
|
||||
["Ada", null, null],
|
||||
["Grace", null, null],
|
||||
]);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user