runstone
a440415e86
## Background Add a read-only toggle for database connections that blocks all write operations (INSERT, UPDATE, DELETE, DROP, etc.) when enabled, allowing only read queries (SELECT, SHOW, EXPLAIN, etc.). Closes #889. ## Changes ### Data Model - Added `read_only: bool` field to ConnectionConfig (Rust struct, TS interfaces, and ConnectionConfigData deserialization layer) - Used `#[serde(default, skip_serializing_if = "is_false")]` for backward/forward compatibility with existing configs ### Frontend UI - Added "Read Only" checkbox in connection dialog - 7-language i18n support (en/es/it/pt-BR/zh-CN/zh-TW) ### SQL Classification (query_execution_sql.rs) - Added `is_write_sql()` with two-layer defense: - Layer 1: First-keyword check (must start with known read keyword) - Layer 2: Embedded dangerous keyword detection (catches CTE-wrapped writes like `WITH ... AS (DELETE FROM ...)`) - `FROM` keyword supported as DuckDB SELECT-less syntax indicator - Added `check_read_only()` returning descriptive error with connection name - Added 16 unit tests covering: pure reads/writes, CTE, case insensitivity, string literal masking, comment stripping, stored procedure calls, edge cases ### SQL Execution Guards (query.rs / transfer.rs) - Added `check_read_only_for_connection()` and `_multi()` helper functions with lazy name clone (only allocates when read_only is true) - 6 interception points: `do_execute`, MySQL batch, SQL Server batch, DuckDB batch, transaction execution, transfer execution ### Non-SQL Write Guards — Tauri Commands - Added `ensure_connection_writable()` helper (connection.rs) - Mongo: 6 write entry points (insert/update/delete, single + batch) - Redis: 15 write entry points (SET, DEL, HSET, HDEL, LPUSH, LSET, LREM, SADD, SREM, ZADD, ZREM, EXPIRE, FLUSHDB, delete_keys, execute_command) - execute_command uses RedisCommandSafety classification to allow safe read commands through raw command interface - etcd: 2 write entry points (put, delete) - sql_file: SQL file execution guarded - MCP Bridge: 4 write entry points (Insert/Update/Delete/SQL query) ### Non-SQL Write Guards — Web API - Local `ensure_writable()` helper in each route module - Redis: 12 write endpoints including classified execute_command - Mongo: 6 write endpoints - etcd: 2 write endpoints - sql_file, table_import, transfer: early rejection ### Test Updates - Updated ConnectionConfig construction in 7 test files with `read_only: false` initialization ## Defense-in-Depth - Layer 1: Command/Route-level early rejection (saves resources) - Layer 2: Core SQL classifier (`is_write_sql` — first keyword + embedded scan) - Layer 3: Core execution-time interception (do_execute/transfer/transaction)
71 lines
2.3 KiB
Rust
71 lines
2.3 KiB
Rust
use std::collections::HashSet;
|
|
use std::sync::{Arc, OnceLock};
|
|
|
|
use tauri::{AppHandle, Emitter, State};
|
|
use tokio::sync::RwLock;
|
|
|
|
use crate::commands::connection::{ensure_connection_writable, AppState};
|
|
use crate::commands::transfer::get_db_type;
|
|
|
|
// Re-export types for backward compatibility
|
|
pub use dbx_core::table_import::{TableImportPreview, TableImportProgress, TableImportRequest, TableImportSummary};
|
|
|
|
static CANCELLED_IMPORTS: OnceLock<RwLock<HashSet<String>>> = OnceLock::new();
|
|
|
|
fn cancelled_imports() -> &'static RwLock<HashSet<String>> {
|
|
CANCELLED_IMPORTS.get_or_init(|| RwLock::new(HashSet::new()))
|
|
}
|
|
|
|
fn emit_progress(app: &AppHandle, progress: TableImportProgress) {
|
|
let _ = app.emit("table-import-progress", progress);
|
|
}
|
|
|
|
async fn is_cancelled(import_id: &str) -> bool {
|
|
cancelled_imports().read().await.contains(import_id)
|
|
}
|
|
|
|
async fn clear_cancelled(import_id: &str) {
|
|
cancelled_imports().write().await.remove(import_id);
|
|
}
|
|
|
|
#[tauri::command]
|
|
pub async fn preview_table_import_file(file_path: String) -> Result<TableImportPreview, String> {
|
|
dbx_core::table_import::preview_table_import_file_core(&file_path).await
|
|
}
|
|
|
|
#[tauri::command]
|
|
pub async fn import_table_file(
|
|
app: AppHandle,
|
|
state: State<'_, Arc<AppState>>,
|
|
request: TableImportRequest,
|
|
) -> Result<TableImportSummary, String> {
|
|
clear_cancelled(&request.import_id).await;
|
|
// Reject import early if the connection is read-only — importing is inherently a write operation
|
|
ensure_connection_writable(&state, &request.connection_id, "Import").await?;
|
|
let db_type = get_db_type(&state, &request.connection_id).await?;
|
|
let pool_key = if request.database.is_empty() {
|
|
request.connection_id.clone()
|
|
} else {
|
|
state.get_or_create_pool(&request.connection_id, Some(&request.database)).await?
|
|
};
|
|
|
|
let result = dbx_core::table_import::import_table_file_core(
|
|
&state,
|
|
&request,
|
|
&db_type,
|
|
&pool_key,
|
|
|import_id| Box::pin(is_cancelled(import_id)),
|
|
|progress| emit_progress(&app, progress),
|
|
)
|
|
.await;
|
|
|
|
clear_cancelled(&request.import_id).await;
|
|
result
|
|
}
|
|
|
|
#[tauri::command]
|
|
pub async fn cancel_table_import(import_id: String) -> Result<bool, String> {
|
|
cancelled_imports().write().await.insert(import_id);
|
|
Ok(true)
|
|
}
|