Fixing squid:S1155 - Collection.isEmpty() should be used to test for emptiness

This commit is contained in:
Artyom Melnikov committed 2016-06-22 13:43:15 +03:00
1 parent a64a020e36
commit 0a3b819991
66 files changed
+92 -92

No files matched your search

@@ -452,7 +452,7 @@ public class CQueryBuilder {
String inheritanceWhere = select.getInheritanceWhereSql();
boolean hasWhere = false;
if (inheritanceWhere.length() > 0) {
if (!inheritanceWhere.isEmpty()) {
sb.append(" where");
sb.append(inheritanceWhere);
hasWhere = true;
@@ -557,7 +557,7 @@ public class CQueryBuilder {
}
private boolean isEmpty(String s) {
return s == null || s.length() == 0;
return s == null || s.isEmpty();
}
}
@@ -134,7 +134,7 @@ public class CQueryBuilderRawSql {
}
private boolean isEmpty(String s) {
return s == null || s.length() == 0;
return s == null || s.isEmpty();
}
private String getOrderBy(CQueryPredicates predicates, RawSql.Sql sql) {
@@ -305,7 +305,7 @@ public class CQueryPredicates {
}
private boolean isEmpty(String s) {
return s == null || s.length() == 0;
return s == null || s.isEmpty();
}
private String parse(String expr, DeployParser deployParser) {
@@ -138,7 +138,7 @@ public class DefaultDbSqlContext implements DbSqlContext {
// add on any inheritance where clause
if (inheritance != null && inheritance.length() > 0) {
if (inheritance != null && !inheritance.isEmpty()) {
sb.append(" and ");
sb.append(a2);
sb.append(".");
@@ -417,7 +417,7 @@ public class SqlTreeBuilder {
// This makes sense for transient properties used to
// hold sum() count() type values (with SqlSelect)
for (String propName : queryProps.getSelectProperties()) {
if (propName.length() > 0) {
if (!propName.isEmpty()) {
addProperty(selectProps, desc, queryProps, propName);
}
}