DbMigration is a plugin now

This commit is contained in:
Roland Praml committed 2022-01-04 09:47:00 +01:00
1 parent 803325cb4b
commit 208e987ab5
14 files changed
+284 -87

No files matched your search

@@ -75,13 +75,11 @@ public class DbMigrationDropHistoryTest {
List<String> pendingDrops = migration.getPendingDrops();
assertThat(pendingDrops).contains("1.1");
//System.setProperty("ddl.migration.pendingDropsFor", "1.1");
migration.setGeneratePendingDrop("1.1");
assertThat(migration.generateMigration()).isEqualTo("1.2__dropsFor_1.1");
assertThatThrownBy(()->migration.generateMigration())
.isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("No 'pendingDrops'"); // subsequent call
System.clearProperty("ddl.migration.pendingDropsFor");
server.shutdown();
logger.info("end");
@@ -1,8 +1,6 @@
package io.ebeaninternal.dbmigration;
import io.ebean.Database;
import io.ebean.DatabaseFactory;
import io.ebean.annotation.Platform;
import io.ebean.config.DatabaseConfig;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
@@ -16,7 +14,6 @@ import java.nio.file.Paths;
import java.util.Arrays;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
/**
@@ -45,14 +42,7 @@ public class DbMigrationGenerateTest {
config.loadFromProperties();
config.setRegister(false);
config.setDefaultServer(false);
config.getProperties().put("ebean.hana.generateUniqueDdl", "true"); // need to generate unique statements to prevent them from being filtered out as duplicates by the DdlRunner
config.getProperties().put("ebean.migrationtest.migration.pathToResources", pathToResources);
config.getProperties().put("ebean.migrationtest.migration.includeIndex", "true");
config.getProperties().put("ebean.migrationtest.migration.generateInit", "true");
config.getProperties().put("ebean.migrationtest.migration.generatePendingDrop", "auto");
config.getProperties().put("ebean.migrationtest.migration.platforms", "db2,h2,hsqldb,mysql,mysql55=mysql55,postgres,oracle,sqlite,sqlserver17=sqlserver17,hana");
config.setPackages(Arrays.asList("misc.migration.v1_0"));
// First, we clean up the output-directory
@@ -1,19 +1,14 @@
package io.ebeaninternal.dbmigration;
import io.ebean.Database;
import io.ebean.DatabaseFactory;
import io.ebean.annotation.Platform;
import io.ebean.config.DatabaseConfig;
import io.ebean.config.PlatformConfig;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import java.io.File;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Arrays;
import static org.assertj.core.api.Assertions.assertThat;
@@ -25,62 +20,102 @@ import static org.assertj.core.api.Assertions.assertThat;
*/
public class MysqlGenerateMigrationTest {
@AfterEach
public void resetPendingDropsProperty() {
System.clearProperty("ddl.migration.pendingDropsFor");
}
@Test
public void testMysqlStoredProcedures() throws Exception {
DefaultDbMigration migration = new DefaultDbMigration();
migration.setIncludeIndex(true);
// We use src/test/resources as output directory (so we see in GIT if files will change)
migration.setPathToResources("src/test/resources");
migration.addPlatform(Platform.MYSQL, "mysql");
final PlatformConfig platformConfig = new PlatformConfig();
platformConfig.setUseMigrationStoredProcedures(true);
String pathToResources = "src/test/resources";
DatabaseConfig config = new DatabaseConfig();
config.setName("migrationtest");
config.loadFromProperties();
config.setPlatformConfig(platformConfig);
config.setRegister(false);
config.setDefaultServer(false);
config.getProperties().put("ebean.migration.migrationPath", "db/migration/mysql");
config.setPackages(Arrays.asList("misc.migration.mysql_v1_0"));
Database server = DatabaseFactory.create(config);
migration.setServer(server);
migration.setMigrationPath("mysql/procedures");
config.getProperties().put("ebean.migrationtest.migration.pathToResources", pathToResources);
config.getProperties().put("ebean.migrationtest.useMigrationStoredProcedures", true);
config.getProperties().put("ebean.migrationtest.migration.platforms", "mysql");
config.getProperties().put("ebean.migrationtest.migration.migrationPath", "dbmigration/migrationtest-procedures/");
config.setPackages(Arrays.asList("misc.migration.v1_0"));
// First, we clean up the output-directory
assertThat(migration.migrationDirectory().getAbsolutePath()).contains("procedures");
Files.walk(migration.migrationDirectory().toPath())
.filter(Files::isRegularFile)
.map(Path::toFile).forEach(File::delete);
// Files.walk(Paths.get(pathToResources , "dbmigration","migrationtest-procedures"))
// .filter(Files::isRegularFile).map(Path::toFile).forEach(File::delete);
DatabaseFactory.create(config).shutdown();
// then we generate migration scripts for v1_0
assertThat(migration.generateMigration()).isEqualTo("1.0__initial");
assertThat(DbMigrationPlugin.getLastMigration()).isEqualTo("1.0__initial");
assertThat(DbMigrationPlugin.getLastInit()).isEqualTo("1.0__initial");
// and we check repeatative calls
DatabaseFactory.create(config).shutdown();
assertThat(DbMigrationPlugin.getLastMigration()).isNull();
assertThat(DbMigrationPlugin.getLastInit()).isNull();
// and now for v1_1
config.setPackages(Arrays.asList("misc.migration.v1_1"));
DatabaseFactory.create(config).shutdown();
assertThat(DbMigrationPlugin.getLastMigration()).isEqualTo("1.1,1.2__dropsFor_1.1");
assertThat(DbMigrationPlugin.getLastInit()).isEqualTo("1.2");
config.setPackages(Arrays.asList("misc.migration.mysql_v1_1"));
server.shutdown();
server = DatabaseFactory.create(config);
migration.setServer(server);
migration.setMigrationPath("mysql/procedures");
assertThat(migration.generateMigration()).isEqualTo("1.1");
System.setProperty("ddl.migration.pendingDropsFor", "1.1");
assertThat(migration.generateMigration()).isEqualTo("1.2__dropsFor_1.1");
final Path sqlFile = migration.migrationDirectory().toPath()
.resolve("mysql/1.2__dropsFor_1.1.sql");
assertThat(sqlFile).isNotEmptyFile();
assertThat(Files.readAllLines(sqlFile, StandardCharsets.UTF_8))
.contains("CALL usp_ebean_drop_column('migtest_e_basic', 'status2');")
.contains("CALL usp_ebean_drop_column('migtest_e_basic', 'description');");
// // subsequent call
// DatabaseFactory.create(config).shutdown();
// assertThat(DbMigrationPlugin.getLastMigration()).isNull();
// assertThat(DbMigrationPlugin.getLastInit()).isNull();
//
// // and now for v1_2
// config.setPackages(Arrays.asList("misc.migration.v1_2"));
// DatabaseFactory.create(config).shutdown();
// assertThat(DbMigrationPlugin.getLastMigration()).isEqualTo("1.3,1.4__dropsFor_1.3");
// assertThat(DbMigrationPlugin.getLastInit()).isEqualTo("1.4");
//
//
// DefaultDbMigration migration = new DefaultDbMigration();
// migration.setIncludeIndex(true);
// // We use src/test/resources as output directory (so we see in GIT if files will change)
// migration.setPathToResources("src/test/resources");
//
// migration.addPlatform(Platform.MYSQL, "mysql");
//
// final PlatformConfig platformConfig = new PlatformConfig();
// platformConfig.setUseMigrationStoredProcedures(true);
//
// DatabaseConfig config = new DatabaseConfig();
// config.setName("migrationtest");
// config.loadFromProperties();
// config.setPlatformConfig(platformConfig);
// config.setRegister(false);
// config.setDefaultServer(false);
// config.getProperties().put("ebean.migration.migrationPath", "db/migration/mysql");
//
// config.setPackages(Arrays.asList("misc.migration.mysql_v1_0"));
// Database server = DatabaseFactory.create(config);
// migration.setServer(server);
// migration.setMigrationPath("mysql/procedures");
//
// // First, we clean up the output-directory
// assertThat(migration.migrationDirectory().getAbsolutePath()).contains("procedures");
// Files.walk(migration.migrationDirectory().toPath())
// .filter(Files::isRegularFile)
// .map(Path::toFile).forEach(File::delete);
//
// // then we generate migration scripts for v1_0
// assertThat(migration.generateMigration()).isEqualTo("1.0__initial");
//
// config.setPackages(Arrays.asList("misc.migration.mysql_v1_1"));
// server.shutdown();
// server = DatabaseFactory.create(config);
// migration.setServer(server);
// migration.setMigrationPath("mysql/procedures");
// assertThat(migration.generateMigration()).isEqualTo("1.1,1.2__dropsFor_1.1");
//
// final Path sqlFile = migration.migrationDirectory().toPath()
// .resolve("mysql/1.2__dropsFor_1.1.sql");
//
// assertThat(sqlFile).isNotEmptyFile();
// assertThat(Files.readAllLines(sqlFile, StandardCharsets.UTF_8))
// .contains("CALL usp_ebean_drop_column('migtest_e_basic', 'status2');")
// .contains("CALL usp_ebean_drop_column('migtest_e_basic', 'description');");
}
}