github/ebean
4
0 Fork 0
mirror of https://github.com/ebean-orm/ebean.git synced 2026-11-12 22:41:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

#2089 - Postgres - Use NO KEY with FOR UPDATE clauses with Postgres

Browse Source 
Rename PlatformConfig.defaultLockWithKey to PlatformConfig.forUpdateNoKey
This commit is contained in:
rob bygrave committed 2020-11-24 23:58:58 +13:00
1 parent 92a4bfb38e
commit 20fc74219a
5 files changed
+33 -18
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ebean-core/src/test/java/io/ebean/config/ServerConfigTest.java
+2 -2
View File
@@ -73,7 +73,7 @@ public class ServerConfigTest {
props.setProperty("caseSensitiveCollation", "false");
props.setProperty("loadModuleInfo", "true");
props.setProperty("collectQueryPlanThresholdMicros", "10000");
props.setProperty("lockWithKey", "false");
props.setProperty("forUpdateNoKey", "true");
serverConfig.loadFromProperties(props);
@@ -85,7 +85,7 @@ public class ServerConfigTest {
assertTrue(serverConfig.isIdGeneratorAutomatic());
assertFalse(serverConfig.getPlatformConfig().isCaseSensitiveCollation());
assertFalse(serverConfig.getPlatformConfig().isLockWithKey());
assertTrue(serverConfig.getPlatformConfig().isForUpdateNoKey());
assertThat(serverConfig.getNamingConvention()).isInstanceOf(MatchingNamingConvention.class);
ebean-core/src/test/java/io/ebean/config/dbplatform/PostgresPlatformTest.java
+3 -3
View File
@@ -29,7 +29,7 @@ public class PostgresPlatformTest {
PlatformConfig config = new PlatformConfig();
platform.configure(config);
assertThat(config.isLockWithKey()).isTrue();
assertThat(config.isForUpdateNoKey()).isFalse();
assertThat(platform.withForUpdate("X", Query.ForUpdate.SKIPLOCKED, Query.LockType.Default)).isEqualTo("X for update skip locked");
assertThat(platform.withForUpdate("X", Query.ForUpdate.NOWAIT, Query.LockType.Default)).isEqualTo("X for update nowait");
assertThat(platform.withForUpdate("X", Query.ForUpdate.BASE, Query.LockType.Default)).isEqualTo("X for update");
@@ -56,10 +56,10 @@ public class PostgresPlatformTest {
DatabasePlatform platform = new PostgresPlatform();
PlatformConfig config = new PlatformConfig();
config.setLockWithKey(false);
config.setForUpdateNoKey(true);
platform.configure(config);
assertThat(config.isLockWithKey()).isFalse();
assertThat(config.isForUpdateNoKey()).isTrue();
assertThat(platform.withForUpdate("X", Query.ForUpdate.SKIPLOCKED, Query.LockType.Default)).isEqualTo("X for no key update skip locked");
assertThat(platform.withForUpdate("X", Query.ForUpdate.NOWAIT, Query.LockType.Default)).isEqualTo("X for no key update nowait");
assertThat(platform.withForUpdate("X", Query.ForUpdate.BASE, Query.LockType.Default)).isEqualTo("X for no key update");