#2647 - When Postgres + isAllQuotedIdentifiers true + using DataSourceConfig THEN datasourceConfig.addProperty("quoteReturningIdentifiers", false);

I think there is not a case where we do NOT want to do this. allQuotedIdentifiers + Postgres is almost not usable without this.
This commit is contained in:
Rob Bygrave committed 2022-05-03 10:15:07 +12:00
1 parent f92887b2f0
commit 244f336f54
2 files changed
+45

No files matched your search

@@ -4,6 +4,9 @@ import io.ebean.config.DatabaseConfig;
import io.ebean.datasource.DataSourceAlert;
import io.ebean.datasource.DataSourceConfig;
import io.ebean.datasource.DataSourcePool;
import io.ebean.platform.h2.H2Platform;
import io.ebean.platform.postgres.Postgres9Platform;
import io.ebean.platform.postgres.PostgresPlatform;
import org.junit.jupiter.api.Test;
import javax.sql.DataSource;
@@ -128,6 +131,41 @@ public class InitDataSourceTest {
assertEquals("foo", roConfig.getUrl());
}
@Test
void isPostgresAllQuotedIdentifiers_true_when_postgres() {
DatabaseConfig config = new DatabaseConfig();
config.setAllQuotedIdentifiers(true);
config.setDatabasePlatform(new PostgresPlatform());
assertTrue(new InitDataSource(config).isPostgresAllQuotedIdentifiers());
}
@Test
void isPostgresAllQuotedIdentifiers_true_when_postgres9() {
DatabaseConfig config = new DatabaseConfig();
config.setAllQuotedIdentifiers(true);
config.setDatabasePlatform(new Postgres9Platform());
assertTrue(new InitDataSource(config).isPostgresAllQuotedIdentifiers());
}
@Test
void isPostgresAllQuotedIdentifiers_false() {
DatabaseConfig config = new DatabaseConfig();
config.setAllQuotedIdentifiers(false);
config.setDatabasePlatform(new PostgresPlatform());
assertFalse(new InitDataSource(config).isPostgresAllQuotedIdentifiers());
}
@Test
void isPostgresAllQuotedIdentifiers_false_when_notPostgres() {
DatabaseConfig config = new DatabaseConfig();
config.setAllQuotedIdentifiers(true);
config.setDatabasePlatform(new H2Platform());
assertFalse(new InitDataSource(config).isPostgresAllQuotedIdentifiers());
}
@Test
public void online() {