From e6e53e0d9391a92cf20489a1306c1dd38b9136cc Mon Sep 17 00:00:00 2001 From: Rob Bygrave Date: Sat, 10 Feb 2024 12:15:50 +1300 Subject: [PATCH 1/2] Change default persistBatchSize from 20 to 100 (as a better default value) This is the batch size used with PreparedStatement executeBatch() with batched inserts, updates and deletes. 20 is really on the low side and bumping this default to 100 seems good and right. --- ebean-api/src/main/java/io/ebean/config/DatabaseConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ebean-api/src/main/java/io/ebean/config/DatabaseConfig.java b/ebean-api/src/main/java/io/ebean/config/DatabaseConfig.java index b173215db..b3ad2ef43 100644 --- a/ebean-api/src/main/java/io/ebean/config/DatabaseConfig.java +++ b/ebean-api/src/main/java/io/ebean/config/DatabaseConfig.java @@ -236,7 +236,7 @@ public class DatabaseConfig implements DatabaseBuilder.Settings { */ private PersistBatch persistBatchOnCascade = PersistBatch.INHERIT; - private int persistBatchSize = 20; + private int persistBatchSize = 100; private EnumType defaultEnumType = EnumType.ORDINAL; From e4df20b9dca66f9f9c6f0c238e1bf0799a8985db Mon Sep 17 00:00:00 2001 From: Rob Bygrave Date: Sat, 10 Feb 2024 13:28:04 +1300 Subject: [PATCH 2/2] Update test TestPersistCascade with default batch size 100 --- .../src/test/java/org/tests/iud/TestPersistCascade.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ebean-test/src/test/java/org/tests/iud/TestPersistCascade.java b/ebean-test/src/test/java/org/tests/iud/TestPersistCascade.java index 39136c284..d8d4424a9 100644 --- a/ebean-test/src/test/java/org/tests/iud/TestPersistCascade.java +++ b/ebean-test/src/test/java/org/tests/iud/TestPersistCascade.java @@ -35,11 +35,9 @@ public class TestPersistCascade extends BaseTestCase { assertThat(sql.get(23)).contains("insert into pcf_city"); assertSqlBind(sql, 24, 26); assertThat(sql.get(28)).contains("insert into pcf_event"); - assertSqlBind(sql, 29, 48); - assertThat(sql.get(50)).contains("insert into pcf_event"); - assertSqlBind(sql, 51, 70); - assertThat(sql.get(72)).contains("insert into pcf_event"); - assertSqlBind(sql, 73, 87); + assertSqlBind(sql, 29, 128); + assertThat(sql.get(130)).contains("insert into pcf_event"); + assertSqlBind(sql, 131, 150); } country.deletePermanent();