diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/BeanRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/BeanRequest.java index 0b57ce2c3..5a56719c5 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/core/BeanRequest.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/BeanRequest.java @@ -14,21 +14,13 @@ public abstract class BeanRequest { static final Logger log = LoggerFactory.getLogger(BeanRequest.class); - /** - * The server processing the request. - */ - protected final SpiEbeanServer ebeanServer; - - /** - * The transaction this is part of. - */ + protected final SpiEbeanServer server; protected SpiTransaction transaction; - protected boolean createdTransaction; - public BeanRequest(SpiEbeanServer ebeanServer, SpiTransaction t) { - this.ebeanServer = ebeanServer; - this.transaction = t; + public BeanRequest(SpiEbeanServer server, SpiTransaction transaction) { + this.server = server; + this.transaction = transaction; } /** @@ -44,10 +36,10 @@ public abstract class BeanRequest { if (transaction != null) { return false; } - transaction = ebeanServer.currentServerTransaction(); + transaction = server.currentServerTransaction(); if (transaction == null || !transaction.isActive()) { // create an implicit transaction to execute this query - transaction = ebeanServer.beginServerTransaction(); + transaction = server.beginServerTransaction(); createdTransaction = true; } return true; @@ -58,7 +50,7 @@ public abstract class BeanRequest { */ public void commitTransIfRequired() { if (createdTransaction) { - ebeanServer.commitTransaction(); + server.commitTransaction(); } } @@ -68,7 +60,7 @@ public abstract class BeanRequest { public void rollbackTransIfRequired() { if (createdTransaction) { try { - ebeanServer.endTransaction(); + server.endTransaction(); } catch (Exception e) { // Just log this and carry on. A previous exception has been // thrown and if this rollback throws exception it likely means @@ -83,7 +75,7 @@ public abstract class BeanRequest { */ public void clearTransIfRequired() { if (createdTransaction) { - ebeanServer.clearServerTransaction(); + server.clearServerTransaction(); } } @@ -92,11 +84,11 @@ public abstract class BeanRequest { * BeanController and BeanFinder. */ public EbeanServer getEbeanServer() { - return ebeanServer; + return server; } - public SpiEbeanServer getServer() { - return ebeanServer; + public SpiEbeanServer server() { + return server; } /** @@ -109,28 +101,28 @@ public abstract class BeanRequest { /** * Set the transaction to use for this request. */ - public void setTransaction(SpiTransaction transaction) { + public void transaction(SpiTransaction transaction) { this.transaction = transaction; } /** * Return true if SQL should be logged for this transaction. */ - public boolean isLogSql() { + public boolean logSql() { return transaction.isLogSql(); } /** * Return true if SUMMARY information should be logged for this transaction. */ - public boolean isLogSummary() { + public boolean logSummary() { return transaction.isLogSummary(); } /** * Return the DataTimeZone to use. */ - public DataTimeZone getDataTimeZone() { - return ebeanServer.getDataTimeZone(); + public DataTimeZone dataTimeZone() { + return server.getDataTimeZone(); } } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java index 5cbc7ae32..3fba544c6 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java @@ -146,7 +146,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery */ @Override public String getDBLikeClause(boolean rawLikeExpression) { - return ebeanServer.getDatabasePlatform().getLikeClause(rawLikeExpression); + return server.getDatabasePlatform().getLikeClause(rawLikeExpression); } /** @@ -154,7 +154,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery */ @Override public String escapeLikeString(String value) { - return ebeanServer.getDatabasePlatform().escapeLikeString(value); + return server.getDatabasePlatform().escapeLikeString(value); } @Override @@ -271,11 +271,11 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery if (transaction == null) { if (query.getType().isUpdate()) { // bulk update or delete query - transaction = ebeanServer.beginServerTransaction(); + transaction = server.beginServerTransaction(); } else { // create an implicit transaction to execute this query // potentially using read-only DataSource with autoCommit - transaction = ebeanServer.createReadOnlyTransaction(query.getTenantId()); + transaction = server.createReadOnlyTransaction(query.getTenantId()); } createdTransaction = true; } @@ -343,7 +343,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery if (ctx != null) return ctx; // determine the scope (from the query and then server) - PersistenceContextScope scope = ebeanServer.getPersistenceContextScope(query); + PersistenceContextScope scope = server.getPersistenceContextScope(query); if (scope == PersistenceContextScope.QUERY || t == null) { return new DefaultPersistenceContext(); } @@ -365,7 +365,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery transaction.commit(); if (query.getType().isUpdate()) { // for implicit update/delete queries clear the thread local - ebeanServer.clearServerTransaction(); + server.clearServerTransaction(); } } } @@ -688,7 +688,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery public Object getFromQueryCache() { if (query.getUseQueryCache() == CacheMode.OFF || (transaction != null && transaction.isSkipCache()) - || ebeanServer.isDisableL2Cache()) { + || server.isDisableL2Cache()) { return null; } else { cacheKey = query.queryHash(); @@ -768,7 +768,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery */ public int getLazyLoadBatchSize() { int batchSize = query.getLazyLoadBatchSize(); - return (batchSize > 0) ? batchSize : ebeanServer.getLazyLoadBatchSize(); + return (batchSize > 0) ? batchSize : server.getLazyLoadBatchSize(); } /** @@ -806,7 +806,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery * Check for slow query event. */ public void slowQueryCheck(long executionTimeMicros, int rowCount) { - ebeanServer.slowQueryCheck(executionTimeMicros, rowCount, query); + server.slowQueryCheck(executionTimeMicros, rowCount, query); } public void setInlineCountDistinct() { @@ -830,6 +830,6 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery * Return true if no MaxRows or use LIMIT in SQL update. */ public boolean isInlineSqlUpdateLimit() { - return query.getMaxRows() < 1 || ebeanServer.getDatabasePlatform().isInlineSqlUpdateLimit(); + return query.getMaxRows() < 1 || server.getDatabasePlatform().isInlineSqlUpdateLimit(); } } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java index af6ed1aeb..dddfc032c 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java @@ -95,12 +95,12 @@ public abstract class PersistRequest extends BeanRequest implements BatchPostExe } @Override - public boolean isLogSql() { + public boolean logSql() { return transaction.isLogSql(); } @Override - public boolean isLogSummary() { + public boolean logSummary() { return transaction.isLogSummary(); } @@ -149,10 +149,9 @@ public abstract class PersistRequest extends BeanRequest implements BatchPostExe } /** - * Return the type of this request. One of INSERT, UPDATE, DELETE, UPDATESQL - * or CALLABLESQL. + * Return the type of this request. One of INSERT, UPDATE, DELETE, UPDATESQL or CALLABLESQL. */ - public Type getType() { + public Type type() { return type; } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java index 038281833..17a2d1907 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java @@ -937,8 +937,8 @@ public final class PersistRequestBean extends PersistRequest implements BeanP } addPostCommitListeners(); notifyCacheOnPostExecute(); - if (isLogSummary()) { - logSummary(); + if (logSummary()) { + logSummaryMessage(); } } @@ -985,7 +985,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP } } - private void logSummary() { + private void logSummaryMessage() { String draft = (beanDescriptor.isDraftable() && !publish) ? " draft[true]" : ""; String name = beanDescriptor.getName(); switch (type) { @@ -1031,7 +1031,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP * Register the derived relationships to get executed later (on JDBC batch flush or commit). */ public void deferredRelationship(EntityBean assocBean, ImportedId importedId, EntityBean bean) { - transaction.registerDeferred(new PersistDeferredRelationship(ebeanServer, beanDescriptor, assocBean, importedId, bean)); + transaction.registerDeferred(new PersistDeferredRelationship(server, beanDescriptor, assocBean, importedId, bean)); } private void postInsert() { @@ -1175,7 +1175,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP requestUpdateAllLoadedProps = txnUpdateAll; } else { // if using batch use the server default setting - requestUpdateAllLoadedProps = isBatchThisRequest() && ebeanServer.isUpdateAllPropertiesInBatch(); + requestUpdateAllLoadedProps = isBatchThisRequest() && server.isUpdateAllPropertiesInBatch(); } return requestUpdateAllLoadedProps; } @@ -1313,7 +1313,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP */ public long now() { if (now == 0) { - now = ebeanServer.clockNow(); + now = server.clockNow(); } return now; } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java index f9f8fa97d..42b5aebe6 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java @@ -777,7 +777,7 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType { * Return true if this request should be included in the change log. */ public BeanChange getChangeLogBean(PersistRequestBean request) { - switch (request.getType()) { + switch (request.type()) { case INSERT: return changeLogFilter.includeInsert(request) ? insertBeanChange(request) : null; case UPDATE: @@ -786,7 +786,7 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType { case DELETE: return changeLogFilter.includeDelete(request) ? deleteBeanChange(request) : null; default: - throw new IllegalStateException("Unhandled request type " + request.getType()); + throw new IllegalStateException("Unhandled request type " + request.type()); } } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/loadcontext/DLoadContext.java b/ebean-core/src/main/java/io/ebeaninternal/server/loadcontext/DLoadContext.java index b7460a69c..b42049e87 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/loadcontext/DLoadContext.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/loadcontext/DLoadContext.java @@ -93,7 +93,7 @@ public final class DLoadContext implements LoadContext { public DLoadContext(OrmQueryRequest request, SpiQuerySecondary secondaryQueries) { this.tenantId = request.getTenantId(); this.persistenceContext = request.getPersistenceContext(); - this.ebeanServer = request.getServer(); + this.ebeanServer = request.server(); this.defaultBatchSize = request.getLazyLoadBatchSize(); this.rootDescriptor = request.getBeanDescriptor(); diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/BatchedBeanHolder.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/BatchedBeanHolder.java index db6d85a35..06bc8a1d1 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/BatchedBeanHolder.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/BatchedBeanHolder.java @@ -127,7 +127,7 @@ final class BatchedBeanHolder { public int append(PersistRequestBean request) { empty = false; request.setBatched(); - switch (request.getType()) { + switch (request.type()) { case INSERT: if (inserts == null) { inserts = new ArrayList<>(); @@ -151,7 +151,7 @@ final class BatchedBeanHolder { return deletes.size(); default: - throw new RuntimeException("Invalid type code " + request.getType()); + throw new RuntimeException("Invalid type code " + request.type()); } } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeCallableSql.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeCallableSql.java index 5728df639..f4cbacb42 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeCallableSql.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeCallableSql.java @@ -64,7 +64,7 @@ final class ExeCallableSql { // process named parameters if required sql = BindParamsParser.parse(bindParams, sql); - boolean logSql = request.isLogSql(); + boolean logSql = request.logSql(); CallableStatement cstmt; if (batchThisRequest) { diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBase.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBase.java index b14311b0b..9353ebd31 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBase.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBase.java @@ -30,7 +30,7 @@ abstract class SaveManyBase implements SaveMany { SaveManyBase(DefaultPersister persister, boolean insertedParent, BeanPropertyAssocMany many, EntityBean parentBean, PersistRequestBean request) { this.persister = persister; this.request = request; - this.server = request.getServer(); + this.server = request.server(); this.many = many; this.parentBean = parentBean; this.transaction = request.transaction(); diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DmlHandler.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DmlHandler.java index 323f8c369..7785223c6 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DmlHandler.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DmlHandler.java @@ -68,7 +68,7 @@ public abstract class DmlHandler implements PersistHandler, BindableRequest { * Bind to the statement returning the DataBind. */ DataBind bind(PreparedStatement stmt) { - return new DataBind(persistRequest.getDataTimeZone(), stmt, transaction.getInternalConnection()); + return new DataBind(persistRequest.dataTimeZone(), stmt, transaction.getInternalConnection()); } /** diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryEngine.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryEngine.java index 0e748402d..1380de179 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryEngine.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryEngine.java @@ -79,7 +79,7 @@ public final class CQueryEngine { private int executeUpdate(OrmQueryRequest request, CQueryUpdate query) { try { int rows = query.execute(); - if (request.isLogSql()) { + if (request.logSql()) { request.logSql(Str.add(query.getGeneratedSql(), "; --bind(", query.getBindLog(), ") --micros(", query.micros() + ") --rows(", rows + ")")); } return rows; @@ -101,10 +101,10 @@ public final class CQueryEngine { private List findAttributeList(OrmQueryRequest request, CQueryFetchSingleAttribute rcQuery) { try { List list = (List) rcQuery.findList(); - if (request.isLogSql()) { + if (request.logSql()) { logGeneratedSql(request, rcQuery.getGeneratedSql(), rcQuery.getBindLog(), rcQuery.micros()); } - if (request.isLogSummary()) { + if (request.logSummary()) { request.transaction().logSummary(rcQuery.getSummary()); } if (request.isQueryCachePut()) { @@ -159,10 +159,10 @@ public final class CQueryEngine { request.setCancelableQuery(rcQuery); try { int count = rcQuery.findCount(); - if (request.isLogSql()) { + if (request.logSql()) { logGeneratedSql(request, rcQuery.getGeneratedSql(), rcQuery.getBindLog(), rcQuery.micros()); } - if (request.isLogSummary()) { + if (request.logSummary()) { request.transaction().logSummary(rcQuery.getSummary()); } if (request.query().isFutureFetch()) { @@ -194,7 +194,7 @@ public final class CQueryEngine { logger.trace("Future fetch already cancelled"); return null; } - if (request.isLogSql()) { + if (request.logSql()) { logSql(cquery); } // first check batch sizes set on query joins @@ -210,7 +210,7 @@ public final class CQueryEngine { } QueryIterator readIterate = cquery.readIterate(iterateBufferSize, request); - if (request.isLogSummary()) { + if (request.logSummary()) { logFindManySummary(cquery); } if (request.isAuditReads()) { @@ -248,7 +248,7 @@ public final class CQueryEngine { request.setCancelableQuery(cquery); try { cquery.prepareBindExecuteQuery(); - if (request.isLogSql()) { + if (request.logSql()) { logSql(cquery); } List> versions = cquery.readVersions(); @@ -256,7 +256,7 @@ public final class CQueryEngine { // is not universally supported, not expect huge list here versions.sort(OrderVersionDesc.INSTANCE); deriveVersionDiffs(versions, request); - if (request.isLogSummary()) { + if (request.logSummary()) { logFindManySummary(cquery); } if (request.isAuditReads()) { @@ -324,7 +324,7 @@ public final class CQueryEngine { } } ResultSet resultSet = cquery.prepareResultSet(fwdOnly); - if (request.isLogSql()) { + if (request.logSql()) { logSql(cquery); } return new SpiResultSet(cquery.getPstmt(), resultSet); @@ -350,11 +350,11 @@ public final class CQueryEngine { logger.trace("Future fetch already cancelled"); return null; } - if (request.isLogSql()) { + if (request.logSql()) { logSql(cquery); } BeanCollection beanCollection = cquery.readCollection(); - if (request.isLogSummary()) { + if (request.logSummary()) { logFindManySummary(cquery); } if (request.isAuditReads()) { @@ -385,13 +385,13 @@ public final class CQueryEngine { request.setCancelableQuery(cquery); try { cquery.prepareBindExecuteQuery(); - if (request.isLogSql()) { + if (request.logSql()) { logSql(cquery); } if (cquery.readBean()) { bean = cquery.next(); } - if (request.isLogSummary()) { + if (request.logSummary()) { logFindBeanSummary(cquery); } if (request.isAuditReads()) { diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryFetchSingleAttribute.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryFetchSingleAttribute.java index daf6d7c30..2f45f1b2e 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryFetchSingleAttribute.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryFetchSingleAttribute.java @@ -140,7 +140,7 @@ final class CQueryFetchSingleAttribute implements SpiProfileTransactionEvent, Ca } finally { lock.unlock(); } - dataReader = new RsetDataReader(request.getDataTimeZone(), pstmt.executeQuery()); + dataReader = new RsetDataReader(request.dataTimeZone(), pstmt.executeQuery()); query.checkCancelled(); } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java index 8160be906..c40fcf939 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java @@ -85,7 +85,7 @@ public class CQueryPlan implements SpiQueryPlan { * Create a query plan based on a OrmQueryRequest. */ CQueryPlan(OrmQueryRequest request, SqlLimitResponse sqlRes, SqlTree sqlTree, boolean rawSql, String logWhereSql) { - this.server = request.getServer(); + this.server = request.server(); this.dataTimeZone = server.getDataTimeZone(); this.beanType = request.getBeanDescriptor().getBeanType(); this.planKey = request.getQueryPlanKey(); @@ -110,7 +110,7 @@ public class CQueryPlan implements SpiQueryPlan { * Create a query plan for a raw sql query. */ CQueryPlan(OrmQueryRequest request, String sql, SqlTree sqlTree, String logWhereSql) { - this.server = request.getServer(); + this.server = request.server(); this.dataTimeZone = server.getDataTimeZone(); this.beanType = request.getBeanDescriptor().getBeanType(); SpiQuery query = request.query(); diff --git a/ebean-core/src/main/java/io/ebeanservice/docstore/api/DocQueryRequest.java b/ebean-core/src/main/java/io/ebeanservice/docstore/api/DocQueryRequest.java index c9951d67e..d8548d1b2 100644 --- a/ebean-core/src/main/java/io/ebeanservice/docstore/api/DocQueryRequest.java +++ b/ebean-core/src/main/java/io/ebeanservice/docstore/api/DocQueryRequest.java @@ -18,7 +18,7 @@ public interface DocQueryRequest extends DocQueryContext { /** * Set the (document store) transaction to use for this query. */ - void setTransaction(SpiTransaction transaction); + void transaction(SpiTransaction transaction); /** * Return the query for this request.