Merge pull request #2339 from FOCONIS/master12

No effective code change: Add missing @Override annotation
This commit is contained in:
Rob Bygrave authored and GitHub committed 2021-09-02 15:02:03 +12:00
commit 7d6b25ff59
17 files changed
+18 -9

No files matched your search

@@ -36,11 +36,6 @@ public interface SpiDtoQuery<T> extends DtoQuery<T>, SpiSqlBinding {
*/ */
boolean isRelaxedMode(); boolean isRelaxedMode();
/**
* Return the label for the query.
*/
String getLabel();
/** /**
* Return the label with fallback to profile location label. * Return the label with fallback to profile location label.
*/ */
@@ -44,8 +44,4 @@ public interface SpiExpressionList<T> extends ExpressionList<T>, SpiExpression {
// do nothing by default // do nothing by default
} }
/**
* Apply property prefix when filterMany expressions included in main query.
*/
void prefixProperty(String path);
} }
@@ -114,6 +114,7 @@ public final class DtoQueryRequest<T> extends AbstractSqlQueryRequest {
return queryEngine.findList(this); return queryEngine.findList(this);
} }
@Override
public boolean next() throws SQLException { public boolean next() throws SQLException {
query.checkCancelled(); query.checkCancelled();
return dataReader.next(); return dataReader.next();
@@ -145,6 +145,7 @@ public final class PersistRequestUpdateSql extends PersistRequest {
this.bindLog = bindLog; this.bindLog = bindLog;
} }
@Override
public void startBind(boolean batchThisRequest) { public void startBind(boolean batchThisRequest) {
this.batchThisRequest = batchThisRequest; this.batchThisRequest = batchThisRequest;
super.startBind(batchThisRequest); super.startBind(batchThisRequest);
@@ -154,6 +154,7 @@ public class BeanPropertyAssocOne<T> extends BeanPropertyAssoc<T> implements STr
/** /**
* Return the property value as an entity bean. * Return the property value as an entity bean.
*/ */
@Override
public EntityBean getValueAsEntityBean(EntityBean owner) { public EntityBean getValueAsEntityBean(EntityBean owner) {
return (EntityBean) getValue(owner); return (EntityBean) getValue(owner);
} }
@@ -203,6 +204,7 @@ public class BeanPropertyAssocOne<T> extends BeanPropertyAssoc<T> implements STr
} }
} }
@Override
Object naturalKeyVal(Map<String, Object> values) { Object naturalKeyVal(Map<String, Object> values) {
EntityBean bean = (EntityBean) values.get(name); EntityBean bean = (EntityBean) values.get(name);
if (bean == null) { if (bean == null) {
@@ -339,6 +341,7 @@ public class BeanPropertyAssocOne<T> extends BeanPropertyAssoc<T> implements STr
} }
} }
@Override
public boolean hasForeignKey() { public boolean hasForeignKey() {
return foreignKey == null || primaryKeyJoin || !foreignKey.isNoConstraint(); return foreignKey == null || primaryKeyJoin || !foreignKey.isNoConstraint();
} }
@@ -402,6 +405,7 @@ public class BeanPropertyAssocOne<T> extends BeanPropertyAssoc<T> implements STr
/** /**
* Return the bean cache value for this property using original values. * Return the bean cache value for this property using original values.
*/ */
@Override
public Object getCacheDataValueOrig(EntityBeanIntercept ebi) { public Object getCacheDataValueOrig(EntityBeanIntercept ebi) {
return cacheDataConvert(ebi.getOrigValue(propertyIndex)); return cacheDataConvert(ebi.getOrigValue(propertyIndex));
} }
@@ -150,6 +150,7 @@ public final class DefaultPersister implements Persister {
/** /**
* Add to the flush queue in position 0, 1 or 2. * Add to the flush queue in position 0, 1 or 2.
*/ */
@Override
public void addToFlushQueue(SpiSqlUpdate update, SpiTransaction t, int pos) { public void addToFlushQueue(SpiSqlUpdate update, SpiTransaction t, int pos) {
new PersistRequestUpdateSql(server, update, t, persistExecute).addToFlushQueue(pos); new PersistRequestUpdateSql(server, update, t, persistExecute).addToFlushQueue(pos);
} }
@@ -26,6 +26,7 @@ final class DCountMetric implements CountMetric {
count.add(value); count.add(value);
} }
@Override
public void increment() { public void increment() {
count.increment(); count.increment();
} }
@@ -82,6 +82,7 @@ class DProfileLocation implements ProfileLocation {
} }
} }
@Override
public void setTraceCount(int traceCount) { public void setTraceCount(int traceCount) {
this.traceCount = traceCount; this.traceCount = traceCount;
} }
@@ -1339,6 +1339,7 @@ public final class DefaultOrmQuery<T> extends AbstractQuery implements SpiQuery<
return fetchInternal(path, null, FETCH_QUERY); return fetchInternal(path, null, FETCH_QUERY);
} }
@Override
public Query<T> fetchCache(String path) { public Query<T> fetchCache(String path) {
return fetchInternal(path, null, FETCH_CACHE); return fetchInternal(path, null, FETCH_CACHE);
} }
@@ -65,6 +65,7 @@ public final class DefaultPersistenceContext implements SpiPersistenceContext {
return new DefaultPersistenceContext(this, false); return new DefaultPersistenceContext(this, false);
} }
@Override
public boolean resetLimit() { public boolean resetLimit() {
lock.lock(); lock.lock();
try { try {
@@ -201,6 +201,7 @@ public class TransactionManager implements SpiTransactionManager {
/** /**
* Return the scope manager. * Return the scope manager.
*/ */
@Override
public final TransactionScopeManager scope() { public final TransactionScopeManager scope() {
return scopeManager; return scopeManager;
} }
@@ -104,6 +104,7 @@ interface ArrayElementConverter<T> {
*/ */
class StringConverter implements ArrayElementConverter<String> { class StringConverter implements ArrayElementConverter<String> {
@Override
public String fromDbArray(Object rawValue) { public String fromDbArray(Object rawValue) {
return (String) rawValue; return (String) rawValue;
} }
@@ -19,6 +19,7 @@ final class ScalarTypeLocalDate extends ScalarTypeBaseDate<LocalDate> {
super(mode, LocalDate.class, false, Types.DATE); super(mode, LocalDate.class, false, Types.DATE);
} }
@Override
protected String toIsoFormat(LocalDate value) { protected String toIsoFormat(LocalDate value) {
return value.toString(); return value.toString();
} }
@@ -95,6 +95,7 @@ final class ScalarTypeUtilDate {
super(mode, Date.class, false, Types.DATE); super(mode, Date.class, false, Types.DATE);
} }
@Override
protected String toIsoFormat(java.util.Date value) { protected String toIsoFormat(java.util.Date value) {
return UtilDateParser.format(value); return UtilDateParser.format(value);
} }
@@ -90,6 +90,7 @@ public class TestElementCollectionBasicCache extends BaseTestCase {
LoggedSqlCollector.stop(); LoggedSqlCollector.stop();
} }
@Override
public boolean isPersistBatchOnCascade() { public boolean isPersistBatchOnCascade() {
return ((SpiEbeanServer) Ebean.getDefaultServer()).getDatabasePlatform().getPersistBatchOnCascade() != PersistBatch.NONE; return ((SpiEbeanServer) Ebean.getDefaultServer()).getDatabasePlatform().getPersistBatchOnCascade() != PersistBatch.NONE;
} }
@@ -96,6 +96,7 @@ public class TestElementCollectionBasicMapCache extends BaseTestCase {
LoggedSqlCollector.stop(); LoggedSqlCollector.stop();
} }
@Override
public boolean isPersistBatchOnCascade() { public boolean isPersistBatchOnCascade() {
return ((SpiEbeanServer) Ebean.getDefaultServer()).getDatabasePlatform().getPersistBatchOnCascade() != PersistBatch.NONE; return ((SpiEbeanServer) Ebean.getDefaultServer()).getDatabasePlatform().getPersistBatchOnCascade() != PersistBatch.NONE;
} }
@@ -24,6 +24,7 @@ public class PostgresDdl extends PlatformDdl {
this.indexConcurrent = "concurrently "; this.indexConcurrent = "concurrently ";
} }
@Override
public String setLockTimeout(int lockTimeoutSeconds) { public String setLockTimeout(int lockTimeoutSeconds) {
return "set lock_timeout = " + (lockTimeoutSeconds * 1000); return "set lock_timeout = " + (lockTimeoutSeconds * 1000);
} }